[INFO] crate delta_e 0.2.0 is already in cache [INFO] extracting crate delta_e 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/delta_e/0.2.0 [INFO] extracting crate delta_e 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/delta_e/0.2.0 [INFO] validating manifest of delta_e-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of delta_e-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing delta_e-0.2.0 [INFO] finished frobbing delta_e-0.2.0 [INFO] frobbed toml for delta_e-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/delta_e/0.2.0/Cargo.toml [INFO] started frobbing delta_e-0.2.0 [INFO] finished frobbing delta_e-0.2.0 [INFO] frobbed toml for delta_e-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/delta_e/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting delta_e-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/delta_e/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c38f6d83c9e6f870cd8c5ef7f188d86c93964340f72b201b8553c81ad73b5cb5 [INFO] running `"docker" "start" "-a" "c38f6d83c9e6f870cd8c5ef7f188d86c93964340f72b201b8553c81ad73b5cb5"` [INFO] [stderr] Checking lab v0.4.4 [INFO] [stderr] Checking delta_e v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/de2000.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new(color_1: Lab, color_2: Lab) -> f32 { [INFO] [stderr] 36 | | let ksub_l = 1.0; [INFO] [stderr] 37 | | let ksub_c = 1.0; [INFO] [stderr] 38 | | let ksub_h = 1.0; [INFO] [stderr] ... | [INFO] [stderr] 88 | | (lightness.powi(2) + chroma.powi(2) + hue.powi(2) + r_sub_t * chroma * hue).sqrt() [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/de2000.rs:109:30 [INFO] [stderr] | [INFO] [stderr] 109 | pub fn from_rgb(color_1: &[u8; 3], color_2: &[u8; 3]) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 3]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/de2000.rs:109:49 [INFO] [stderr] | [INFO] [stderr] 109 | pub fn from_rgb(color_1: &[u8; 3], color_2: &[u8; 3]) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/de2000.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new(color_1: Lab, color_2: Lab) -> f32 { [INFO] [stderr] 36 | | let ksub_l = 1.0; [INFO] [stderr] 37 | | let ksub_c = 1.0; [INFO] [stderr] 38 | | let ksub_h = 1.0; [INFO] [stderr] ... | [INFO] [stderr] 88 | | (lightness.powi(2) + chroma.powi(2) + hue.powi(2) + r_sub_t * chroma * hue).sqrt() [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/de2000.rs:109:30 [INFO] [stderr] | [INFO] [stderr] 109 | pub fn from_rgb(color_1: &[u8; 3], color_2: &[u8; 3]) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 3]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/de2000.rs:109:49 [INFO] [stderr] | [INFO] [stderr] 109 | pub fn from_rgb(color_1: &[u8; 3], color_2: &[u8; 3]) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/de2000.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | assert_eq!(round(DE2000::new(color_1, color_2)), expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/de2000.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | assert_eq!(round(DE2000::new(color_1, color_2)), expected); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `delta_e`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c38f6d83c9e6f870cd8c5ef7f188d86c93964340f72b201b8553c81ad73b5cb5"` [INFO] running `"docker" "rm" "-f" "c38f6d83c9e6f870cd8c5ef7f188d86c93964340f72b201b8553c81ad73b5cb5"` [INFO] [stdout] c38f6d83c9e6f870cd8c5ef7f188d86c93964340f72b201b8553c81ad73b5cb5