[INFO] crate delaunator 0.2.0 is already in cache [INFO] extracting crate delaunator 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/delaunator/0.2.0 [INFO] extracting crate delaunator 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/delaunator/0.2.0 [INFO] validating manifest of delaunator-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of delaunator-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing delaunator-0.2.0 [INFO] finished frobbing delaunator-0.2.0 [INFO] frobbed toml for delaunator-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/delaunator/0.2.0/Cargo.toml [INFO] started frobbing delaunator-0.2.0 [INFO] finished frobbing delaunator-0.2.0 [INFO] frobbed toml for delaunator-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/delaunator/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting delaunator-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/delaunator/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8000963a8d46f34259f4283d485e3b81095d463487b3353cdf5062ebe614b5a0 [INFO] running `"docker" "start" "-a" "8000963a8d46f34259f4283d485e3b81095d463487b3353cdf5062ebe614b5a0"` [INFO] [stderr] Checking delaunator v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | let y = (dx * cl - ex * bl) * d; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:466:17 [INFO] [stderr] | [INFO] [stderr] 466 | let q = hull.next[n]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:479:21 [INFO] [stderr] | [INFO] [stderr] 479 | let q = hull.prev[e]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | let y = (dx * cl - ex * bl) * d; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:466:17 [INFO] [stderr] | [INFO] [stderr] 466 | let q = hull.next[n]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:479:21 [INFO] [stderr] | [INFO] [stderr] 479 | let q = hull.prev[e]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: item `Triangulation` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:141:1 [INFO] [stderr] | [INFO] [stderr] 141 | / impl Triangulation { [INFO] [stderr] 142 | | fn new(n: usize) -> Triangulation { [INFO] [stderr] 143 | | let max_triangles = 2 * n - 5; [INFO] [stderr] 144 | | Triangulation { [INFO] [stderr] ... | [INFO] [stderr] 263 | | } [INFO] [stderr] 264 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `Triangulation` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:141:1 [INFO] [stderr] | [INFO] [stderr] 141 | / impl Triangulation { [INFO] [stderr] 142 | | fn new(n: usize) -> Triangulation { [INFO] [stderr] 143 | | let max_triangles = 2 * n - 5; [INFO] [stderr] 144 | | Triangulation { [INFO] [stderr] ... | [INFO] [stderr] 263 | | } [INFO] [stderr] 264 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `x`. [INFO] [stderr] --> tests/tests.rs:125:14 [INFO] [stderr] | [INFO] [stderr] 125 | for i in 1..x.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 125 | for in x.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.29s [INFO] running `"docker" "inspect" "8000963a8d46f34259f4283d485e3b81095d463487b3353cdf5062ebe614b5a0"` [INFO] running `"docker" "rm" "-f" "8000963a8d46f34259f4283d485e3b81095d463487b3353cdf5062ebe614b5a0"` [INFO] [stdout] 8000963a8d46f34259f4283d485e3b81095d463487b3353cdf5062ebe614b5a0