[INFO] crate dedup_signature 0.2.1 is already in cache [INFO] extracting crate dedup_signature 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/dedup_signature/0.2.1 [INFO] extracting crate dedup_signature 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dedup_signature/0.2.1 [INFO] validating manifest of dedup_signature-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dedup_signature-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dedup_signature-0.2.1 [INFO] finished frobbing dedup_signature-0.2.1 [INFO] frobbed toml for dedup_signature-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/dedup_signature/0.2.1/Cargo.toml [INFO] started frobbing dedup_signature-0.2.1 [INFO] finished frobbing dedup_signature-0.2.1 [INFO] frobbed toml for dedup_signature-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dedup_signature/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dedup_signature-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dedup_signature/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3c2865b97df1119a3286c38dc9070e52568b8458223d6e50a98bd0fb8b8638f7 [INFO] running `"docker" "start" "-a" "3c2865b97df1119a3286c38dc9070e52568b8458223d6e50a98bd0fb8b8638f7"` [INFO] [stderr] Checking dedup_signature v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | let mut i = offset as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:81:14 [INFO] [stderr] | [INFO] [stderr] 81 | let (d, e, f) = mix(a, b, c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:81:17 [INFO] [stderr] | [INFO] [stderr] 81 | let (d, e, f) = mix(a, b, c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | let (d, e, f) = mix(a, b, c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | let mut i = offset as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:134:14 [INFO] [stderr] | [INFO] [stderr] 134 | let (d, e, f) = mix(a, b, c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | let (d, e, f) = mix(a, b, c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | let (d, e, f) = mix(a, b, c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | let mut i = offset as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:81:14 [INFO] [stderr] | [INFO] [stderr] 81 | let (d, e, f) = mix(a, b, c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:81:17 [INFO] [stderr] | [INFO] [stderr] 81 | let (d, e, f) = mix(a, b, c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | let (d, e, f) = mix(a, b, c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | let mut i = offset as usize; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:134:14 [INFO] [stderr] | [INFO] [stderr] 134 | let (d, e, f) = mix(a, b, c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | let (d, e, f) = mix(a, b, c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/hash.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | let (d, e, f) = mix(a, b, c); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/generator/text_profile_signature.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 52 | | if current_token.chars().count() > 0 { [INFO] [stderr] 53 | | if current_token.chars().count() > self.min_token_length { [INFO] [stderr] 54 | | if !tokens.contains_key(¤t_token) { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | } else if current_token.chars().count() > 0 { [INFO] [stderr] 52 | if current_token.chars().count() > self.min_token_length { [INFO] [stderr] 53 | if !tokens.contains_key(¤t_token) { [INFO] [stderr] 54 | let tok = Token { [INFO] [stderr] 55 | count: 0, [INFO] [stderr] 56 | term: current_token.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:67:22 [INFO] [stderr] | [INFO] [stderr] 67 | let mut a: u32 = 0xdeadbeef; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | let mut b: u32 = 0xdeadbeef; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | let mut c: u32 = 0xdeadbeef; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/hash.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | a = a.wrapping_add(((length as u32) << 2)).wrapping_add(initval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/hash.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | a = a.wrapping_add(((length as u32) << 2)).wrapping_add(initval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/hash.rs:71:24 [INFO] [stderr] | [INFO] [stderr] 71 | b = b.wrapping_add(((length as u32) << 2)).wrapping_add(initval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/hash.rs:71:24 [INFO] [stderr] | [INFO] [stderr] 71 | b = b.wrapping_add(((length as u32) << 2)).wrapping_add(initval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/hash.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | c = c.wrapping_add(((length as u32) << 2)).wrapping_add(initval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/hash.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | c = c.wrapping_add(((length as u32) << 2)).wrapping_add(initval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:114:22 [INFO] [stderr] | [INFO] [stderr] 114 | let mut a: u32 = 0xdeadbeef; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:115:22 [INFO] [stderr] | [INFO] [stderr] 115 | let mut b: u32 = 0xdeadbeef; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:116:22 [INFO] [stderr] | [INFO] [stderr] 116 | let mut c: u32 = 0xdeadbeef; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/hash.rs:117:24 [INFO] [stderr] | [INFO] [stderr] 117 | a = a.wrapping_add(((length as u32) << 2)).wrapping_add( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/hash.rs:117:24 [INFO] [stderr] | [INFO] [stderr] 117 | a = a.wrapping_add(((length as u32) << 2)).wrapping_add( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/hash.rs:120:24 [INFO] [stderr] | [INFO] [stderr] 120 | b = b.wrapping_add(((length as u32) << 2)).wrapping_add( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/hash.rs:120:24 [INFO] [stderr] | [INFO] [stderr] 120 | b = b.wrapping_add(((length as u32) << 2)).wrapping_add( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/hash.rs:123:24 [INFO] [stderr] | [INFO] [stderr] 123 | c = c.wrapping_add(((length as u32) << 2)).wrapping_add( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/hash.rs:123:24 [INFO] [stderr] | [INFO] [stderr] 123 | c = c.wrapping_add(((length as u32) << 2)).wrapping_add( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/generator/text_profile_signature.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 52 | | if current_token.chars().count() > 0 { [INFO] [stderr] 53 | | if current_token.chars().count() > self.min_token_length { [INFO] [stderr] 54 | | if !tokens.contains_key(¤t_token) { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | } else if current_token.chars().count() > 0 { [INFO] [stderr] 52 | if current_token.chars().count() > self.min_token_length { [INFO] [stderr] 53 | if !tokens.contains_key(¤t_token) { [INFO] [stderr] 54 | let tok = Token { [INFO] [stderr] 55 | count: 0, [INFO] [stderr] 56 | term: current_token.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:67:22 [INFO] [stderr] | [INFO] [stderr] 67 | let mut a: u32 = 0xdeadbeef; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | let mut b: u32 = 0xdeadbeef; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | let mut c: u32 = 0xdeadbeef; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/hash.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | a = a.wrapping_add(((length as u32) << 2)).wrapping_add(initval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/hash.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | a = a.wrapping_add(((length as u32) << 2)).wrapping_add(initval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/hash.rs:71:24 [INFO] [stderr] | [INFO] [stderr] 71 | b = b.wrapping_add(((length as u32) << 2)).wrapping_add(initval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/hash.rs:71:24 [INFO] [stderr] | [INFO] [stderr] 71 | b = b.wrapping_add(((length as u32) << 2)).wrapping_add(initval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/hash.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | c = c.wrapping_add(((length as u32) << 2)).wrapping_add(initval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/hash.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | c = c.wrapping_add(((length as u32) << 2)).wrapping_add(initval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:114:22 [INFO] [stderr] | [INFO] [stderr] 114 | let mut a: u32 = 0xdeadbeef; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:115:22 [INFO] [stderr] | [INFO] [stderr] 115 | let mut b: u32 = 0xdeadbeef; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:116:22 [INFO] [stderr] | [INFO] [stderr] 116 | let mut c: u32 = 0xdeadbeef; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/hash.rs:117:24 [INFO] [stderr] | [INFO] [stderr] 117 | a = a.wrapping_add(((length as u32) << 2)).wrapping_add( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/hash.rs:117:24 [INFO] [stderr] | [INFO] [stderr] 117 | a = a.wrapping_add(((length as u32) << 2)).wrapping_add( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/hash.rs:120:24 [INFO] [stderr] | [INFO] [stderr] 120 | b = b.wrapping_add(((length as u32) << 2)).wrapping_add( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/hash.rs:120:24 [INFO] [stderr] | [INFO] [stderr] 120 | b = b.wrapping_add(((length as u32) << 2)).wrapping_add( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/hash.rs:123:24 [INFO] [stderr] | [INFO] [stderr] 123 | c = c.wrapping_add(((length as u32) << 2)).wrapping_add( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/hash.rs:123:24 [INFO] [stderr] | [INFO] [stderr] 123 | c = c.wrapping_add(((length as u32) << 2)).wrapping_add( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | 0xc4c20dd5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc4c2_0dd5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | 0x3ab04cc3, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3ab0_4cc3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | 0xebe874a3, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xebe8_74a3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | 0x0e770ef3, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0e77_0ef3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | 0xec321498, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xec32_1498` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | 0x73845e86, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7384_5e86` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | 0x8a2db728, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8a2d_b728` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | 0x03c313bb, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03c3_13bb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | 0xfe5b9199, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfe5b_9199` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | 0x95965125, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x9596_5125` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | 0xcbc4e7c2, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xcbc4_e7c2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | 0xddaa5545, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xddaa_5545` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | 0xeb6d1e8f, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xeb6d_1e8f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | 0xa3e01aa5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa3e0_1aa5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | 0xdc1b974d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdc1b_974d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | 0x11ab2013, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x11ab_2013` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | 0xf577bc81, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf577_bc81` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | 0xb37516ae, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xb375_16ae` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | 0xe696e02d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xe696_e02d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | 0x27f779c5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x27f7_79c5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | 0xdeadbef3c4c20dd5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xdead_bef3_c4c2_0dd5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | 0xdeadbf5c2b0533e5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xdead_bf5c_2b05_33e5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | 0xdeadbf601977d67f, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xdead_bf60_1977_d67f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:228:13 [INFO] [stderr] | [INFO] [stderr] 228 | 0x8d29c8f6a0056e90, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8d29_c8f6_a005_6e90` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | 0xb1042c1b7df4026b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xb104_2c1b_7df4_026b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | 0xa88f28eacfe50268, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xa88f_28ea_cfe5_0268` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | 0xb5349593ca06e1de, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xb534_9593_ca06_e1de` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | 0x478e5eebd73775f2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x478e_5eeb_d737_75f2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | 0xd7ed36c3d2ab23a3, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd7ed_36c3_d2ab_23a3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | 0x46e0336bb914de3c, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x46e0_336b_b914_de3c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | 0xf8a1d3dcc94dc067, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xf8a1_d3dc_c94d_c067` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/generator/text_profile_signature.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | if tokens.get(¤t_token).unwrap().count > max_freq { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[¤t_token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/generator/text_profile_signature.rs:65:40 [INFO] [stderr] | [INFO] [stderr] 65 | max_freq = tokens.get(¤t_token).unwrap().count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[¤t_token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/generator/text_profile_signature.rs:86:16 [INFO] [stderr] | [INFO] [stderr] 86 | if tokens.get(¤t_token).unwrap().count > max_freq { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[¤t_token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/generator/text_profile_signature.rs:87:28 [INFO] [stderr] | [INFO] [stderr] 87 | max_freq = tokens.get(¤t_token).unwrap().count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[¤t_token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/generator/text_profile_signature.rs:92:26 [INFO] [stderr] | [INFO] [stderr] 92 | let mut quant = (max_freq as f32 * self.quant_rate).round() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(max_freq)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/hash.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn lookup3(k: &Vec, offset: u32, mut length: usize, initval: u32) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/hash.rs:96:20 [INFO] [stderr] | [INFO] [stderr] 96 | a += k[i + 0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/hash.rs:101:20 [INFO] [stderr] | [INFO] [stderr] 101 | a += k[i + 0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/hash.rs:105:20 [INFO] [stderr] | [INFO] [stderr] 105 | a += k[i + 0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/hash.rs:112:23 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn lookup3_u64(k: &Vec, offset: u32, mut length: usize, initval: u64) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/hash.rs:149:20 [INFO] [stderr] | [INFO] [stderr] 149 | a += k[i + 0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | do_final(a, b, c) as u64 + ((b as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(do_final(a, b, c))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:150:41 [INFO] [stderr] | [INFO] [stderr] 150 | do_final(a, b, c) as u64 + ((b as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/hash.rs:154:20 [INFO] [stderr] | [INFO] [stderr] 154 | a += k[i + 0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | do_final(a, b, c) as u64 + ((b as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(do_final(a, b, c))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:155:41 [INFO] [stderr] | [INFO] [stderr] 155 | do_final(a, b, c) as u64 + ((b as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/hash.rs:158:20 [INFO] [stderr] | [INFO] [stderr] 158 | a += k[i + 0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | do_final(a, b, c) as u64 + ((b as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(do_final(a, b, c))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:159:41 [INFO] [stderr] | [INFO] [stderr] 159 | do_final(a, b, c) as u64 + ((b as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:161:14 [INFO] [stderr] | [INFO] [stderr] 161 | _ => c as u64 + ((b as u64) << 32), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:161:26 [INFO] [stderr] | [INFO] [stderr] 161 | _ => c as u64 + ((b as u64) << 32), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/generator/text_profile_signature.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | if tokens.get(¤t_token).unwrap().count > max_freq { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[¤t_token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/generator/text_profile_signature.rs:65:40 [INFO] [stderr] | [INFO] [stderr] 65 | max_freq = tokens.get(¤t_token).unwrap().count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[¤t_token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/generator/text_profile_signature.rs:86:16 [INFO] [stderr] | [INFO] [stderr] 86 | if tokens.get(¤t_token).unwrap().count > max_freq { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[¤t_token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/generator/text_profile_signature.rs:87:28 [INFO] [stderr] | [INFO] [stderr] 87 | max_freq = tokens.get(¤t_token).unwrap().count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[¤t_token]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/generator/text_profile_signature.rs:92:26 [INFO] [stderr] | [INFO] [stderr] 92 | let mut quant = (max_freq as f32 * self.quant_rate).round() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(max_freq)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/hash.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn lookup3(k: &Vec, offset: u32, mut length: usize, initval: u32) -> u32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/hash.rs:96:20 [INFO] [stderr] | [INFO] [stderr] 96 | a += k[i + 0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/hash.rs:101:20 [INFO] [stderr] | [INFO] [stderr] 101 | a += k[i + 0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/hash.rs:105:20 [INFO] [stderr] | [INFO] [stderr] 105 | a += k[i + 0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/hash.rs:112:23 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn lookup3_u64(k: &Vec, offset: u32, mut length: usize, initval: u64) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/hash.rs:149:20 [INFO] [stderr] | [INFO] [stderr] 149 | a += k[i + 0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | do_final(a, b, c) as u64 + ((b as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(do_final(a, b, c))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:150:41 [INFO] [stderr] | [INFO] [stderr] 150 | do_final(a, b, c) as u64 + ((b as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/hash.rs:154:20 [INFO] [stderr] | [INFO] [stderr] 154 | a += k[i + 0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | do_final(a, b, c) as u64 + ((b as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(do_final(a, b, c))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:155:41 [INFO] [stderr] | [INFO] [stderr] 155 | do_final(a, b, c) as u64 + ((b as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> src/hash.rs:158:20 [INFO] [stderr] | [INFO] [stderr] 158 | a += k[i + 0]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | do_final(a, b, c) as u64 + ((b as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(do_final(a, b, c))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:159:41 [INFO] [stderr] | [INFO] [stderr] 159 | do_final(a, b, c) as u64 + ((b as u64) << 32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:161:14 [INFO] [stderr] | [INFO] [stderr] 161 | _ => c as u64 + ((b as u64) << 32), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash.rs:161:26 [INFO] [stderr] | [INFO] [stderr] 161 | _ => c as u64 + ((b as u64) << 32), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.31s [INFO] running `"docker" "inspect" "3c2865b97df1119a3286c38dc9070e52568b8458223d6e50a98bd0fb8b8638f7"` [INFO] running `"docker" "rm" "-f" "3c2865b97df1119a3286c38dc9070e52568b8458223d6e50a98bd0fb8b8638f7"` [INFO] [stdout] 3c2865b97df1119a3286c38dc9070e52568b8458223d6e50a98bd0fb8b8638f7