[INFO] crate deckofcards 0.3.4 is already in cache [INFO] extracting crate deckofcards 0.3.4 into work/ex/clippy-test-run/sources/stable/reg/deckofcards/0.3.4 [INFO] extracting crate deckofcards 0.3.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/deckofcards/0.3.4 [INFO] validating manifest of deckofcards-0.3.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of deckofcards-0.3.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing deckofcards-0.3.4 [INFO] finished frobbing deckofcards-0.3.4 [INFO] frobbed toml for deckofcards-0.3.4 written to work/ex/clippy-test-run/sources/stable/reg/deckofcards/0.3.4/Cargo.toml [INFO] started frobbing deckofcards-0.3.4 [INFO] finished frobbing deckofcards-0.3.4 [INFO] frobbed toml for deckofcards-0.3.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/deckofcards/0.3.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting deckofcards-0.3.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/deckofcards/0.3.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b2e10fdb0137febccfe6c3ee8cbd78dc0771bf4bbd72c5655e47e1bf6c875259 [INFO] running `"docker" "start" "-a" "b2e10fdb0137febccfe6c3ee8cbd78dc0771bf4bbd72c5655e47e1bf6c875259"` [INFO] [stderr] Checking deckofcards v0.3.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/card.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | rank: rank, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rank` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/card.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | suit: suit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `suit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hand.rs:80:16 [INFO] [stderr] | [INFO] [stderr] 80 | Hand { cards: cards } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cards` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/card.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | rank: rank, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rank` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/card.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | suit: suit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `suit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hand.rs:80:16 [INFO] [stderr] | [INFO] [stderr] 80 | Hand { cards: cards } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cards` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hand.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | return Hand { [INFO] [stderr] | _________^ [INFO] [stderr] 30 | | cards: self.cards.clone() [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | Hand { [INFO] [stderr] 30 | cards: self.cards.clone() [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/suit.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | Suit::suits().into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/suit.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn ordinal(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/suit.rs:56:20 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn to_char(&self) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/suit.rs:63:19 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/rank.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | Rank::ranks().into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rank.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn ordinal(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rank.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn cmp_ace_low(&self, other: &Rank) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rank.rs:64:38 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn cmp_ace_low(&self, other: &Rank) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Rank` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rank.rs:95:20 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn to_char(&self) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rank.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:48:31 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn cmp_rank_then_suit(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:48:45 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn cmp_rank_then_suit(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn cmp_desc_rank_then_suit(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:57:50 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn cmp_desc_rank_then_suit(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:67:31 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn cmp_suit_then_rank(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:67:45 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn cmp_suit_then_rank(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:76:36 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn cmp_suit_then_desc_rank(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:76:50 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn cmp_suit_then_desc_rank(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/card.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 86 | | if s.len() != 2 { [INFO] [stderr] 87 | | return Err("String is wrong length"); [INFO] [stderr] 88 | | } [INFO] [stderr] ... | [INFO] [stderr] 108 | | Err("Invalid string") [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:112:19 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn to_str(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn name(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/card.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | name = name + " of "; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name += " of "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/card.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | name = name + self.suit.to_str(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name += self.suit.to_str()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:128:20 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn ordinal(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:133:22 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn is_hearts(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:138:21 [INFO] [stderr] | [INFO] [stderr] 138 | pub fn is_clubs(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:143:22 [INFO] [stderr] | [INFO] [stderr] 143 | pub fn is_spades(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:148:24 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn is_diamonds(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/card.rs:215:27 [INFO] [stderr] | [INFO] [stderr] 215 | Card::all_cards().into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `deck::Deck` [INFO] [stderr] --> src/deck.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new() -> Deck { [INFO] [stderr] 46 | | Deck::from_cards(Card::all_cards()) [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `hand::Hand` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/hand.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | / impl Hand { [INFO] [stderr] 58 | | /// Make a new empty `Hand` [INFO] [stderr] 59 | | pub fn new() -> Hand { [INFO] [stderr] 60 | | Hand { cards: Vec::new() } [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hand::Hand` [INFO] [stderr] --> src/hand.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new() -> Hand { [INFO] [stderr] 60 | | Hand { cards: Vec::new() } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hand.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | return Hand { [INFO] [stderr] | _________^ [INFO] [stderr] 30 | | cards: self.cards.clone() [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | Hand { [INFO] [stderr] 30 | cards: self.cards.clone() [INFO] [stderr] 31 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/suit.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | Suit::suits().into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/suit.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn ordinal(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/suit.rs:56:20 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn to_char(&self) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/suit.rs:63:19 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/rank.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | Rank::ranks().into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rank.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn ordinal(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rank.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn cmp_ace_low(&self, other: &Rank) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rank.rs:64:38 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn cmp_ace_low(&self, other: &Rank) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Rank` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rank.rs:95:20 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn to_char(&self) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rank.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:48:31 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn cmp_rank_then_suit(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:48:45 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn cmp_rank_then_suit(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn cmp_desc_rank_then_suit(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:57:50 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn cmp_desc_rank_then_suit(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:67:31 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn cmp_suit_then_rank(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:67:45 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn cmp_suit_then_rank(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:76:36 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn cmp_suit_then_desc_rank(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:76:50 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn cmp_suit_then_desc_rank(&self, other: &Card) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Card` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/card.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 86 | | if s.len() != 2 { [INFO] [stderr] 87 | | return Err("String is wrong length"); [INFO] [stderr] 88 | | } [INFO] [stderr] ... | [INFO] [stderr] 108 | | Err("Invalid string") [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:112:19 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn to_str(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn name(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/card.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | name = name + " of "; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name += " of "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/card.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | name = name + self.suit.to_str(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name += self.suit.to_str()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:128:20 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn ordinal(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:133:22 [INFO] [stderr] | [INFO] [stderr] 133 | pub fn is_hearts(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:138:21 [INFO] [stderr] | [INFO] [stderr] 138 | pub fn is_clubs(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:143:22 [INFO] [stderr] | [INFO] [stderr] 143 | pub fn is_spades(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/card.rs:148:24 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn is_diamonds(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/card.rs:215:27 [INFO] [stderr] | [INFO] [stderr] 215 | Card::all_cards().into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `deck::Deck` [INFO] [stderr] --> src/deck.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new() -> Deck { [INFO] [stderr] 46 | | Deck::from_cards(Card::all_cards()) [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `hand::Hand` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/hand.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | / impl Hand { [INFO] [stderr] 58 | | /// Make a new empty `Hand` [INFO] [stderr] 59 | | pub fn new() -> Hand { [INFO] [stderr] 60 | | Hand { cards: Vec::new() } [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hand::Hand` [INFO] [stderr] --> src/hand.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new() -> Hand { [INFO] [stderr] 60 | | Hand { cards: Vec::new() } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/tests.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / fn rank_cmp() { [INFO] [stderr] 57 | | // Validate aces [INFO] [stderr] 58 | | assert_eq!(Rank::Ace.cmp(&Rank::Two), Ordering::Greater); [INFO] [stderr] 59 | | assert_eq!(Rank::Ace.cmp(&Rank::Ace), Ordering::Equal); [INFO] [stderr] ... | [INFO] [stderr] 93 | | assert_eq!(Rank::Ace.cmp_ace_low(&Rank::King), Ordering::Less); [INFO] [stderr] 94 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/tests.rs:412:1 [INFO] [stderr] | [INFO] [stderr] 412 | / fn hand_cards_of_suit() { [INFO] [stderr] 413 | | let h = hand!("TC", "2C", "AS", "QS", "3D", "4D", "5D"); [INFO] [stderr] 414 | | let clubs = h.cards_of_suit(Suit::Clubs); [INFO] [stderr] 415 | | assert_eq!(clubs.len(), 2); [INFO] [stderr] ... | [INFO] [stderr] 428 | | assert_eq!(diamonds[2], card!("5D")); [INFO] [stderr] 429 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.03s [INFO] running `"docker" "inspect" "b2e10fdb0137febccfe6c3ee8cbd78dc0771bf4bbd72c5655e47e1bf6c875259"` [INFO] running `"docker" "rm" "-f" "b2e10fdb0137febccfe6c3ee8cbd78dc0771bf4bbd72c5655e47e1bf6c875259"` [INFO] [stdout] b2e10fdb0137febccfe6c3ee8cbd78dc0771bf4bbd72c5655e47e1bf6c875259