[INFO] crate debug-rs 0.1.3 is already in cache [INFO] extracting crate debug-rs 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/debug-rs/0.1.3 [INFO] extracting crate debug-rs 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/debug-rs/0.1.3 [INFO] validating manifest of debug-rs-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of debug-rs-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing debug-rs-0.1.3 [INFO] finished frobbing debug-rs-0.1.3 [INFO] frobbed toml for debug-rs-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/debug-rs/0.1.3/Cargo.toml [INFO] started frobbing debug-rs-0.1.3 [INFO] finished frobbing debug-rs-0.1.3 [INFO] frobbed toml for debug-rs-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/debug-rs/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting debug-rs-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/debug-rs/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ada0919f3d5211d2fffd04c0f352ebab9f1b3360fa35d9960966c6eb43256172 [INFO] running `"docker" "start" "-a" "ada0919f3d5211d2fffd04c0f352ebab9f1b3360fa35d9960966c6eb43256172"` [INFO] [stderr] Checking globset v0.2.1 [INFO] [stderr] Checking debug-rs v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return colors[hash % colors.len()]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `colors[hash % colors.len()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / return !DEBUG_MATHERS.1.iter().any(|g| g.is_match(&meta)) && [INFO] [stderr] 86 | | DEBUG_MATHERS.0.iter().any(|g| g.is_match(&meta)); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | !DEBUG_MATHERS.1.iter().any(|g| g.is_match(&meta)) && [INFO] [stderr] 86 | DEBUG_MATHERS.0.iter().any(|g| g.is_match(&meta)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:39:70 [INFO] [stderr] | [INFO] [stderr] 39 | static ref DEBUG_MATHERS: (Vec, Vec) = ::std::env::var("DEBUG") [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 40 | | .unwrap_or(String::new()) [INFO] [stderr] | |_________________________________^ help: try this: `::std::env::var("DEBUG").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | } else if s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return colors[hash % colors.len()]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `colors[hash % colors.len()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / return !DEBUG_MATHERS.1.iter().any(|g| g.is_match(&meta)) && [INFO] [stderr] 86 | | DEBUG_MATHERS.0.iter().any(|g| g.is_match(&meta)); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | !DEBUG_MATHERS.1.iter().any(|g| g.is_match(&meta)) && [INFO] [stderr] 86 | DEBUG_MATHERS.0.iter().any(|g| g.is_match(&meta)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:39:70 [INFO] [stderr] | [INFO] [stderr] 39 | static ref DEBUG_MATHERS: (Vec, Vec) = ::std::env::var("DEBUG") [INFO] [stderr] | ______________________________________________________________________^ [INFO] [stderr] 40 | | .unwrap_or(String::new()) [INFO] [stderr] | |_________________________________^ help: try this: `::std::env::var("DEBUG").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | } else if s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.07s [INFO] running `"docker" "inspect" "ada0919f3d5211d2fffd04c0f352ebab9f1b3360fa35d9960966c6eb43256172"` [INFO] running `"docker" "rm" "-f" "ada0919f3d5211d2fffd04c0f352ebab9f1b3360fa35d9960966c6eb43256172"` [INFO] [stdout] ada0919f3d5211d2fffd04c0f352ebab9f1b3360fa35d9960966c6eb43256172