[INFO] crate debug-cell 0.1.1 is already in cache [INFO] extracting crate debug-cell 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/debug-cell/0.1.1 [INFO] extracting crate debug-cell 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/debug-cell/0.1.1 [INFO] validating manifest of debug-cell-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of debug-cell-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing debug-cell-0.1.1 [INFO] removed 1 missing tests [INFO] finished frobbing debug-cell-0.1.1 [INFO] frobbed toml for debug-cell-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/debug-cell/0.1.1/Cargo.toml [INFO] started frobbing debug-cell-0.1.1 [INFO] removed 1 missing tests [INFO] finished frobbing debug-cell-0.1.1 [INFO] frobbed toml for debug-cell-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/debug-cell/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting debug-cell-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/debug-cell/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 53f3ed1b1c0b094df2ee5754dca1c854b48a3039fa92a8b3b917e5617199f974 [INFO] running `"docker" "start" "-a" "53f3ed1b1c0b094df2ee5754dca1c854b48a3039fa92a8b3b917e5617199f974"` [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/smoke.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking debug-cell v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:232:26 [INFO] [stderr] | [INFO] [stderr] 232 | Some(BorrowRef { borrow: borrow }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `borrow` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:277:29 [INFO] [stderr] | [INFO] [stderr] 277 | Some(BorrowRefMut { borrow: borrow }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `borrow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:232:26 [INFO] [stderr] | [INFO] [stderr] 232 | Some(BorrowRef { borrow: borrow }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `borrow` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:277:29 [INFO] [stderr] | [INFO] [stderr] 277 | Some(BorrowRefMut { borrow: borrow }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `borrow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/lib.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | unsafe { self.value.into_inner() } [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn borrow<'a>(&'a self) -> Ref<'a, T> { [INFO] [stderr] 103 | | match BorrowRef::new(&self.borrow) { [INFO] [stderr] 104 | | Some(b) => Ref { [INFO] [stderr] 105 | | _value: unsafe { &*self.value.get() }, [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn borrow_mut<'a>(&'a self) -> RefMut<'a, T> { [INFO] [stderr] 122 | | match BorrowRefMut::new(&self.borrow) { [INFO] [stderr] 123 | | Some(b) => RefMut { [INFO] [stderr] 124 | | _value: unsafe { &mut *self.value.get() }, [INFO] [stderr] ... | [INFO] [stderr] 128 | | } [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/lib.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | unsafe { self.value.into_inner() } [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn borrow<'a>(&'a self) -> Ref<'a, T> { [INFO] [stderr] 103 | | match BorrowRef::new(&self.borrow) { [INFO] [stderr] 104 | | Some(b) => Ref { [INFO] [stderr] 105 | | _value: unsafe { &*self.value.get() }, [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn borrow_mut<'a>(&'a self) -> RefMut<'a, T> { [INFO] [stderr] 122 | | match BorrowRefMut::new(&self.borrow) { [INFO] [stderr] 123 | | Some(b) => RefMut { [INFO] [stderr] 124 | | _value: unsafe { &mut *self.value.get() }, [INFO] [stderr] ... | [INFO] [stderr] 128 | | } [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.39s [INFO] running `"docker" "inspect" "53f3ed1b1c0b094df2ee5754dca1c854b48a3039fa92a8b3b917e5617199f974"` [INFO] running `"docker" "rm" "-f" "53f3ed1b1c0b094df2ee5754dca1c854b48a3039fa92a8b3b917e5617199f974"` [INFO] [stdout] 53f3ed1b1c0b094df2ee5754dca1c854b48a3039fa92a8b3b917e5617199f974