[INFO] crate ddsfile 0.2.3 is already in cache [INFO] extracting crate ddsfile 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/ddsfile/0.2.3 [INFO] extracting crate ddsfile 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ddsfile/0.2.3 [INFO] validating manifest of ddsfile-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ddsfile-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ddsfile-0.2.3 [INFO] finished frobbing ddsfile-0.2.3 [INFO] frobbed toml for ddsfile-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/ddsfile/0.2.3/Cargo.toml [INFO] started frobbing ddsfile-0.2.3 [INFO] finished frobbing ddsfile-0.2.3 [INFO] frobbed toml for ddsfile-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ddsfile/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ddsfile-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ddsfile/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ab74413045f6d2b55bb1d72065dafce27cec028e813d866d60da1a6a3431b79d [INFO] running `"docker" "start" "-a" "ab74413045f6d2b55bb1d72065dafce27cec028e813d866d60da1a6a3431b79d"` [INFO] [stderr] Checking ddsfile v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/pixel_format.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/pixel_format.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:253:13 [INFO] [stderr] | [INFO] [stderr] 253 | reserved1: reserved1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reserved1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | spf: spf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `spf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | caps3: caps3, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `caps3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | caps4: caps4, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `caps4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | reserved2: reserved2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reserved2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header10.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | resource_dimension: resource_dimension, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resource_dimension` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header10.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | array_size: array_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header10.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | alpha_mode: alpha_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alpha_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header10.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | misc_flag: misc_flag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `misc_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header10.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | array_size: array_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/pixel_format.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/pixel_format.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | header10: header10, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `header10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | data: data [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:253:13 [INFO] [stderr] | [INFO] [stderr] 253 | reserved1: reserved1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reserved1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | spf: spf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `spf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | caps3: caps3, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `caps3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | caps4: caps4, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `caps4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | reserved2: reserved2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reserved2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header10.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | resource_dimension: resource_dimension, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resource_dimension` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header10.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | array_size: array_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header10.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | alpha_mode: alpha_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alpha_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header10.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | misc_flag: misc_flag, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `misc_flag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/header10.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | array_size: array_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | header10: header10, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `header10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | data: data [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:237:27 [INFO] [stderr] | [INFO] [stderr] 237 | pub const DXT1: u32 = 0x31545844; //u32_code!(b"DXT1"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3154_5844` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:238:27 [INFO] [stderr] | [INFO] [stderr] 238 | pub const DXT2: u32 = 0x32545844; //u32_code!(b"DXT2"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3254_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:239:27 [INFO] [stderr] | [INFO] [stderr] 239 | pub const DXT3: u32 = 0x33545844; //u32_code!(b"DXT3"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3354_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:240:27 [INFO] [stderr] | [INFO] [stderr] 240 | pub const DXT4: u32 = 0x34545844; //u32_code!(b"DXT4"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3454_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:241:27 [INFO] [stderr] | [INFO] [stderr] 241 | pub const DXT5: u32 = 0x35545844; //u32_code!(b"DXT5"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3554_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:242:32 [INFO] [stderr] | [INFO] [stderr] 242 | pub const R8G8_B8G8: u32 = 0x47424752; //u32_code!(b"RGBG"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4742_4752` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:243:32 [INFO] [stderr] | [INFO] [stderr] 243 | pub const G8R8_G8B8: u32 = 0x42475247;//u32_code!(b"GRGB"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4247_5247` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:252:27 [INFO] [stderr] | [INFO] [stderr] 252 | pub const UYVY: u32 = 0x59565955; //u32_code!(b"UYVY"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5956_5955` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:253:27 [INFO] [stderr] | [INFO] [stderr] 253 | pub const YUY2: u32 = 0x32595559; //u32_code!(b"YUY2"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3259_5559` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:255:27 [INFO] [stderr] | [INFO] [stderr] 255 | pub const ATI1: u32 = 0x31495441; //u32_code!(b"ATI1"); // BC4 unorm [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3149_5441` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:256:27 [INFO] [stderr] | [INFO] [stderr] 256 | pub const ATI2: u32 = 0x32495441; //u32_code!(b"ATI2"); // BC5 unorm [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3249_5441` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:257:27 [INFO] [stderr] | [INFO] [stderr] 257 | pub const DX10: u32 = 0x30315844; //u32_code!(b"DX10"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3031_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:260:32 [INFO] [stderr] | [INFO] [stderr] 260 | pub const BC1_UNORM: u32 = 0x31545844; //u32_code!(b"DXT1"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3154_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:261:32 [INFO] [stderr] | [INFO] [stderr] 261 | pub const BC2_UNORM: u32 = 0x33545844; //u32_code!(b"DXT3"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3354_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:262:32 [INFO] [stderr] | [INFO] [stderr] 262 | pub const BC3_UNORM: u32 = 0x35545844; //u32_code!(b"DXT5"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3554_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:263:32 [INFO] [stderr] | [INFO] [stderr] 263 | pub const BC4_UNORM: u32 = 0x55344342; //u32_code!(b"BC4U"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5534_4342` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:264:32 [INFO] [stderr] | [INFO] [stderr] 264 | pub const BC4_SNORM: u32 = 0x53344342; //u32_code!(b"BC4S"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5334_4342` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:265:32 [INFO] [stderr] | [INFO] [stderr] 265 | pub const BC5_UNORM: u32 = 0x32495441; //u32_code!(b"ATI2"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3249_5441` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:266:32 [INFO] [stderr] | [INFO] [stderr] 266 | pub const BC5_SNORM: u32 = 0x53354342; //u32_code!(b"BC5S"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5335_4342` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:267:38 [INFO] [stderr] | [INFO] [stderr] 267 | pub const R8G8_B8G8_UNORM: u32 = 0x47424752; //u32_code!(b"RGBG"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4742_4752` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:268:38 [INFO] [stderr] | [INFO] [stderr] 268 | pub const G8R8_G8B8_UNORM: u32 = 0x42475247; //u32_code!(b"GRGB"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4247_5247` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/format/d3d.rs:248:41 [INFO] [stderr] | [INFO] [stderr] 248 | D3DFormat::A8B8G8R8 => Some(0x00ff_00000), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0x0000_0ff0_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_digit_groups)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:335:92 [INFO] [stderr] | [INFO] [stderr] 335 | (false, true, true, Some(32), Some( 0xff), Some( 0xff00), Some( 0xff0000), Some(0xff000000)) => Some(D3DFormat::A8B8G8R8), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:335:108 [INFO] [stderr] | [INFO] [stderr] 335 | (false, true, true, Some(32), Some( 0xff), Some( 0xff00), Some( 0xff0000), Some(0xff000000)) => Some(D3DFormat::A8B8G8R8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:336:72 [INFO] [stderr] | [INFO] [stderr] 336 | (false, true, false, Some(32), Some( 0xffff), Some(0xffff0000), None, None ) => Some(D3DFormat::G16R16), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:337:90 [INFO] [stderr] | [INFO] [stderr] 337 | (false, true, true, Some(32), Some( 0x3ff), Some( 0xffc00), Some(0x3ff00000), None ) => Some(D3DFormat::A2B10G10R10), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3ff0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:341:56 [INFO] [stderr] | [INFO] [stderr] 341 | (false, true, true, Some(32), Some( 0xff0000), Some( 0xff00), Some( 0xff), Some(0xff000000)) => Some(D3DFormat::A8R8G8B8), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:341:108 [INFO] [stderr] | [INFO] [stderr] 341 | (false, true, true, Some(32), Some( 0xff0000), Some( 0xff00), Some( 0xff), Some(0xff000000)) => Some(D3DFormat::A8R8G8B8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:342:56 [INFO] [stderr] | [INFO] [stderr] 342 | (false, true, false, Some(32), Some( 0xff0000), Some( 0xff00), Some( 0xff), None ) => Some(D3DFormat::X8R8G8B8), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:343:92 [INFO] [stderr] | [INFO] [stderr] 343 | (false, true, false, Some(32), Some( 0xff), Some( 0xff00), Some( 0xff0000), None ) => Some(D3DFormat::X8B8G8R8), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:344:54 [INFO] [stderr] | [INFO] [stderr] 344 | (false, true, true, Some(32), Some(0x3ff00000), Some( 0xffc00), Some( 0x3ff), Some(0xc0000000)) => Some(D3DFormat::A2R10G10B10), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3ff0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:344:108 [INFO] [stderr] | [INFO] [stderr] 344 | (false, true, true, Some(32), Some(0x3ff00000), Some( 0xffc00), Some( 0x3ff), Some(0xc0000000)) => Some(D3DFormat::A2R10G10B10), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:345:56 [INFO] [stderr] | [INFO] [stderr] 345 | (false, true, false, Some(24), Some( 0xff0000), Some( 0xff00), Some( 0xff), None ) => Some(D3DFormat::R8G8B8), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/dxgi.rs:149:40 [INFO] [stderr] | [INFO] [stderr] 149 | Force_UInt = -0x80000000, // 0xffffffff [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/header.rs:324:23 [INFO] [stderr] | [INFO] [stderr] 324 | const DEPTH = 0x800000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/header.rs:334:24 [INFO] [stderr] | [INFO] [stderr] 334 | const MIPMAP = 0x400000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/header.rs:357:24 [INFO] [stderr] | [INFO] [stderr] 357 | const VOLUME = 0x200000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | const MAGIC: u32 = 0x20534444; // b"DDS " in little endian [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2053_4444` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:237:27 [INFO] [stderr] | [INFO] [stderr] 237 | pub const DXT1: u32 = 0x31545844; //u32_code!(b"DXT1"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3154_5844` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:238:27 [INFO] [stderr] | [INFO] [stderr] 238 | pub const DXT2: u32 = 0x32545844; //u32_code!(b"DXT2"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3254_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:239:27 [INFO] [stderr] | [INFO] [stderr] 239 | pub const DXT3: u32 = 0x33545844; //u32_code!(b"DXT3"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3354_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:240:27 [INFO] [stderr] | [INFO] [stderr] 240 | pub const DXT4: u32 = 0x34545844; //u32_code!(b"DXT4"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3454_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:241:27 [INFO] [stderr] | [INFO] [stderr] 241 | pub const DXT5: u32 = 0x35545844; //u32_code!(b"DXT5"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3554_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:242:32 [INFO] [stderr] | [INFO] [stderr] 242 | pub const R8G8_B8G8: u32 = 0x47424752; //u32_code!(b"RGBG"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4742_4752` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:243:32 [INFO] [stderr] | [INFO] [stderr] 243 | pub const G8R8_G8B8: u32 = 0x42475247;//u32_code!(b"GRGB"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4247_5247` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:252:27 [INFO] [stderr] | [INFO] [stderr] 252 | pub const UYVY: u32 = 0x59565955; //u32_code!(b"UYVY"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5956_5955` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:253:27 [INFO] [stderr] | [INFO] [stderr] 253 | pub const YUY2: u32 = 0x32595559; //u32_code!(b"YUY2"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3259_5559` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:255:27 [INFO] [stderr] | [INFO] [stderr] 255 | pub const ATI1: u32 = 0x31495441; //u32_code!(b"ATI1"); // BC4 unorm [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3149_5441` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:256:27 [INFO] [stderr] | [INFO] [stderr] 256 | pub const ATI2: u32 = 0x32495441; //u32_code!(b"ATI2"); // BC5 unorm [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3249_5441` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:257:27 [INFO] [stderr] | [INFO] [stderr] 257 | pub const DX10: u32 = 0x30315844; //u32_code!(b"DX10"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3031_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:260:32 [INFO] [stderr] | [INFO] [stderr] 260 | pub const BC1_UNORM: u32 = 0x31545844; //u32_code!(b"DXT1"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3154_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:261:32 [INFO] [stderr] | [INFO] [stderr] 261 | pub const BC2_UNORM: u32 = 0x33545844; //u32_code!(b"DXT3"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3354_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:262:32 [INFO] [stderr] | [INFO] [stderr] 262 | pub const BC3_UNORM: u32 = 0x35545844; //u32_code!(b"DXT5"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3554_5844` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:263:32 [INFO] [stderr] | [INFO] [stderr] 263 | pub const BC4_UNORM: u32 = 0x55344342; //u32_code!(b"BC4U"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5534_4342` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:264:32 [INFO] [stderr] | [INFO] [stderr] 264 | pub const BC4_SNORM: u32 = 0x53344342; //u32_code!(b"BC4S"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5334_4342` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:265:32 [INFO] [stderr] | [INFO] [stderr] 265 | pub const BC5_UNORM: u32 = 0x32495441; //u32_code!(b"ATI2"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3249_5441` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:266:32 [INFO] [stderr] | [INFO] [stderr] 266 | pub const BC5_SNORM: u32 = 0x53354342; //u32_code!(b"BC5S"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5335_4342` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:267:38 [INFO] [stderr] | [INFO] [stderr] 267 | pub const R8G8_B8G8_UNORM: u32 = 0x47424752; //u32_code!(b"RGBG"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4742_4752` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/pixel_format.rs:268:38 [INFO] [stderr] | [INFO] [stderr] 268 | pub const G8R8_G8B8_UNORM: u32 = 0x42475247; //u32_code!(b"GRGB"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4247_5247` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/format/d3d.rs:248:41 [INFO] [stderr] | [INFO] [stderr] 248 | D3DFormat::A8B8G8R8 => Some(0x00ff_00000), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0x0000_0ff0_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_digit_groups)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:335:92 [INFO] [stderr] | [INFO] [stderr] 335 | (false, true, true, Some(32), Some( 0xff), Some( 0xff00), Some( 0xff0000), Some(0xff000000)) => Some(D3DFormat::A8B8G8R8), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:335:108 [INFO] [stderr] | [INFO] [stderr] 335 | (false, true, true, Some(32), Some( 0xff), Some( 0xff00), Some( 0xff0000), Some(0xff000000)) => Some(D3DFormat::A8B8G8R8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:336:72 [INFO] [stderr] | [INFO] [stderr] 336 | (false, true, false, Some(32), Some( 0xffff), Some(0xffff0000), None, None ) => Some(D3DFormat::G16R16), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:337:90 [INFO] [stderr] | [INFO] [stderr] 337 | (false, true, true, Some(32), Some( 0x3ff), Some( 0xffc00), Some(0x3ff00000), None ) => Some(D3DFormat::A2B10G10R10), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3ff0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:341:56 [INFO] [stderr] | [INFO] [stderr] 341 | (false, true, true, Some(32), Some( 0xff0000), Some( 0xff00), Some( 0xff), Some(0xff000000)) => Some(D3DFormat::A8R8G8B8), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:341:108 [INFO] [stderr] | [INFO] [stderr] 341 | (false, true, true, Some(32), Some( 0xff0000), Some( 0xff00), Some( 0xff), Some(0xff000000)) => Some(D3DFormat::A8R8G8B8), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:342:56 [INFO] [stderr] | [INFO] [stderr] 342 | (false, true, false, Some(32), Some( 0xff0000), Some( 0xff00), Some( 0xff), None ) => Some(D3DFormat::X8R8G8B8), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:343:92 [INFO] [stderr] | [INFO] [stderr] 343 | (false, true, false, Some(32), Some( 0xff), Some( 0xff00), Some( 0xff0000), None ) => Some(D3DFormat::X8B8G8R8), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:344:54 [INFO] [stderr] | [INFO] [stderr] 344 | (false, true, true, Some(32), Some(0x3ff00000), Some( 0xffc00), Some( 0x3ff), Some(0xc0000000)) => Some(D3DFormat::A2R10G10B10), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3ff0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:344:108 [INFO] [stderr] | [INFO] [stderr] 344 | (false, true, true, Some(32), Some(0x3ff00000), Some( 0xffc00), Some( 0x3ff), Some(0xc0000000)) => Some(D3DFormat::A2R10G10B10), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/d3d.rs:345:56 [INFO] [stderr] | [INFO] [stderr] 345 | (false, true, false, Some(24), Some( 0xff0000), Some( 0xff00), Some( 0xff), None ) => Some(D3DFormat::R8G8B8), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format/dxgi.rs:149:40 [INFO] [stderr] | [INFO] [stderr] 149 | Force_UInt = -0x80000000, // 0xffffffff [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/header.rs:324:23 [INFO] [stderr] | [INFO] [stderr] 324 | const DEPTH = 0x800000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/header.rs:334:24 [INFO] [stderr] | [INFO] [stderr] 334 | const MIPMAP = 0x400000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/header.rs:357:24 [INFO] [stderr] | [INFO] [stderr] 357 | const VOLUME = 0x200000; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | const MAGIC: u32 = 0x20534444; // b"DDS " in little endian [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2053_4444` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/format/pixel_format.rs:164:37 [INFO] [stderr] | [INFO] [stderr] 164 | pf.rgb_bit_count = Some(bpp as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(bpp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/format/pixel_format.rs:187:37 [INFO] [stderr] | [INFO] [stderr] 187 | pf.rgb_bit_count = Some(bpp as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(bpp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/format/d3d.rs:81:27 [INFO] [stderr] | [INFO] [stderr] 81 | Some((width * bpp as u32 + 7) / 8) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(bpp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/d3d.rs:194:23 [INFO] [stderr] | [INFO] [stderr] 194 | pub fn r_bit_mask(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/d3d.rs:220:23 [INFO] [stderr] | [INFO] [stderr] 220 | pub fn g_bit_mask(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/d3d.rs:246:23 [INFO] [stderr] | [INFO] [stderr] 246 | pub fn b_bit_mask(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/d3d.rs:272:23 [INFO] [stderr] | [INFO] [stderr] 272 | pub fn a_bit_mask(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/format/dxgi.rs:165:27 [INFO] [stderr] | [INFO] [stderr] 165 | Some((width * bpp as u32 + 7) / 8) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(bpp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/format/mod.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | Some((bpp as u32 + 7) / 8) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(bpp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/header.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | header.flags = header.flags | HeaderFlags::LINEARSIZE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header.flags |= HeaderFlags::LINEARSIZE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/header.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | header.flags = header.flags | HeaderFlags::PITCH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header.flags |= HeaderFlags::PITCH` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/header.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | header.flags = header.flags | HeaderFlags::LINEARSIZE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header.flags |= HeaderFlags::LINEARSIZE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/header.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | header.flags = header.flags | HeaderFlags::PITCH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header.flags |= HeaderFlags::PITCH` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/format/pixel_format.rs:164:37 [INFO] [stderr] | [INFO] [stderr] 164 | pf.rgb_bit_count = Some(bpp as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(bpp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/format/pixel_format.rs:187:37 [INFO] [stderr] | [INFO] [stderr] 187 | pf.rgb_bit_count = Some(bpp as u32) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(bpp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/format/d3d.rs:81:27 [INFO] [stderr] | [INFO] [stderr] 81 | Some((width * bpp as u32 + 7) / 8) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(bpp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/header10.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | flags = flags | MiscFlag::TEXTURECUBE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= MiscFlag::TEXTURECUBE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/d3d.rs:194:23 [INFO] [stderr] | [INFO] [stderr] 194 | pub fn r_bit_mask(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/d3d.rs:220:23 [INFO] [stderr] | [INFO] [stderr] 220 | pub fn g_bit_mask(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/header10.rs:106:47 [INFO] [stderr] | [INFO] [stderr] 106 | DxgiFormat::from_u32(dxgi_format).ok_or( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 107 | | ErrorKind::InvalidField("dxgi_format".to_owned()).into() [INFO] [stderr] 108 | | ); [INFO] [stderr] | |_____________^ help: try this: `ok_or_else(|| ErrorKind::InvalidField("dxgi_format".to_owned()).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/header10.rs:110:66 [INFO] [stderr] | [INFO] [stderr] 110 | D3D10ResourceDimension::from_u32(resource_dimension).ok_or( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 111 | | ErrorKind::InvalidField("resource_dimension".to_owned()).into() [INFO] [stderr] 112 | | ); [INFO] [stderr] | |_____________^ help: try this: `ok_or_else(|| ErrorKind::InvalidField("resource_dimension".to_owned()).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/header10.rs:115:45 [INFO] [stderr] | [INFO] [stderr] 115 | AlphaMode::from_u32(alpha_mode).ok_or( [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 116 | | ErrorKind::InvalidField("alpha mode (misc_flags2)".to_owned()).into() [INFO] [stderr] 117 | | ); [INFO] [stderr] | |_____________^ help: try this: `ok_or_else(|| ErrorKind::InvalidField("alpha mode (misc_flags2)".to_owned()).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/d3d.rs:246:23 [INFO] [stderr] | [INFO] [stderr] 246 | pub fn b_bit_mask(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/d3d.rs:272:23 [INFO] [stderr] | [INFO] [stderr] 272 | pub fn a_bit_mask(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn new_dxgi(height: u32, width: u32, depth: Option, [INFO] [stderr] 94 | | format: DxgiFormat, [INFO] [stderr] 95 | | mipmap_levels: Option, array_layers: Option, [INFO] [stderr] 96 | | caps2: Option, is_cubemap: bool, [INFO] [stderr] ... | [INFO] [stderr] 132 | | }) [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:223:29 [INFO] [stderr] | [INFO] [stderr] 223 | return Some(bpp as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(bpp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:315:46 [INFO] [stderr] | [INFO] [stderr] 315 | self.data.get(offset .. offset+size).ok_or( [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 316 | | ErrorKind::OutOfBounds.into()) [INFO] [stderr] | |__________________________________________^ help: try this: `ok_or_else(|| ErrorKind::OutOfBounds.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:327:50 [INFO] [stderr] | [INFO] [stderr] 327 | self.data.get_mut(offset .. offset+size).ok_or( [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 328 | | ErrorKind::OutOfBounds.into()) [INFO] [stderr] | |__________________________________________^ help: try this: `ok_or_else(|| ErrorKind::OutOfBounds.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/format/dxgi.rs:165:27 [INFO] [stderr] | [INFO] [stderr] 165 | Some((width * bpp as u32 + 7) / 8) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(bpp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/format/mod.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | Some((bpp as u32 + 7) / 8) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(bpp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/header.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | header.flags = header.flags | HeaderFlags::LINEARSIZE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header.flags |= HeaderFlags::LINEARSIZE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/header.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | header.flags = header.flags | HeaderFlags::PITCH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header.flags |= HeaderFlags::PITCH` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/header.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | header.flags = header.flags | HeaderFlags::LINEARSIZE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header.flags |= HeaderFlags::LINEARSIZE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/header.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | header.flags = header.flags | HeaderFlags::PITCH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header.flags |= HeaderFlags::PITCH` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/header10.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | flags = flags | MiscFlag::TEXTURECUBE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= MiscFlag::TEXTURECUBE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/header10.rs:106:47 [INFO] [stderr] | [INFO] [stderr] 106 | DxgiFormat::from_u32(dxgi_format).ok_or( [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 107 | | ErrorKind::InvalidField("dxgi_format".to_owned()).into() [INFO] [stderr] 108 | | ); [INFO] [stderr] | |_____________^ help: try this: `ok_or_else(|| ErrorKind::InvalidField("dxgi_format".to_owned()).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/header10.rs:110:66 [INFO] [stderr] | [INFO] [stderr] 110 | D3D10ResourceDimension::from_u32(resource_dimension).ok_or( [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 111 | | ErrorKind::InvalidField("resource_dimension".to_owned()).into() [INFO] [stderr] 112 | | ); [INFO] [stderr] | |_____________^ help: try this: `ok_or_else(|| ErrorKind::InvalidField("resource_dimension".to_owned()).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/header10.rs:115:45 [INFO] [stderr] | [INFO] [stderr] 115 | AlphaMode::from_u32(alpha_mode).ok_or( [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 116 | | ErrorKind::InvalidField("alpha mode (misc_flags2)".to_owned()).into() [INFO] [stderr] 117 | | ); [INFO] [stderr] | |_____________^ help: try this: `ok_or_else(|| ErrorKind::InvalidField("alpha mode (misc_flags2)".to_owned()).into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn new_dxgi(height: u32, width: u32, depth: Option, [INFO] [stderr] 94 | | format: DxgiFormat, [INFO] [stderr] 95 | | mipmap_levels: Option, array_layers: Option, [INFO] [stderr] 96 | | caps2: Option, is_cubemap: bool, [INFO] [stderr] ... | [INFO] [stderr] 132 | | }) [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:223:29 [INFO] [stderr] | [INFO] [stderr] 223 | return Some(bpp as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(bpp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:315:46 [INFO] [stderr] | [INFO] [stderr] 315 | self.data.get(offset .. offset+size).ok_or( [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 316 | | ErrorKind::OutOfBounds.into()) [INFO] [stderr] | |__________________________________________^ help: try this: `ok_or_else(|| ErrorKind::OutOfBounds.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:327:50 [INFO] [stderr] | [INFO] [stderr] 327 | self.data.get_mut(offset .. offset+size).ok_or( [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 328 | | ErrorKind::OutOfBounds.into()) [INFO] [stderr] | |__________________________________________^ help: try this: `ok_or_else(|| ErrorKind::OutOfBounds.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/bin/ddsinfo.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | let filename = match env::args().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/bin/ddsinfo.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | let filename = match env::args().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.76s [INFO] running `"docker" "inspect" "ab74413045f6d2b55bb1d72065dafce27cec028e813d866d60da1a6a3431b79d"` [INFO] running `"docker" "rm" "-f" "ab74413045f6d2b55bb1d72065dafce27cec028e813d866d60da1a6a3431b79d"` [INFO] [stdout] ab74413045f6d2b55bb1d72065dafce27cec028e813d866d60da1a6a3431b79d