[INFO] crate dd-lib 0.2.1 is already in cache [INFO] extracting crate dd-lib 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/dd-lib/0.2.1 [INFO] extracting crate dd-lib 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dd-lib/0.2.1 [INFO] validating manifest of dd-lib-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dd-lib-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dd-lib-0.2.1 [INFO] finished frobbing dd-lib-0.2.1 [INFO] frobbed toml for dd-lib-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/dd-lib/0.2.1/Cargo.toml [INFO] started frobbing dd-lib-0.2.1 [INFO] finished frobbing dd-lib-0.2.1 [INFO] frobbed toml for dd-lib-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dd-lib/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dd-lib-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dd-lib/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd5abc2b339d834ddf1a79da6a45920d503c05550a90e0e76b90ea9749a92b5a [INFO] running `"docker" "start" "-a" "bd5abc2b339d834ddf1a79da6a45920d503c05550a90e0e76b90ea9749a92b5a"` [INFO] [stderr] Checking encoding8 v0.3.2 [INFO] [stderr] Checking dd-lib v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/io/copy.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | n => c.convert_copy(&buf[..n]), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | let e = ErrHandler::new(err, o); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:156:27 [INFO] [stderr] | [INFO] [stderr] 156 | opts::Mode::Block(n) => io::copy::block(r, &mut w, c, e, n), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | opts::Mode::Unblock(n) => io::copy::unblock(r, &mut w, c, e, n), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/io/copy.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | n => c.convert_copy(&buf[..n]), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | let e = ErrHandler::new(err, o); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:156:27 [INFO] [stderr] | [INFO] [stderr] 156 | opts::Mode::Block(n) => io::copy::block(r, &mut w, c, e, n), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | opts::Mode::Unblock(n) => io::copy::unblock(r, &mut w, c, e, n), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/io/read.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | / return Err(Error::from(ConflictingOption( [INFO] [stderr] 96 | | "iflag 'append' is only usable with an input file", [INFO] [stderr] 97 | | ))) [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 95 | Err(Error::from(ConflictingOption( [INFO] [stderr] 96 | "iflag 'append' is only usable with an input file", [INFO] [stderr] 97 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/io/read.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | / return Err(Error::from(ConflictingOption( [INFO] [stderr] 101 | | "options 'input_seek' and 'seek_bytes' are only usable with an input file", [INFO] [stderr] 102 | | ))) [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 100 | Err(Error::from(ConflictingOption( [INFO] [stderr] 101 | "options 'input_seek' and 'seek_bytes' are only usable with an input file", [INFO] [stderr] 102 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io/copy.rs:25:30 [INFO] [stderr] | [INFO] [stderr] 25 | Some(ref buf) if buf.len() == 0 => return Ok(Success::Bytes { bytes, start }), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io/copy.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | buf.len() != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io/copy.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | buf.len() != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/io/copy.rs:136:30 [INFO] [stderr] | [INFO] [stderr] 136 | e.handle(w.write_all(&mut buf))?; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/io/conv.rs:124:19 [INFO] [stderr] | [INFO] [stderr] 124 | pub fn new(c: &CFlag) -> Result { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `CFlag` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/io/conv.rs:151:15 [INFO] [stderr] | [INFO] [stderr] 151 | fn new(c: &CFlag) -> Result { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `CFlag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io/errhandler.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | writeln!(self.e, "io error: <{}>; continuing", err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io/errhandler.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | / writeln!( [INFO] [stderr] 73 | | self, [INFO] [stderr] 74 | | "dd in progress: unblock: elapsed: {}, wrote {} lines", [INFO] [stderr] 75 | | elapsed(&start), [INFO] [stderr] 76 | | lines [INFO] [stderr] 77 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io/errhandler.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | / writeln!( [INFO] [stderr] 84 | | self, [INFO] [stderr] 85 | | "dd in progress: unblock: elapsed: {}, wrote {} fixed-length blocks", [INFO] [stderr] 86 | | elapsed(&start), [INFO] [stderr] 87 | | blocks [INFO] [stderr] 88 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/opts/flags/cflag.rs:96:60 [INFO] [stderr] | [INFO] [stderr] 96 | for flag in s.split(',').map(str::trim).filter(|s| s.len() > 0) { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/opts/flags/iflag.rs:69:60 [INFO] [stderr] | [INFO] [stderr] 69 | for flag in s.split(',').map(str::trim).filter(|s| s.len() > 0) { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/opts/flags/oflag.rs:60:60 [INFO] [stderr] | [INFO] [stderr] 60 | for flag in s.split(',').map(str::trim).filter(|s| s.len() > 0) { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/opts/mod.rs:335:29 [INFO] [stderr] | [INFO] [stderr] 335 | let mut split = s.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/io/read.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | / return Err(Error::from(ConflictingOption( [INFO] [stderr] 96 | | "iflag 'append' is only usable with an input file", [INFO] [stderr] 97 | | ))) [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 95 | Err(Error::from(ConflictingOption( [INFO] [stderr] 96 | "iflag 'append' is only usable with an input file", [INFO] [stderr] 97 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/io/read.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | / return Err(Error::from(ConflictingOption( [INFO] [stderr] 101 | | "options 'input_seek' and 'seek_bytes' are only usable with an input file", [INFO] [stderr] 102 | | ))) [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 100 | Err(Error::from(ConflictingOption( [INFO] [stderr] 101 | "options 'input_seek' and 'seek_bytes' are only usable with an input file", [INFO] [stderr] 102 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io/copy.rs:25:30 [INFO] [stderr] | [INFO] [stderr] 25 | Some(ref buf) if buf.len() == 0 => return Ok(Success::Bytes { bytes, start }), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io/copy.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | buf.len() != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/io/copy.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | buf.len() != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/io/copy.rs:136:30 [INFO] [stderr] | [INFO] [stderr] 136 | e.handle(w.write_all(&mut buf))?; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/io/conv.rs:124:19 [INFO] [stderr] | [INFO] [stderr] 124 | pub fn new(c: &CFlag) -> Result { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `CFlag` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/io/conv.rs:151:15 [INFO] [stderr] | [INFO] [stderr] 151 | fn new(c: &CFlag) -> Result { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `CFlag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io/errhandler.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | writeln!(self.e, "io error: <{}>; continuing", err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io/errhandler.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | / writeln!( [INFO] [stderr] 73 | | self, [INFO] [stderr] 74 | | "dd in progress: unblock: elapsed: {}, wrote {} lines", [INFO] [stderr] 75 | | elapsed(&start), [INFO] [stderr] 76 | | lines [INFO] [stderr] 77 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/io/errhandler.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | / writeln!( [INFO] [stderr] 84 | | self, [INFO] [stderr] 85 | | "dd in progress: unblock: elapsed: {}, wrote {} fixed-length blocks", [INFO] [stderr] 86 | | elapsed(&start), [INFO] [stderr] 87 | | blocks [INFO] [stderr] 88 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/opts/flags/cflag.rs:96:60 [INFO] [stderr] | [INFO] [stderr] 96 | for flag in s.split(',').map(str::trim).filter(|s| s.len() > 0) { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/opts/flags/iflag.rs:69:60 [INFO] [stderr] | [INFO] [stderr] 69 | for flag in s.split(',').map(str::trim).filter(|s| s.len() > 0) { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/opts/flags/oflag.rs:60:60 [INFO] [stderr] | [INFO] [stderr] 60 | for flag in s.split(',').map(str::trim).filter(|s| s.len() > 0) { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/opts/mod.rs:335:29 [INFO] [stderr] | [INFO] [stderr] 335 | let mut split = s.split("="); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.18s [INFO] running `"docker" "inspect" "bd5abc2b339d834ddf1a79da6a45920d503c05550a90e0e76b90ea9749a92b5a"` [INFO] running `"docker" "rm" "-f" "bd5abc2b339d834ddf1a79da6a45920d503c05550a90e0e76b90ea9749a92b5a"` [INFO] [stdout] bd5abc2b339d834ddf1a79da6a45920d503c05550a90e0e76b90ea9749a92b5a