[INFO] crate dcpu16-gui 0.2.0 is already in cache [INFO] extracting crate dcpu16-gui 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/dcpu16-gui/0.2.0 [INFO] extracting crate dcpu16-gui 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dcpu16-gui/0.2.0 [INFO] validating manifest of dcpu16-gui-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dcpu16-gui-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dcpu16-gui-0.2.0 [INFO] finished frobbing dcpu16-gui-0.2.0 [INFO] frobbed toml for dcpu16-gui-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/dcpu16-gui/0.2.0/Cargo.toml [INFO] started frobbing dcpu16-gui-0.2.0 [INFO] finished frobbing dcpu16-gui-0.2.0 [INFO] frobbed toml for dcpu16-gui-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dcpu16-gui/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dcpu16-gui-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dcpu16-gui/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a33ecb398624eb596b15374f7011a0383f93d1f9391ef6fe7ce3b84c423981a1 [INFO] running `"docker" "start" "-a" "a33ecb398624eb596b15374f7011a0383f93d1f9391ef6fe7ce3b84c423981a1"` [INFO] [stderr] Checking dcpu16 v0.1.0 [INFO] [stderr] Checking gfx_core v0.4.0 [INFO] [stderr] Checking pistoncore-event_loop v0.27.0 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.33.0 [INFO] [stderr] Checking piston v0.27.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.36.2 [INFO] [stderr] Checking gfx v0.12.2 [INFO] [stderr] Checking gfx_device_gl v0.11.2 [INFO] [stderr] Checking piston-gfx_texture v0.18.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.33.2 [INFO] [stderr] Checking piston_window v0.58.0 [INFO] [stderr] Checking dcpu16-gui v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | const DEFAULT_FONT: &'static [u16] = &[ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | const DEFAULT_PALETTE: &'static [u16] = &[ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | const LOGO_PIXELS: &'static [usize] = &[ [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:232:53 [INFO] [stderr] | [INFO] [stderr] 232 | fn process_interrupt(&mut self, cpu: &mut DCPU) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:398:35 [INFO] [stderr] | [INFO] [stderr] 398 | img.put_pixel((k as u32 % MONITOR_WIDTH), k as u32 / MONITOR_WIDTH as u32, color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | let mut slice = &mut v[..]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GUIHWMonitorLEM1802` [INFO] [stderr] --> src/main.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn new() -> GUIHWMonitorLEM1802 { [INFO] [stderr] 94 | | GUIHWMonitorLEM1802{ [INFO] [stderr] 95 | | connected: false, [INFO] [stderr] 96 | | ram_location: 0, [INFO] [stderr] ... | [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:131:18 [INFO] [stderr] | [INFO] [stderr] 131 | ((cpu.mem[(loc as usize + c * 2) % dcpu::MEMORY_SIZE] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(cpu.mem[(loc as usize + c * 2) % dcpu::MEMORY_SIZE])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:132:18 [INFO] [stderr] | [INFO] [stderr] 132 | (cpu.mem[(loc as usize + c * 2 + 1) % dcpu::MEMORY_SIZE] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(cpu.mem[(loc as usize + c * 2 + 1) % dcpu::MEMORY_SIZE])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:135:18 [INFO] [stderr] | [INFO] [stderr] 135 | ((DEFAULT_FONT[c * 2] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(DEFAULT_FONT[c * 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:136:18 [INFO] [stderr] | [INFO] [stderr] 136 | (DEFAULT_FONT[c * 2 + 1] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(DEFAULT_FONT[c * 2 + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `DEFAULT_FONT` [INFO] [stderr] --> src/main.rs:263:26 [INFO] [stderr] | [INFO] [stderr] 263 | for i in 0..DEFAULT_FONT.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 263 | for (i, ) in DEFAULT_FONT.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `DEFAULT_PALETTE` [INFO] [stderr] --> src/main.rs:269:26 [INFO] [stderr] | [INFO] [stderr] 269 | for i in 0..DEFAULT_PALETTE.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 269 | for (i, ) in DEFAULT_PALETTE.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | let ref filename = matches.free[0]; [INFO] [stderr] | ----^^^^^^^^^^^^------------------- help: try: `let filename = &matches.free[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `::from_image` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:371:79 [INFO] [stderr] | [INFO] [stderr] 371 | let mut texture = piston_window::Texture::from_image(&mut window.factory, &mut img, &text_sett).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:390:16 [INFO] [stderr] | [INFO] [stderr] 390 | if let Some(_) = e.render_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 391 | | // TODO: Make the speed a setting [INFO] [stderr] 392 | | cpu.run(3000); [INFO] [stderr] 393 | | let dev = cpu.devices.get(0).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 407 | | } [INFO] [stderr] 408 | | } [INFO] [stderr] | |_________- help: try this: `if e.render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:393:23 [INFO] [stderr] | [INFO] [stderr] 393 | let dev = cpu.devices.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cpu.devices[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:410:23 [INFO] [stderr] | [INFO] [stderr] 410 | let dev = cpu.devices.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cpu.devices[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:413:39 [INFO] [stderr] | [INFO] [stderr] 413 | piston_window::clear([col_r as f32 / 255.0, col_g as f32 / 255.0, col_b as f32 / 255.0, 1.0], g); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(col_r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:413:61 [INFO] [stderr] | [INFO] [stderr] 413 | piston_window::clear([col_r as f32 / 255.0, col_g as f32 / 255.0, col_b as f32 / 255.0, 1.0], g); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(col_g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:413:83 [INFO] [stderr] | [INFO] [stderr] 413 | piston_window::clear([col_r as f32 / 255.0, col_g as f32 / 255.0, col_b as f32 / 255.0, 1.0], g); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(col_b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:416:28 [INFO] [stderr] | [INFO] [stderr] 416 | .trans(BORDER as f64, BORDER as f64).zoom(SCALE as f64), g); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(BORDER)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:416:43 [INFO] [stderr] | [INFO] [stderr] 416 | .trans(BORDER as f64, BORDER as f64).zoom(SCALE as f64), g); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(BORDER)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:416:63 [INFO] [stderr] | [INFO] [stderr] 416 | .trans(BORDER as f64, BORDER as f64).zoom(SCALE as f64), g); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | const DEFAULT_FONT: &'static [u16] = &[ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | const DEFAULT_PALETTE: &'static [u16] = &[ [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | const LOGO_PIXELS: &'static [usize] = &[ [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:232:53 [INFO] [stderr] | [INFO] [stderr] 232 | fn process_interrupt(&mut self, cpu: &mut DCPU) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/main.rs:398:35 [INFO] [stderr] | [INFO] [stderr] 398 | img.put_pixel((k as u32 % MONITOR_WIDTH), k as u32 / MONITOR_WIDTH as u32, color); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | let mut slice = &mut v[..]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `GUIHWMonitorLEM1802` [INFO] [stderr] --> src/main.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn new() -> GUIHWMonitorLEM1802 { [INFO] [stderr] 94 | | GUIHWMonitorLEM1802{ [INFO] [stderr] 95 | | connected: false, [INFO] [stderr] 96 | | ram_location: 0, [INFO] [stderr] ... | [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:131:18 [INFO] [stderr] | [INFO] [stderr] 131 | ((cpu.mem[(loc as usize + c * 2) % dcpu::MEMORY_SIZE] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(cpu.mem[(loc as usize + c * 2) % dcpu::MEMORY_SIZE])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:132:18 [INFO] [stderr] | [INFO] [stderr] 132 | (cpu.mem[(loc as usize + c * 2 + 1) % dcpu::MEMORY_SIZE] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(cpu.mem[(loc as usize + c * 2 + 1) % dcpu::MEMORY_SIZE])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:135:18 [INFO] [stderr] | [INFO] [stderr] 135 | ((DEFAULT_FONT[c * 2] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(DEFAULT_FONT[c * 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:136:18 [INFO] [stderr] | [INFO] [stderr] 136 | (DEFAULT_FONT[c * 2 + 1] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(DEFAULT_FONT[c * 2 + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `DEFAULT_FONT` [INFO] [stderr] --> src/main.rs:263:26 [INFO] [stderr] | [INFO] [stderr] 263 | for i in 0..DEFAULT_FONT.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 263 | for (i, ) in DEFAULT_FONT.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `DEFAULT_PALETTE` [INFO] [stderr] --> src/main.rs:269:26 [INFO] [stderr] | [INFO] [stderr] 269 | for i in 0..DEFAULT_PALETTE.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 269 | for (i, ) in DEFAULT_PALETTE.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | let ref filename = matches.free[0]; [INFO] [stderr] | ----^^^^^^^^^^^^------------------- help: try: `let filename = &matches.free[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `::from_image` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:371:79 [INFO] [stderr] | [INFO] [stderr] 371 | let mut texture = piston_window::Texture::from_image(&mut window.factory, &mut img, &text_sett).unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:390:16 [INFO] [stderr] | [INFO] [stderr] 390 | if let Some(_) = e.render_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 391 | | // TODO: Make the speed a setting [INFO] [stderr] 392 | | cpu.run(3000); [INFO] [stderr] 393 | | let dev = cpu.devices.get(0).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 407 | | } [INFO] [stderr] 408 | | } [INFO] [stderr] | |_________- help: try this: `if e.render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:393:23 [INFO] [stderr] | [INFO] [stderr] 393 | let dev = cpu.devices.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cpu.devices[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:410:23 [INFO] [stderr] | [INFO] [stderr] 410 | let dev = cpu.devices.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&cpu.devices[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:413:39 [INFO] [stderr] | [INFO] [stderr] 413 | piston_window::clear([col_r as f32 / 255.0, col_g as f32 / 255.0, col_b as f32 / 255.0, 1.0], g); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(col_r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:413:61 [INFO] [stderr] | [INFO] [stderr] 413 | piston_window::clear([col_r as f32 / 255.0, col_g as f32 / 255.0, col_b as f32 / 255.0, 1.0], g); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(col_g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:413:83 [INFO] [stderr] | [INFO] [stderr] 413 | piston_window::clear([col_r as f32 / 255.0, col_g as f32 / 255.0, col_b as f32 / 255.0, 1.0], g); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(col_b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:416:28 [INFO] [stderr] | [INFO] [stderr] 416 | .trans(BORDER as f64, BORDER as f64).zoom(SCALE as f64), g); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(BORDER)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:416:43 [INFO] [stderr] | [INFO] [stderr] 416 | .trans(BORDER as f64, BORDER as f64).zoom(SCALE as f64), g); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(BORDER)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:416:63 [INFO] [stderr] | [INFO] [stderr] 416 | .trans(BORDER as f64, BORDER as f64).zoom(SCALE as f64), g); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 48.88s [INFO] running `"docker" "inspect" "a33ecb398624eb596b15374f7011a0383f93d1f9391ef6fe7ce3b84c423981a1"` [INFO] running `"docker" "rm" "-f" "a33ecb398624eb596b15374f7011a0383f93d1f9391ef6fe7ce3b84c423981a1"` [INFO] [stdout] a33ecb398624eb596b15374f7011a0383f93d1f9391ef6fe7ce3b84c423981a1