[INFO] crate dbus-tokio 0.3.0 is already in cache [INFO] extracting crate dbus-tokio 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/dbus-tokio/0.3.0 [INFO] extracting crate dbus-tokio 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dbus-tokio/0.3.0 [INFO] validating manifest of dbus-tokio-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dbus-tokio-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dbus-tokio-0.3.0 [INFO] finished frobbing dbus-tokio-0.3.0 [INFO] frobbed toml for dbus-tokio-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/dbus-tokio/0.3.0/Cargo.toml [INFO] started frobbing dbus-tokio-0.3.0 [INFO] finished frobbing dbus-tokio-0.3.0 [INFO] frobbed toml for dbus-tokio-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dbus-tokio/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dbus-tokio-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dbus-tokio/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 93f34241b128b86eea9b20b6c35b4a820128dbfc026abc7f2d7a6b8d78981728 [INFO] running `"docker" "start" "-a" "93f34241b128b86eea9b20b6c35b4a820128dbfc026abc7f2d7a6b8d78981728"` [INFO] [stderr] Checking dbus-tokio v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:121:41 [INFO] [stderr] | [INFO] [stderr] 121 | ATreeServer { conn: c, tree: t, stream: stream, pendingresults: vec![] } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/adriver.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let i = AConnection { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:121:41 [INFO] [stderr] | [INFO] [stderr] 121 | ATreeServer { conn: c, tree: t, stream: stream, pendingresults: vec![] } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/adriver.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let i = AConnection { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/adriver.rs:173:20 [INFO] [stderr] | [INFO] [stderr] 173 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 174 | | if let Async::Ready(wt) = pwr { [INFO] [stderr] 175 | | UnixReady::from(wt) [INFO] [stderr] 176 | | } else { [INFO] [stderr] 177 | | continue; [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 173 | } else if let Async::Ready(wt) = pwr { [INFO] [stderr] 174 | UnixReady::from(wt) [INFO] [stderr] 175 | } else { [INFO] [stderr] 176 | continue; [INFO] [stderr] 177 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/adriver.rs:173:20 [INFO] [stderr] | [INFO] [stderr] 173 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 174 | | if let Async::Ready(wt) = pwr { [INFO] [stderr] 175 | | UnixReady::from(wt) [INFO] [stderr] 176 | | } else { [INFO] [stderr] 177 | | continue; [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 173 | } else if let Async::Ready(wt) = pwr { [INFO] [stderr] 174 | UnixReady::from(wt) [INFO] [stderr] 175 | } else { [INFO] [stderr] 176 | continue; [INFO] [stderr] 177 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/adriver.rs:80:78 [INFO] [stderr] | [INFO] [stderr] 80 | Ok(AMessageStream { inner: rx, stream: self.msgstream.clone(), quit: self.quit.as_ref().map(|q| q.clone()) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.quit.as_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/adriver.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | self.msgstream.borrow().as_ref().map(|z| { z.unbounded_send(m).unwrap() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(z) = self.msgstream.borrow().as_ref() { z.unbounded_send(m).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::reactor::Handle::current': semantics were sometimes surprising, use Handle::default() [INFO] [stderr] --> src/adriver.rs:295:48 [INFO] [stderr] | [INFO] [stderr] 295 | let aconn = AConnection::new(conn.clone(), CoreHandle::current(), &mut rt).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::reactor::Handle::current': semantics were sometimes surprising, use Handle::default() [INFO] [stderr] --> src/adriver.rs:308:48 [INFO] [stderr] | [INFO] [stderr] 308 | let aconn = AConnection::new(conn.clone(), CoreHandle::current(), &mut rt).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/adriver.rs:80:78 [INFO] [stderr] | [INFO] [stderr] 80 | Ok(AMessageStream { inner: rx, stream: self.msgstream.clone(), quit: self.quit.as_ref().map(|q| q.clone()) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.quit.as_ref().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/adriver.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | self.msgstream.borrow().as_ref().map(|z| { z.unbounded_send(m).unwrap() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(z) = self.msgstream.borrow().as_ref() { z.unbounded_send(m).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::reactor::Handle::current': semantics were sometimes surprising, use Handle::default() [INFO] [stderr] --> examples/tokio_server.rs:90:45 [INFO] [stderr] | [INFO] [stderr] 90 | let aconn = AConnection::new(c.clone(), Handle::current(), &mut rt).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> examples/tokio_server.rs:58:77 [INFO] [stderr] | [INFO] [stderr] 58 | let sleep_future = tokio_timer::sleep(Duration::from_millis(t as u64)); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::reactor::Handle::current': semantics were sometimes surprising, use Handle::default() [INFO] [stderr] --> examples/tokio_client.rs:35:45 [INFO] [stderr] | [INFO] [stderr] 35 | let aconn = AConnection::new(c.clone(), Handle::current(), &mut rt).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.86s [INFO] running `"docker" "inspect" "93f34241b128b86eea9b20b6c35b4a820128dbfc026abc7f2d7a6b8d78981728"` [INFO] running `"docker" "rm" "-f" "93f34241b128b86eea9b20b6c35b4a820128dbfc026abc7f2d7a6b8d78981728"` [INFO] [stdout] 93f34241b128b86eea9b20b6c35b4a820128dbfc026abc7f2d7a6b8d78981728