[INFO] crate dbmigrate-lib 0.1.3 is already in cache [INFO] extracting crate dbmigrate-lib 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/dbmigrate-lib/0.1.3 [INFO] extracting crate dbmigrate-lib 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dbmigrate-lib/0.1.3 [INFO] validating manifest of dbmigrate-lib-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dbmigrate-lib-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dbmigrate-lib-0.1.3 [INFO] finished frobbing dbmigrate-lib-0.1.3 [INFO] frobbed toml for dbmigrate-lib-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/dbmigrate-lib/0.1.3/Cargo.toml [INFO] started frobbing dbmigrate-lib-0.1.3 [INFO] finished frobbing dbmigrate-lib-0.1.3 [INFO] frobbed toml for dbmigrate-lib-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dbmigrate-lib/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dbmigrate-lib-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dbmigrate-lib/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 40b972c4654037ccb1457cbfdfdad9e7e2769004477fdb94df26dd43c356dda9 [INFO] running `"docker" "start" "-a" "40b972c4654037ccb1457cbfdfdad9e7e2769004477fdb94df26dd43c356dda9"` [INFO] [stderr] Checking rusqlite v0.14.0 [INFO] [stderr] Checking mysql_common v0.5.0 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking mysql v12.3.1 [INFO] [stderr] Checking dbmigrate-lib v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | direction: direction [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/drivers/mysql.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | let mysql = Mysql { pool: pool }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/drivers/postgres.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | let pg = Postgres { conn: conn }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/drivers/sqlite.rs:16:31 [INFO] [stderr] | [INFO] [stderr] 16 | let sqlite = Sqlite { conn: conn }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | direction: direction [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/drivers/mysql.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | let mysql = Mysql { pool: pool }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/drivers/postgres.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | let pg = Postgres { conn: conn }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/drivers/sqlite.rs:16:31 [INFO] [stderr] | [INFO] [stderr] 16 | let sqlite = Sqlite { conn: conn }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/drivers/postgres.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | const SSLMODE: &'static str = "sslmode"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/drivers/postgres.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | const SSLMODE: &'static str = "sslmode"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/errors.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / error_chain! { [INFO] [stderr] 9 | | foreign_links { [INFO] [stderr] 10 | | Io(::std::io::Error) #[doc = "Failed to created/read migration files"]; [INFO] [stderr] 11 | | Postgres(postgres_client::error::Error) #[doc = "Couldn't get connection to pg database"] #[cfg(feature = "postgres_support")]; [INFO] [stderr] ... | [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/errors.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / error_chain! { [INFO] [stderr] 9 | | foreign_links { [INFO] [stderr] 10 | | Io(::std::io::Error) #[doc = "Failed to created/read migration files"]; [INFO] [stderr] 11 | | Postgres(postgres_client::error::Error) #[doc = "Couldn't get connection to pg database"] #[cfg(feature = "postgres_support")]; [INFO] [stderr] ... | [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.86s [INFO] running `"docker" "inspect" "40b972c4654037ccb1457cbfdfdad9e7e2769004477fdb94df26dd43c356dda9"` [INFO] running `"docker" "rm" "-f" "40b972c4654037ccb1457cbfdfdad9e7e2769004477fdb94df26dd43c356dda9"` [INFO] [stdout] 40b972c4654037ccb1457cbfdfdad9e7e2769004477fdb94df26dd43c356dda9