[INFO] crate dbi 0.3.0 is already in cache
[INFO] extracting crate dbi 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/dbi/0.3.0
[INFO] extracting crate dbi 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dbi/0.3.0
[INFO] validating manifest of dbi-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dbi-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dbi-0.3.0
[INFO] finished frobbing dbi-0.3.0
[INFO] frobbed toml for dbi-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/dbi/0.3.0/Cargo.toml
[INFO] started frobbing dbi-0.3.0
[INFO] finished frobbing dbi-0.3.0
[INFO] frobbed toml for dbi-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dbi/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dbi-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dbi/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 71187cf58d11cd5c9ae583c666854f3e1580a84b1a40cf6ada64abb6b204b210
[INFO] running `"docker" "start" "-a" "71187cf58d11cd5c9ae583c666854f3e1580a84b1a40cf6ada64abb6b204b210"`
[INFO] [stderr]    Compiling dbi-macros v0.3.0
[INFO] [stderr]     Checking mysql_async v0.15.1
[INFO] [stderr]     Checking dbi v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `super::Connection`
[INFO] [stderr]   --> src/mysql.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 |     use super::Connection;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/mysql.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |         rt
[INFO] [stderr]    |         ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/mysql.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |           let rt = conn_fut.and_then(move |conn| {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 25 | |             conn.prep_exec(sql, params)
[INFO] [stderr] 26 | |         }).and_then(move |res| {
[INFO] [stderr] 27 | |             res.reduce_and_drop(crate::ResultSet::None, move |mut acc, row| {
[INFO] [stderr] ...  |
[INFO] [stderr] 35 | |                 })
[INFO] [stderr] 36 | |         });
[INFO] [stderr]    | |__________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/mysql.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         rt
[INFO] [stderr]    |         ^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/mysql.rs:50:18
[INFO] [stderr]    |
[INFO] [stderr] 50 |           let rt = conn_fut.and_then(move |conn| {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 51 | |             conn.prep_exec(sql, params)
[INFO] [stderr] 52 | |         }).and_then(move |res| {
[INFO] [stderr] 53 | |             let id = if get_last_insert_id {
[INFO] [stderr] ...  |
[INFO] [stderr] 62 | |             res.drop_result().map(|_| id )
[INFO] [stderr] 63 | |         });
[INFO] [stderr]    | |__________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/mysql.rs:83:9
[INFO] [stderr]    |
[INFO] [stderr] 83 |         rt
[INFO] [stderr]    |         ^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/mysql.rs:77:18
[INFO] [stderr]    |
[INFO] [stderr] 77 |           let rt = conn_fut.and_then(move |conn| {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 78 | |             conn.batch_exec(sql, params)
[INFO] [stderr] 79 | |         }).map(|res| {
[INFO] [stderr] 80 | |             crate::ResultSet::None
[INFO] [stderr] 81 | |         });
[INFO] [stderr]    | |__________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `futures::Future`
[INFO] [stderr]   --> src/lib.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | use futures::Future;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/lib.rs:49:19
[INFO] [stderr]    |
[INFO] [stderr] 49 |     fn into(self) -> () {
[INFO] [stderr]    |                   ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/lib.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 |         ()
[INFO] [stderr]    |         ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'futures::stream::iter': implementation moved to `iter_ok` and `iter_result`
[INFO] [stderr]   --> src/mysql.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             futures::stream::iter(val)
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::Connection`
[INFO] [stderr]   --> src/mysql.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 |     use super::Connection;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/mysql.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |         rt
[INFO] [stderr]    |         ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/mysql.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |           let rt = conn_fut.and_then(move |conn| {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 25 | |             conn.prep_exec(sql, params)
[INFO] [stderr] 26 | |         }).and_then(move |res| {
[INFO] [stderr] 27 | |             res.reduce_and_drop(crate::ResultSet::None, move |mut acc, row| {
[INFO] [stderr] ...  |
[INFO] [stderr] 35 | |                 })
[INFO] [stderr] 36 | |         });
[INFO] [stderr]    | |__________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/mysql.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         rt
[INFO] [stderr]    |         ^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/mysql.rs:50:18
[INFO] [stderr]    |
[INFO] [stderr] 50 |           let rt = conn_fut.and_then(move |conn| {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 51 | |             conn.prep_exec(sql, params)
[INFO] [stderr] 52 | |         }).and_then(move |res| {
[INFO] [stderr] 53 | |             let id = if get_last_insert_id {
[INFO] [stderr] ...  |
[INFO] [stderr] 62 | |             res.drop_result().map(|_| id )
[INFO] [stderr] 63 | |         });
[INFO] [stderr]    | |__________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/mysql.rs:83:9
[INFO] [stderr]    |
[INFO] [stderr] 83 |         rt
[INFO] [stderr]    |         ^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/mysql.rs:77:18
[INFO] [stderr]    |
[INFO] [stderr] 77 |           let rt = conn_fut.and_then(move |conn| {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 78 | |             conn.batch_exec(sql, params)
[INFO] [stderr] 79 | |         }).map(|res| {
[INFO] [stderr] 80 | |             crate::ResultSet::None
[INFO] [stderr] 81 | |         });
[INFO] [stderr]    | |__________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `futures::Future`
[INFO] [stderr]   --> src/lib.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | use futures::Future;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/lib.rs:49:19
[INFO] [stderr]    |
[INFO] [stderr] 49 |     fn into(self) -> () {
[INFO] [stderr]    |                   ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]   --> src/lib.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 |         ()
[INFO] [stderr]    |         ^^ help: remove the final `()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'futures::stream::iter': implementation moved to `iter_ok` and `iter_result`
[INFO] [stderr]   --> src/mysql.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             futures::stream::iter(val)
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::my::prelude`
[INFO] [stderr]   --> src/mysql.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |         use ::my::prelude::*;
[INFO] [stderr]    |             ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Stream`
[INFO] [stderr]   --> src/mysql.rs:47:31
[INFO] [stderr]    |
[INFO] [stderr] 47 |         use futures::{Future, Stream};
[INFO] [stderr]    |                               ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::my::prelude`
[INFO] [stderr]   --> src/mysql.rs:48:13
[INFO] [stderr]    |
[INFO] [stderr] 48 |         use ::my::prelude::*;
[INFO] [stderr]    |             ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Stream`
[INFO] [stderr]   --> src/mysql.rs:74:31
[INFO] [stderr]    |
[INFO] [stderr] 74 |         use futures::{Future, Stream};
[INFO] [stderr]    |                               ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::my::prelude`
[INFO] [stderr]   --> src/mysql.rs:75:13
[INFO] [stderr]    |
[INFO] [stderr] 75 |         use ::my::prelude::*;
[INFO] [stderr]    |             ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `res`
[INFO] [stderr]   --> src/mysql.rs:79:17
[INFO] [stderr]    |
[INFO] [stderr] 79 |         }).map(|res| {
[INFO] [stderr]    |                 ^^^ help: consider using `_res` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/mysql.rs:27:63
[INFO] [stderr]    |
[INFO] [stderr] 27 |             res.reduce_and_drop(crate::ResultSet::None, move |mut acc, row| {
[INFO] [stderr]    |                                                               ----^^^
[INFO] [stderr]    |                                                               |
[INFO] [stderr]    |                                                               help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/mysql.rs:33:48
[INFO] [stderr]    |
[INFO] [stderr] 33 |                 .fold(crate::ResultSet::None, |mut acc, val| {
[INFO] [stderr]    |                                                ----^^^
[INFO] [stderr]    |                                                |
[INFO] [stderr]    |                                                help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/mysql.rs:60:22
[INFO] [stderr]    |
[INFO] [stderr] 60 |                 .map(|x| crate::ResultSet::One(x) )
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `crate::ResultSet::One`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::my::prelude`
[INFO] [stderr]   --> src/mysql.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |         use ::my::prelude::*;
[INFO] [stderr]    |             ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Stream`
[INFO] [stderr]   --> src/mysql.rs:47:31
[INFO] [stderr]    |
[INFO] [stderr] 47 |         use futures::{Future, Stream};
[INFO] [stderr]    |                               ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::my::prelude`
[INFO] [stderr]   --> src/mysql.rs:48:13
[INFO] [stderr]    |
[INFO] [stderr] 48 |         use ::my::prelude::*;
[INFO] [stderr]    |             ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Stream`
[INFO] [stderr]   --> src/mysql.rs:74:31
[INFO] [stderr]    |
[INFO] [stderr] 74 |         use futures::{Future, Stream};
[INFO] [stderr]    |                               ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `::my::prelude`
[INFO] [stderr]   --> src/mysql.rs:75:13
[INFO] [stderr]    |
[INFO] [stderr] 75 |         use ::my::prelude::*;
[INFO] [stderr]    |             ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `res`
[INFO] [stderr]   --> src/mysql.rs:79:17
[INFO] [stderr]    |
[INFO] [stderr] 79 |         }).map(|res| {
[INFO] [stderr]    |                 ^^^ help: consider using `_res` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/mysql.rs:27:63
[INFO] [stderr]    |
[INFO] [stderr] 27 |             res.reduce_and_drop(crate::ResultSet::None, move |mut acc, row| {
[INFO] [stderr]    |                                                               ----^^^
[INFO] [stderr]    |                                                               |
[INFO] [stderr]    |                                                               help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/mysql.rs:33:48
[INFO] [stderr]    |
[INFO] [stderr] 33 |                 .fold(crate::ResultSet::None, |mut acc, val| {
[INFO] [stderr]    |                                                ----^^^
[INFO] [stderr]    |                                                |
[INFO] [stderr]    |                                                help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/mysql.rs:60:22
[INFO] [stderr]    |
[INFO] [stderr] 60 |                 .map(|x| crate::ResultSet::One(x) )
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `crate::ResultSet::One`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: environment variable `DB_USERNAME` not defined
[INFO] [stderr]   --> examples/simple.rs:43:37
[INFO] [stderr]    |
[INFO] [stderr] 43 |     let (username, password, db) = (env!("DB_USERNAME"), env!("DB_PASSWORD"), env!("DB_NAME"));
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: environment variable `DB_PASSWORD` not defined
[INFO] [stderr]   --> examples/simple.rs:43:58
[INFO] [stderr]    |
[INFO] [stderr] 43 |     let (username, password, db) = (env!("DB_USERNAME"), env!("DB_PASSWORD"), env!("DB_NAME"));
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: environment variable `DB_NAME` not defined
[INFO] [stderr]   --> examples/simple.rs:43:79
[INFO] [stderr]    |
[INFO] [stderr] 43 |     let (username, password, db) = (env!("DB_USERNAME"), env!("DB_PASSWORD"), env!("DB_NAME"));
[INFO] [stderr]    |                                                                               ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `dbi`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "71187cf58d11cd5c9ae583c666854f3e1580a84b1a40cf6ada64abb6b204b210"`
[INFO] running `"docker" "rm" "-f" "71187cf58d11cd5c9ae583c666854f3e1580a84b1a40cf6ada64abb6b204b210"`
[INFO] [stdout] 71187cf58d11cd5c9ae583c666854f3e1580a84b1a40cf6ada64abb6b204b210