[INFO] crate david-set 0.1.2 is already in cache [INFO] extracting crate david-set 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/david-set/0.1.2 [INFO] extracting crate david-set 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/david-set/0.1.2 [INFO] validating manifest of david-set-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of david-set-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing david-set-0.1.2 [INFO] finished frobbing david-set-0.1.2 [INFO] frobbed toml for david-set-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/david-set/0.1.2/Cargo.toml [INFO] started frobbing david-set-0.1.2 [INFO] finished frobbing david-set-0.1.2 [INFO] frobbed toml for david-set-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/david-set/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting david-set-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/david-set/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0779360482f5c70e65c4a988a47bb496bcdfacbe4237ae1a109b81c7a0dd63db [INFO] running `"docker" "start" "-a" "0779360482f5c70e65c4a988a47bb496bcdfacbe4237ae1a109b81c7a0dd63db"` [INFO] [stderr] Checking david-set v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/castset.rs:289:20 [INFO] [stderr] | [INFO] [stderr] 289 | IntoIter { set: set, nleft: sz } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/castset.rs:289:20 [INFO] [stderr] | [INFO] [stderr] 289 | IntoIter { set: set, nleft: sz } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/castset.rs:239:21 [INFO] [stderr] | [INFO] [stderr] 239 | let i = h+dist & mask; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(h+dist) & mask` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/castset.rs:262:21 [INFO] [stderr] | [INFO] [stderr] 262 | let i = h+dist & mask; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(h+dist) & mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: item `vecset::VecSet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/vecset.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl VecSet { [INFO] [stderr] 9 | | /// Creates an empty set.. [INFO] [stderr] 10 | | pub fn new() -> VecSet { [INFO] [stderr] 11 | | VecSet { v: Vec::new() } [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vecset::VecSet` [INFO] [stderr] --> src/vecset.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> VecSet { [INFO] [stderr] 11 | | VecSet { v: Vec::new() } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `copyset::Set` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/copyset.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / impl Set { [INFO] [stderr] 52 | | /// Creates an empty set.. [INFO] [stderr] 53 | | pub fn new() -> Set { [INFO] [stderr] 54 | | Set { inner: SS::Small(0, unsafe { std::mem::uninitialized() }) } [INFO] [stderr] ... | [INFO] [stderr] 194 | | } [INFO] [stderr] 195 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `copyset::Set` [INFO] [stderr] --> src/copyset.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / pub fn new() -> Set { [INFO] [stderr] 54 | | Set { inner: SS::Small(0, unsafe { std::mem::uninitialized() }) } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | impl Default for copyset::Set { [INFO] [stderr] 52 | fn default() -> Self { [INFO] [stderr] 53 | Self::new() [INFO] [stderr] 54 | } [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `arr`. [INFO] [stderr] --> src/copyset.rs:82:26 [INFO] [stderr] | [INFO] [stderr] 82 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 82 | for in arr.iter().take(len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `arr`. [INFO] [stderr] --> src/copyset.rs:100:26 [INFO] [stderr] | [INFO] [stderr] 100 | for i in 0 .. *len { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 100 | for in arr.iter().take(*len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `arr`. [INFO] [stderr] --> src/copyset.rs:116:26 [INFO] [stderr] | [INFO] [stderr] 116 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 116 | for in arr.iter().take(len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `arr`. [INFO] [stderr] --> src/copyset.rs:156:26 [INFO] [stderr] | [INFO] [stderr] 156 | for i in 0 .. len { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 156 | for in arr.iter().take(len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/castset.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match self { [INFO] [stderr] 70 | | &Data::Sm(_,_) => { [INFO] [stderr] 71 | | Data::::cutoff() [INFO] [stderr] 72 | | }, [INFO] [stderr] 73 | | &Data::V(_,ref v) => v.len(), [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | match *self { [INFO] [stderr] 70 | Data::Sm(_,_) => { [INFO] [stderr] 71 | Data::::cutoff() [INFO] [stderr] 72 | }, [INFO] [stderr] 73 | Data::V(_,ref v) => v.len(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/castset.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / match self { [INFO] [stderr] 78 | | &Data::Sm(_,ref v) => { [INFO] [stderr] 79 | | let num = Data::::cutoff(); [INFO] [stderr] 80 | | match num { [INFO] [stderr] ... | [INFO] [stderr] 89 | | &Data::V(_,ref v) => v, [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | match *self { [INFO] [stderr] 78 | Data::Sm(_,ref v) => { [INFO] [stderr] 79 | let num = Data::::cutoff(); [INFO] [stderr] 80 | match num { [INFO] [stderr] 81 | 1 => unsafe { std::mem::transmute::<&[usize;2],&[T;1]>(v) }, [INFO] [stderr] 82 | 2 => unsafe { std::mem::transmute::<&[usize;2],&[T;2]>(v) }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:81:35 [INFO] [stderr] | [INFO] [stderr] 81 | 1 => unsafe { std::mem::transmute::<&[usize;2],&[T;1]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(v as *const [usize; 2] as *const [T; 1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:82:35 [INFO] [stderr] | [INFO] [stderr] 82 | 2 => unsafe { std::mem::transmute::<&[usize;2],&[T;2]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(v as *const [usize; 2] as *const [T; 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:83:35 [INFO] [stderr] | [INFO] [stderr] 83 | 4 => unsafe { std::mem::transmute::<&[usize;2],&[T;4]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(v as *const [usize; 2] as *const [T; 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:84:35 [INFO] [stderr] | [INFO] [stderr] 84 | 8 => unsafe { std::mem::transmute::<&[usize;2],&[T;8]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(v as *const [usize; 2] as *const [T; 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:85:36 [INFO] [stderr] | [INFO] [stderr] 85 | 16 => unsafe { std::mem::transmute::<&[usize;2],&[T;16]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(v as *const [usize; 2] as *const [T; 16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/castset.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / match self { [INFO] [stderr] 94 | | &mut Data::Sm(_,ref mut v) => { [INFO] [stderr] 95 | | let num = Data::::cutoff(); [INFO] [stderr] 96 | | match num { [INFO] [stderr] ... | [INFO] [stderr] 105 | | &mut Data::V(_,ref mut v) => v, [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | match *self { [INFO] [stderr] 94 | Data::Sm(_,ref mut v) => { [INFO] [stderr] 95 | let num = Data::::cutoff(); [INFO] [stderr] 96 | match num { [INFO] [stderr] 97 | 1 => unsafe { std::mem::transmute::<&mut [usize;2],&mut [T;1]>(v) }, [INFO] [stderr] 98 | 2 => unsafe { std::mem::transmute::<&mut [usize;2],&mut [T;2]>(v) }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | 1 => unsafe { std::mem::transmute::<&mut [usize;2],&mut [T;1]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(v as *mut [usize; 2] as *mut [T; 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:98:35 [INFO] [stderr] | [INFO] [stderr] 98 | 2 => unsafe { std::mem::transmute::<&mut [usize;2],&mut [T;2]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(v as *mut [usize; 2] as *mut [T; 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | 4 => unsafe { std::mem::transmute::<&mut [usize;2],&mut [T;4]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(v as *mut [usize; 2] as *mut [T; 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:100:35 [INFO] [stderr] | [INFO] [stderr] 100 | 8 => unsafe { std::mem::transmute::<&mut [usize;2],&mut [T;8]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(v as *mut [usize; 2] as *mut [T; 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:101:36 [INFO] [stderr] | [INFO] [stderr] 101 | 16 => unsafe { std::mem::transmute::<&mut [usize;2],&mut [T;16]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(v as *mut [usize; 2] as *mut [T; 16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: item `castset::CastSet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/castset.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | / impl CastSet { [INFO] [stderr] 115 | | fn mut_sz(&mut self) -> &mut u32 { [INFO] [stderr] 116 | | match &mut self.v { [INFO] [stderr] 117 | | &mut Data::Sm(ref mut sz,_) => sz, [INFO] [stderr] ... | [INFO] [stderr] 290 | | } [INFO] [stderr] 291 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `castset::CastSet` [INFO] [stderr] --> src/castset.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / pub fn new() -> CastSet { [INFO] [stderr] 123 | | CastSet::with_capacity(0) [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | impl Default for castset::CastSet { [INFO] [stderr] 115 | fn default() -> Self { [INFO] [stderr] 116 | Self::new() [INFO] [stderr] 117 | } [INFO] [stderr] 118 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/castset.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / match &mut self.v { [INFO] [stderr] 117 | | &mut Data::Sm(ref mut sz,_) => sz, [INFO] [stderr] 118 | | &mut Data::V(ref mut sz,_) => sz, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 116 | match *(&mut self.v) { [INFO] [stderr] 117 | Data::Sm(ref mut sz,_) => sz, [INFO] [stderr] 118 | Data::V(ref mut sz,_) => sz, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/castset.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / match &self.v { [INFO] [stderr] 139 | | &Data::Sm(sz,_) => sz as usize, [INFO] [stderr] 140 | | &Data::V(sz,_) => sz as usize, [INFO] [stderr] 141 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 138 | match self.v { [INFO] [stderr] 139 | Data::Sm(sz,_) => sz as usize, [INFO] [stderr] 140 | Data::V(sz,_) => sz as usize, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/castset.rs:239:21 [INFO] [stderr] | [INFO] [stderr] 239 | let i = h+dist & mask; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(h+dist) & mask` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/castset.rs:262:21 [INFO] [stderr] | [INFO] [stderr] 262 | let i = h+dist & mask; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(h+dist) & mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `david-set`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: item `vecset::VecSet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/vecset.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / impl VecSet { [INFO] [stderr] 9 | | /// Creates an empty set.. [INFO] [stderr] 10 | | pub fn new() -> VecSet { [INFO] [stderr] 11 | | VecSet { v: Vec::new() } [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vecset::VecSet` [INFO] [stderr] --> src/vecset.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> VecSet { [INFO] [stderr] 11 | | VecSet { v: Vec::new() } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `copyset::Set` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/copyset.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / impl Set { [INFO] [stderr] 52 | | /// Creates an empty set.. [INFO] [stderr] 53 | | pub fn new() -> Set { [INFO] [stderr] 54 | | Set { inner: SS::Small(0, unsafe { std::mem::uninitialized() }) } [INFO] [stderr] ... | [INFO] [stderr] 194 | | } [INFO] [stderr] 195 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `copyset::Set` [INFO] [stderr] --> src/copyset.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / pub fn new() -> Set { [INFO] [stderr] 54 | | Set { inner: SS::Small(0, unsafe { std::mem::uninitialized() }) } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | impl Default for copyset::Set { [INFO] [stderr] 52 | fn default() -> Self { [INFO] [stderr] 53 | Self::new() [INFO] [stderr] 54 | } [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `arr`. [INFO] [stderr] --> src/copyset.rs:82:26 [INFO] [stderr] | [INFO] [stderr] 82 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 82 | for in arr.iter().take(len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `arr`. [INFO] [stderr] --> src/copyset.rs:100:26 [INFO] [stderr] | [INFO] [stderr] 100 | for i in 0 .. *len { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 100 | for in arr.iter().take(*len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `arr`. [INFO] [stderr] --> src/copyset.rs:116:26 [INFO] [stderr] | [INFO] [stderr] 116 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 116 | for in arr.iter().take(len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `arr`. [INFO] [stderr] --> src/copyset.rs:156:26 [INFO] [stderr] | [INFO] [stderr] 156 | for i in 0 .. len { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 156 | for in arr.iter().take(len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/castset.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match self { [INFO] [stderr] 70 | | &Data::Sm(_,_) => { [INFO] [stderr] 71 | | Data::::cutoff() [INFO] [stderr] 72 | | }, [INFO] [stderr] 73 | | &Data::V(_,ref v) => v.len(), [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | match *self { [INFO] [stderr] 70 | Data::Sm(_,_) => { [INFO] [stderr] 71 | Data::::cutoff() [INFO] [stderr] 72 | }, [INFO] [stderr] 73 | Data::V(_,ref v) => v.len(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/castset.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / match self { [INFO] [stderr] 78 | | &Data::Sm(_,ref v) => { [INFO] [stderr] 79 | | let num = Data::::cutoff(); [INFO] [stderr] 80 | | match num { [INFO] [stderr] ... | [INFO] [stderr] 89 | | &Data::V(_,ref v) => v, [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | match *self { [INFO] [stderr] 78 | Data::Sm(_,ref v) => { [INFO] [stderr] 79 | let num = Data::::cutoff(); [INFO] [stderr] 80 | match num { [INFO] [stderr] 81 | 1 => unsafe { std::mem::transmute::<&[usize;2],&[T;1]>(v) }, [INFO] [stderr] 82 | 2 => unsafe { std::mem::transmute::<&[usize;2],&[T;2]>(v) }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:81:35 [INFO] [stderr] | [INFO] [stderr] 81 | 1 => unsafe { std::mem::transmute::<&[usize;2],&[T;1]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(v as *const [usize; 2] as *const [T; 1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:82:35 [INFO] [stderr] | [INFO] [stderr] 82 | 2 => unsafe { std::mem::transmute::<&[usize;2],&[T;2]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(v as *const [usize; 2] as *const [T; 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:83:35 [INFO] [stderr] | [INFO] [stderr] 83 | 4 => unsafe { std::mem::transmute::<&[usize;2],&[T;4]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(v as *const [usize; 2] as *const [T; 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:84:35 [INFO] [stderr] | [INFO] [stderr] 84 | 8 => unsafe { std::mem::transmute::<&[usize;2],&[T;8]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(v as *const [usize; 2] as *const [T; 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:85:36 [INFO] [stderr] | [INFO] [stderr] 85 | 16 => unsafe { std::mem::transmute::<&[usize;2],&[T;16]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(v as *const [usize; 2] as *const [T; 16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/castset.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / match self { [INFO] [stderr] 94 | | &mut Data::Sm(_,ref mut v) => { [INFO] [stderr] 95 | | let num = Data::::cutoff(); [INFO] [stderr] 96 | | match num { [INFO] [stderr] ... | [INFO] [stderr] 105 | | &mut Data::V(_,ref mut v) => v, [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 93 | match *self { [INFO] [stderr] 94 | Data::Sm(_,ref mut v) => { [INFO] [stderr] 95 | let num = Data::::cutoff(); [INFO] [stderr] 96 | match num { [INFO] [stderr] 97 | 1 => unsafe { std::mem::transmute::<&mut [usize;2],&mut [T;1]>(v) }, [INFO] [stderr] 98 | 2 => unsafe { std::mem::transmute::<&mut [usize;2],&mut [T;2]>(v) }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:97:35 [INFO] [stderr] | [INFO] [stderr] 97 | 1 => unsafe { std::mem::transmute::<&mut [usize;2],&mut [T;1]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(v as *mut [usize; 2] as *mut [T; 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:98:35 [INFO] [stderr] | [INFO] [stderr] 98 | 2 => unsafe { std::mem::transmute::<&mut [usize;2],&mut [T;2]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(v as *mut [usize; 2] as *mut [T; 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:99:35 [INFO] [stderr] | [INFO] [stderr] 99 | 4 => unsafe { std::mem::transmute::<&mut [usize;2],&mut [T;4]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(v as *mut [usize; 2] as *mut [T; 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:100:35 [INFO] [stderr] | [INFO] [stderr] 100 | 8 => unsafe { std::mem::transmute::<&mut [usize;2],&mut [T;8]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(v as *mut [usize; 2] as *mut [T; 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/castset.rs:101:36 [INFO] [stderr] | [INFO] [stderr] 101 | 16 => unsafe { std::mem::transmute::<&mut [usize;2],&mut [T;16]>(v) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(v as *mut [usize; 2] as *mut [T; 16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: item `castset::CastSet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/castset.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | / impl CastSet { [INFO] [stderr] 115 | | fn mut_sz(&mut self) -> &mut u32 { [INFO] [stderr] 116 | | match &mut self.v { [INFO] [stderr] 117 | | &mut Data::Sm(ref mut sz,_) => sz, [INFO] [stderr] ... | [INFO] [stderr] 290 | | } [INFO] [stderr] 291 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `castset::CastSet` [INFO] [stderr] --> src/castset.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | / pub fn new() -> CastSet { [INFO] [stderr] 123 | | CastSet::with_capacity(0) [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | impl Default for castset::CastSet { [INFO] [stderr] 115 | fn default() -> Self { [INFO] [stderr] 116 | Self::new() [INFO] [stderr] 117 | } [INFO] [stderr] 118 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/castset.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / match &mut self.v { [INFO] [stderr] 117 | | &mut Data::Sm(ref mut sz,_) => sz, [INFO] [stderr] 118 | | &mut Data::V(ref mut sz,_) => sz, [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 116 | match *(&mut self.v) { [INFO] [stderr] 117 | Data::Sm(ref mut sz,_) => sz, [INFO] [stderr] 118 | Data::V(ref mut sz,_) => sz, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/castset.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / match &self.v { [INFO] [stderr] 139 | | &Data::Sm(sz,_) => sz as usize, [INFO] [stderr] 140 | | &Data::V(sz,_) => sz as usize, [INFO] [stderr] 141 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 138 | match self.v { [INFO] [stderr] 139 | Data::Sm(sz,_) => sz as usize, [INFO] [stderr] 140 | Data::V(sz,_) => sz as usize, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "0779360482f5c70e65c4a988a47bb496bcdfacbe4237ae1a109b81c7a0dd63db"` [INFO] running `"docker" "rm" "-f" "0779360482f5c70e65c4a988a47bb496bcdfacbe4237ae1a109b81c7a0dd63db"` [INFO] [stdout] 0779360482f5c70e65c4a988a47bb496bcdfacbe4237ae1a109b81c7a0dd63db