[INFO] crate datetime 0.4.7 is already in cache [INFO] extracting crate datetime 0.4.7 into work/ex/clippy-test-run/sources/stable/reg/datetime/0.4.7 [INFO] extracting crate datetime 0.4.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/datetime/0.4.7 [INFO] validating manifest of datetime-0.4.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of datetime-0.4.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing datetime-0.4.7 [INFO] finished frobbing datetime-0.4.7 [INFO] frobbed toml for datetime-0.4.7 written to work/ex/clippy-test-run/sources/stable/reg/datetime/0.4.7/Cargo.toml [INFO] started frobbing datetime-0.4.7 [INFO] finished frobbing datetime-0.4.7 [INFO] frobbed toml for datetime-0.4.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/datetime/0.4.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting datetime-0.4.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/datetime/0.4.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] afa5c260afc87c7c540cac622677062c7349ece3f789bb4bfa4dbc68c978848b [INFO] running `"docker" "start" "-a" "afa5c260afc87c7c540cac622677062c7349ece3f789bb4bfa4dbc68c978848b"` [INFO] [stderr] Checking datetime v0.4.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | month: month, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:433:15 [INFO] [stderr] | [INFO] [stderr] 433 | YMD { year: year, month: month, day: day } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:433:27 [INFO] [stderr] | [INFO] [stderr] 433 | YMD { year: year, month: month, day: day } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:433:41 [INFO] [stderr] | [INFO] [stderr] 433 | YMD { year: year, month: month, day: day } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:459:31 [INFO] [stderr] | [INFO] [stderr] 459 | let jan_1 = YMD { year: year, month: January, day: 1 }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:508:27 [INFO] [stderr] | [INFO] [stderr] 508 | let jan_4 = YMD { year: year, month: January, day: 4 }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:657:13 [INFO] [stderr] | [INFO] [stderr] 657 | weekday: weekday, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weekday` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:658:13 [INFO] [stderr] | [INFO] [stderr] 658 | yearday: yearday, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `yearday` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:656:24 [INFO] [stderr] | [INFO] [stderr] 656 | ymd: YMD { year: year, month: month, day: day }, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:656:36 [INFO] [stderr] | [INFO] [stderr] 656 | ymd: YMD { year: year, month: month, day: day }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:656:50 [INFO] [stderr] | [INFO] [stderr] 656 | ymd: YMD { year: year, month: month, day: day }, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:730:28 [INFO] [stderr] | [INFO] [stderr] 730 | Ok(LocalTime { hour: hour, minute: minute, second: 0, millisecond: 0 }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:730:40 [INFO] [stderr] | [INFO] [stderr] 730 | Ok(LocalTime { hour: hour, minute: minute, second: 0, millisecond: 0 }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:745:28 [INFO] [stderr] | [INFO] [stderr] 745 | Ok(LocalTime { hour: hour, minute: minute, second: second, millisecond: 0 }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:745:40 [INFO] [stderr] | [INFO] [stderr] 745 | Ok(LocalTime { hour: hour, minute: minute, second: second, millisecond: 0 }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:745:56 [INFO] [stderr] | [INFO] [stderr] 745 | Ok(LocalTime { hour: hour, minute: minute, second: second, millisecond: 0 }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `second` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:761:28 [INFO] [stderr] | [INFO] [stderr] 761 | Ok(LocalTime { hour: hour, minute: minute, second: second, millisecond: millisecond }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:761:40 [INFO] [stderr] | [INFO] [stderr] 761 | Ok(LocalTime { hour: hour, minute: minute, second: second, millisecond: millisecond }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:761:56 [INFO] [stderr] | [INFO] [stderr] 761 | Ok(LocalTime { hour: hour, minute: minute, second: second, millisecond: millisecond }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `second` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:761:72 [INFO] [stderr] | [INFO] [stderr] 761 | Ok(LocalTime { hour: hour, minute: minute, second: second, millisecond: millisecond }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `millisecond` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:824:13 [INFO] [stderr] | [INFO] [stderr] 824 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:825:13 [INFO] [stderr] | [INFO] [stderr] 825 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:99:62 [INFO] [stderr] | [INFO] [stderr] 99 | Some(existing) => Err(FormatError::DoubleWidth { open_pos: open_pos, current_width: existing }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `open_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:106:66 [INFO] [stderr] | [INFO] [stderr] 106 | Some(existing) => Err(FormatError::DoubleAlignment { open_pos: open_pos, current_alignment: existing }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `open_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:319:81 [INFO] [stderr] | [INFO] [stderr] 319 | Some((pos, c)) => return Err(FormatError::InvalidChar { c: c, colon: true, pos: pos }), [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:319:100 [INFO] [stderr] | [INFO] [stderr] 319 | Some((pos, c)) => return Err(FormatError::InvalidChar { c: c, colon: true, pos: pos }), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:320:74 [INFO] [stderr] | [INFO] [stderr] 320 | None => return Err(FormatError::OpenCurlyBrace { open_pos: open_pos }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `open_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:326:73 [INFO] [stderr] | [INFO] [stderr] 326 | Some((pos, c)) => return Err(FormatError::InvalidChar { c: c, colon: false, pos: pos }), [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:326:93 [INFO] [stderr] | [INFO] [stderr] 326 | Some((pos, c)) => return Err(FormatError::InvalidChar { c: c, colon: false, pos: pos }), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:327:66 [INFO] [stderr] | [INFO] [stderr] 327 | None => return Err(FormatError::OpenCurlyBrace { open_pos: open_pos }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `open_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:335:56 [INFO] [stderr] | [INFO] [stderr] 335 | None => Err(FormatError::MissingField { open_pos: open_pos, close_pos: close_pos }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `open_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:335:76 [INFO] [stderr] | [INFO] [stderr] 335 | None => Err(FormatError::MissingField { open_pos: open_pos, close_pos: close_pos }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `close_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/offset.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | local: local, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `local` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/duration.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | Duration { seconds: seconds, milliseconds: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/duration.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | Duration { seconds: seconds, milliseconds: milliseconds } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/duration.rs:30:38 [INFO] [stderr] | [INFO] [stderr] 30 | Duration { seconds: seconds, milliseconds: milliseconds } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `milliseconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instant.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | Instant { seconds: seconds, milliseconds: milliseconds } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instant.rs:35:37 [INFO] [stderr] | [INFO] [stderr] 35 | Instant { seconds: seconds, milliseconds: milliseconds } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `milliseconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | month: month, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:433:15 [INFO] [stderr] | [INFO] [stderr] 433 | YMD { year: year, month: month, day: day } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:433:27 [INFO] [stderr] | [INFO] [stderr] 433 | YMD { year: year, month: month, day: day } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:433:41 [INFO] [stderr] | [INFO] [stderr] 433 | YMD { year: year, month: month, day: day } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:459:31 [INFO] [stderr] | [INFO] [stderr] 459 | let jan_1 = YMD { year: year, month: January, day: 1 }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:508:27 [INFO] [stderr] | [INFO] [stderr] 508 | let jan_4 = YMD { year: year, month: January, day: 4 }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:657:13 [INFO] [stderr] | [INFO] [stderr] 657 | weekday: weekday, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weekday` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:658:13 [INFO] [stderr] | [INFO] [stderr] 658 | yearday: yearday, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `yearday` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:656:24 [INFO] [stderr] | [INFO] [stderr] 656 | ymd: YMD { year: year, month: month, day: day }, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:656:36 [INFO] [stderr] | [INFO] [stderr] 656 | ymd: YMD { year: year, month: month, day: day }, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:656:50 [INFO] [stderr] | [INFO] [stderr] 656 | ymd: YMD { year: year, month: month, day: day }, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:730:28 [INFO] [stderr] | [INFO] [stderr] 730 | Ok(LocalTime { hour: hour, minute: minute, second: 0, millisecond: 0 }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:730:40 [INFO] [stderr] | [INFO] [stderr] 730 | Ok(LocalTime { hour: hour, minute: minute, second: 0, millisecond: 0 }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:745:28 [INFO] [stderr] | [INFO] [stderr] 745 | Ok(LocalTime { hour: hour, minute: minute, second: second, millisecond: 0 }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:745:40 [INFO] [stderr] | [INFO] [stderr] 745 | Ok(LocalTime { hour: hour, minute: minute, second: second, millisecond: 0 }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:745:56 [INFO] [stderr] | [INFO] [stderr] 745 | Ok(LocalTime { hour: hour, minute: minute, second: second, millisecond: 0 }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `second` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:761:28 [INFO] [stderr] | [INFO] [stderr] 761 | Ok(LocalTime { hour: hour, minute: minute, second: second, millisecond: millisecond }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:761:40 [INFO] [stderr] | [INFO] [stderr] 761 | Ok(LocalTime { hour: hour, minute: minute, second: second, millisecond: millisecond }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:761:56 [INFO] [stderr] | [INFO] [stderr] 761 | Ok(LocalTime { hour: hour, minute: minute, second: second, millisecond: millisecond }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `second` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:761:72 [INFO] [stderr] | [INFO] [stderr] 761 | Ok(LocalTime { hour: hour, minute: minute, second: second, millisecond: millisecond }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `millisecond` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:824:13 [INFO] [stderr] | [INFO] [stderr] 824 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/datetime.rs:825:13 [INFO] [stderr] | [INFO] [stderr] 825 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:99:62 [INFO] [stderr] | [INFO] [stderr] 99 | Some(existing) => Err(FormatError::DoubleWidth { open_pos: open_pos, current_width: existing }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `open_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:106:66 [INFO] [stderr] | [INFO] [stderr] 106 | Some(existing) => Err(FormatError::DoubleAlignment { open_pos: open_pos, current_alignment: existing }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `open_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:319:81 [INFO] [stderr] | [INFO] [stderr] 319 | Some((pos, c)) => return Err(FormatError::InvalidChar { c: c, colon: true, pos: pos }), [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:319:100 [INFO] [stderr] | [INFO] [stderr] 319 | Some((pos, c)) => return Err(FormatError::InvalidChar { c: c, colon: true, pos: pos }), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:320:74 [INFO] [stderr] | [INFO] [stderr] 320 | None => return Err(FormatError::OpenCurlyBrace { open_pos: open_pos }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `open_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:326:73 [INFO] [stderr] | [INFO] [stderr] 326 | Some((pos, c)) => return Err(FormatError::InvalidChar { c: c, colon: false, pos: pos }), [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:326:93 [INFO] [stderr] | [INFO] [stderr] 326 | Some((pos, c)) => return Err(FormatError::InvalidChar { c: c, colon: false, pos: pos }), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:327:66 [INFO] [stderr] | [INFO] [stderr] 327 | None => return Err(FormatError::OpenCurlyBrace { open_pos: open_pos }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `open_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:335:56 [INFO] [stderr] | [INFO] [stderr] 335 | None => Err(FormatError::MissingField { open_pos: open_pos, close_pos: close_pos }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `open_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/fmt/custom.rs:335:76 [INFO] [stderr] | [INFO] [stderr] 335 | None => Err(FormatError::MissingField { open_pos: open_pos, close_pos: close_pos }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `close_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cal/offset.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | local: local, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `local` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/duration.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | Duration { seconds: seconds, milliseconds: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/duration.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | Duration { seconds: seconds, milliseconds: milliseconds } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/duration.rs:30:38 [INFO] [stderr] | [INFO] [stderr] 30 | Duration { seconds: seconds, milliseconds: milliseconds } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `milliseconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instant.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | Instant { seconds: seconds, milliseconds: milliseconds } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instant.rs:35:37 [INFO] [stderr] | [INFO] [stderr] 35 | Instant { seconds: seconds, milliseconds: milliseconds } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `milliseconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cal/datetime.rs:366:23 [INFO] [stderr] | [INFO] [stderr] 366 | const TIME_TRIANGLE: &'static [i64; 11] = [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[i64; 11]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cal/datetime.rs:366:23 [INFO] [stderr] | [INFO] [stderr] 366 | const TIME_TRIANGLE: &'static [i64; 11] = [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[i64; 11]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/cal/datetime.rs:1186:50 [INFO] [stderr] | [INFO] [stderr] 1186 | LocalDate::ymd(1970, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1186 | LocalDate::ymd(1970, Month::from_one(1).unwrap(), 01).unwrap(), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1186 | LocalDate::ymd(1970, Month::from_one(0o1).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/cal/datetime.rs:1186:64 [INFO] [stderr] | [INFO] [stderr] 1186 | LocalDate::ymd(1970, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1186 | LocalDate::ymd(1970, Month::from_one(01).unwrap(), 1).unwrap(), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1186 | LocalDate::ymd(1970, Month::from_one(01).unwrap(), 0o1).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/cal/datetime.rs:1187:30 [INFO] [stderr] | [INFO] [stderr] 1187 | LocalDate::ymd( 01, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1187 | LocalDate::ymd( 1, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1187 | LocalDate::ymd( 0o1, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/cal/datetime.rs:1187:50 [INFO] [stderr] | [INFO] [stderr] 1187 | LocalDate::ymd( 01, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1187 | LocalDate::ymd( 01, Month::from_one(1).unwrap(), 01).unwrap(), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1187 | LocalDate::ymd( 01, Month::from_one(0o1).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/cal/datetime.rs:1187:64 [INFO] [stderr] | [INFO] [stderr] 1187 | LocalDate::ymd( 01, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1187 | LocalDate::ymd( 01, Month::from_one(01).unwrap(), 1).unwrap(), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1187 | LocalDate::ymd( 01, Month::from_one(01).unwrap(), 0o1).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/cal/datetime.rs:1188:50 [INFO] [stderr] | [INFO] [stderr] 1188 | LocalDate::ymd(1971, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1188 | LocalDate::ymd(1971, Month::from_one(1).unwrap(), 01).unwrap(), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1188 | LocalDate::ymd(1971, Month::from_one(0o1).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/cal/datetime.rs:1188:64 [INFO] [stderr] | [INFO] [stderr] 1188 | LocalDate::ymd(1971, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1188 | LocalDate::ymd(1971, Month::from_one(01).unwrap(), 1).unwrap(), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1188 | LocalDate::ymd(1971, Month::from_one(01).unwrap(), 0o1).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/cal/datetime.rs:1189:50 [INFO] [stderr] | [INFO] [stderr] 1189 | LocalDate::ymd(1973, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1189 | LocalDate::ymd(1973, Month::from_one(1).unwrap(), 01).unwrap(), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1189 | LocalDate::ymd(1973, Month::from_one(0o1).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/cal/datetime.rs:1189:64 [INFO] [stderr] | [INFO] [stderr] 1189 | LocalDate::ymd(1973, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1189 | LocalDate::ymd(1973, Month::from_one(01).unwrap(), 1).unwrap(), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1189 | LocalDate::ymd(1973, Month::from_one(01).unwrap(), 0o1).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/cal/datetime.rs:1190:50 [INFO] [stderr] | [INFO] [stderr] 1190 | LocalDate::ymd(1977, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1190 | LocalDate::ymd(1977, Month::from_one(1).unwrap(), 01).unwrap(), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1190 | LocalDate::ymd(1977, Month::from_one(0o1).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/cal/datetime.rs:1190:64 [INFO] [stderr] | [INFO] [stderr] 1190 | LocalDate::ymd(1977, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1190 | LocalDate::ymd(1977, Month::from_one(01).unwrap(), 1).unwrap(), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1190 | LocalDate::ymd(1977, Month::from_one(01).unwrap(), 0o1).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/cal/datetime.rs:1194:64 [INFO] [stderr] | [INFO] [stderr] 1194 | LocalDate::ymd(2001, Month::from_one( 2).unwrap(), 03).unwrap() [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1194 | LocalDate::ymd(2001, Month::from_one( 2).unwrap(), 3).unwrap() [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1194 | LocalDate::ymd(2001, Month::from_one( 2).unwrap(), 0o3).unwrap() [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cal/fmt/custom.rs:404:132 [INFO] [stderr] | [INFO] [stderr] 404 | test!(width_123456789: "{>123456789:D}" => Ok(DateFormat { fields: vec![ Day(NumArguments(Arguments::empty().set_width(123456789).set_alignment(Alignment::Right))) ] })); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cal/zone.rs:413:48 [INFO] [stderr] | [INFO] [stderr] 413 | assert_eq!(NONE.find_with_surroundings(1184000000), Surroundings { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_184_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cal/zone.rs:431:14 [INFO] [stderr] | [INFO] [stderr] 431 | (1174784400, FixedTimespan { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_174_784_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cal/zone.rs:441:47 [INFO] [stderr] | [INFO] [stderr] 441 | assert_eq!(ONE.find_with_surroundings(1184000000), Surroundings { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_184_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cal/zone.rs:448:17 [INFO] [stderr] | [INFO] [stderr] 448 | 1174784400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_174_784_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cal/zone.rs:461:47 [INFO] [stderr] | [INFO] [stderr] 461 | assert_eq!(ONE.find_with_surroundings(1174000000), Surroundings { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_174_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cal/zone.rs:469:17 [INFO] [stderr] | [INFO] [stderr] 469 | 1174784400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_174_784_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cal/zone.rs:486:14 [INFO] [stderr] | [INFO] [stderr] 486 | (1174784400, FixedTimespan { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_174_784_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cal/zone.rs:491:14 [INFO] [stderr] | [INFO] [stderr] 491 | (1193533200, FixedTimespan { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_193_533_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cal/zone.rs:501:48 [INFO] [stderr] | [INFO] [stderr] 501 | assert_eq!(MANY.find_with_surroundings(1184000000), Surroundings { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_184_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cal/zone.rs:508:17 [INFO] [stderr] | [INFO] [stderr] 508 | 1174784400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_174_784_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cal/zone.rs:516:17 [INFO] [stderr] | [INFO] [stderr] 516 | 1193533200, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_193_533_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cal/zone.rs:528:48 [INFO] [stderr] | [INFO] [stderr] 528 | assert_eq!(MANY.find_with_surroundings(1200000000), Surroundings { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_200_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cal/zone.rs:535:17 [INFO] [stderr] | [INFO] [stderr] 535 | 1193533200, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_193_533_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: trivial numeric cast: `i64` as `i64` [INFO] [stderr] --> src/system.rs:76:6 [INFO] [stderr] | [INFO] [stderr] 76 | (tv.tv_sec as i64, (tv.tv_nsec / 1000) as i16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | #![warn(trivial_casts, trivial_numeric_casts)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: cast can be replaced by coercion; this might require a temporary variable [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn is_leap_year(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:72:33 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn months(&self, span: S) -> YearMonths { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:90:18 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn month(&self, month: Month) -> YearMonth { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:102:31 [INFO] [stderr] | [INFO] [stderr] 102 | fn leap_year_calculations(&self) -> (i64, bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/cal/datetime.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / fn deref<'a>(&'a self) -> &'a Self::Target { [INFO] [stderr] 127 | | &self.0 [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cal/datetime.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | 1 .. ym.day_count() + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=ym.day_count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cal/datetime.rs:278:9 [INFO] [stderr] | [INFO] [stderr] 278 | self.start .. ym.day_count() + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.start..=ym.day_count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/datetime.rs:509:26 [INFO] [stderr] | [INFO] [stderr] 509 | let correction = days_to_weekday(jan_4.to_days_since_epoch().unwrap() - EPOCH_DIFFERENCE).days_from_monday_as_one() as i64 + 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(days_to_weekday(jan_4.to_days_since_epoch().unwrap() - EPOCH_DIFFERENCE).days_from_monday_as_one())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/datetime.rs:511:34 [INFO] [stderr] | [INFO] [stderr] 511 | let yearday = 7 * week + weekday.days_from_monday_as_one() as i64 - correction; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(weekday.days_from_monday_as_one())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:770:23 [INFO] [stderr] | [INFO] [stderr] 770 | pub fn to_seconds(&self) -> i64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/datetime.rs:771:9 [INFO] [stderr] | [INFO] [stderr] 771 | self.hour as i64 * 3600 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(self.hour)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/datetime.rs:772:15 [INFO] [stderr] | [INFO] [stderr] 772 | + self.minute as i64 * 60 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.minute)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/datetime.rs:773:15 [INFO] [stderr] | [INFO] [stderr] 773 | + self.second as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/datetime.rs:942:15 [INFO] [stderr] | [INFO] [stderr] 942 | + self.month.days_before_start() as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.month.days_before_start())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/datetime.rs:949:15 [INFO] [stderr] | [INFO] [stderr] 949 | + (self.day - 1) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.day - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:1032:26 [INFO] [stderr] | [INFO] [stderr] 1032 | pub fn days_in_month(&self, leap_year: bool) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:1045:26 [INFO] [stderr] | [INFO] [stderr] 1045 | fn days_before_start(&self) -> i16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:1054:32 [INFO] [stderr] | [INFO] [stderr] 1054 | pub fn months_from_january(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:1118:32 [INFO] [stderr] | [INFO] [stderr] 1118 | fn days_from_monday_as_one(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/cal/fmt/custom.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | None => Ok({ self.width = Some(width); }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 98 | None => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/cal/fmt/custom.rs:105:24 [INFO] [stderr] | [INFO] [stderr] 105 | None => Ok({ self.alignment = Some(alignment); }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 105 | None => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/cal/fmt/custom.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | peekee: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cal/fmt/custom.rs:239:64 [INFO] [stderr] | [INFO] [stderr] 239 | let field = Field::Literal(&self.input[new_pos .. new_pos + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `new_pos..=new_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/cal/fmt/custom.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | / loop { [INFO] [stderr] 276 | | if let Some((_, n)) = self.peek() { [INFO] [stderr] 277 | | if n.is_digit(10) { [INFO] [stderr] 278 | | buf.push(n); [INFO] [stderr] ... | [INFO] [stderr] 287 | | } [INFO] [stderr] 288 | | } [INFO] [stderr] | |_________^ help: try: `while let Some((_, n)) = self.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cal/fmt/custom.rs:302:83 [INFO] [stderr] | [INFO] [stderr] 302 | Some((pos, '{')) if first => return Ok(Field::Literal(&self.input[pos .. pos + 1])), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `pos..=pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/offset.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | fn adjust(&self, local: LocalDateTime) -> LocalDateTime { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/offset.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | Some(s) => local + Duration::of(s as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/cal/offset.rs:47:49 [INFO] [stderr] | [INFO] [stderr] 47 | else if minutes <= -60 || minutes >= 60 { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 48 | | Err(Error::OutOfRange) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/cal/offset.rs:44:45 [INFO] [stderr] | [INFO] [stderr] 44 | else if hours <= -24 || hours >= 24 { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 45 | | Err(Error::OutOfRange) [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cal/offset.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | let hours = hours as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cal/offset.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | let minutes = minutes as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/offset.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn transform_date(&self, local: LocalDateTime) -> OffsetDateTime { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cal/offset.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | offset: self.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/offset.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn is_utc(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/offset.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn is_negative(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/offset.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn hours(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/offset.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn minutes(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/offset.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn seconds(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/parse.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | LocalDate::ymd(year as i64, month_variant, day as i8) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(year)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/parse.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | LocalDate::ywd(year as i64, ww as i64, weekday_variant) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(year)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/parse.rs:72:37 [INFO] [stderr] | [INFO] [stderr] 72 | LocalDate::ywd(year as i64, ww as i64, weekday_variant) [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(ww)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/parse.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | LocalDate::yd(year as i64, ddd as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(year)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/parse.rs:75:36 [INFO] [stderr] | [INFO] [stderr] 75 | LocalDate::yd(year as i64, ddd as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(ddd)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/duration.rs:52:64 [INFO] [stderr] | [INFO] [stderr] 52 | Duration::of_ms(self.seconds + rhs.seconds + 1, ms - 1000) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/duration.rs:66:64 [INFO] [stderr] | [INFO] [stderr] 66 | Duration::of_ms(self.seconds - rhs.seconds - 1, ms + 1000) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/duration.rs:78:18 [INFO] [stderr] | [INFO] [stderr] 78 | let ms = self.milliseconds as i64 * amount; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.milliseconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/duration.rs:79:64 [INFO] [stderr] | [INFO] [stderr] 79 | Duration::of_ms(self.seconds * amount + ms / 1000, (ms % 1000) as i16) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `datetime`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: trivial numeric cast: `i64` as `i64` [INFO] [stderr] --> src/system.rs:76:6 [INFO] [stderr] | [INFO] [stderr] 76 | (tv.tv_sec as i64, (tv.tv_nsec / 1000) as i16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | #![warn(trivial_casts, trivial_numeric_casts)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: cast can be replaced by coercion; this might require a temporary variable [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn is_leap_year(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:72:33 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn months(&self, span: S) -> YearMonths { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:90:18 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn month(&self, month: Month) -> YearMonth { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:102:31 [INFO] [stderr] | [INFO] [stderr] 102 | fn leap_year_calculations(&self) -> (i64, bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/cal/datetime.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | / fn deref<'a>(&'a self) -> &'a Self::Target { [INFO] [stderr] 127 | | &self.0 [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cal/datetime.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | 1 .. ym.day_count() + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=ym.day_count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cal/datetime.rs:278:9 [INFO] [stderr] | [INFO] [stderr] 278 | self.start .. ym.day_count() + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.start..=ym.day_count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/datetime.rs:509:26 [INFO] [stderr] | [INFO] [stderr] 509 | let correction = days_to_weekday(jan_4.to_days_since_epoch().unwrap() - EPOCH_DIFFERENCE).days_from_monday_as_one() as i64 + 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(days_to_weekday(jan_4.to_days_since_epoch().unwrap() - EPOCH_DIFFERENCE).days_from_monday_as_one())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/datetime.rs:511:34 [INFO] [stderr] | [INFO] [stderr] 511 | let yearday = 7 * week + weekday.days_from_monday_as_one() as i64 - correction; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(weekday.days_from_monday_as_one())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:770:23 [INFO] [stderr] | [INFO] [stderr] 770 | pub fn to_seconds(&self) -> i64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/datetime.rs:771:9 [INFO] [stderr] | [INFO] [stderr] 771 | self.hour as i64 * 3600 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(self.hour)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/datetime.rs:772:15 [INFO] [stderr] | [INFO] [stderr] 772 | + self.minute as i64 * 60 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.minute)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/datetime.rs:773:15 [INFO] [stderr] | [INFO] [stderr] 773 | + self.second as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.second)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/datetime.rs:942:15 [INFO] [stderr] | [INFO] [stderr] 942 | + self.month.days_before_start() as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.month.days_before_start())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/datetime.rs:949:15 [INFO] [stderr] | [INFO] [stderr] 949 | + (self.day - 1) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.day - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:1032:26 [INFO] [stderr] | [INFO] [stderr] 1032 | pub fn days_in_month(&self, leap_year: bool) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:1045:26 [INFO] [stderr] | [INFO] [stderr] 1045 | fn days_before_start(&self) -> i16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:1054:32 [INFO] [stderr] | [INFO] [stderr] 1054 | pub fn months_from_january(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/datetime.rs:1118:32 [INFO] [stderr] | [INFO] [stderr] 1118 | fn days_from_monday_as_one(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/cal/datetime.rs:1185:22 [INFO] [stderr] | [INFO] [stderr] 1185 | for date in vec![ [INFO] [stderr] | ______________________^ [INFO] [stderr] 1186 | | LocalDate::ymd(1970, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] 1187 | | LocalDate::ymd( 01, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] 1188 | | LocalDate::ymd(1971, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 1194 | | LocalDate::ymd(2001, Month::from_one( 2).unwrap(), 03).unwrap() [INFO] [stderr] 1195 | | ]{ [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] help: you can use a slice directly [INFO] [stderr] | [INFO] [stderr] 1185 | for date in &[LocalDate::ymd(1970, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] 1186 | LocalDate::ymd( 01, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] 1187 | LocalDate::ymd(1971, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] 1188 | LocalDate::ymd(1973, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] 1189 | LocalDate::ymd(1977, Month::from_one(01).unwrap(), 01).unwrap(), [INFO] [stderr] 1190 | LocalDate::ymd(1989, Month::from_one(11).unwrap(), 10).unwrap(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/cal/fmt/custom.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | None => Ok({ self.width = Some(width); }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 98 | None => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/cal/fmt/custom.rs:105:24 [INFO] [stderr] | [INFO] [stderr] 105 | None => Ok({ self.alignment = Some(alignment); }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 105 | None => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/cal/fmt/custom.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | peekee: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cal/fmt/custom.rs:239:64 [INFO] [stderr] | [INFO] [stderr] 239 | let field = Field::Literal(&self.input[new_pos .. new_pos + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `new_pos..=new_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/cal/fmt/custom.rs:275:9 [INFO] [stderr] | [INFO] [stderr] 275 | / loop { [INFO] [stderr] 276 | | if let Some((_, n)) = self.peek() { [INFO] [stderr] 277 | | if n.is_digit(10) { [INFO] [stderr] 278 | | buf.push(n); [INFO] [stderr] ... | [INFO] [stderr] 287 | | } [INFO] [stderr] 288 | | } [INFO] [stderr] | |_________^ help: try: `while let Some((_, n)) = self.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cal/fmt/custom.rs:302:83 [INFO] [stderr] | [INFO] [stderr] 302 | Some((pos, '{')) if first => return Ok(Field::Literal(&self.input[pos .. pos + 1])), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `pos..=pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/offset.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | fn adjust(&self, local: LocalDateTime) -> LocalDateTime { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/offset.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | Some(s) => local + Duration::of(s as i64), [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/cal/offset.rs:47:49 [INFO] [stderr] | [INFO] [stderr] 47 | else if minutes <= -60 || minutes >= 60 { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 48 | | Err(Error::OutOfRange) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/cal/offset.rs:44:45 [INFO] [stderr] | [INFO] [stderr] 44 | else if hours <= -24 || hours >= 24 { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 45 | | Err(Error::OutOfRange) [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cal/offset.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | let hours = hours as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cal/offset.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | let minutes = minutes as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/offset.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn transform_date(&self, local: LocalDateTime) -> OffsetDateTime { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cal/offset.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | offset: self.clone(), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/offset.rs:64:19 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn is_utc(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/offset.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn is_negative(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/offset.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn hours(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/offset.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | pub fn minutes(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cal/offset.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn seconds(&self) -> i8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/parse.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | LocalDate::ymd(year as i64, month_variant, day as i8) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(year)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/parse.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | LocalDate::ywd(year as i64, ww as i64, weekday_variant) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(year)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/parse.rs:72:37 [INFO] [stderr] | [INFO] [stderr] 72 | LocalDate::ywd(year as i64, ww as i64, weekday_variant) [INFO] [stderr] | ^^^^^^^^^ help: try: `i64::from(ww)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/parse.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | LocalDate::yd(year as i64, ddd as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(year)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cal/parse.rs:75:36 [INFO] [stderr] | [INFO] [stderr] 75 | LocalDate::yd(year as i64, ddd as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(ddd)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/duration.rs:52:64 [INFO] [stderr] | [INFO] [stderr] 52 | Duration::of_ms(self.seconds + rhs.seconds + 1, ms - 1000) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/duration.rs:66:64 [INFO] [stderr] | [INFO] [stderr] 66 | Duration::of_ms(self.seconds - rhs.seconds - 1, ms + 1000) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/duration.rs:78:18 [INFO] [stderr] | [INFO] [stderr] 78 | let ms = self.milliseconds as i64 * amount; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.milliseconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/duration.rs:79:64 [INFO] [stderr] | [INFO] [stderr] 79 | Duration::of_ms(self.seconds * amount + ms / 1000, (ms % 1000) as i16) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `datetime`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "afa5c260afc87c7c540cac622677062c7349ece3f789bb4bfa4dbc68c978848b"` [INFO] running `"docker" "rm" "-f" "afa5c260afc87c7c540cac622677062c7349ece3f789bb4bfa4dbc68c978848b"` [INFO] [stdout] afa5c260afc87c7c540cac622677062c7349ece3f789bb4bfa4dbc68c978848b