[INFO] crate date_time 1.4.1 is already in cache [INFO] extracting crate date_time 1.4.1 into work/ex/clippy-test-run/sources/stable/reg/date_time/1.4.1 [INFO] extracting crate date_time 1.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/date_time/1.4.1 [INFO] validating manifest of date_time-1.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of date_time-1.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing date_time-1.4.1 [INFO] finished frobbing date_time-1.4.1 [INFO] frobbed toml for date_time-1.4.1 written to work/ex/clippy-test-run/sources/stable/reg/date_time/1.4.1/Cargo.toml [INFO] started frobbing date_time-1.4.1 [INFO] finished frobbing date_time-1.4.1 [INFO] frobbed toml for date_time-1.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/date_time/1.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting date_time-1.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/date_time/1.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d9241e2e3272475fe996d5583fce7d41bb62e586995a61219ec3d0412de9fd03 [INFO] running `"docker" "start" "-a" "d9241e2e3272475fe996d5583fce7d41bb62e586995a61219ec3d0412de9fd03"` [INFO] [stderr] Checking date_time v1.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/date_tuple.rs:38:28 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(DateTuple { y: y, m, d }) [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/date_tuple.rs:38:28 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(DateTuple { y: y, m, d }) [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date_tuple.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | / return DateTuple { [INFO] [stderr] 73 | | y: self.y + 1, [INFO] [stderr] 74 | | m: 0, [INFO] [stderr] 75 | | d: 1, [INFO] [stderr] 76 | | }; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | DateTuple { [INFO] [stderr] 73 | y: self.y + 1, [INFO] [stderr] 74 | m: 0, [INFO] [stderr] 75 | d: 1, [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date_tuple.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | / return DateTuple { [INFO] [stderr] 79 | | y: self.y, [INFO] [stderr] 80 | | m: self.m + 1, [INFO] [stderr] 81 | | d: 1, [INFO] [stderr] 82 | | }; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 78 | DateTuple { [INFO] [stderr] 79 | y: self.y, [INFO] [stderr] 80 | m: self.m + 1, [INFO] [stderr] 81 | d: 1, [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date_tuple.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / return DateTuple { [INFO] [stderr] 86 | | y: self.y, [INFO] [stderr] 87 | | m: self.m, [INFO] [stderr] 88 | | d: self.d + 1, [INFO] [stderr] 89 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | DateTuple { [INFO] [stderr] 86 | y: self.y, [INFO] [stderr] 87 | m: self.m, [INFO] [stderr] 88 | d: self.d + 1, [INFO] [stderr] 89 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date_tuple.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | / return DateTuple { [INFO] [stderr] 102 | | y: self.y - 1, [INFO] [stderr] 103 | | m: 11, [INFO] [stderr] 104 | | d: get_last_date_in_month(11, self.y - 1), [INFO] [stderr] 105 | | }; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 101 | DateTuple { [INFO] [stderr] 102 | y: self.y - 1, [INFO] [stderr] 103 | m: 11, [INFO] [stderr] 104 | d: get_last_date_in_month(11, self.y - 1), [INFO] [stderr] 105 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date_tuple.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | / return DateTuple { [INFO] [stderr] 108 | | y: self.y, [INFO] [stderr] 109 | | m: self.m - 1, [INFO] [stderr] 110 | | d: get_last_date_in_month(self.m - 1, self.y), [INFO] [stderr] 111 | | }; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 107 | DateTuple { [INFO] [stderr] 108 | y: self.y, [INFO] [stderr] 109 | m: self.m - 1, [INFO] [stderr] 110 | d: get_last_date_in_month(self.m - 1, self.y), [INFO] [stderr] 111 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date_tuple.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | / return DateTuple { [INFO] [stderr] 115 | | y: self.y, [INFO] [stderr] 116 | | m: self.m, [INFO] [stderr] 117 | | d: self.d - 1, [INFO] [stderr] 118 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 114 | DateTuple { [INFO] [stderr] 115 | y: self.y, [INFO] [stderr] 116 | m: self.m, [INFO] [stderr] 117 | d: self.d - 1, [INFO] [stderr] 118 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/date_utils.rs:8:32 [INFO] [stderr] | [INFO] [stderr] 8 | const SECONDS_IN_A_YEAR: u64 = 31557600; [INFO] [stderr] | ^^^^^^^^ help: consider: `31_557_600` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/date_utils.rs:9:33 [INFO] [stderr] | [INFO] [stderr] 9 | const SECONDS_IN_A_MONTH: u64 = 2629800; [INFO] [stderr] | ^^^^^^^ help: consider: `2_629_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/date_time_tuple.rs:24:21 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn get_date(&self) -> DateTuple { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/date_time_tuple.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn get_time(&self) -> TimeTuple { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/date_time_tuple.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn to_readable_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/date_tuple.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn get_year(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/date_tuple.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn get_month(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/date_tuple.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn get_date(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date_tuple.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | / return DateTuple { [INFO] [stderr] 73 | | y: self.y + 1, [INFO] [stderr] 74 | | m: 0, [INFO] [stderr] 75 | | d: 1, [INFO] [stderr] 76 | | }; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | DateTuple { [INFO] [stderr] 73 | y: self.y + 1, [INFO] [stderr] 74 | m: 0, [INFO] [stderr] 75 | d: 1, [INFO] [stderr] 76 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date_tuple.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | / return DateTuple { [INFO] [stderr] 79 | | y: self.y, [INFO] [stderr] 80 | | m: self.m + 1, [INFO] [stderr] 81 | | d: 1, [INFO] [stderr] 82 | | }; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 78 | DateTuple { [INFO] [stderr] 79 | y: self.y, [INFO] [stderr] 80 | m: self.m + 1, [INFO] [stderr] 81 | d: 1, [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date_tuple.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / return DateTuple { [INFO] [stderr] 86 | | y: self.y, [INFO] [stderr] 87 | | m: self.m, [INFO] [stderr] 88 | | d: self.d + 1, [INFO] [stderr] 89 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | DateTuple { [INFO] [stderr] 86 | y: self.y, [INFO] [stderr] 87 | m: self.m, [INFO] [stderr] 88 | d: self.d + 1, [INFO] [stderr] 89 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date_tuple.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | / return DateTuple { [INFO] [stderr] 102 | | y: self.y - 1, [INFO] [stderr] 103 | | m: 11, [INFO] [stderr] 104 | | d: get_last_date_in_month(11, self.y - 1), [INFO] [stderr] 105 | | }; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 101 | DateTuple { [INFO] [stderr] 102 | y: self.y - 1, [INFO] [stderr] 103 | m: 11, [INFO] [stderr] 104 | d: get_last_date_in_month(11, self.y - 1), [INFO] [stderr] 105 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date_tuple.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | / return DateTuple { [INFO] [stderr] 108 | | y: self.y, [INFO] [stderr] 109 | | m: self.m - 1, [INFO] [stderr] 110 | | d: get_last_date_in_month(self.m - 1, self.y), [INFO] [stderr] 111 | | }; [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 107 | DateTuple { [INFO] [stderr] 108 | y: self.y, [INFO] [stderr] 109 | m: self.m - 1, [INFO] [stderr] 110 | d: get_last_date_in_month(self.m - 1, self.y), [INFO] [stderr] 111 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/date_tuple.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | / return DateTuple { [INFO] [stderr] 115 | | y: self.y, [INFO] [stderr] 116 | | m: self.m, [INFO] [stderr] 117 | | d: self.d - 1, [INFO] [stderr] 118 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 114 | DateTuple { [INFO] [stderr] 115 | y: self.y, [INFO] [stderr] 116 | m: self.m, [INFO] [stderr] 117 | d: self.d - 1, [INFO] [stderr] 118 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/date_tuple.rs:188:29 [INFO] [stderr] | [INFO] [stderr] 188 | let mut new_years = self.y as i32 - years as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/date_tuple.rs:188:45 [INFO] [stderr] | [INFO] [stderr] 188 | let mut new_years = self.y as i32 - years as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(years)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/date_tuple.rs:204:31 [INFO] [stderr] | [INFO] [stderr] 204 | pub fn to_readable_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/date_utils.rs:8:32 [INFO] [stderr] | [INFO] [stderr] 8 | const SECONDS_IN_A_YEAR: u64 = 31557600; [INFO] [stderr] | ^^^^^^^^ help: consider: `31_557_600` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/date_utils.rs:9:33 [INFO] [stderr] | [INFO] [stderr] 9 | const SECONDS_IN_A_MONTH: u64 = 2629800; [INFO] [stderr] | ^^^^^^^ help: consider: `2_629_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/month_tuple.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn get_year(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/month_tuple.rs:62:22 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn get_month(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/month_tuple.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | let mut new_years = self.y as i32 - years as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/month_tuple.rs:129:45 [INFO] [stderr] | [INFO] [stderr] 129 | let mut new_years = self.y as i32 - years as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(years)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/month_tuple.rs:141:31 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn to_readable_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/month_tuple.rs:142:15 [INFO] [stderr] | [INFO] [stderr] 142 | match MONTH_STRINGS.iter().skip(self.m as usize).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn get_hours(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn get_minutes(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn get_seconds(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:81:27 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn to_hhmm_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn to_seconds(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:87:16 [INFO] [stderr] | [INFO] [stderr] 87 | 3600 * self.h as u32 + 60 * self.m as u32 + self.s as u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:87:37 [INFO] [stderr] | [INFO] [stderr] 87 | 3600 * self.h as u32 + 60 * self.m as u32 + self.s as u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:87:53 [INFO] [stderr] | [INFO] [stderr] 87 | 3600 * self.h as u32 + 60 * self.m as u32 + self.s as u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:93:27 [INFO] [stderr] | [INFO] [stderr] 93 | let new_seconds = self.s as i32 + seconds; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:94:32 [INFO] [stderr] | [INFO] [stderr] 94 | *self = TimeTuple::new(self.h as i32, self.m as i32, new_seconds); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:94:47 [INFO] [stderr] | [INFO] [stderr] 94 | *self = TimeTuple::new(self.h as i32, self.m as i32, new_seconds); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:100:27 [INFO] [stderr] | [INFO] [stderr] 100 | let new_seconds = self.s as i32 - seconds; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:101:32 [INFO] [stderr] | [INFO] [stderr] 101 | *self = TimeTuple::new(self.h as i32, self.m as i32, new_seconds); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:101:47 [INFO] [stderr] | [INFO] [stderr] 101 | *self = TimeTuple::new(self.h as i32, self.m as i32, new_seconds); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:107:27 [INFO] [stderr] | [INFO] [stderr] 107 | let new_minutes = self.m as i32 + minutes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:108:32 [INFO] [stderr] | [INFO] [stderr] 108 | *self = TimeTuple::new(self.h as i32, new_minutes, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:108:60 [INFO] [stderr] | [INFO] [stderr] 108 | *self = TimeTuple::new(self.h as i32, new_minutes, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:114:27 [INFO] [stderr] | [INFO] [stderr] 114 | let new_minutes = self.m as i32 - minutes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:115:32 [INFO] [stderr] | [INFO] [stderr] 115 | *self = TimeTuple::new(self.h as i32, new_minutes, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:115:60 [INFO] [stderr] | [INFO] [stderr] 115 | *self = TimeTuple::new(self.h as i32, new_minutes, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:121:25 [INFO] [stderr] | [INFO] [stderr] 121 | let new_hours = self.h as i32 + hours; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:122:43 [INFO] [stderr] | [INFO] [stderr] 122 | *self = TimeTuple::new(new_hours, self.m as i32, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:122:58 [INFO] [stderr] | [INFO] [stderr] 122 | *self = TimeTuple::new(new_hours, self.m as i32, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | let new_hours = self.h as i32 - hours; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:129:43 [INFO] [stderr] | [INFO] [stderr] 129 | *self = TimeTuple::new(new_hours, self.m as i32, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:129:58 [INFO] [stderr] | [INFO] [stderr] 129 | *self = TimeTuple::new(new_hours, self.m as i32, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | (self.h + other.h) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.h + other.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | (self.m + other.m) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.m + other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | (self.s + other.s) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.s + other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | (self.h + other.h) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.h + other.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | (self.m + other.m) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.m + other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | (self.s + other.s) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.s + other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | (self.h - other.h) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.h - other.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | (self.m - other.m) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.m - other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | (self.s - other.s) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.s - other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | (self.h - other.h) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.h - other.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | (self.m - other.m) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.m - other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | (self.s - other.s) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.s - other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:236:32 [INFO] [stderr] | [INFO] [stderr] 236 | Duration::from_seconds(total_seconds as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(total_seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:254:22 [INFO] [stderr] | [INFO] [stderr] 254 | pub fn get_hours(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:258:24 [INFO] [stderr] | [INFO] [stderr] 258 | pub fn get_minutes(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:262:24 [INFO] [stderr] | [INFO] [stderr] 262 | pub fn get_seconds(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:271:40 [INFO] [stderr] | [INFO] [stderr] 271 | pub fn to_hours_and_minutes_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:276:23 [INFO] [stderr] | [INFO] [stderr] 276 | pub fn to_seconds(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:277:16 [INFO] [stderr] | [INFO] [stderr] 277 | 3600 * self.h as u64 + 60 * self.m as u64 + self.s as u64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:277:37 [INFO] [stderr] | [INFO] [stderr] 277 | 3600 * self.h as u64 + 60 * self.m as u64 + self.s as u64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:277:53 [INFO] [stderr] | [INFO] [stderr] 277 | 3600 * self.h as u64 + 60 * self.m as u64 + self.s as u64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:283:27 [INFO] [stderr] | [INFO] [stderr] 283 | let new_seconds = self.s as u32 + seconds; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:284:46 [INFO] [stderr] | [INFO] [stderr] 284 | *self = Duration::new(self.h as u32, self.m as u32, new_seconds); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:290:27 [INFO] [stderr] | [INFO] [stderr] 290 | let new_seconds = self.s as u32 - seconds; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:291:46 [INFO] [stderr] | [INFO] [stderr] 291 | *self = Duration::new(self.h as u32, self.m as u32, new_seconds); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:297:27 [INFO] [stderr] | [INFO] [stderr] 297 | let new_minutes = self.m as u32 + minutes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:298:59 [INFO] [stderr] | [INFO] [stderr] 298 | *self = Duration::new(self.h as u32, new_minutes, self.s as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:304:27 [INFO] [stderr] | [INFO] [stderr] 304 | let new_minutes = self.m as u32 - minutes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:305:59 [INFO] [stderr] | [INFO] [stderr] 305 | *self = Duration::new(self.h as u32, new_minutes, self.s as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:312:42 [INFO] [stderr] | [INFO] [stderr] 312 | *self = Duration::new(new_hours, self.m as u32, self.s as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:312:57 [INFO] [stderr] | [INFO] [stderr] 312 | *self = Duration::new(new_hours, self.m as u32, self.s as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:319:42 [INFO] [stderr] | [INFO] [stderr] 319 | *self = Duration::new(new_hours, self.m as u32, self.s as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:319:57 [INFO] [stderr] | [INFO] [stderr] 319 | *self = Duration::new(new_hours, self.m as u32, self.s as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | (self.m + other.m) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.m + other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | (self.s + other.s) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.s + other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | (self.m + other.m) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.m + other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:378:13 [INFO] [stderr] | [INFO] [stderr] 378 | (self.s + other.s) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.s + other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | (self.m - other.m) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.m - other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:389:13 [INFO] [stderr] | [INFO] [stderr] 389 | (self.s - other.s) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.s - other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | (self.m - other.m) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.m - other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:399:13 [INFO] [stderr] | [INFO] [stderr] 399 | (self.s - other.s) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.s - other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:406:32 [INFO] [stderr] | [INFO] [stderr] 406 | Duration::from_seconds(time.to_seconds() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(time.to_seconds())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/date_time_tuple.rs:24:21 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn get_date(&self) -> DateTuple { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/date_time_tuple.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn get_time(&self) -> TimeTuple { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/date_time_tuple.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn to_readable_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/date_tuple.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn get_year(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/date_tuple.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn get_month(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/date_tuple.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn get_date(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/date_tuple.rs:188:29 [INFO] [stderr] | [INFO] [stderr] 188 | let mut new_years = self.y as i32 - years as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/date_tuple.rs:188:45 [INFO] [stderr] | [INFO] [stderr] 188 | let mut new_years = self.y as i32 - years as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(years)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/date_tuple.rs:204:31 [INFO] [stderr] | [INFO] [stderr] 204 | pub fn to_readable_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/date_tuple.rs:336:20 [INFO] [stderr] | [INFO] [stderr] 336 | if let Err(_) = v { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 337 | | assert!(false); [INFO] [stderr] 338 | | } [INFO] [stderr] | |_____________- help: try this: `if v.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/date_tuple.rs:341:20 [INFO] [stderr] | [INFO] [stderr] 341 | if let Ok(_) = i { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 342 | | assert!(false); [INFO] [stderr] 343 | | } [INFO] [stderr] | |_____________- help: try this: `if i.is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/month_tuple.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn get_year(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/month_tuple.rs:62:22 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn get_month(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/month_tuple.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | let mut new_years = self.y as i32 - years as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/month_tuple.rs:129:45 [INFO] [stderr] | [INFO] [stderr] 129 | let mut new_years = self.y as i32 - years as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(years)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/month_tuple.rs:141:31 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn to_readable_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/month_tuple.rs:142:15 [INFO] [stderr] | [INFO] [stderr] 142 | match MONTH_STRINGS.iter().skip(self.m as usize).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/month_tuple.rs:254:16 [INFO] [stderr] | [INFO] [stderr] 254 | if let Ok(_) = super::MonthTuple::new(2000, 12) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 255 | | assert!(false) [INFO] [stderr] 256 | | } [INFO] [stderr] | |_________- help: try this: `if super::MonthTuple::new(2000, 12).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:66:22 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn get_hours(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn get_minutes(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn get_seconds(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:81:27 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn to_hhmm_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn to_seconds(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:87:16 [INFO] [stderr] | [INFO] [stderr] 87 | 3600 * self.h as u32 + 60 * self.m as u32 + self.s as u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:87:37 [INFO] [stderr] | [INFO] [stderr] 87 | 3600 * self.h as u32 + 60 * self.m as u32 + self.s as u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:87:53 [INFO] [stderr] | [INFO] [stderr] 87 | 3600 * self.h as u32 + 60 * self.m as u32 + self.s as u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:93:27 [INFO] [stderr] | [INFO] [stderr] 93 | let new_seconds = self.s as i32 + seconds; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:94:32 [INFO] [stderr] | [INFO] [stderr] 94 | *self = TimeTuple::new(self.h as i32, self.m as i32, new_seconds); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:94:47 [INFO] [stderr] | [INFO] [stderr] 94 | *self = TimeTuple::new(self.h as i32, self.m as i32, new_seconds); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:100:27 [INFO] [stderr] | [INFO] [stderr] 100 | let new_seconds = self.s as i32 - seconds; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:101:32 [INFO] [stderr] | [INFO] [stderr] 101 | *self = TimeTuple::new(self.h as i32, self.m as i32, new_seconds); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:101:47 [INFO] [stderr] | [INFO] [stderr] 101 | *self = TimeTuple::new(self.h as i32, self.m as i32, new_seconds); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:107:27 [INFO] [stderr] | [INFO] [stderr] 107 | let new_minutes = self.m as i32 + minutes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:108:32 [INFO] [stderr] | [INFO] [stderr] 108 | *self = TimeTuple::new(self.h as i32, new_minutes, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:108:60 [INFO] [stderr] | [INFO] [stderr] 108 | *self = TimeTuple::new(self.h as i32, new_minutes, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:114:27 [INFO] [stderr] | [INFO] [stderr] 114 | let new_minutes = self.m as i32 - minutes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:115:32 [INFO] [stderr] | [INFO] [stderr] 115 | *self = TimeTuple::new(self.h as i32, new_minutes, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:115:60 [INFO] [stderr] | [INFO] [stderr] 115 | *self = TimeTuple::new(self.h as i32, new_minutes, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:121:25 [INFO] [stderr] | [INFO] [stderr] 121 | let new_hours = self.h as i32 + hours; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:122:43 [INFO] [stderr] | [INFO] [stderr] 122 | *self = TimeTuple::new(new_hours, self.m as i32, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:122:58 [INFO] [stderr] | [INFO] [stderr] 122 | *self = TimeTuple::new(new_hours, self.m as i32, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:128:25 [INFO] [stderr] | [INFO] [stderr] 128 | let new_hours = self.h as i32 - hours; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:129:43 [INFO] [stderr] | [INFO] [stderr] 129 | *self = TimeTuple::new(new_hours, self.m as i32, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:129:58 [INFO] [stderr] | [INFO] [stderr] 129 | *self = TimeTuple::new(new_hours, self.m as i32, self.s as i32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | (self.h + other.h) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.h + other.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | (self.m + other.m) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.m + other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | (self.s + other.s) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.s + other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | (self.h + other.h) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.h + other.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | (self.m + other.m) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.m + other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | (self.s + other.s) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.s + other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | (self.h - other.h) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.h - other.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | (self.m - other.m) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.m - other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | (self.s - other.s) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.s - other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | (self.h - other.h) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.h - other.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | (self.m - other.m) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.m - other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | (self.s - other.s) as i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.s - other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:236:32 [INFO] [stderr] | [INFO] [stderr] 236 | Duration::from_seconds(total_seconds as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(total_seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:254:22 [INFO] [stderr] | [INFO] [stderr] 254 | pub fn get_hours(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:258:24 [INFO] [stderr] | [INFO] [stderr] 258 | pub fn get_minutes(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:262:24 [INFO] [stderr] | [INFO] [stderr] 262 | pub fn get_seconds(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:271:40 [INFO] [stderr] | [INFO] [stderr] 271 | pub fn to_hours_and_minutes_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/time_tuple.rs:276:23 [INFO] [stderr] | [INFO] [stderr] 276 | pub fn to_seconds(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:277:16 [INFO] [stderr] | [INFO] [stderr] 277 | 3600 * self.h as u64 + 60 * self.m as u64 + self.s as u64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:277:37 [INFO] [stderr] | [INFO] [stderr] 277 | 3600 * self.h as u64 + 60 * self.m as u64 + self.s as u64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:277:53 [INFO] [stderr] | [INFO] [stderr] 277 | 3600 * self.h as u64 + 60 * self.m as u64 + self.s as u64 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:283:27 [INFO] [stderr] | [INFO] [stderr] 283 | let new_seconds = self.s as u32 + seconds; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:284:46 [INFO] [stderr] | [INFO] [stderr] 284 | *self = Duration::new(self.h as u32, self.m as u32, new_seconds); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:290:27 [INFO] [stderr] | [INFO] [stderr] 290 | let new_seconds = self.s as u32 - seconds; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:291:46 [INFO] [stderr] | [INFO] [stderr] 291 | *self = Duration::new(self.h as u32, self.m as u32, new_seconds); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:297:27 [INFO] [stderr] | [INFO] [stderr] 297 | let new_minutes = self.m as u32 + minutes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:298:59 [INFO] [stderr] | [INFO] [stderr] 298 | *self = Duration::new(self.h as u32, new_minutes, self.s as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:304:27 [INFO] [stderr] | [INFO] [stderr] 304 | let new_minutes = self.m as u32 - minutes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:305:59 [INFO] [stderr] | [INFO] [stderr] 305 | *self = Duration::new(self.h as u32, new_minutes, self.s as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:312:42 [INFO] [stderr] | [INFO] [stderr] 312 | *self = Duration::new(new_hours, self.m as u32, self.s as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:312:57 [INFO] [stderr] | [INFO] [stderr] 312 | *self = Duration::new(new_hours, self.m as u32, self.s as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:319:42 [INFO] [stderr] | [INFO] [stderr] 319 | *self = Duration::new(new_hours, self.m as u32, self.s as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:319:57 [INFO] [stderr] | [INFO] [stderr] 319 | *self = Duration::new(new_hours, self.m as u32, self.s as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(self.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | (self.m + other.m) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.m + other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:368:13 [INFO] [stderr] | [INFO] [stderr] 368 | (self.s + other.s) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.s + other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | (self.m + other.m) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.m + other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:378:13 [INFO] [stderr] | [INFO] [stderr] 378 | (self.s + other.s) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.s + other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | (self.m - other.m) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.m - other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:389:13 [INFO] [stderr] | [INFO] [stderr] 389 | (self.s - other.s) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.s - other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | (self.m - other.m) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.m - other.m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:399:13 [INFO] [stderr] | [INFO] [stderr] 399 | (self.s - other.s) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.s - other.s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/time_tuple.rs:406:32 [INFO] [stderr] | [INFO] [stderr] 406 | Duration::from_seconds(time.to_seconds() as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(time.to_seconds())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> src/time_tuple.rs:503:28 [INFO] [stderr] | [INFO] [stderr] 503 | assert_eq!(zeroes, ones - ones); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `<=` [INFO] [stderr] --> src/time_tuple.rs:508:17 [INFO] [stderr] | [INFO] [stderr] 508 | assert!(ones <= ones); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `date_time`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d9241e2e3272475fe996d5583fce7d41bb62e586995a61219ec3d0412de9fd03"` [INFO] running `"docker" "rm" "-f" "d9241e2e3272475fe996d5583fce7d41bb62e586995a61219ec3d0412de9fd03"` [INFO] [stdout] d9241e2e3272475fe996d5583fce7d41bb62e586995a61219ec3d0412de9fd03