[INFO] crate datafrog 1.0.0 is already in cache
[INFO] extracting crate datafrog 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/datafrog/1.0.0
[INFO] extracting crate datafrog 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/datafrog/1.0.0
[INFO] validating manifest of datafrog-1.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of datafrog-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing datafrog-1.0.0
[INFO] finished frobbing datafrog-1.0.0
[INFO] frobbed toml for datafrog-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/datafrog/1.0.0/Cargo.toml
[INFO] started frobbing datafrog-1.0.0
[INFO] finished frobbing datafrog-1.0.0
[INFO] frobbed toml for datafrog-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/datafrog/1.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting datafrog-1.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/datafrog/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3661ae75f0ecd8b6dfc7ecf135c5771a4a3eb9b09eaa98985af63a29d2812eaf
[INFO] running `"docker" "start" "-a" "3661ae75f0ecd8b6dfc7ecf135c5771a4a3eb9b09eaa98985af63a29d2812eaf"`
[INFO] [stderr]     Checking datafrog v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: the loop variable `index` is used to index `leapers`
[INFO] [stderr]   --> src/treefrog.rs:19:22
[INFO] [stderr]    |
[INFO] [stderr] 19 |         for index in 0..leapers.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 19 |         for (index, <item>) in leapers.iter_mut().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `index` is used to index `leapers`
[INFO] [stderr]   --> src/treefrog.rs:36:26
[INFO] [stderr]    |
[INFO] [stderr] 36 |             for index in 0..leapers.len() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 36 |             for (index, <item>) in leapers.iter_mut().enumerate() {
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/treefrog.rs:188:64
[INFO] [stderr]     |
[INFO] [stderr] 188 |             self.start = binary_search(&self.relation[..], |x| &x.0 < &key);
[INFO] [stderr]     |                                                                ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 188 |             self.start = binary_search(&self.relation[..], |x| x.0 < key);
[INFO] [stderr]     |                                                                ^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/treefrog.rs:190:45
[INFO] [stderr]     |
[INFO] [stderr] 190 |             let slice2 = gallop(slice1, |x| &x.0 <= &key);
[INFO] [stderr]     |                                             ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 190 |             let slice2 = gallop(slice1, |x| x.0 <= key);
[INFO] [stderr]     |                                             ^^^    ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/treefrog.rs:201:44
[INFO] [stderr]     |
[INFO] [stderr] 201 |                 slice = gallop(slice, |kv| &kv.1 < v);
[INFO] [stderr]     |                                            -----^^^^
[INFO] [stderr]     |                                            |
[INFO] [stderr]     |                                            help: use the left value directly: `kv.1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/treefrog.rs:258:63
[INFO] [stderr]     |
[INFO] [stderr] 258 |             let start = binary_search(&self.relation[..], |x| &x.0 < &key);
[INFO] [stderr]     |                                                               ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 258 |             let start = binary_search(&self.relation[..], |x| x.0 < key);
[INFO] [stderr]     |                                                               ^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/treefrog.rs:260:45
[INFO] [stderr]     |
[INFO] [stderr] 260 |             let slice2 = gallop(slice1, |x| &x.0 <= &key);
[INFO] [stderr]     |                                             ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 260 |             let slice2 = gallop(slice1, |x| x.0 <= key);
[INFO] [stderr]     |                                             ^^^    ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/treefrog.rs:264:48
[INFO] [stderr]     |
[INFO] [stderr] 264 |                     slice = gallop(slice, |kv| &kv.1 < v);
[INFO] [stderr]     |                                                -----^^^^
[INFO] [stderr]     |                                                |
[INFO] [stderr]     |                                                help: use the left value directly: `kv.1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Iteration`
[INFO] [stderr]    --> src/lib.rs:127:5
[INFO] [stderr]     |
[INFO] [stderr] 127 | /     pub fn new() -> Self {
[INFO] [stderr] 128 | |         Iteration {
[INFO] [stderr] 129 | |             variables: Vec::new(),
[INFO] [stderr] 130 | |         }
[INFO] [stderr] 131 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 121 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:223:9
[INFO] [stderr]     |
[INFO] [stderr] 223 |         &self,
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:256:9
[INFO] [stderr]     |
[INFO] [stderr] 256 |         &self,
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:293:30
[INFO] [stderr]     |
[INFO] [stderr] 293 |     pub fn from_map<T2: Ord>(&self, input: &Variable<T2>, logic: impl FnMut(&T2) -> Tuple) {
[INFO] [stderr]     |                              ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:325:9
[INFO] [stderr]     |
[INFO] [stderr] 325 |         &self,
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/lib.rs:420:56
[INFO] [stderr]     |
[INFO] [stderr] 420 |                             while !slice.is_empty() && &slice[0] < x {
[INFO] [stderr]     |                                                        ---------^^^^
[INFO] [stderr]     |                                                        |
[INFO] [stderr]     |                                                        help: use the left value directly: `slice[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `index` is used to index `leapers`
[INFO] [stderr]   --> src/treefrog.rs:19:22
[INFO] [stderr]    |
[INFO] [stderr] 19 |         for index in 0..leapers.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 19 |         for (index, <item>) in leapers.iter_mut().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `index` is used to index `leapers`
[INFO] [stderr]   --> src/treefrog.rs:36:26
[INFO] [stderr]    |
[INFO] [stderr] 36 |             for index in 0..leapers.len() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 36 |             for (index, <item>) in leapers.iter_mut().enumerate() {
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/treefrog.rs:188:64
[INFO] [stderr]     |
[INFO] [stderr] 188 |             self.start = binary_search(&self.relation[..], |x| &x.0 < &key);
[INFO] [stderr]     |                                                                ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 188 |             self.start = binary_search(&self.relation[..], |x| x.0 < key);
[INFO] [stderr]     |                                                                ^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/treefrog.rs:190:45
[INFO] [stderr]     |
[INFO] [stderr] 190 |             let slice2 = gallop(slice1, |x| &x.0 <= &key);
[INFO] [stderr]     |                                             ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 190 |             let slice2 = gallop(slice1, |x| x.0 <= key);
[INFO] [stderr]     |                                             ^^^    ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/treefrog.rs:201:44
[INFO] [stderr]     |
[INFO] [stderr] 201 |                 slice = gallop(slice, |kv| &kv.1 < v);
[INFO] [stderr]     |                                            -----^^^^
[INFO] [stderr]     |                                            |
[INFO] [stderr]     |                                            help: use the left value directly: `kv.1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/treefrog.rs:258:63
[INFO] [stderr]     |
[INFO] [stderr] 258 |             let start = binary_search(&self.relation[..], |x| &x.0 < &key);
[INFO] [stderr]     |                                                               ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 258 |             let start = binary_search(&self.relation[..], |x| x.0 < key);
[INFO] [stderr]     |                                                               ^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/treefrog.rs:260:45
[INFO] [stderr]     |
[INFO] [stderr] 260 |             let slice2 = gallop(slice1, |x| &x.0 <= &key);
[INFO] [stderr]     |                                             ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 260 |             let slice2 = gallop(slice1, |x| x.0 <= key);
[INFO] [stderr]     |                                             ^^^    ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/treefrog.rs:264:48
[INFO] [stderr]     |
[INFO] [stderr] 264 |                     slice = gallop(slice, |kv| &kv.1 < v);
[INFO] [stderr]     |                                                -----^^^^
[INFO] [stderr]     |                                                |
[INFO] [stderr]     |                                                help: use the left value directly: `kv.1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Iteration`
[INFO] [stderr]    --> src/lib.rs:127:5
[INFO] [stderr]     |
[INFO] [stderr] 127 | /     pub fn new() -> Self {
[INFO] [stderr] 128 | |         Iteration {
[INFO] [stderr] 129 | |             variables: Vec::new(),
[INFO] [stderr] 130 | |         }
[INFO] [stderr] 131 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 121 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:223:9
[INFO] [stderr]     |
[INFO] [stderr] 223 |         &self,
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:256:9
[INFO] [stderr]     |
[INFO] [stderr] 256 |         &self,
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:293:30
[INFO] [stderr]     |
[INFO] [stderr] 293 |     pub fn from_map<T2: Ord>(&self, input: &Variable<T2>, logic: impl FnMut(&T2) -> Tuple) {
[INFO] [stderr]     |                              ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:325:9
[INFO] [stderr]     |
[INFO] [stderr] 325 |         &self,
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/lib.rs:420:56
[INFO] [stderr]     |
[INFO] [stderr] 420 |                             while !slice.is_empty() && &slice[0] < x {
[INFO] [stderr]     |                                                        ---------^^^^
[INFO] [stderr]     |                                                        |
[INFO] [stderr]     |                                                        help: use the left value directly: `slice[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.63s
[INFO] running `"docker" "inspect" "3661ae75f0ecd8b6dfc7ecf135c5771a4a3eb9b09eaa98985af63a29d2812eaf"`
[INFO] running `"docker" "rm" "-f" "3661ae75f0ecd8b6dfc7ecf135c5771a4a3eb9b09eaa98985af63a29d2812eaf"`
[INFO] [stdout] 3661ae75f0ecd8b6dfc7ecf135c5771a4a3eb9b09eaa98985af63a29d2812eaf