[INFO] crate dash 0.1.0 is already in cache [INFO] extracting crate dash 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/dash/0.1.0 [INFO] extracting crate dash 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dash/0.1.0 [INFO] validating manifest of dash-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dash-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dash-0.1.0 [INFO] finished frobbing dash-0.1.0 [INFO] frobbed toml for dash-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/dash/0.1.0/Cargo.toml [INFO] started frobbing dash-0.1.0 [INFO] finished frobbing dash-0.1.0 [INFO] frobbed toml for dash-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dash/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dash-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/dash/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cd4dcd67a994b6dcb7fc1d3f59572db9aa8e43829ff6d5a7dca44f9a2dc5e23f [INFO] running `"docker" "start" "-a" "cd4dcd67a994b6dcb7fc1d3f59572db9aa8e43829ff6d5a7dca44f9a2dc5e23f"` [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Checking strsim v0.5.2 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Checking ansi_term v0.9.0 [INFO] [stderr] Checking unicode-segmentation v0.1.3 [INFO] [stderr] Checking vec_map v0.6.0 [INFO] [stderr] Checking term_size v0.2.3 [INFO] [stderr] Checking clap v2.19.3 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking dash v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/predicate/parsers.rs:26:45 [INFO] [stderr] | [INFO] [stderr] 26 | let s: Vec = key.split(".").map(|s| String::from(s)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/predicate/parsers.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | let s: Vec = key.split(".").map(|s| String::from(s)).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/predicate/parsers.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | let splits: Vec<&str> = pred_str.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/predicate/parsers.rs:39:42 [INFO] [stderr] | [INFO] [stderr] 39 | let val: Vec<&str> = splits[2].split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:352:48 [INFO] [stderr] | [INFO] [stderr] 352 | fn compare(a: T, b: T, operator: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:360:45 [INFO] [stderr] | [INFO] [stderr] 360 | fn cast_path(elt: &serde_json::Value, path: &String) -> serde_json::Value { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:361:5 [INFO] [stderr] | [INFO] [stderr] 361 | / let mut val = json!(elt); [INFO] [stderr] 362 | | [INFO] [stderr] 363 | | if path != "$self" { [INFO] [stderr] 364 | | val = json!(elt.pointer(path).unwrap()); [INFO] [stderr] 365 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let val = if path != "$self" { $ crate :: to_value ( & $ other ) . unwrap ( ) } else { $ crate :: to_value ( & $ other ) . unwrap ( ) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:380:5 [INFO] [stderr] | [INFO] [stderr] 380 | io::stdout().write(contents.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `dash`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/predicate/parsers.rs:26:45 [INFO] [stderr] | [INFO] [stderr] 26 | let s: Vec = key.split(".").map(|s| String::from(s)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/predicate/parsers.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | let s: Vec = key.split(".").map(|s| String::from(s)).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/predicate/parsers.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | let splits: Vec<&str> = pred_str.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/predicate/parsers.rs:39:42 [INFO] [stderr] | [INFO] [stderr] 39 | let val: Vec<&str> = splits[2].split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:352:48 [INFO] [stderr] | [INFO] [stderr] 352 | fn compare(a: T, b: T, operator: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:360:45 [INFO] [stderr] | [INFO] [stderr] 360 | fn cast_path(elt: &serde_json::Value, path: &String) -> serde_json::Value { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:361:5 [INFO] [stderr] | [INFO] [stderr] 361 | / let mut val = json!(elt); [INFO] [stderr] 362 | | [INFO] [stderr] 363 | | if path != "$self" { [INFO] [stderr] 364 | | val = json!(elt.pointer(path).unwrap()); [INFO] [stderr] 365 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let val = if path != "$self" { $ crate :: to_value ( & $ other ) . unwrap ( ) } else { $ crate :: to_value ( & $ other ) . unwrap ( ) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:380:5 [INFO] [stderr] | [INFO] [stderr] 380 | io::stdout().write(contents.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `dash`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cd4dcd67a994b6dcb7fc1d3f59572db9aa8e43829ff6d5a7dca44f9a2dc5e23f"` [INFO] running `"docker" "rm" "-f" "cd4dcd67a994b6dcb7fc1d3f59572db9aa8e43829ff6d5a7dca44f9a2dc5e23f"` [INFO] [stdout] cd4dcd67a994b6dcb7fc1d3f59572db9aa8e43829ff6d5a7dca44f9a2dc5e23f