[INFO] crate darling_core 0.8.0 is already in cache
[INFO] extracting crate darling_core 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/darling_core/0.8.0
[INFO] extracting crate darling_core 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/darling_core/0.8.0
[INFO] validating manifest of darling_core-0.8.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of darling_core-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing darling_core-0.8.0
[INFO] finished frobbing darling_core-0.8.0
[INFO] frobbed toml for darling_core-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/darling_core/0.8.0/Cargo.toml
[INFO] started frobbing darling_core-0.8.0
[INFO] finished frobbing darling_core-0.8.0
[INFO] frobbed toml for darling_core-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/darling_core/0.8.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting darling_core-0.8.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/darling_core/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c15c96015cea4c70331816c11ab7570dea0bb8188bf731b6ff6396c87cbab54b
[INFO] running `"docker" "start" "-a" "c15c96015cea4c70331816c11ab7570dea0bb8188bf731b6ff6396c87cbab54b"`
[INFO] [stderr]     Checking ident_case v1.0.0
[INFO] [stderr]     Checking darling_core v0.8.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/error.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/error.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             kind: kind,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/codegen/field.rs:168:16
[INFO] [stderr]     |
[INFO] [stderr] 168 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 169 | |             if let Some(ref expr) = field.default_expression {
[INFO] [stderr] 170 | |                 quote!(#ident: match #ident.1 {
[INFO] [stderr] 171 | |                     ::darling::export::Some(__val) => __val,
[INFO] [stderr] ...   |
[INFO] [stderr] 176 | |             }
[INFO] [stderr] 177 | |         });
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 168 |         } else if let Some(ref expr) = field.default_expression {
[INFO] [stderr] 169 |     quote!(#ident: match #ident.1 {
[INFO] [stderr] 170 |         ::darling::export::Some(__val) => __val,
[INFO] [stderr] 171 |         ::darling::export::None => #expr,
[INFO] [stderr] 172 |     })
[INFO] [stderr] 173 | } else {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/codegen/field.rs:168:16
[INFO] [stderr]     |
[INFO] [stderr] 168 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 169 | |             if let Some(ref expr) = field.default_expression {
[INFO] [stderr] 170 | |                 quote!(#ident: match #ident.1 {
[INFO] [stderr] 171 | |                     ::darling::export::Some(__val) => __val,
[INFO] [stderr] ...   |
[INFO] [stderr] 176 | |             }
[INFO] [stderr] 177 | |         });
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 168 |         } else if let Some(ref expr) = field.default_expression {
[INFO] [stderr] 169 |     quote!(#ident: match #ident.1 {
[INFO] [stderr] 170 |         ::darling::export::Some(__val) => __val,
[INFO] [stderr] 171 |         ::darling::export::None => #expr,
[INFO] [stderr] 172 |     })
[INFO] [stderr] 173 | } else {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: the since field must contain a semver-compliant version
[INFO] [stderr]   --> src/ast/data.rs:19:14
[INFO] [stderr]    |
[INFO] [stderr] 19 | #[deprecated(since = "0.3", note = "this has been renamed to Data")]
[INFO] [stderr]    |              ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::deprecated_semver)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_semver
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/ast/data.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 | /     pub fn as_ref<'a>(&'a self) -> Data<&'a V, &'a F> {
[INFO] [stderr] 34 | |         match *self {
[INFO] [stderr] 35 | |             Data::Enum(ref variants) => Data::Enum(variants.into_iter().collect()),
[INFO] [stderr] 36 | |             Data::Struct(ref data) => Data::Struct(data.as_ref()),
[INFO] [stderr] 37 | |         }
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/ast/data.rs:35:61
[INFO] [stderr]    |
[INFO] [stderr] 35 |             Data::Enum(ref variants) => Data::Enum(variants.into_iter().collect()),
[INFO] [stderr]    |                                                             ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] error: the since field must contain a semver-compliant version
[INFO] [stderr]    --> src/ast/data.rs:165:14
[INFO] [stderr]     |
[INFO] [stderr] 165 | #[deprecated(since = "0.3", note = "this has been renamed to Fields")]
[INFO] [stderr]     |              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_semver
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/ast/data.rs:317:20
[INFO] [stderr]     |
[INFO] [stderr] 317 |     pub fn is_unit(&self) -> bool {
[INFO] [stderr]     |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/ast/data.rs:321:21
[INFO] [stderr]     |
[INFO] [stderr] 321 |     pub fn is_tuple(&self) -> bool {
[INFO] [stderr]     |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/ast/data.rs:325:22
[INFO] [stderr]     |
[INFO] [stderr] 325 |     pub fn is_struct(&self) -> bool {
[INFO] [stderr]     |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/ast/generics.rs:145:5
[INFO] [stderr]     |
[INFO] [stderr] 145 | /     pub fn type_params<'a>(&'a self) -> TypeParams<'a, P> {
[INFO] [stderr] 146 | |         TypeParams(self.params.iter())
[INFO] [stderr] 147 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `codegen::error::ErrorDeclaration`
[INFO] [stderr]   --> src/codegen/error.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn new() -> Self {
[INFO] [stderr] 11 | |         ErrorDeclaration { __hidden: () }
[INFO] [stderr] 12 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 5  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `codegen::error::ErrorCheck<'a>`
[INFO] [stderr]   --> src/codegen/error.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 | /     pub fn new() -> Self {
[INFO] [stderr] 31 | |         ErrorCheck {
[INFO] [stderr] 32 | |             location: None,
[INFO] [stderr] 33 | |             __hidden: (),
[INFO] [stderr] 34 | |         }
[INFO] [stderr] 35 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 24 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/codegen/outer_from_impl.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 | /         if let &mut GenericParam::Type(ref mut typ) = param {
[INFO] [stderr] 53 | |             if applies_to.contains(&typ.ident) {
[INFO] [stderr] 54 | |                 typ.bounds.push(added_bound.clone());
[INFO] [stderr] 55 | |             }
[INFO] [stderr] 56 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 52 |         if let GenericParam::Type(ref mut typ) = *param {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/codegen/trait_impl.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 | /     fn type_params_matching<'b, F, V>(&'b self, field_filter: F, variant_filter: V) -> IdentSet
[INFO] [stderr] 40 | |     where
[INFO] [stderr] 41 | |         F: Fn(&&Field) -> bool,
[INFO] [stderr] 42 | |         V: Fn(&&Variant) -> bool,
[INFO] [stderr] ...  |
[INFO] [stderr] 58 | |         }
[INFO] [stderr] 59 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `foo`
[INFO] [stderr]    --> src/codegen/trait_impl.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |         let foo = match self.data {
[INFO] [stderr]     |             ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `foo`
[INFO] [stderr]    --> src/codegen/trait_impl.rs:142:13
[INFO] [stderr]     |
[INFO] [stderr] 142 |         let foo = match self.data {
[INFO] [stderr]     |             ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/codegen/variant_data.rs:17:34
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 let vdr = fields.into_iter().map(Field::as_declaration);
[INFO] [stderr]    |                                  ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/codegen/variant_data.rs:47:37
[INFO] [stderr]    |
[INFO] [stderr] 47 |                 let checks = fields.into_iter().map(Field::as_presence_check);
[INFO] [stderr]    |                                     ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: item `error::Error` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/error.rs:25:1
[INFO] [stderr]     |
[INFO] [stderr] 25  | / impl Error {
[INFO] [stderr] 26  | |     fn new(kind: ErrorKind) -> Self {
[INFO] [stderr] 27  | |         Error {
[INFO] [stderr] 28  | |             kind: kind,
[INFO] [stderr] ...   |
[INFO] [stderr] 147 | |     }
[INFO] [stderr] 148 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/error.rs:105:15
[INFO] [stderr]     |
[INFO] [stderr] 105 |     fn to_vec(self) -> Vec<Self> {
[INFO] [stderr]     |               ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/from_meta.rs:289:32
[INFO] [stderr]     |
[INFO] [stderr] 289 | impl<V: FromMeta> FromMeta for HashMap<String, V> {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 289 | impl<V: FromMeta, S: ::std::hash::BuildHasher + Default> FromMeta for HashMap<String, V, S> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^              ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: ...and use generic constructor
[INFO] [stderr]     |
[INFO] [stderr] 291 |         let mut map = HashMap::with_capacity_and_hasher(nested.len(), Default::default());
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/options/core.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 | /     fn as_codegen_default<'a>(&'a self) -> Option<codegen::DefaultExpression<'a>> {
[INFO] [stderr] 59 | |         self.default.as_ref().map(|expr| match *expr {
[INFO] [stderr] 60 | |             DefaultExpression::Explicit(ref path) => codegen::DefaultExpression::Explicit(path),
[INFO] [stderr] 61 | |             DefaultExpression::Inherit | DefaultExpression::Trait => {
[INFO] [stderr] ...  |
[INFO] [stderr] 64 | |         })
[INFO] [stderr] 65 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]   --> src/options/core.rs:97:43
[INFO] [stderr]    |
[INFO] [stderr] 97 |             n => Err(Error::unknown_field(n.as_ref())),
[INFO] [stderr]    |                                           ^^^^^^^^^^ help: try this: `n`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/options/input_field.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 | /     pub fn as_codegen_field<'a>(&'a self) -> codegen::Field<'a> {
[INFO] [stderr] 25 | |         codegen::Field {
[INFO] [stderr] 26 | |             ident: &self.ident,
[INFO] [stderr] 27 | |             name_in_attr: self.attr_name
[INFO] [stderr] ...  |
[INFO] [stderr] 38 | |         }
[INFO] [stderr] 39 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/options/input_field.rs:29:18
[INFO] [stderr]    |
[INFO] [stderr] 29 |                 .unwrap_or(self.ident.to_string()),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.ident.to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/options/input_field.rs:34:18
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 .unwrap_or(parse_quote!(::darling::FromMeta::from_meta)),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| parse_quote!(::darling::FromMeta::from_meta))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/options/input_field.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 | /     fn as_codegen_default<'a>(&'a self) -> Option<codegen::DefaultExpression<'a>> {
[INFO] [stderr] 44 | |         self.default.as_ref().map(|expr| match *expr {
[INFO] [stderr] 45 | |             DefaultExpression::Explicit(ref path) => codegen::DefaultExpression::Explicit(path),
[INFO] [stderr] 46 | |             DefaultExpression::Inherit => codegen::DefaultExpression::Inherit(&self.ident),
[INFO] [stderr] 47 | |             DefaultExpression::Trait => codegen::DefaultExpression::Trait,
[INFO] [stderr] 48 | |         })
[INFO] [stderr] 49 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/options/input_field.rs:65:37
[INFO] [stderr]    |
[INFO] [stderr] 65 |           let ident = f.ident.clone().unwrap_or(syn::Ident::new(
[INFO] [stderr]    |  _____________________________________^
[INFO] [stderr] 66 | |             "__unnamed",
[INFO] [stderr] 67 | |             ::proc_macro2::Span::call_site(),
[INFO] [stderr] 68 | |         ));
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 65 |         let ident = f.ident.clone().unwrap_or_else(|| syn::Ident::new(
[INFO] [stderr] 66 |             "__unnamed",
[INFO] [stderr] 67 |             ::proc_macro2::Span::call_site(),
[INFO] [stderr] 68 |         ));
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/options/input_variant.rs:23:18
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 .unwrap_or(self.ident.to_string()),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.ident.to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/options/shape.rs:60:26
[INFO] [stderr]    |
[INFO] [stderr] 60 |         let fn_body = if self.any == true {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.any`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/options/shape.rs:168:53
[INFO] [stderr]     |
[INFO] [stderr] 168 |             let ty = self.prefix.trim_right_matches("_");
[INFO] [stderr]     |                                                     ^^^ help: try using a char instead: `'_'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/usage/lifetimes.rs:103:13
[INFO] [stderr]     |
[INFO] [stderr] 103 |             || Default::default(),
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Default::default`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly
[INFO] [stderr]   --> src/util/ident_string.rs:12:17
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[derive(Clone, Hash, PartialOrd, Ord)]
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::derive_hash_xor_eq)] on by default
[INFO] [stderr] note: `PartialEq` implemented here
[INFO] [stderr]   --> src/util/ident_string.rs:89:1
[INFO] [stderr]    |
[INFO] [stderr] 89 | / impl PartialEq for IdentString {
[INFO] [stderr] 90 | |     fn eq(&self, rhs: &Self) -> bool {
[INFO] [stderr] 91 | |         self.ident == rhs.ident
[INFO] [stderr] 92 | |     }
[INFO] [stderr] 93 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/util/over_ride.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 | /     pub fn as_ref<'a>(&'a self) -> Override<&'a T> {
[INFO] [stderr] 53 | |         match *self {
[INFO] [stderr] 54 | |             Inherit => Inherit,
[INFO] [stderr] 55 | |             Explicit(ref val) => Explicit(val),
[INFO] [stderr] 56 | |         }
[INFO] [stderr] 57 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/util/over_ride.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 | /     pub fn as_mut<'a>(&'a mut self) -> Override<&'a T> {
[INFO] [stderr] 63 | |         match *self {
[INFO] [stderr] 64 | |             Inherit => Inherit,
[INFO] [stderr] 65 | |             Explicit(ref mut val) => Explicit(val),
[INFO] [stderr] 66 | |         }
[INFO] [stderr] 67 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `darling_core`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: the since field must contain a semver-compliant version
[INFO] [stderr]   --> src/ast/data.rs:19:14
[INFO] [stderr]    |
[INFO] [stderr] 19 | #[deprecated(since = "0.3", note = "this has been renamed to Data")]
[INFO] [stderr]    |              ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::deprecated_semver)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_semver
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/ast/data.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 | /     pub fn as_ref<'a>(&'a self) -> Data<&'a V, &'a F> {
[INFO] [stderr] 34 | |         match *self {
[INFO] [stderr] 35 | |             Data::Enum(ref variants) => Data::Enum(variants.into_iter().collect()),
[INFO] [stderr] 36 | |             Data::Struct(ref data) => Data::Struct(data.as_ref()),
[INFO] [stderr] 37 | |         }
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/ast/data.rs:35:61
[INFO] [stderr]    |
[INFO] [stderr] 35 |             Data::Enum(ref variants) => Data::Enum(variants.into_iter().collect()),
[INFO] [stderr]    |                                                             ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] error: the since field must contain a semver-compliant version
[INFO] [stderr]    --> src/ast/data.rs:165:14
[INFO] [stderr]     |
[INFO] [stderr] 165 | #[deprecated(since = "0.3", note = "this has been renamed to Fields")]
[INFO] [stderr]     |              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_semver
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/ast/data.rs:317:20
[INFO] [stderr]     |
[INFO] [stderr] 317 |     pub fn is_unit(&self) -> bool {
[INFO] [stderr]     |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/ast/data.rs:321:21
[INFO] [stderr]     |
[INFO] [stderr] 321 |     pub fn is_tuple(&self) -> bool {
[INFO] [stderr]     |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/ast/data.rs:325:22
[INFO] [stderr]     |
[INFO] [stderr] 325 |     pub fn is_struct(&self) -> bool {
[INFO] [stderr]     |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/ast/generics.rs:145:5
[INFO] [stderr]     |
[INFO] [stderr] 145 | /     pub fn type_params<'a>(&'a self) -> TypeParams<'a, P> {
[INFO] [stderr] 146 | |         TypeParams(self.params.iter())
[INFO] [stderr] 147 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `codegen::error::ErrorDeclaration`
[INFO] [stderr]   --> src/codegen/error.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn new() -> Self {
[INFO] [stderr] 11 | |         ErrorDeclaration { __hidden: () }
[INFO] [stderr] 12 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 5  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `codegen::error::ErrorCheck<'a>`
[INFO] [stderr]   --> src/codegen/error.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 | /     pub fn new() -> Self {
[INFO] [stderr] 31 | |         ErrorCheck {
[INFO] [stderr] 32 | |             location: None,
[INFO] [stderr] 33 | |             __hidden: (),
[INFO] [stderr] 34 | |         }
[INFO] [stderr] 35 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 24 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/codegen/outer_from_impl.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 | /         if let &mut GenericParam::Type(ref mut typ) = param {
[INFO] [stderr] 53 | |             if applies_to.contains(&typ.ident) {
[INFO] [stderr] 54 | |                 typ.bounds.push(added_bound.clone());
[INFO] [stderr] 55 | |             }
[INFO] [stderr] 56 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 52 |         if let GenericParam::Type(ref mut typ) = *param {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/codegen/trait_impl.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 | /     fn type_params_matching<'b, F, V>(&'b self, field_filter: F, variant_filter: V) -> IdentSet
[INFO] [stderr] 40 | |     where
[INFO] [stderr] 41 | |         F: Fn(&&Field) -> bool,
[INFO] [stderr] 42 | |         V: Fn(&&Variant) -> bool,
[INFO] [stderr] ...  |
[INFO] [stderr] 58 | |         }
[INFO] [stderr] 59 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `foo`
[INFO] [stderr]    --> src/codegen/trait_impl.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |         let foo = match self.data {
[INFO] [stderr]     |             ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `foo`
[INFO] [stderr]    --> src/codegen/trait_impl.rs:142:13
[INFO] [stderr]     |
[INFO] [stderr] 142 |         let foo = match self.data {
[INFO] [stderr]     |             ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/codegen/variant_data.rs:17:34
[INFO] [stderr]    |
[INFO] [stderr] 17 |                 let vdr = fields.into_iter().map(Field::as_declaration);
[INFO] [stderr]    |                                  ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/codegen/variant_data.rs:47:37
[INFO] [stderr]    |
[INFO] [stderr] 47 |                 let checks = fields.into_iter().map(Field::as_presence_check);
[INFO] [stderr]    |                                     ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: item `error::Error` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/error.rs:25:1
[INFO] [stderr]     |
[INFO] [stderr] 25  | / impl Error {
[INFO] [stderr] 26  | |     fn new(kind: ErrorKind) -> Self {
[INFO] [stderr] 27  | |         Error {
[INFO] [stderr] 28  | |             kind: kind,
[INFO] [stderr] ...   |
[INFO] [stderr] 147 | |     }
[INFO] [stderr] 148 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/error.rs:105:15
[INFO] [stderr]     |
[INFO] [stderr] 105 |     fn to_vec(self) -> Vec<Self> {
[INFO] [stderr]     |               ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers
[INFO] [stderr]    --> src/from_meta.rs:289:32
[INFO] [stderr]     |
[INFO] [stderr] 289 | impl<V: FromMeta> FromMeta for HashMap<String, V> {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 289 | impl<V: FromMeta, S: ::std::hash::BuildHasher + Default> FromMeta for HashMap<String, V, S> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^              ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: ...and use generic constructor
[INFO] [stderr]     |
[INFO] [stderr] 291 |         let mut map = HashMap::with_capacity_and_hasher(nested.len(), Default::default());
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/from_meta.rs:319:36
[INFO] [stderr]     |
[INFO] [stderr] 319 |         attribute.interpret_meta().ok_or("Unable to parse".into())
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Unable to parse".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/options/core.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 | /     fn as_codegen_default<'a>(&'a self) -> Option<codegen::DefaultExpression<'a>> {
[INFO] [stderr] 59 | |         self.default.as_ref().map(|expr| match *expr {
[INFO] [stderr] 60 | |             DefaultExpression::Explicit(ref path) => codegen::DefaultExpression::Explicit(path),
[INFO] [stderr] 61 | |             DefaultExpression::Inherit | DefaultExpression::Trait => {
[INFO] [stderr] ...  |
[INFO] [stderr] 64 | |         })
[INFO] [stderr] 65 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]   --> src/options/core.rs:97:43
[INFO] [stderr]    |
[INFO] [stderr] 97 |             n => Err(Error::unknown_field(n.as_ref())),
[INFO] [stderr]    |                                           ^^^^^^^^^^ help: try this: `n`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/options/input_field.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 | /     pub fn as_codegen_field<'a>(&'a self) -> codegen::Field<'a> {
[INFO] [stderr] 25 | |         codegen::Field {
[INFO] [stderr] 26 | |             ident: &self.ident,
[INFO] [stderr] 27 | |             name_in_attr: self.attr_name
[INFO] [stderr] ...  |
[INFO] [stderr] 38 | |         }
[INFO] [stderr] 39 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/options/input_field.rs:29:18
[INFO] [stderr]    |
[INFO] [stderr] 29 |                 .unwrap_or(self.ident.to_string()),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.ident.to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/options/input_field.rs:34:18
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 .unwrap_or(parse_quote!(::darling::FromMeta::from_meta)),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| parse_quote!(::darling::FromMeta::from_meta))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/options/input_field.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 | /     fn as_codegen_default<'a>(&'a self) -> Option<codegen::DefaultExpression<'a>> {
[INFO] [stderr] 44 | |         self.default.as_ref().map(|expr| match *expr {
[INFO] [stderr] 45 | |             DefaultExpression::Explicit(ref path) => codegen::DefaultExpression::Explicit(path),
[INFO] [stderr] 46 | |             DefaultExpression::Inherit => codegen::DefaultExpression::Inherit(&self.ident),
[INFO] [stderr] 47 | |             DefaultExpression::Trait => codegen::DefaultExpression::Trait,
[INFO] [stderr] 48 | |         })
[INFO] [stderr] 49 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/options/input_field.rs:65:37
[INFO] [stderr]    |
[INFO] [stderr] 65 |           let ident = f.ident.clone().unwrap_or(syn::Ident::new(
[INFO] [stderr]    |  _____________________________________^
[INFO] [stderr] 66 | |             "__unnamed",
[INFO] [stderr] 67 | |             ::proc_macro2::Span::call_site(),
[INFO] [stderr] 68 | |         ));
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 65 |         let ident = f.ident.clone().unwrap_or_else(|| syn::Ident::new(
[INFO] [stderr] 66 |             "__unnamed",
[INFO] [stderr] 67 |             ::proc_macro2::Span::call_site(),
[INFO] [stderr] 68 |         ));
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/options/input_variant.rs:23:18
[INFO] [stderr]    |
[INFO] [stderr] 23 |                 .unwrap_or(self.ident.to_string()),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.ident.to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/options/shape.rs:60:26
[INFO] [stderr]    |
[INFO] [stderr] 60 |         let fn_body = if self.any == true {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.any`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/options/shape.rs:168:53
[INFO] [stderr]     |
[INFO] [stderr] 168 |             let ty = self.prefix.trim_right_matches("_");
[INFO] [stderr]     |                                                     ^^^ help: try using a char instead: `'_'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/options/shape.rs:218:36
[INFO] [stderr]     |
[INFO] [stderr] 218 |         attribute.interpret_meta().ok_or("Unable to parse".into())
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Unable to parse".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/usage/lifetimes.rs:103:13
[INFO] [stderr]     |
[INFO] [stderr] 103 |             || Default::default(),
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Default::default`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly
[INFO] [stderr]   --> src/util/ident_string.rs:12:17
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[derive(Clone, Hash, PartialOrd, Ord)]
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::derive_hash_xor_eq)] on by default
[INFO] [stderr] note: `PartialEq` implemented here
[INFO] [stderr]   --> src/util/ident_string.rs:89:1
[INFO] [stderr]    |
[INFO] [stderr] 89 | / impl PartialEq for IdentString {
[INFO] [stderr] 90 | |     fn eq(&self, rhs: &Self) -> bool {
[INFO] [stderr] 91 | |         self.ident == rhs.ident
[INFO] [stderr] 92 | |     }
[INFO] [stderr] 93 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/util/over_ride.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 | /     pub fn as_ref<'a>(&'a self) -> Override<&'a T> {
[INFO] [stderr] 53 | |         match *self {
[INFO] [stderr] 54 | |             Inherit => Inherit,
[INFO] [stderr] 55 | |             Explicit(ref val) => Explicit(val),
[INFO] [stderr] 56 | |         }
[INFO] [stderr] 57 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/util/over_ride.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 | /     pub fn as_mut<'a>(&'a mut self) -> Override<&'a T> {
[INFO] [stderr] 63 | |         match *self {
[INFO] [stderr] 64 | |             Inherit => Inherit,
[INFO] [stderr] 65 | |             Explicit(ref mut val) => Explicit(val),
[INFO] [stderr] 66 | |         }
[INFO] [stderr] 67 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `darling_core`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "c15c96015cea4c70331816c11ab7570dea0bb8188bf731b6ff6396c87cbab54b"`
[INFO] running `"docker" "rm" "-f" "c15c96015cea4c70331816c11ab7570dea0bb8188bf731b6ff6396c87cbab54b"`
[INFO] [stdout] c15c96015cea4c70331816c11ab7570dea0bb8188bf731b6ff6396c87cbab54b