[INFO] crate darksky 0.8.1 is already in cache [INFO] extracting crate darksky 0.8.1 into work/ex/clippy-test-run/sources/stable/reg/darksky/0.8.1 [INFO] extracting crate darksky 0.8.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/darksky/0.8.1 [INFO] validating manifest of darksky-0.8.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of darksky-0.8.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing darksky-0.8.1 [INFO] finished frobbing darksky-0.8.1 [INFO] frobbed toml for darksky-0.8.1 written to work/ex/clippy-test-run/sources/stable/reg/darksky/0.8.1/Cargo.toml [INFO] started frobbing darksky-0.8.1 [INFO] finished frobbing darksky-0.8.1 [INFO] frobbed toml for darksky-0.8.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/darksky/0.8.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting darksky-0.8.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/darksky/0.8.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9573c7a0230ca8834407eed5a9c8a39bb357fda7720a419fab623529d6acdbcc [INFO] running `"docker" "start" "-a" "9573c7a0230ca8834407eed5a9c8a39bb357fda7720a419fab623529d6acdbcc"` [INFO] [stderr] Checking darksky v0.8.1 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:102:45 [INFO] [stderr] | [INFO] [stderr] 102 | #![cfg_attr(feature = "cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:102:45 [INFO] [stderr] | [INFO] [stderr] 102 | #![cfg_attr(feature = "cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:102:45 [INFO] [stderr] | [INFO] [stderr] 102 | #![cfg_attr(feature = "cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:102:45 [INFO] [stderr] | [INFO] [stderr] 102 | #![cfg_attr(feature = "cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:4:21 [INFO] [stderr] | [INFO] [stderr] 4 | pub const API_URL: &'static str = "https://api.darksky.net"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:4:21 [INFO] [stderr] | [INFO] [stderr] 4 | pub const API_URL: &'static str = "https://api.darksky.net"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/utils.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | options: HashMap<&'static str, String>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 62 | pub fn uri_optioned( [INFO] [stderr] 63 | token: &str, [INFO] [stderr] 64 | lat: f64, [INFO] [stderr] 65 | long: f64, [INFO] [stderr] 66 | time: Option, [INFO] [stderr] 67 | options: HashMap<&'static str, String, S>, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/utils.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | options: HashMap<&'static str, String>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 62 | pub fn uri_optioned( [INFO] [stderr] 63 | token: &str, [INFO] [stderr] 64 | lat: f64, [INFO] [stderr] 65 | long: f64, [INFO] [stderr] 66 | time: Option, [INFO] [stderr] 67 | options: HashMap<&'static str, String, S>, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> tests/test_hyper.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `thread` [INFO] [stderr] --> tests/test_hyper.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | use std::{env, thread}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> tests/test_hyper.rs:101:4 [INFO] [stderr] | [INFO] [stderr] 101 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> tests/test_hyper.rs:105:4 [INFO] [stderr] | [INFO] [stderr] 105 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `forecast` [INFO] [stderr] --> tests/test_hyper.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | .map(|forecast| { [INFO] [stderr] | ^^^^^^^^ help: consider using `_forecast` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.99s [INFO] running `"docker" "inspect" "9573c7a0230ca8834407eed5a9c8a39bb357fda7720a419fab623529d6acdbcc"` [INFO] running `"docker" "rm" "-f" "9573c7a0230ca8834407eed5a9c8a39bb357fda7720a419fab623529d6acdbcc"` [INFO] [stdout] 9573c7a0230ca8834407eed5a9c8a39bb357fda7720a419fab623529d6acdbcc