[INFO] crate daemon-engine 0.3.1 is already in cache [INFO] extracting crate daemon-engine 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/daemon-engine/0.3.1 [INFO] extracting crate daemon-engine 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/daemon-engine/0.3.1 [INFO] validating manifest of daemon-engine-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of daemon-engine-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing daemon-engine-0.3.1 [INFO] finished frobbing daemon-engine-0.3.1 [INFO] frobbed toml for daemon-engine-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/daemon-engine/0.3.1/Cargo.toml [INFO] started frobbing daemon-engine-0.3.1 [INFO] finished frobbing daemon-engine-0.3.1 [INFO] frobbed toml for daemon-engine-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/daemon-engine/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting daemon-engine-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/daemon-engine/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a9cc0dc91eae5630095d3e2054bef7fcf32a4bd1d8f8bb0468cd6206175c436a [INFO] running `"docker" "start" "-a" "a9cc0dc91eae5630095d3e2054bef7fcf32a4bd1d8f8bb0468cd6206175c436a"` [INFO] [stderr] Checking users v0.7.0 [INFO] [stderr] Checking tokio-serde v0.2.0 [INFO] [stderr] Checking tokio-serde-json-mirror v0.1.0 [INFO] [stderr] Checking daemon-engine v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codecs/json.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return JsonError::Io(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `JsonError::Io(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codecs/json.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return JsonError::Json(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `JsonError::Json(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return Error::IoError(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::IoError(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codecs/json.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return JsonError::Io(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `JsonError::Io(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/codecs/json.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return JsonError::Json(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `JsonError::Json(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/error.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return Error::IoError(e); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::IoError(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/server.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | incoming_rx: Arc>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tcp.rs:178:37 [INFO] [stderr] | [INFO] [stderr] 178 | let info = TcpInfo{address: address.clone()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/server.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | incoming_rx: Arc>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/connection.rs:156:16 [INFO] [stderr] | [INFO] [stderr] 156 | if val.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!val.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tcp.rs:178:37 [INFO] [stderr] | [INFO] [stderr] 178 | let info = TcpInfo{address: address.clone()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.23s [INFO] running `"docker" "inspect" "a9cc0dc91eae5630095d3e2054bef7fcf32a4bd1d8f8bb0468cd6206175c436a"` [INFO] running `"docker" "rm" "-f" "a9cc0dc91eae5630095d3e2054bef7fcf32a4bd1d8f8bb0468cd6206175c436a"` [INFO] [stdout] a9cc0dc91eae5630095d3e2054bef7fcf32a4bd1d8f8bb0468cd6206175c436a