[INFO] crate daemon 0.0.8 is already in cache [INFO] extracting crate daemon 0.0.8 into work/ex/clippy-test-run/sources/stable/reg/daemon/0.0.8 [INFO] extracting crate daemon 0.0.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/daemon/0.0.8 [INFO] validating manifest of daemon-0.0.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of daemon-0.0.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing daemon-0.0.8 [INFO] finished frobbing daemon-0.0.8 [INFO] frobbed toml for daemon-0.0.8 written to work/ex/clippy-test-run/sources/stable/reg/daemon/0.0.8/Cargo.toml [INFO] started frobbing daemon-0.0.8 [INFO] finished frobbing daemon-0.0.8 [INFO] frobbed toml for daemon-0.0.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/daemon/0.0.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting daemon-0.0.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/daemon/0.0.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 085e205d24935da8f2c86855a4577dc4490770007417383a6df8961768c46b40 [INFO] running `"docker" "start" "-a" "085e205d24935da8f2c86855a4577dc4490770007417383a6df8961768c46b40"` [INFO] [stderr] Checking daemon v0.0.8 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/linux.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/linux.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | let result = match singleton.lock() { [INFO] [stderr] | __________________^ [INFO] [stderr] 68 | | Ok(ref mut daemon) => func(daemon), [INFO] [stderr] 69 | | Err(e) => { [INFO] [stderr] 70 | | panic!("Mutex error: {:?}", e); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/linux.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / return match daemon.holder.take_tx() { [INFO] [stderr] 129 | | Some(ref tx) => { [INFO] [stderr] 130 | | let _ = tx.send(State::Stop); [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | None => (), [INFO] [stderr] 133 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 128 | match daemon.holder.take_tx() { [INFO] [stderr] 129 | Some(ref tx) => { [INFO] [stderr] 130 | let _ = tx.send(State::Stop); [INFO] [stderr] 131 | } [INFO] [stderr] 132 | None => (), [INFO] [stderr] 133 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sig` [INFO] [stderr] --> src/linux.rs:125:42 [INFO] [stderr] | [INFO] [stderr] 125 | unsafe extern "system" fn signal_handler(sig: libc::c_int) { [INFO] [stderr] | ^^^ help: consider using `_sig` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/linux.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `signal_handler` [INFO] [stderr] --> src/linux.rs:125:1 [INFO] [stderr] | [INFO] [stderr] 125 | unsafe extern "system" fn signal_handler(sig: libc::c_int) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: foreign function is never used: `raise` [INFO] [stderr] --> src/linux.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | fn raise(sig: libc::c_int) -> libc::c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: foreign function is never used: `signal` [INFO] [stderr] --> src/linux.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | fn signal(sig: libc::c_int, handler: *const libc::c_void) -> libc::c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: foreign function is never used: `kill` [INFO] [stderr] --> src/linux.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | fn kill(pid: libc::pid_t, sig: libc::c_int) -> libc::c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/linux.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | holder: 0 as *mut DaemonStatic [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/linux.rs:128:16 [INFO] [stderr] | [INFO] [stderr] 128 | return match daemon.holder.take_tx() { [INFO] [stderr] | ________________^ [INFO] [stderr] 129 | | Some(ref tx) => { [INFO] [stderr] 130 | | let _ = tx.send(State::Stop); [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | None => (), [INFO] [stderr] 133 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | return if let Some(ref tx) = daemon.holder.take_tx() { [INFO] [stderr] 129 | let _ = tx.send(State::Stop); [INFO] [stderr] 130 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/linux.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | 0 as *mut DaemonStatic [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/linux.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/linux.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | let result = match singleton.lock() { [INFO] [stderr] | __________________^ [INFO] [stderr] 68 | | Ok(ref mut daemon) => func(daemon), [INFO] [stderr] 69 | | Err(e) => { [INFO] [stderr] 70 | | panic!("Mutex error: {:?}", e); [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/linux.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / return match daemon.holder.take_tx() { [INFO] [stderr] 129 | | Some(ref tx) => { [INFO] [stderr] 130 | | let _ = tx.send(State::Stop); [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | None => (), [INFO] [stderr] 133 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 128 | match daemon.holder.take_tx() { [INFO] [stderr] 129 | Some(ref tx) => { [INFO] [stderr] 130 | let _ = tx.send(State::Stop); [INFO] [stderr] 131 | } [INFO] [stderr] 132 | None => (), [INFO] [stderr] 133 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sig` [INFO] [stderr] --> src/linux.rs:125:42 [INFO] [stderr] | [INFO] [stderr] 125 | unsafe extern "system" fn signal_handler(sig: libc::c_int) { [INFO] [stderr] | ^^^ help: consider using `_sig` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/linux.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `signal_handler` [INFO] [stderr] --> src/linux.rs:125:1 [INFO] [stderr] | [INFO] [stderr] 125 | unsafe extern "system" fn signal_handler(sig: libc::c_int) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: foreign function is never used: `raise` [INFO] [stderr] --> src/linux.rs:142:5 [INFO] [stderr] | [INFO] [stderr] 142 | fn raise(sig: libc::c_int) -> libc::c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: foreign function is never used: `signal` [INFO] [stderr] --> src/linux.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | fn signal(sig: libc::c_int, handler: *const libc::c_void) -> libc::c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: foreign function is never used: `kill` [INFO] [stderr] --> src/linux.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | fn kill(pid: libc::pid_t, sig: libc::c_int) -> libc::c_int; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/singleton.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / match simple.lock() { [INFO] [stderr] 64 | | Ok(_) => {} [INFO] [stderr] 65 | | Err(_) => {} [INFO] [stderr] 66 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = simple.lock() {}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/linux.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | holder: 0 as *mut DaemonStatic [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/linux.rs:128:16 [INFO] [stderr] | [INFO] [stderr] 128 | return match daemon.holder.take_tx() { [INFO] [stderr] | ________________^ [INFO] [stderr] 129 | | Some(ref tx) => { [INFO] [stderr] 130 | | let _ = tx.send(State::Stop); [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | None => (), [INFO] [stderr] 133 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | return if let Some(ref tx) = daemon.holder.take_tx() { [INFO] [stderr] 129 | let _ = tx.send(State::Stop); [INFO] [stderr] 130 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/linux.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | 0 as *mut DaemonStatic [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bin/example.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | file.write(message.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bin/example.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | file.write(b"\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `daemon`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bin/example.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | file.write(message.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bin/example.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | file.write(b"\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `daemon`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "085e205d24935da8f2c86855a4577dc4490770007417383a6df8961768c46b40"` [INFO] running `"docker" "rm" "-f" "085e205d24935da8f2c86855a4577dc4490770007417383a6df8961768c46b40"` [INFO] [stdout] 085e205d24935da8f2c86855a4577dc4490770007417383a6df8961768c46b40