[INFO] crate cxema 0.1.1 is already in cache [INFO] extracting crate cxema 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/cxema/0.1.1 [INFO] extracting crate cxema 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cxema/0.1.1 [INFO] validating manifest of cxema-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cxema-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cxema-0.1.1 [INFO] finished frobbing cxema-0.1.1 [INFO] frobbed toml for cxema-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/cxema/0.1.1/Cargo.toml [INFO] started frobbing cxema-0.1.1 [INFO] finished frobbing cxema-0.1.1 [INFO] frobbed toml for cxema-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cxema/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cxema-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cxema/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 22eccf6ed7f1c2e598adcaf53ae84d7cd4b776301adf9a916f16360f77c0d0f1 [INFO] running `"docker" "start" "-a" "22eccf6ed7f1c2e598adcaf53ae84d7cd4b776301adf9a916f16360f77c0d0f1"` [INFO] [stderr] Checking cxema v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sha1.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | let mut d: u32 = self.intermediate_hash[3]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sha1.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | let mut e: u32 = self.intermediate_hash[4]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sha1.rs:97:18 [INFO] [stderr] | [INFO] [stderr] 97 | let (k, f) = match i { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/sha1.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | let (k, f) = match i { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sha1.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | let mut d: u32 = self.intermediate_hash[3]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sha1.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | let mut e: u32 = self.intermediate_hash[4]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sha1.rs:97:18 [INFO] [stderr] | [INFO] [stderr] 97 | let (k, f) = match i { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/sha1.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | let (k, f) = match i { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | 0x67452301u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6745_2301u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | 0xefcdab89u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xefcd_ab89u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | 0x98badcfeu32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x98ba_dcfeu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | 0x10325476u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x1032_5476u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | 0xc3d2e1f0u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xc3d2_e1f0u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:98:28 [INFO] [stderr] | [INFO] [stderr] 98 | 0...19 => (0x5A827999, ch!(b, c, d)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5A82_7999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:99:29 [INFO] [stderr] | [INFO] [stderr] 99 | 20...39 => (0x6ED9EBA1, parity!(b, c, d)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6ED9_EBA1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:100:29 [INFO] [stderr] | [INFO] [stderr] 100 | 40...59 => (0x8F1BBCDC, maj!(b, c, d)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8F1B_BCDC` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:101:29 [INFO] [stderr] | [INFO] [stderr] 101 | 60...79 => (0xCA62C1D6, parity!(b, c, d)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCA62_C1D6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/sha1.rs:136:23 [INFO] [stderr] | [INFO] [stderr] 136 | out[i] = (self.intermediate_hash[i >> 2] >> 8 * (3 - (i & 0x03))) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `self.intermediate_hash[i >> 2] >> (8 * (3 - (i & 0x03)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | 0x67452301u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x6745_2301u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | 0xefcdab89u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xefcd_ab89u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | 0x98badcfeu32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x98ba_dcfeu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | 0x10325476u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x1032_5476u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | 0xc3d2e1f0u32 [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xc3d2_e1f0u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:98:28 [INFO] [stderr] | [INFO] [stderr] 98 | 0...19 => (0x5A827999, ch!(b, c, d)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5A82_7999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:99:29 [INFO] [stderr] | [INFO] [stderr] 99 | 20...39 => (0x6ED9EBA1, parity!(b, c, d)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6ED9_EBA1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:100:29 [INFO] [stderr] | [INFO] [stderr] 100 | 40...59 => (0x8F1BBCDC, maj!(b, c, d)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8F1B_BCDC` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sha1.rs:101:29 [INFO] [stderr] | [INFO] [stderr] 101 | 60...79 => (0xCA62C1D6, parity!(b, c, d)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCA62_C1D6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/sha1.rs:136:23 [INFO] [stderr] | [INFO] [stderr] 136 | out[i] = (self.intermediate_hash[i >> 2] >> 8 * (3 - (i & 0x03))) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `self.intermediate_hash[i >> 2] >> (8 * (3 - (i & 0x03)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sha1::Sha1` [INFO] [stderr] --> src/sha1.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn new() -> Sha1 { [INFO] [stderr] 51 | | let mut new_sha1 = Sha1 { [INFO] [stderr] 52 | | intermediate_hash: [0u32; SHA1_HASH_SIZE / 4], [INFO] [stderr] 53 | | length_low: 0, [INFO] [stderr] ... | [INFO] [stderr] 63 | | new_sha1 [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | impl Default for sha1::Sha1 { [INFO] [stderr] 50 | fn default() -> Self { [INFO] [stderr] 51 | Self::new() [INFO] [stderr] 52 | } [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `w` [INFO] [stderr] --> src/sha1.rs:79:18 [INFO] [stderr] | [INFO] [stderr] 79 | for i in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 79 | for (i, ) in w.iter_mut().enumerate().take(16) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sha1.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | w[i] = (self.message_block[i * 4] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.message_block[i * 4])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sha1.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | w[i] |= (self.message_block[i * 4 + 1] as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.message_block[i * 4 + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sha1.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | w[i] |= (self.message_block[i * 4 + 2] as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.message_block[i * 4 + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sha1.rs:83:21 [INFO] [stderr] | [INFO] [stderr] 83 | w[i] |= self.message_block[i * 4 + 3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.message_block[i * 4 + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `w` [INFO] [stderr] --> src/sha1.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | for i in 0..80 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 96 | for (i, ) in w.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `out` [INFO] [stderr] --> src/sha1.rs:135:18 [INFO] [stderr] | [INFO] [stderr] 135 | for i in 0..SHA1_HASH_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 135 | for (i, ) in out.iter_mut().enumerate().take(SHA1_HASH_SIZE) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/sha1.rs:199:18 [INFO] [stderr] | [INFO] [stderr] 199 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 199 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sha1::Sha1` [INFO] [stderr] --> src/sha1.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn new() -> Sha1 { [INFO] [stderr] 51 | | let mut new_sha1 = Sha1 { [INFO] [stderr] 52 | | intermediate_hash: [0u32; SHA1_HASH_SIZE / 4], [INFO] [stderr] 53 | | length_low: 0, [INFO] [stderr] ... | [INFO] [stderr] 63 | | new_sha1 [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | impl Default for sha1::Sha1 { [INFO] [stderr] 50 | fn default() -> Self { [INFO] [stderr] 51 | Self::new() [INFO] [stderr] 52 | } [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `w` [INFO] [stderr] --> src/sha1.rs:79:18 [INFO] [stderr] | [INFO] [stderr] 79 | for i in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 79 | for (i, ) in w.iter_mut().enumerate().take(16) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sha1.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | w[i] = (self.message_block[i * 4] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.message_block[i * 4])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sha1.rs:81:21 [INFO] [stderr] | [INFO] [stderr] 81 | w[i] |= (self.message_block[i * 4 + 1] as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.message_block[i * 4 + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sha1.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | w[i] |= (self.message_block[i * 4 + 2] as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.message_block[i * 4 + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sha1.rs:83:21 [INFO] [stderr] | [INFO] [stderr] 83 | w[i] |= self.message_block[i * 4 + 3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.message_block[i * 4 + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `w` [INFO] [stderr] --> src/sha1.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | for i in 0..80 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 96 | for (i, ) in w.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `out` [INFO] [stderr] --> src/sha1.rs:135:18 [INFO] [stderr] | [INFO] [stderr] 135 | for i in 0..SHA1_HASH_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 135 | for (i, ) in out.iter_mut().enumerate().take(SHA1_HASH_SIZE) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/sha1.rs:199:18 [INFO] [stderr] | [INFO] [stderr] 199 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 199 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sha1.rs:310:17 [INFO] [stderr] | [INFO] [stderr] 310 | left = left - take; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `left -= take` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.90s [INFO] running `"docker" "inspect" "22eccf6ed7f1c2e598adcaf53ae84d7cd4b776301adf9a916f16360f77c0d0f1"` [INFO] running `"docker" "rm" "-f" "22eccf6ed7f1c2e598adcaf53ae84d7cd4b776301adf9a916f16360f77c0d0f1"` [INFO] [stdout] 22eccf6ed7f1c2e598adcaf53ae84d7cd4b776301adf9a916f16360f77c0d0f1