[INFO] crate currency_layer 0.1.1 is already in cache [INFO] extracting crate currency_layer 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/currency_layer/0.1.1 [INFO] extracting crate currency_layer 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/currency_layer/0.1.1 [INFO] validating manifest of currency_layer-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of currency_layer-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing currency_layer-0.1.1 [INFO] finished frobbing currency_layer-0.1.1 [INFO] frobbed toml for currency_layer-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/currency_layer/0.1.1/Cargo.toml [INFO] started frobbing currency_layer-0.1.1 [INFO] finished frobbing currency_layer-0.1.1 [INFO] frobbed toml for currency_layer-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/currency_layer/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting currency_layer-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/currency_layer/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97b632a365a8dcefb1eb1cf1972ce565acb513a80808732277d25255d8d18d04 [INFO] running `"docker" "start" "-a" "97b632a365a8dcefb1eb1cf1972ce565acb513a80808732277d25255d8d18d04"` [INFO] [stderr] Checking currency_layer v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return self.get_rates(base, currencies, None, "http://apilayer.net/api/live"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_rates(base, currencies, None, "http://apilayer.net/api/live")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / return self.get_rates( [INFO] [stderr] 89 | | base, [INFO] [stderr] 90 | | currencies, [INFO] [stderr] 91 | | Some(date), [INFO] [stderr] 92 | | "http://apilayer.net/api/historical", [INFO] [stderr] 93 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 88 | self.get_rates( [INFO] [stderr] 89 | base, [INFO] [stderr] 90 | currencies, [INFO] [stderr] 91 | Some(date), [INFO] [stderr] 92 | "http://apilayer.net/api/historical", [INFO] [stderr] 93 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | / return Err(CurrencyLayerError::ServerError { [INFO] [stderr] 158 | | code: result.error.code, [INFO] [stderr] 159 | | message: result.error.info, [INFO] [stderr] 160 | | }.into()); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 157 | Err(CurrencyLayerError::ServerError { [INFO] [stderr] 158 | code: result.error.code, [INFO] [stderr] 159 | message: result.error.info, [INFO] [stderr] 160 | }.into()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return self.get_rates(base, currencies, None, "http://apilayer.net/api/live"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_rates(base, currencies, None, "http://apilayer.net/api/live")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / return self.get_rates( [INFO] [stderr] 89 | | base, [INFO] [stderr] 90 | | currencies, [INFO] [stderr] 91 | | Some(date), [INFO] [stderr] 92 | | "http://apilayer.net/api/historical", [INFO] [stderr] 93 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 88 | self.get_rates( [INFO] [stderr] 89 | base, [INFO] [stderr] 90 | currencies, [INFO] [stderr] 91 | Some(date), [INFO] [stderr] 92 | "http://apilayer.net/api/historical", [INFO] [stderr] 93 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | / return Err(CurrencyLayerError::ServerError { [INFO] [stderr] 158 | | code: result.error.code, [INFO] [stderr] 159 | | message: result.error.info, [INFO] [stderr] 160 | | }.into()); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 157 | Err(CurrencyLayerError::ServerError { [INFO] [stderr] 158 | code: result.error.code, [INFO] [stderr] 159 | message: result.error.info, [INFO] [stderr] 160 | }.into()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.35s [INFO] running `"docker" "inspect" "97b632a365a8dcefb1eb1cf1972ce565acb513a80808732277d25255d8d18d04"` [INFO] running `"docker" "rm" "-f" "97b632a365a8dcefb1eb1cf1972ce565acb513a80808732277d25255d8d18d04"` [INFO] [stdout] 97b632a365a8dcefb1eb1cf1972ce565acb513a80808732277d25255d8d18d04