[INFO] crate currency 0.4.0 is already in cache [INFO] extracting crate currency 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/currency/0.4.0 [INFO] extracting crate currency 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/currency/0.4.0 [INFO] validating manifest of currency-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of currency-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing currency-0.4.0 [INFO] finished frobbing currency-0.4.0 [INFO] frobbed toml for currency-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/currency/0.4.0/Cargo.toml [INFO] started frobbing currency-0.4.0 [INFO] finished frobbing currency-0.4.0 [INFO] frobbed toml for currency-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/currency/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting currency-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/currency/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe51359281a93b68e3035b04f33f1ece061f17985e51fc0ccfd59a17922fea79 [INFO] running `"docker" "start" "-a" "fe51359281a93b68e3035b04f33f1ece061f17985e51fc0ccfd59a17922fea79"` [INFO] [stderr] Checking currency v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | symbol: symbol, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `symbol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | coin: coin [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `coin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | symbol: symbol, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `symbol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | coin: coin [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `coin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:770:73 [INFO] [stderr] | [INFO] [stderr] 770 | let expected = Currency { symbol: Some('$'), coin: BigInt::from(121000) }; [INFO] [stderr] | ^^^^^^ help: consider: `121_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:784:73 [INFO] [stderr] | [INFO] [stderr] 784 | let expected = Currency { symbol: Some('$'), coin: BigInt::from(1200099) }; [INFO] [stderr] | ^^^^^^^ help: consider: `1_200_099` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:788:73 [INFO] [stderr] | [INFO] [stderr] 788 | let expected = Currency { symbol: Some('£'), coin: BigInt::from(1200099) }; [INFO] [stderr] | ^^^^^^^ help: consider: `1_200_099` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:988:62 [INFO] [stderr] | [INFO] [stderr] 988 | Currency { symbol: Some('£'), coin: BigInt::from(100010) }.to_string(), [INFO] [stderr] | ^^^^^^ help: consider: `100_010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1012:78 [INFO] [stderr] | [INFO] [stderr] 1012 | format!("{:e}", Currency { symbol: Some('£'), coin: BigInt::from(100000) }), [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1017:78 [INFO] [stderr] | [INFO] [stderr] 1017 | format!("{:e}", Currency { symbol: Some('£'), coin: BigInt::from(123400101) }), [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_400_101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::FromStr` [INFO] [stderr] --> src/lib.rs:752:13 [INFO] [stderr] | [INFO] [stderr] 752 | use std::str::FromStr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 84 | | use std::str::FromStr; [INFO] [stderr] 85 | | use num::bigint::{BigUint, Sign}; [INFO] [stderr] 86 | | [INFO] [stderr] ... | [INFO] [stderr] 152 | | Ok(currency) [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:104:28 [INFO] [stderr] | [INFO] [stderr] 104 | if c == '-' && digits.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `digits.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:119:34 [INFO] [stderr] | [INFO] [stderr] 119 | let unsigned_bigint = if digits.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!digits.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:551:62 [INFO] [stderr] | [INFO] [stderr] 551 | coin: self.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:564:62 [INFO] [stderr] | [INFO] [stderr] 564 | coin: self.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:577:54 [INFO] [stderr] | [INFO] [stderr] 577 | coin: self.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:590:54 [INFO] [stderr] | [INFO] [stderr] 590 | coin: self.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:603:63 [INFO] [stderr] | [INFO] [stderr] 603 | coin: other.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:616:55 [INFO] [stderr] | [INFO] [stderr] 616 | coin: other.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:629:63 [INFO] [stderr] | [INFO] [stderr] 629 | coin: other.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:642:55 [INFO] [stderr] | [INFO] [stderr] 642 | coin: other.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:551:62 [INFO] [stderr] | [INFO] [stderr] 551 | coin: self.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:564:62 [INFO] [stderr] | [INFO] [stderr] 564 | coin: self.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:577:54 [INFO] [stderr] | [INFO] [stderr] 577 | coin: self.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:590:54 [INFO] [stderr] | [INFO] [stderr] 590 | coin: self.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:603:63 [INFO] [stderr] | [INFO] [stderr] 603 | coin: other.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:616:55 [INFO] [stderr] | [INFO] [stderr] 616 | coin: other.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:629:63 [INFO] [stderr] | [INFO] [stderr] 629 | coin: other.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:642:55 [INFO] [stderr] | [INFO] [stderr] 642 | coin: other.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:548:66 [INFO] [stderr] | [INFO] [stderr] 548 | let big_int = BigInt::$conv_method(other.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:561:58 [INFO] [stderr] | [INFO] [stderr] 561 | let big_int = BigInt::$conv_method(other * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:574:66 [INFO] [stderr] | [INFO] [stderr] 574 | let big_int = BigInt::$conv_method(other.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:587:58 [INFO] [stderr] | [INFO] [stderr] 587 | let big_int = BigInt::$conv_method(other * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:600:65 [INFO] [stderr] | [INFO] [stderr] 600 | let big_int = BigInt::$conv_method(self.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:613:65 [INFO] [stderr] | [INFO] [stderr] 613 | let big_int = BigInt::$conv_method(self.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:626:57 [INFO] [stderr] | [INFO] [stderr] 626 | let big_int = BigInt::$conv_method(self * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:639:57 [INFO] [stderr] | [INFO] [stderr] 639 | let big_int = BigInt::$conv_method(self * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:548:66 [INFO] [stderr] | [INFO] [stderr] 548 | let big_int = BigInt::$conv_method(other.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:561:58 [INFO] [stderr] | [INFO] [stderr] 561 | let big_int = BigInt::$conv_method(other * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:574:66 [INFO] [stderr] | [INFO] [stderr] 574 | let big_int = BigInt::$conv_method(other.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:587:58 [INFO] [stderr] | [INFO] [stderr] 587 | let big_int = BigInt::$conv_method(other * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:600:65 [INFO] [stderr] | [INFO] [stderr] 600 | let big_int = BigInt::$conv_method(self.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:613:65 [INFO] [stderr] | [INFO] [stderr] 613 | let big_int = BigInt::$conv_method(self.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:626:57 [INFO] [stderr] | [INFO] [stderr] 626 | let big_int = BigInt::$conv_method(self * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:639:57 [INFO] [stderr] | [INFO] [stderr] 639 | let big_int = BigInt::$conv_method(self * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:735:21 [INFO] [stderr] | [INFO] [stderr] 735 | symbol: self.symbol.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.symbol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 32 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `currency`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 84 | | use std::str::FromStr; [INFO] [stderr] 85 | | use num::bigint::{BigUint, Sign}; [INFO] [stderr] 86 | | [INFO] [stderr] ... | [INFO] [stderr] 152 | | Ok(currency) [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:104:28 [INFO] [stderr] | [INFO] [stderr] 104 | if c == '-' && digits.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `digits.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:119:34 [INFO] [stderr] | [INFO] [stderr] 119 | let unsigned_bigint = if digits.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!digits.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:551:62 [INFO] [stderr] | [INFO] [stderr] 551 | coin: self.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:564:62 [INFO] [stderr] | [INFO] [stderr] 564 | coin: self.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:577:54 [INFO] [stderr] | [INFO] [stderr] 577 | coin: self.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:590:54 [INFO] [stderr] | [INFO] [stderr] 590 | coin: self.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:603:63 [INFO] [stderr] | [INFO] [stderr] 603 | coin: other.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:616:55 [INFO] [stderr] | [INFO] [stderr] 616 | coin: other.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:629:63 [INFO] [stderr] | [INFO] [stderr] 629 | coin: other.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:642:55 [INFO] [stderr] | [INFO] [stderr] 642 | coin: other.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 649 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:551:62 [INFO] [stderr] | [INFO] [stderr] 551 | coin: self.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:564:62 [INFO] [stderr] | [INFO] [stderr] 564 | coin: self.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:577:54 [INFO] [stderr] | [INFO] [stderr] 577 | coin: self.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:590:54 [INFO] [stderr] | [INFO] [stderr] 590 | coin: self.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:603:63 [INFO] [stderr] | [INFO] [stderr] 603 | coin: other.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:616:55 [INFO] [stderr] | [INFO] [stderr] 616 | coin: other.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:629:63 [INFO] [stderr] | [INFO] [stderr] 629 | coin: other.coin.clone().$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:642:55 [INFO] [stderr] | [INFO] [stderr] 642 | coin: other.coin.$method(big_int) / BigInt::from(100) [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 650 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Mul, mul, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:548:66 [INFO] [stderr] | [INFO] [stderr] 548 | let big_int = BigInt::$conv_method(other.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:561:58 [INFO] [stderr] | [INFO] [stderr] 561 | let big_int = BigInt::$conv_method(other * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:574:66 [INFO] [stderr] | [INFO] [stderr] 574 | let big_int = BigInt::$conv_method(other.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:587:58 [INFO] [stderr] | [INFO] [stderr] 587 | let big_int = BigInt::$conv_method(other * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:600:65 [INFO] [stderr] | [INFO] [stderr] 600 | let big_int = BigInt::$conv_method(self.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:613:65 [INFO] [stderr] | [INFO] [stderr] 613 | let big_int = BigInt::$conv_method(self.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:626:57 [INFO] [stderr] | [INFO] [stderr] 626 | let big_int = BigInt::$conv_method(self * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:639:57 [INFO] [stderr] | [INFO] [stderr] 639 | let big_int = BigInt::$conv_method(self * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 652 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f32, from_f32); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:548:66 [INFO] [stderr] | [INFO] [stderr] 548 | let big_int = BigInt::$conv_method(other.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:561:58 [INFO] [stderr] | [INFO] [stderr] 561 | let big_int = BigInt::$conv_method(other * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:574:66 [INFO] [stderr] | [INFO] [stderr] 574 | let big_int = BigInt::$conv_method(other.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:587:58 [INFO] [stderr] | [INFO] [stderr] 587 | let big_int = BigInt::$conv_method(other * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:600:65 [INFO] [stderr] | [INFO] [stderr] 600 | let big_int = BigInt::$conv_method(self.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:613:65 [INFO] [stderr] | [INFO] [stderr] 613 | let big_int = BigInt::$conv_method(self.clone() * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:626:57 [INFO] [stderr] | [INFO] [stderr] 626 | let big_int = BigInt::$conv_method(self * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:639:57 [INFO] [stderr] | [INFO] [stderr] 639 | let big_int = BigInt::$conv_method(self * 100.0).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 653 | impl_all_trait_combinations_for_currency_conv_bigint!(ops::Div, div, f64, from_f64); [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:735:21 [INFO] [stderr] | [INFO] [stderr] 735 | symbol: self.symbol.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.symbol` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/lib.rs:751:5 [INFO] [stderr] | [INFO] [stderr] 751 | / fn test_from_str() { [INFO] [stderr] 752 | | use std::str::FromStr; [INFO] [stderr] 753 | | [INFO] [stderr] 754 | | let expected = Currency { symbol: Some('$'), coin: BigInt::from(1210) }; [INFO] [stderr] ... | [INFO] [stderr] 831 | | // assert_eq!(expected, actual); [INFO] [stderr] 832 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/lib.rs:841:17 [INFO] [stderr] | [INFO] [stderr] 841 | assert!(b == b); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `<=` [INFO] [stderr] --> src/lib.rs:862:17 [INFO] [stderr] | [INFO] [stderr] 862 | assert!(a <= a); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `>=` [INFO] [stderr] --> src/lib.rs:866:17 [INFO] [stderr] | [INFO] [stderr] 866 | assert!(a >= a); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/lib.rs:883:17 [INFO] [stderr] | [INFO] [stderr] 883 | assert!(&a + &b == &b + &a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of right operand [INFO] [stderr] --> src/lib.rs:913:20 [INFO] [stderr] | [INFO] [stderr] 913 | assert_eq!(&a * &f, &f * &a); [INFO] [stderr] | ^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:913:29 [INFO] [stderr] | [INFO] [stderr] 913 | assert_eq!(&a * &f, &f * &a); [INFO] [stderr] | --^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 36 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `currency`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fe51359281a93b68e3035b04f33f1ece061f17985e51fc0ccfd59a17922fea79"` [INFO] running `"docker" "rm" "-f" "fe51359281a93b68e3035b04f33f1ece061f17985e51fc0ccfd59a17922fea79"` [INFO] [stdout] fe51359281a93b68e3035b04f33f1ece061f17985e51fc0ccfd59a17922fea79