[INFO] crate cue_sheet 0.2.0 is already in cache [INFO] extracting crate cue_sheet 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/cue_sheet/0.2.0 [INFO] extracting crate cue_sheet 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cue_sheet/0.2.0 [INFO] validating manifest of cue_sheet-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cue_sheet-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cue_sheet-0.2.0 [INFO] finished frobbing cue_sheet-0.2.0 [INFO] frobbed toml for cue_sheet-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/cue_sheet/0.2.0/Cargo.toml [INFO] started frobbing cue_sheet-0.2.0 [INFO] finished frobbing cue_sheet-0.2.0 [INFO] frobbed toml for cue_sheet-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cue_sheet/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cue_sheet-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cue_sheet/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 11f42e1e41a860a1de8794063887d10c8dbc47d29a5c37aa31e7de3a61ac02e4 [INFO] running `"docker" "start" "-a" "11f42e1e41a860a1de8794063887d10c8dbc47d29a5c37aa31e7de3a61ac02e4"` [INFO] [stderr] Checking cue_sheet v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | mins: mins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mins` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | secs: secs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `secs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | frames: frames, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `frames` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | performer: performer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `performer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | tracks: tracks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tracks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:200:21 [INFO] [stderr] | [INFO] [stderr] 200 | track_type: track_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `track_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:202:21 [INFO] [stderr] | [INFO] [stderr] 202 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:204:21 [INFO] [stderr] | [INFO] [stderr] 204 | performer: performer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `performer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | mins: mins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mins` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | secs: secs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `secs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | frames: frames, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `frames` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | performer: performer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `performer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | tracks: tracks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tracks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:200:21 [INFO] [stderr] | [INFO] [stderr] 200 | track_type: track_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `track_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:202:21 [INFO] [stderr] | [INFO] [stderr] 202 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tracklist.rs:204:21 [INFO] [stderr] | [INFO] [stderr] 204 | performer: performer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `performer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/parser/tokenization.rs:62:22 [INFO] [stderr] | [INFO] [stderr] 62 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/parser/tokenization.rs:92:50 [INFO] [stderr] | [INFO] [stderr] 92 | if s.chars().map(|c| DIGITS.contains(&c)).fold( [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 93 | | true, [INFO] [stderr] 94 | | |old, new| old && new, [INFO] [stderr] | |__________________________________^ help: try: `.all(|new| new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/command.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | if tokens.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/command.rs:109:23 [INFO] [stderr] | [INFO] [stderr] 109 | while tokens.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/command.rs:130:20 [INFO] [stderr] | [INFO] [stderr] 130 | if flags.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `flags.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser/mod.rs:67:10 [INFO] [stderr] | [INFO] [stderr] 67 | ((self.mins * 60) as i64 + self.secs as i64) * FPS + self.frames as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.mins * 60)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser/mod.rs:67:36 [INFO] [stderr] | [INFO] [stderr] 67 | ((self.mins * 60) as i64 + self.secs as i64) * FPS + self.frames as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(self.secs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser/mod.rs:67:62 [INFO] [stderr] | [INFO] [stderr] 67 | ((self.mins * 60) as i64 + self.secs as i64) * FPS + self.frames as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.frames)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/mod.rs:233:11 [INFO] [stderr] | [INFO] [stderr] 233 | while tokens.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tracklist.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | while commands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tracklist.rs:65:15 [INFO] [stderr] | [INFO] [stderr] 65 | while commands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tracklist.rs:104:19 [INFO] [stderr] | [INFO] [stderr] 104 | while commands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tracklist.rs:106:24 [INFO] [stderr] | [INFO] [stderr] 106 | if track.index.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!track.index.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tracklist.rs:177:19 [INFO] [stderr] | [INFO] [stderr] 177 | while commands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/parser/tokenization.rs:62:22 [INFO] [stderr] | [INFO] [stderr] 62 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/parser/tokenization.rs:92:50 [INFO] [stderr] | [INFO] [stderr] 92 | if s.chars().map(|c| DIGITS.contains(&c)).fold( [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 93 | | true, [INFO] [stderr] 94 | | |old, new| old && new, [INFO] [stderr] | |__________________________________^ help: try: `.all(|new| new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/command.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | if tokens.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/command.rs:109:23 [INFO] [stderr] | [INFO] [stderr] 109 | while tokens.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/command.rs:130:20 [INFO] [stderr] | [INFO] [stderr] 130 | if flags.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `flags.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser/mod.rs:67:10 [INFO] [stderr] | [INFO] [stderr] 67 | ((self.mins * 60) as i64 + self.secs as i64) * FPS + self.frames as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.mins * 60)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser/mod.rs:67:36 [INFO] [stderr] | [INFO] [stderr] 67 | ((self.mins * 60) as i64 + self.secs as i64) * FPS + self.frames as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(self.secs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser/mod.rs:67:62 [INFO] [stderr] | [INFO] [stderr] 67 | ((self.mins * 60) as i64 + self.secs as i64) * FPS + self.frames as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.frames)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/mod.rs:233:11 [INFO] [stderr] | [INFO] [stderr] 233 | while tokens.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tracklist.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | while commands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tracklist.rs:65:15 [INFO] [stderr] | [INFO] [stderr] 65 | while commands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tracklist.rs:104:19 [INFO] [stderr] | [INFO] [stderr] 104 | while commands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tracklist.rs:106:24 [INFO] [stderr] | [INFO] [stderr] 106 | if track.index.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!track.index.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tracklist.rs:177:19 [INFO] [stderr] | [INFO] [stderr] 177 | while commands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!commands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/tracklist.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | let ref f = files[0]; [INFO] [stderr] | ----^^^^^------------ help: try: `let f = &files[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/tracklist.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | let ref tracks = f.tracks; [INFO] [stderr] | ----^^^^^^^^^^------------ help: try: `let tracks = &f.tracks;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/to_mb.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | for ref t in file.tracks { [INFO] [stderr] | ^^^^^ ----------- help: try: `let t = &file.tracks;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> examples/to_mb.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | file.read_to_string(&mut content); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.47s [INFO] running `"docker" "inspect" "11f42e1e41a860a1de8794063887d10c8dbc47d29a5c37aa31e7de3a61ac02e4"` [INFO] running `"docker" "rm" "-f" "11f42e1e41a860a1de8794063887d10c8dbc47d29a5c37aa31e7de3a61ac02e4"` [INFO] [stdout] 11f42e1e41a860a1de8794063887d10c8dbc47d29a5c37aa31e7de3a61ac02e4