[INFO] crate cucumber 0.3.1 is already in cache [INFO] extracting crate cucumber 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/cucumber/0.3.1 [INFO] extracting crate cucumber 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cucumber/0.3.1 [INFO] validating manifest of cucumber-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cucumber-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cucumber-0.3.1 [INFO] removed 0 missing tests [INFO] finished frobbing cucumber-0.3.1 [INFO] frobbed toml for cucumber-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/cucumber/0.3.1/Cargo.toml [INFO] started frobbing cucumber-0.3.1 [INFO] removed 0 missing tests [INFO] finished frobbing cucumber-0.3.1 [INFO] frobbed toml for cucumber-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cucumber/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cucumber-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cucumber/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] acd332d85bf69ad585866511e995b88f1cc4ddc15c1ef231feac89d1f5c815bd [INFO] running `"docker" "start" "-a" "acd332d85bf69ad585866511e995b88f1cc4ddc15c1ef231feac89d1f5c815bd"` [INFO] [stderr] Compiling cucumber v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state.rs:113:27 [INFO] [stderr] | [INFO] [stderr] 113 | StepArg { pos: pos, val: captures.at(idx).map(|v| v.to_owned()) } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | Server { runner: runner } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `runner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/runner.rs:37:7 [INFO] [stderr] | [INFO] [stderr] 37 | world: world, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/launcher.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | world: world, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state.rs:113:27 [INFO] [stderr] | [INFO] [stderr] 113 | StepArg { pos: pos, val: captures.at(idx).map(|v| v.to_owned()) } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | Server { runner: runner } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `runner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/runner.rs:37:7 [INFO] [stderr] | [INFO] [stderr] 37 | world: world, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/launcher.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | world: world, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:153:36 [INFO] [stderr] | [INFO] [stderr] 153 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:153:46 [INFO] [stderr] | [INFO] [stderr] 153 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:326:36 [INFO] [stderr] | [INFO] [stderr] 326 | const FIELDS: &'static [&'static str] = &["id", "args"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:326:46 [INFO] [stderr] | [INFO] [stderr] 326 | const FIELDS: &'static [&'static str] = &["id", "args"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:465:36 [INFO] [stderr] | [INFO] [stderr] 465 | const FIELDS: &'static [&'static str] = &["tags"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:465:46 [INFO] [stderr] | [INFO] [stderr] 465 | const FIELDS: &'static [&'static str] = &["tags"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:605:36 [INFO] [stderr] | [INFO] [stderr] 605 | const FIELDS: &'static [&'static str] = &["tags"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:605:46 [INFO] [stderr] | [INFO] [stderr] 605 | const FIELDS: &'static [&'static str] = &["tags"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:828:36 [INFO] [stderr] | [INFO] [stderr] 828 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:828:46 [INFO] [stderr] | [INFO] [stderr] 828 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/event/request.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:153:36 [INFO] [stderr] | [INFO] [stderr] 153 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:153:46 [INFO] [stderr] | [INFO] [stderr] 153 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:326:36 [INFO] [stderr] | [INFO] [stderr] 326 | const FIELDS: &'static [&'static str] = &["id", "args"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:326:46 [INFO] [stderr] | [INFO] [stderr] 326 | const FIELDS: &'static [&'static str] = &["id", "args"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:465:36 [INFO] [stderr] | [INFO] [stderr] 465 | const FIELDS: &'static [&'static str] = &["tags"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:465:46 [INFO] [stderr] | [INFO] [stderr] 465 | const FIELDS: &'static [&'static str] = &["tags"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:605:36 [INFO] [stderr] | [INFO] [stderr] 605 | const FIELDS: &'static [&'static str] = &["tags"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:605:46 [INFO] [stderr] | [INFO] [stderr] 605 | const FIELDS: &'static [&'static str] = &["tags"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:828:36 [INFO] [stderr] | [INFO] [stderr] 828 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/request.rs:828:46 [INFO] [stderr] | [INFO] [stderr] 828 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/event/request.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/event/request.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `state::Cucumber` [INFO] [stderr] --> src/state.rs:70:3 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn new() -> Cucumber { [INFO] [stderr] 71 | | Cucumber { [INFO] [stderr] 72 | | step_regexes: Vec::new(), [INFO] [stderr] 73 | | step_ids: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/state.rs:90:36 [INFO] [stderr] | [INFO] [stderr] 90 | self.step_ids.insert(str_rep, (this_id.clone(), path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `this_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/state.rs:116:28 [INFO] [stderr] | [INFO] [stderr] 116 | let (id, path) = self.step_ids.get(regex.as_str()).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.step_ids[regex.as_str()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/state.rs:155:16 [INFO] [stderr] | [INFO] [stderr] 155 | .map(|arg| InvokeArgument::from_step_arg(arg)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `InvokeArgument::from_step_arg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | let _ = self.kill_sender.send(()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | / match request { [INFO] [stderr] 128 | | Ok(req_body) => { [INFO] [stderr] 129 | | let response = self.runner.execute_cmd(req_body); [INFO] [stderr] 130 | | let _ = [INFO] [stderr] ... | [INFO] [stderr] 134 | | _ => {}, [INFO] [stderr] 135 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 127 | if let Ok(req_body) = request { [INFO] [stderr] 128 | let response = self.runner.execute_cmd(req_body); [INFO] [stderr] 129 | let _ = [INFO] [stderr] 130 | stream.write(format!("{}\n", serde_json::to_string(&response).unwrap()) [INFO] [stderr] 131 | .as_bytes()); [INFO] [stderr] 132 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/runner.rs:72:12 [INFO] [stderr] | [INFO] [stderr] 72 | if matches.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/definitions/destructuring/invoke_arg.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | .map(|r| Some(r)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/event/request.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:59:8 [INFO] [stderr] | [INFO] [stderr] 59 | if args.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 69 | auto_define_for_tuple!(1; [A]); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 70 | auto_define_for_tuple!(2; [A, B]); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 70 | auto_define_for_tuple!(2; [A, B]); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 70 | auto_define_for_tuple!(2; [A, B]); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 70 | auto_define_for_tuple!(2; [A, B]); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 70 | auto_define_for_tuple!(2; [A, B]); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 71 | auto_define_for_tuple!(3; [A, B, C]); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 71 | auto_define_for_tuple!(3; [A, B, C]); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 71 | auto_define_for_tuple!(3; [A, B, C]); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 72 | auto_define_for_tuple!(4; [A, B, C, D]); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 72 | auto_define_for_tuple!(4; [A, B, C, D]); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 72 | auto_define_for_tuple!(4; [A, B, C, D]); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 73 | auto_define_for_tuple!(5; [A, B, C, D, E]); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 73 | auto_define_for_tuple!(5; [A, B, C, D, E]); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 73 | auto_define_for_tuple!(5; [A, B, C, D, E]); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 74 | auto_define_for_tuple!(6; [A, B, C, D, E, F]); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 74 | auto_define_for_tuple!(6; [A, B, C, D, E, F]); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 74 | auto_define_for_tuple!(6; [A, B, C, D, E, F]); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 75 | auto_define_for_tuple!(7; [A, B, C, D, E, F, G]); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 75 | auto_define_for_tuple!(7; [A, B, C, D, E, F, G]); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 75 | auto_define_for_tuple!(7; [A, B, C, D, E, F, G]); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 76 | auto_define_for_tuple!(8; [A, B, C, D, E, F, G, H]); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 76 | auto_define_for_tuple!(8; [A, B, C, D, E, F, G, H]); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 76 | auto_define_for_tuple!(8; [A, B, C, D, E, F, G, H]); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 77 | auto_define_for_tuple!(9; [A, B, C, D, E, F, G, H, I]); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 77 | auto_define_for_tuple!(9; [A, B, C, D, E, F, G, H, I]); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 77 | auto_define_for_tuple!(9; [A, B, C, D, E, F, G, H, I]); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 78 | auto_define_for_tuple!(10; [A, B, C, D, E, F, G, H, I, J]); [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 78 | auto_define_for_tuple!(10; [A, B, C, D, E, F, G, H, I, J]); [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 78 | auto_define_for_tuple!(10; [A, B, C, D, E, F, G, H, I, J]); [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 79 | auto_define_for_tuple!(11; [A, B, C, D, E, F, G, H, I, J, K]); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 79 | auto_define_for_tuple!(11; [A, B, C, D, E, F, G, H, I, J, K]); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 79 | auto_define_for_tuple!(11; [A, B, C, D, E, F, G, H, I, J, K]); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 80 | auto_define_for_tuple!(12; [A, B, C, D, E, F, G, H, I, J, K, L]); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 80 | auto_define_for_tuple!(12; [A, B, C, D, E, F, G, H, I, J, K, L]); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 80 | auto_define_for_tuple!(12; [A, B, C, D, E, F, G, H, I, J, K, L]); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/event/request.rs:121:3 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn from_str(arg: &str) -> InvokeArgument { [INFO] [stderr] 122 | | InvokeArgument::String(arg.to_owned()) [INFO] [stderr] 123 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/event/request.rs:153:47 [INFO] [stderr] | [INFO] [stderr] 153 | VecVisitor::new().visit_seq(_visitor).map(|res| InvokeArgument::Table(res)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `InvokeArgument::Table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | / loop { [INFO] [stderr] 39 | | match self.state { [INFO] [stderr] 40 | | 0usize => { [INFO] [stderr] 41 | | self.state += 1; [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:42:56 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Some(try!(_serializer.serialize_struct_elt("id", &self.value.id)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:46:56 [INFO] [stderr] | [INFO] [stderr] 46 | return Ok(Some(try!(_serializer.serialize_struct_elt("args", &self.value.args)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:50:56 [INFO] [stderr] | [INFO] [stderr] 50 | return Ok(Some(try!(_serializer.serialize_struct_elt("source", &self.value.source)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:57:63 [INFO] [stderr] | [INFO] [stderr] 57 | fn len(&self) -> Option { Some(0 + 1 + 1 + 1) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:97:29 [INFO] [stderr] | [INFO] [stderr] 97 | / loop { [INFO] [stderr] 98 | | match self.state { [INFO] [stderr] 99 | | 0usize => { [INFO] [stderr] 100 | | self.state += 1; [INFO] [stderr] ... | [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:101:56 [INFO] [stderr] | [INFO] [stderr] 101 | return Ok(Some(try!(_serializer.serialize_struct_elt("message", &self.value.message)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:105:56 [INFO] [stderr] | [INFO] [stderr] 105 | return Ok(Some(try!(_serializer.serialize_struct_elt("exception", &self.value.exception)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:112:63 [INFO] [stderr] | [INFO] [stderr] 112 | fn len(&self) -> Option { Some(0 + 1 + 1) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/event/response.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &Response::StepMatches(ref response) => { [INFO] [stderr] 37 | | let empty_vec = Vec::new(); [INFO] [stderr] 38 | | let body = match response { [INFO] [stderr] ... | [INFO] [stderr] 59 | | }, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | Response::StepMatches(ref response) => { [INFO] [stderr] 37 | let empty_vec = Vec::new(); [INFO] [stderr] 38 | let body = match response { [INFO] [stderr] 39 | &StepMatchesResponse::NoMatch => &empty_vec, [INFO] [stderr] 40 | &StepMatchesResponse::Match(ref steps) => steps, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/event/response.rs:38:20 [INFO] [stderr] | [INFO] [stderr] 38 | let body = match response { [INFO] [stderr] | ____________________^ [INFO] [stderr] 39 | | &StepMatchesResponse::NoMatch => &empty_vec, [INFO] [stderr] 40 | | &StepMatchesResponse::Match(ref steps) => steps, [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | let body = match *response { [INFO] [stderr] 39 | StepMatchesResponse::NoMatch => &empty_vec, [INFO] [stderr] 40 | StepMatchesResponse::Match(ref steps) => steps, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/event/response.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / match response { [INFO] [stderr] 46 | | &InvokeResponse::Pending(ref message) => { [INFO] [stderr] 47 | | s.serialize_seq(TupleVisitor2::new(&("pending", message))) [INFO] [stderr] 48 | | }, [INFO] [stderr] ... | [INFO] [stderr] 52 | | }, [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *response { [INFO] [stderr] 46 | InvokeResponse::Pending(ref message) => { [INFO] [stderr] 47 | s.serialize_seq(TupleVisitor2::new(&("pending", message))) [INFO] [stderr] 48 | }, [INFO] [stderr] 49 | InvokeResponse::Success => s.serialize_seq(Some(&("success"))), [INFO] [stderr] 50 | InvokeResponse::Fail(ref message) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/event/response.rs:93:34 [INFO] [stderr] | [INFO] [stderr] 93 | Some(ref v) => Ok(Some(try!(serializer.serialize_struct_elt("val", v.clone())))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/event/response.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | None => Ok(Some(try!(serializer.serialize_struct_elt("val", ())))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/event/response.rs:100:34 [INFO] [stderr] | [INFO] [stderr] 100 | Some(ref v) => Ok(Some(try!(serializer.serialize_struct_elt("pos", v.clone())))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/event/response.rs:101:27 [INFO] [stderr] | [INFO] [stderr] 101 | None => Ok(Some(try!(serializer.serialize_struct_elt("pos", ())))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cucumber`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `state::Cucumber` [INFO] [stderr] --> src/state.rs:70:3 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn new() -> Cucumber { [INFO] [stderr] 71 | | Cucumber { [INFO] [stderr] 72 | | step_regexes: Vec::new(), [INFO] [stderr] 73 | | step_ids: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/state.rs:90:36 [INFO] [stderr] | [INFO] [stderr] 90 | self.step_ids.insert(str_rep, (this_id.clone(), path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `this_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/state.rs:116:28 [INFO] [stderr] | [INFO] [stderr] 116 | let (id, path) = self.step_ids.get(regex.as_str()).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.step_ids[regex.as_str()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/state.rs:155:16 [INFO] [stderr] | [INFO] [stderr] 155 | .map(|arg| InvokeArgument::from_step_arg(arg)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `InvokeArgument::from_step_arg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | let _ = self.kill_sender.send(()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | / match request { [INFO] [stderr] 128 | | Ok(req_body) => { [INFO] [stderr] 129 | | let response = self.runner.execute_cmd(req_body); [INFO] [stderr] 130 | | let _ = [INFO] [stderr] ... | [INFO] [stderr] 134 | | _ => {}, [INFO] [stderr] 135 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 127 | if let Ok(req_body) = request { [INFO] [stderr] 128 | let response = self.runner.execute_cmd(req_body); [INFO] [stderr] 129 | let _ = [INFO] [stderr] 130 | stream.write(format!("{}\n", serde_json::to_string(&response).unwrap()) [INFO] [stderr] 131 | .as_bytes()); [INFO] [stderr] 132 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:187:7 [INFO] [stderr] | [INFO] [stderr] 187 | stream.write(b"[\"begin_scenario\"]\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:195:7 [INFO] [stderr] | [INFO] [stderr] 195 | stream.write(b"[\"end_scenario\"]\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:203:7 [INFO] [stderr] | [INFO] [stderr] 203 | stream.write(b"[\"invoke\", {\"id\": \"1\", \"args\": []}]\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:211:7 [INFO] [stderr] | [INFO] [stderr] 211 | stream.write(b"[\"step_matches\", {\"name_to_match\": \"test\"}]\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server.rs:219:7 [INFO] [stderr] | [INFO] [stderr] 219 | stream.write(b"[\"snippet_text\", {\"step_keyword\": \"Given\", \"multiline_arg_class\": \"\", \"step_name\": \"test\"}]\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/runner.rs:72:12 [INFO] [stderr] | [INFO] [stderr] 72 | if matches.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/definitions/destructuring/invoke_arg.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | .map(|r| Some(r)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:59:8 [INFO] [stderr] | [INFO] [stderr] 59 | if args.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 69 | auto_define_for_tuple!(1; [A]); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 70 | auto_define_for_tuple!(2; [A, B]); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 70 | auto_define_for_tuple!(2; [A, B]); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 70 | auto_define_for_tuple!(2; [A, B]); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 70 | auto_define_for_tuple!(2; [A, B]); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 70 | auto_define_for_tuple!(2; [A, B]); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 71 | auto_define_for_tuple!(3; [A, B, C]); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 71 | auto_define_for_tuple!(3; [A, B, C]); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 71 | auto_define_for_tuple!(3; [A, B, C]); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 72 | auto_define_for_tuple!(4; [A, B, C, D]); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 72 | auto_define_for_tuple!(4; [A, B, C, D]); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 72 | auto_define_for_tuple!(4; [A, B, C, D]); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 73 | auto_define_for_tuple!(5; [A, B, C, D, E]); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 73 | auto_define_for_tuple!(5; [A, B, C, D, E]); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 73 | auto_define_for_tuple!(5; [A, B, C, D, E]); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 74 | auto_define_for_tuple!(6; [A, B, C, D, E, F]); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 74 | auto_define_for_tuple!(6; [A, B, C, D, E, F]); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 74 | auto_define_for_tuple!(6; [A, B, C, D, E, F]); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 75 | auto_define_for_tuple!(7; [A, B, C, D, E, F, G]); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 75 | auto_define_for_tuple!(7; [A, B, C, D, E, F, G]); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 75 | auto_define_for_tuple!(7; [A, B, C, D, E, F, G]); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 76 | auto_define_for_tuple!(8; [A, B, C, D, E, F, G, H]); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 76 | auto_define_for_tuple!(8; [A, B, C, D, E, F, G, H]); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 76 | auto_define_for_tuple!(8; [A, B, C, D, E, F, G, H]); [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 77 | auto_define_for_tuple!(9; [A, B, C, D, E, F, G, H, I]); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 77 | auto_define_for_tuple!(9; [A, B, C, D, E, F, G, H, I]); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 77 | auto_define_for_tuple!(9; [A, B, C, D, E, F, G, H, I]); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 78 | auto_define_for_tuple!(10; [A, B, C, D, E, F, G, H, I, J]); [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 78 | auto_define_for_tuple!(10; [A, B, C, D, E, F, G, H, I, J]); [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 78 | auto_define_for_tuple!(10; [A, B, C, D, E, F, G, H, I, J]); [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 79 | auto_define_for_tuple!(11; [A, B, C, D, E, F, G, H, I, J, K]); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 79 | auto_define_for_tuple!(11; [A, B, C, D, E, F, G, H, I, J, K]); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 79 | auto_define_for_tuple!(11; [A, B, C, D, E, F, G, H, I, J, K]); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] ... [INFO] [stderr] 80 | auto_define_for_tuple!(12; [A, B, C, D, E, F, G, H, I, J, K, L]); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 80 | auto_define_for_tuple!(12; [A, B, C, D, E, F, G, H, I, J, K, L]); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/definitions/destructuring/invoke_arg_set.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 80 | auto_define_for_tuple!(12; [A, B, C, D, E, F, G, H, I, J, K, L]); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/event/request.rs:121:3 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn from_str(arg: &str) -> InvokeArgument { [INFO] [stderr] 122 | | InvokeArgument::String(arg.to_owned()) [INFO] [stderr] 123 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/event/request.rs:153:47 [INFO] [stderr] | [INFO] [stderr] 153 | VecVisitor::new().visit_seq(_visitor).map(|res| InvokeArgument::Table(res)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `InvokeArgument::Table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | / loop { [INFO] [stderr] 39 | | match self.state { [INFO] [stderr] 40 | | 0usize => { [INFO] [stderr] 41 | | self.state += 1; [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:42:56 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Some(try!(_serializer.serialize_struct_elt("id", &self.value.id)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:46:56 [INFO] [stderr] | [INFO] [stderr] 46 | return Ok(Some(try!(_serializer.serialize_struct_elt("args", &self.value.args)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:50:56 [INFO] [stderr] | [INFO] [stderr] 50 | return Ok(Some(try!(_serializer.serialize_struct_elt("source", &self.value.source)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:57:63 [INFO] [stderr] | [INFO] [stderr] 57 | fn len(&self) -> Option { Some(0 + 1 + 1 + 1) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:97:29 [INFO] [stderr] | [INFO] [stderr] 97 | / loop { [INFO] [stderr] 98 | | match self.state { [INFO] [stderr] 99 | | 0usize => { [INFO] [stderr] 100 | | self.state += 1; [INFO] [stderr] ... | [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:101:56 [INFO] [stderr] | [INFO] [stderr] 101 | return Ok(Some(try!(_serializer.serialize_struct_elt("message", &self.value.message)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:105:56 [INFO] [stderr] | [INFO] [stderr] 105 | return Ok(Some(try!(_serializer.serialize_struct_elt("exception", &self.value.exception)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/cucumber-593bf46d457814be/out/event/response.rs:112:63 [INFO] [stderr] | [INFO] [stderr] 112 | fn len(&self) -> Option { Some(0 + 1 + 1) } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/event/response.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &Response::StepMatches(ref response) => { [INFO] [stderr] 37 | | let empty_vec = Vec::new(); [INFO] [stderr] 38 | | let body = match response { [INFO] [stderr] ... | [INFO] [stderr] 59 | | }, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | Response::StepMatches(ref response) => { [INFO] [stderr] 37 | let empty_vec = Vec::new(); [INFO] [stderr] 38 | let body = match response { [INFO] [stderr] 39 | &StepMatchesResponse::NoMatch => &empty_vec, [INFO] [stderr] 40 | &StepMatchesResponse::Match(ref steps) => steps, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/event/response.rs:38:20 [INFO] [stderr] | [INFO] [stderr] 38 | let body = match response { [INFO] [stderr] | ____________________^ [INFO] [stderr] 39 | | &StepMatchesResponse::NoMatch => &empty_vec, [INFO] [stderr] 40 | | &StepMatchesResponse::Match(ref steps) => steps, [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | let body = match *response { [INFO] [stderr] 39 | StepMatchesResponse::NoMatch => &empty_vec, [INFO] [stderr] 40 | StepMatchesResponse::Match(ref steps) => steps, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/event/response.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / match response { [INFO] [stderr] 46 | | &InvokeResponse::Pending(ref message) => { [INFO] [stderr] 47 | | s.serialize_seq(TupleVisitor2::new(&("pending", message))) [INFO] [stderr] 48 | | }, [INFO] [stderr] ... | [INFO] [stderr] 52 | | }, [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *response { [INFO] [stderr] 46 | InvokeResponse::Pending(ref message) => { [INFO] [stderr] 47 | s.serialize_seq(TupleVisitor2::new(&("pending", message))) [INFO] [stderr] 48 | }, [INFO] [stderr] 49 | InvokeResponse::Success => s.serialize_seq(Some(&("success"))), [INFO] [stderr] 50 | InvokeResponse::Fail(ref message) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/event/response.rs:93:34 [INFO] [stderr] | [INFO] [stderr] 93 | Some(ref v) => Ok(Some(try!(serializer.serialize_struct_elt("val", v.clone())))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/event/response.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | None => Ok(Some(try!(serializer.serialize_struct_elt("val", ())))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/event/response.rs:100:34 [INFO] [stderr] | [INFO] [stderr] 100 | Some(ref v) => Ok(Some(try!(serializer.serialize_struct_elt("pos", v.clone())))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/event/response.rs:101:27 [INFO] [stderr] | [INFO] [stderr] 101 | None => Ok(Some(try!(serializer.serialize_struct_elt("pos", ())))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cucumber`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "acd332d85bf69ad585866511e995b88f1cc4ddc15c1ef231feac89d1f5c815bd"` [INFO] running `"docker" "rm" "-f" "acd332d85bf69ad585866511e995b88f1cc4ddc15c1ef231feac89d1f5c815bd"` [INFO] [stdout] acd332d85bf69ad585866511e995b88f1cc4ddc15c1ef231feac89d1f5c815bd