[INFO] crate csvc 0.1.0 is already in cache [INFO] extracting crate csvc 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/csvc/0.1.0 [INFO] extracting crate csvc 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/csvc/0.1.0 [INFO] validating manifest of csvc-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of csvc-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing csvc-0.1.0 [INFO] finished frobbing csvc-0.1.0 [INFO] frobbed toml for csvc-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/csvc/0.1.0/Cargo.toml [INFO] started frobbing csvc-0.1.0 [INFO] finished frobbing csvc-0.1.0 [INFO] frobbed toml for csvc-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/csvc/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting csvc-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/csvc/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 285636585a96639f0ad06fa448f8456a5c91e86be1f469843a4a6a879ab3a776 [INFO] running `"docker" "start" "-a" "285636585a96639f0ad06fa448f8456a5c91e86be1f469843a4a6a879ab3a776"` [INFO] [stderr] Checking csvc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if let Some(_) = line.find(',') { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 32 | | Some(String::from(",")) [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | else if let Some(_) = line.find('\t') { [INFO] [stderr] ... | [INFO] [stderr] 38 | | None [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____- help: try this: `if line.find(',').is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | else if let Some(_) = line.find('\t') { [INFO] [stderr] | __________- ^^^^^^^ [INFO] [stderr] 35 | | Some(String::from("\t")) [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | else { [INFO] [stderr] 38 | | None [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____- help: try this: `if line.find('\t').is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:85:8 [INFO] [stderr] | [INFO] [stderr] 85 | if headers_vec.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `headers_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:106:54 [INFO] [stderr] | [INFO] [stderr] 106 | for column_name in output_column_names.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:133:33 [INFO] [stderr] | [INFO] [stderr] 133 | let header_row = if output_columns.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `output_columns.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:145:30 [INFO] [stderr] | [INFO] [stderr] 145 | let content_row = if output_columns.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output_columns.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if let Some(_) = line.find(',') { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 32 | | Some(String::from(",")) [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | else if let Some(_) = line.find('\t') { [INFO] [stderr] ... | [INFO] [stderr] 38 | | None [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____- help: try this: `if line.find(',').is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | else if let Some(_) = line.find('\t') { [INFO] [stderr] | __________- ^^^^^^^ [INFO] [stderr] 35 | | Some(String::from("\t")) [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | else { [INFO] [stderr] 38 | | None [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____- help: try this: `if line.find('\t').is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:85:8 [INFO] [stderr] | [INFO] [stderr] 85 | if headers_vec.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `headers_vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:106:54 [INFO] [stderr] | [INFO] [stderr] 106 | for column_name in output_column_names.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:133:33 [INFO] [stderr] | [INFO] [stderr] 133 | let header_row = if output_columns.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `output_columns.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:145:30 [INFO] [stderr] | [INFO] [stderr] 145 | let content_row = if output_columns.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output_columns.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.84s [INFO] running `"docker" "inspect" "285636585a96639f0ad06fa448f8456a5c91e86be1f469843a4a6a879ab3a776"` [INFO] running `"docker" "rm" "-f" "285636585a96639f0ad06fa448f8456a5c91e86be1f469843a4a6a879ab3a776"` [INFO] [stdout] 285636585a96639f0ad06fa448f8456a5c91e86be1f469843a4a6a879ab3a776