[INFO] crate csv-sniffer 0.1.1 is already in cache [INFO] extracting crate csv-sniffer 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/csv-sniffer/0.1.1 [INFO] extracting crate csv-sniffer 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/csv-sniffer/0.1.1 [INFO] validating manifest of csv-sniffer-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of csv-sniffer-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing csv-sniffer-0.1.1 [INFO] finished frobbing csv-sniffer-0.1.1 [INFO] frobbed toml for csv-sniffer-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/csv-sniffer/0.1.1/Cargo.toml [INFO] started frobbing csv-sniffer-0.1.1 [INFO] finished frobbing csv-sniffer-0.1.1 [INFO] frobbed toml for csv-sniffer-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/csv-sniffer/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting csv-sniffer-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/csv-sniffer/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8b4a2d8546fdfdd37c5a73782255f2a616f3008aa61e4a5047957187bcb2938b [INFO] running `"docker" "start" "-a" "8b4a2d8546fdfdd37c5a73782255f2a616f3008aa61e4a5047957187bcb2938b"` [INFO] [stderr] Checking csv v1.0.5 [INFO] [stderr] Checking csv-sniffer v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain.rs:152:53 [INFO] [stderr] | [INFO] [stderr] 152 | ViterbiResults { max_delim_freq: max_value, path: path } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sample.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | sample_size: sample_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sample_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain.rs:152:53 [INFO] [stderr] | [INFO] [stderr] 152 | ViterbiResults { max_delim_freq: max_value, path: path } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sample.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | sample_size: sample_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sample_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/field_type.rs:10:27 [INFO] [stderr] | [INFO] [stderr] 10 | const BOOLEAN = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/field_type.rs:11:27 [INFO] [stderr] | [INFO] [stderr] 11 | const UNSIGNED = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/field_type.rs:12:27 [INFO] [stderr] | [INFO] [stderr] 12 | const SIGNED = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/field_type.rs:13:27 [INFO] [stderr] | [INFO] [stderr] 13 | const FLOAT = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/field_type.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | const TEXT = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/field_type.rs:10:27 [INFO] [stderr] | [INFO] [stderr] 10 | const BOOLEAN = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/field_type.rs:11:27 [INFO] [stderr] | [INFO] [stderr] 11 | const UNSIGNED = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/field_type.rs:12:27 [INFO] [stderr] | [INFO] [stderr] 12 | const SIGNED = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/field_type.rs:13:27 [INFO] [stderr] | [INFO] [stderr] 13 | const FLOAT = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/field_type.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | const TEXT = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/chain.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | if self.observations.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.observations.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `state_idx` is only used to index `start_prob`. [INFO] [stderr] --> src/chain.rs:94:26 [INFO] [stderr] | [INFO] [stderr] 94 | for state_idx in 0..N_STATES { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 94 | for in start_prob.iter().take(N_STATES) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sniffer.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | self.sample_size.clone().unwrap_or(SampleSize::Bytes(1<<14)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.sample_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/sniffer.rs:181:12 [INFO] [stderr] | [INFO] [stderr] 181 | Ok(if quote_cnt == 0 { [INFO] [stderr] | ____________^ [INFO] [stderr] 182 | | self.quote = Some(Quote::None); [INFO] [stderr] 183 | | } else { [INFO] [stderr] 184 | | self.quote = Some(Quote::Some(quote_chr)); [INFO] [stderr] 185 | | self.delimiter = Some(delim_guess); [INFO] [stderr] 186 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 181 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: You appear to be counting bytes the naive way [INFO] [stderr] --> src/sniffer.rs:230:28 [INFO] [stderr] | [INFO] [stderr] 230 | let freq = line.as_bytes().iter().filter(|&&c| c == delim).count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(line.as_bytes(), delim)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::naive_bytecount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#naive_bytecount [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sniffer.rs:398:82 [INFO] [stderr] | [INFO] [stderr] 398 | fn quote_count(sample_iter: &mut SampleIter, character: char, delim: &Option) [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: The function/method `captures_iter` doesn't need a mutable reference [INFO] [stderr] --> src/sniffer.rs:413:37 [INFO] [stderr] | [INFO] [stderr] 413 | for cap in re.captures_iter(&mut line) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/sniffer.rs:416:20 [INFO] [stderr] | [INFO] [stderr] 416 | if let Some(_) = *delim {} else { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 417 | | *delim_count_map.entry(cap["delim"].to_string()).or_insert(0) += 1; [INFO] [stderr] 418 | | } [INFO] [stderr] | |_____________- help: try this: `if *delim.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sample.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn take_sample_from_start<'a, R: Read + Seek>(reader: &'a mut R, sample_size: SampleSize) [INFO] [stderr] 17 | | -> Result> [INFO] [stderr] 18 | | { [INFO] [stderr] 19 | | reader.seek(SeekFrom::Start(0))?; [INFO] [stderr] 20 | | Ok(take_sample(reader, sample_size)) [INFO] [stderr] 21 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sample.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn take_sample<'a, R: Read>(reader: &'a mut R, sample_size: SampleSize) -> SampleIter { [INFO] [stderr] 23 | | SampleIter::new(reader, sample_size) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/field_type.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | pub(crate) fn best(&self) -> Type { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/field_type.rs:38:26 [INFO] [stderr] | [INFO] [stderr] 38 | pub(crate) fn allows(&self, other: &TypeGuesses) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/field_type.rs:38:40 [INFO] [stderr] | [INFO] [stderr] 38 | pub(crate) fn allows(&self, other: &TypeGuesses) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `TypeGuesses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/field_type.rs:44:8 [INFO] [stderr] | [INFO] [stderr] 44 | if s.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/field_type.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | if let Ok(_) = s.parse::() { guesses |= TypeGuesses::UNSIGNED; } [INFO] [stderr] | -------^^^^^--------------------------------------------------------- help: try this: `if s.parse::().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/field_type.rs:51:12 [INFO] [stderr] | [INFO] [stderr] 51 | if let Ok(_) = s.parse::() { guesses |= TypeGuesses::SIGNED; } [INFO] [stderr] | -------^^^^^------------------------------------------------------- help: try this: `if s.parse::().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/field_type.rs:52:12 [INFO] [stderr] | [INFO] [stderr] 52 | if let Ok(_) = s.parse::() { guesses |= TypeGuesses::BOOLEAN; } [INFO] [stderr] | -------^^^^^--------------------------------------------------------- help: try this: `if s.parse::().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/field_type.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if let Ok(_) = s.parse::() { guesses |= TypeGuesses::FLOAT; } [INFO] [stderr] | -------^^^^^------------------------------------------------------ help: try this: `if s.parse::().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/chain.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | if self.observations.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.observations.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `state_idx` is only used to index `start_prob`. [INFO] [stderr] --> src/chain.rs:94:26 [INFO] [stderr] | [INFO] [stderr] 94 | for state_idx in 0..N_STATES { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 94 | for in start_prob.iter().take(N_STATES) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sniffer.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | self.sample_size.clone().unwrap_or(SampleSize::Bytes(1<<14)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.sample_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/sniffer.rs:181:12 [INFO] [stderr] | [INFO] [stderr] 181 | Ok(if quote_cnt == 0 { [INFO] [stderr] | ____________^ [INFO] [stderr] 182 | | self.quote = Some(Quote::None); [INFO] [stderr] 183 | | } else { [INFO] [stderr] 184 | | self.quote = Some(Quote::Some(quote_chr)); [INFO] [stderr] 185 | | self.delimiter = Some(delim_guess); [INFO] [stderr] 186 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 181 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: You appear to be counting bytes the naive way [INFO] [stderr] --> src/sniffer.rs:230:28 [INFO] [stderr] | [INFO] [stderr] 230 | let freq = line.as_bytes().iter().filter(|&&c| c == delim).count(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider using the bytecount crate: `bytecount::count(line.as_bytes(), delim)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::naive_bytecount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#naive_bytecount [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sniffer.rs:398:82 [INFO] [stderr] | [INFO] [stderr] 398 | fn quote_count(sample_iter: &mut SampleIter, character: char, delim: &Option) [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: The function/method `captures_iter` doesn't need a mutable reference [INFO] [stderr] --> src/sniffer.rs:413:37 [INFO] [stderr] | [INFO] [stderr] 413 | for cap in re.captures_iter(&mut line) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/sniffer.rs:416:20 [INFO] [stderr] | [INFO] [stderr] 416 | if let Some(_) = *delim {} else { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 417 | | *delim_count_map.entry(cap["delim"].to_string()).or_insert(0) += 1; [INFO] [stderr] 418 | | } [INFO] [stderr] | |_____________- help: try this: `if *delim.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sample.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn take_sample_from_start<'a, R: Read + Seek>(reader: &'a mut R, sample_size: SampleSize) [INFO] [stderr] 17 | | -> Result> [INFO] [stderr] 18 | | { [INFO] [stderr] 19 | | reader.seek(SeekFrom::Start(0))?; [INFO] [stderr] 20 | | Ok(take_sample(reader, sample_size)) [INFO] [stderr] 21 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/sample.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn take_sample<'a, R: Read>(reader: &'a mut R, sample_size: SampleSize) -> SampleIter { [INFO] [stderr] 23 | | SampleIter::new(reader, sample_size) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/field_type.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | pub(crate) fn best(&self) -> Type { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/field_type.rs:38:26 [INFO] [stderr] | [INFO] [stderr] 38 | pub(crate) fn allows(&self, other: &TypeGuesses) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/field_type.rs:38:40 [INFO] [stderr] | [INFO] [stderr] 38 | pub(crate) fn allows(&self, other: &TypeGuesses) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `TypeGuesses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/field_type.rs:44:8 [INFO] [stderr] | [INFO] [stderr] 44 | if s.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/field_type.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | if let Ok(_) = s.parse::() { guesses |= TypeGuesses::UNSIGNED; } [INFO] [stderr] | -------^^^^^--------------------------------------------------------- help: try this: `if s.parse::().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/field_type.rs:51:12 [INFO] [stderr] | [INFO] [stderr] 51 | if let Ok(_) = s.parse::() { guesses |= TypeGuesses::SIGNED; } [INFO] [stderr] | -------^^^^^------------------------------------------------------- help: try this: `if s.parse::().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/field_type.rs:52:12 [INFO] [stderr] | [INFO] [stderr] 52 | if let Ok(_) = s.parse::() { guesses |= TypeGuesses::BOOLEAN; } [INFO] [stderr] | -------^^^^^--------------------------------------------------------- help: try this: `if s.parse::().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/field_type.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if let Ok(_) = s.parse::() { guesses |= TypeGuesses::FLOAT; } [INFO] [stderr] | -------^^^^^------------------------------------------------------ help: try this: `if s.parse::().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> examples/worldbank.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / for result in reader.records() { [INFO] [stderr] 23 | | let record = result.unwrap(); [INFO] [stderr] 24 | | println!("{:?}", record); [INFO] [stderr] 25 | | break; [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `csv-sniffer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "8b4a2d8546fdfdd37c5a73782255f2a616f3008aa61e4a5047957187bcb2938b"` [INFO] running `"docker" "rm" "-f" "8b4a2d8546fdfdd37c5a73782255f2a616f3008aa61e4a5047957187bcb2938b"` [INFO] [stdout] 8b4a2d8546fdfdd37c5a73782255f2a616f3008aa61e4a5047957187bcb2938b