[INFO] crate css-modules 0.4.0 is already in cache
[INFO] extracting crate css-modules 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/css-modules/0.4.0
[INFO] extracting crate css-modules 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/css-modules/0.4.0
[INFO] validating manifest of css-modules-0.4.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of css-modules-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing css-modules-0.4.0
[INFO] finished frobbing css-modules-0.4.0
[INFO] frobbed toml for css-modules-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/css-modules/0.4.0/Cargo.toml
[INFO] started frobbing css-modules-0.4.0
[INFO] finished frobbing css-modules-0.4.0
[INFO] frobbed toml for css-modules-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/css-modules/0.4.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting css-modules-0.4.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/css-modules/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 67c5253662ceeb6dc55d8e0ef5ba9ee545674ab456380d55bd03bedf56f47515
[INFO] running `"docker" "start" "-a" "67c5253662ceeb6dc55d8e0ef5ba9ee545674ab456380d55bd03bedf56f47515"`
[INFO] [stderr]     Checking css-modules v0.4.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/stylesheet.rs:39:25
[INFO] [stderr]    |
[INFO] [stderr] 39 |                         write!(formatter, "@{} {};\n", name, rule.trim())
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/stylesheet.rs:47:25
[INFO] [stderr]    |
[INFO] [stderr] 47 |                         write!(formatter, "@{} {} {{ {} }}\n", name, rule.trim(), result)
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/stylesheet.rs:59:25
[INFO] [stderr]    |
[INFO] [stderr] 59 |                         write!(formatter, "@{} {{ {} }}\n", name, result)
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/stylesheet.rs:82:21
[INFO] [stderr]    |
[INFO] [stderr] 82 |                     write!(formatter, "\t{}: {};\n", name, value)
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/stylesheet.rs:84:21
[INFO] [stderr]    |
[INFO] [stderr] 84 |                     write!(formatter, "\t{}:;\n", name)
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/stylesheet.rs:39:25
[INFO] [stderr]    |
[INFO] [stderr] 39 |                         write!(formatter, "@{} {};\n", name, rule.trim())
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/stylesheet.rs:47:25
[INFO] [stderr]    |
[INFO] [stderr] 47 |                         write!(formatter, "@{} {} {{ {} }}\n", name, rule.trim(), result)
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/stylesheet.rs:59:25
[INFO] [stderr]    |
[INFO] [stderr] 59 |                         write!(formatter, "@{} {{ {} }}\n", name, result)
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/stylesheet.rs:82:21
[INFO] [stderr]    |
[INFO] [stderr] 82 |                     write!(formatter, "\t{}: {};\n", name, value)
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/stylesheet.rs:84:21
[INFO] [stderr]    |
[INFO] [stderr] 84 |                     write!(formatter, "\t{}:;\n", name)
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/stylesheet.rs:187:26
[INFO] [stderr]     |
[INFO] [stderr] 187 |                         .or_insert(format!("{}_{}_{}", &stylesheet.name, &animation, length));
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| format!("{}_{}_{}", &stylesheet.name, &animation, length))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/stylesheet.rs:215:1
[INFO] [stderr]     |
[INFO] [stderr] 215 | / fn create_comment<'t>(pair: Pair<'t, Rule>) -> Node {
[INFO] [stderr] 216 | |     Node::Comment {
[INFO] [stderr] 217 | |         value: Some(pair.as_str().to_string()),
[INFO] [stderr] 218 | |     }
[INFO] [stderr] 219 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/stylesheet.rs:264:22
[INFO] [stderr]     |
[INFO] [stderr] 264 |                     .or_insert(format!("{}_{}_{}", &stylesheet.name, &animation, length));
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| format!("{}_{}_{}", &stylesheet.name, &animation, length))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/stylesheet.rs:266:34
[INFO] [stderr]     |
[INFO] [stderr] 266 |                 result.push_str(&format!("{}", replacement));
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `replacement.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/stylesheet.rs:327:22
[INFO] [stderr]     |
[INFO] [stderr] 327 |                     .or_insert(format!("{}_{}_{}", &stylesheet.name, &class, length));
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| format!("{}_{}_{}", &stylesheet.name, &class, length))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/stylesheet.rs:187:26
[INFO] [stderr]     |
[INFO] [stderr] 187 |                         .or_insert(format!("{}_{}_{}", &stylesheet.name, &animation, length));
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| format!("{}_{}_{}", &stylesheet.name, &animation, length))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/stylesheet.rs:215:1
[INFO] [stderr]     |
[INFO] [stderr] 215 | / fn create_comment<'t>(pair: Pair<'t, Rule>) -> Node {
[INFO] [stderr] 216 | |     Node::Comment {
[INFO] [stderr] 217 | |         value: Some(pair.as_str().to_string()),
[INFO] [stderr] 218 | |     }
[INFO] [stderr] 219 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/stylesheet.rs:264:22
[INFO] [stderr]     |
[INFO] [stderr] 264 |                     .or_insert(format!("{}_{}_{}", &stylesheet.name, &animation, length));
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| format!("{}_{}_{}", &stylesheet.name, &animation, length))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/stylesheet.rs:266:34
[INFO] [stderr]     |
[INFO] [stderr] 266 |                 result.push_str(&format!("{}", replacement));
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `replacement.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/stylesheet.rs:327:22
[INFO] [stderr]     |
[INFO] [stderr] 327 |                     .or_insert(format!("{}_{}_{}", &stylesheet.name, &class, length));
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| format!("{}_{}_{}", &stylesheet.name, &class, length))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.74s
[INFO] running `"docker" "inspect" "67c5253662ceeb6dc55d8e0ef5ba9ee545674ab456380d55bd03bedf56f47515"`
[INFO] running `"docker" "rm" "-f" "67c5253662ceeb6dc55d8e0ef5ba9ee545674ab456380d55bd03bedf56f47515"`
[INFO] [stdout] 67c5253662ceeb6dc55d8e0ef5ba9ee545674ab456380d55bd03bedf56f47515