[INFO] crate cryptomkt 0.2.0 is already in cache [INFO] extracting crate cryptomkt 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/cryptomkt/0.2.0 [INFO] extracting crate cryptomkt 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cryptomkt/0.2.0 [INFO] validating manifest of cryptomkt-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cryptomkt-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cryptomkt-0.2.0 [INFO] finished frobbing cryptomkt-0.2.0 [INFO] frobbed toml for cryptomkt-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/cryptomkt/0.2.0/Cargo.toml [INFO] started frobbing cryptomkt-0.2.0 [INFO] finished frobbing cryptomkt-0.2.0 [INFO] frobbed toml for cryptomkt-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cryptomkt/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cryptomkt-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cryptomkt/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a80cf515e7e61c408b4d817a2f328b76f319502debd6a6e35961417aed6d4c0 [INFO] running `"docker" "start" "-a" "6a80cf515e7e61c408b4d817a2f328b76f319502debd6a6e35961417aed6d4c0"` [INFO] [stderr] Checking cryptomkt v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/market.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | api: api, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `api` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/market.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | api: api, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `api` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/internal/api.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | const X_MKT_APIKEY: &'static str = "X-MKT-APIKEY"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/internal/api.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | const X_MKT_SIGNATURE: &'static str = "X-MKT-SIGNATURE"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/internal/api.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | const X_MKT_TIMESTAMP: &'static str = "X-MKT-TIMESTAMP"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/internal/api.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | const X_MKT_APIKEY: &'static str = "X-MKT-APIKEY"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/internal/api.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | const X_MKT_SIGNATURE: &'static str = "X-MKT-SIGNATURE"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/internal/api.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | const X_MKT_TIMESTAMP: &'static str = "X-MKT-TIMESTAMP"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/internal/mod.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | const API_KEY: &'static str = "FS24FJ7"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/internal/mod.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | const SECRET_KEY: &'static str = "SFT23GSD"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/internal/api.rs:218:47 [INFO] [stderr] | [INFO] [stderr] 218 | let timestamp = msg_to_sign.split("/").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/market.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn new<'m>(api: CryptoMktApi, market_name: &'m str) -> Self { [INFO] [stderr] 50 | | Market { [INFO] [stderr] 51 | | api: api, [INFO] [stderr] 52 | | name: market_name.to_string(), [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/client.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / pub fn create_payment_order<'a>( [INFO] [stderr] 96 | | &self, [INFO] [stderr] 97 | | to_receive: f32, [INFO] [stderr] 98 | | to_receive_currency: &'a str, [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/internal/api.rs:218:47 [INFO] [stderr] | [INFO] [stderr] 218 | let timestamp = msg_to_sign.split("/").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/market.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn new<'m>(api: CryptoMktApi, market_name: &'m str) -> Self { [INFO] [stderr] 50 | | Market { [INFO] [stderr] 51 | | api: api, [INFO] [stderr] 52 | | name: market_name.to_string(), [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/client.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / pub fn create_payment_order<'a>( [INFO] [stderr] 96 | | &self, [INFO] [stderr] 97 | | to_receive: f32, [INFO] [stderr] 98 | | to_receive_currency: &'a str, [INFO] [stderr] ... | [INFO] [stderr] 136 | | } [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/simple.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | const API_KEY: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/simple.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | const API_SECRET: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.40s [INFO] running `"docker" "inspect" "6a80cf515e7e61c408b4d817a2f328b76f319502debd6a6e35961417aed6d4c0"` [INFO] running `"docker" "rm" "-f" "6a80cf515e7e61c408b4d817a2f328b76f319502debd6a6e35961417aed6d4c0"` [INFO] [stdout] 6a80cf515e7e61c408b4d817a2f328b76f319502debd6a6e35961417aed6d4c0