[INFO] crate crypto-tests 0.5.5 is already in cache [INFO] extracting crate crypto-tests 0.5.5 into work/ex/clippy-test-run/sources/stable/reg/crypto-tests/0.5.5 [INFO] extracting crate crypto-tests 0.5.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crypto-tests/0.5.5 [INFO] validating manifest of crypto-tests-0.5.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of crypto-tests-0.5.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing crypto-tests-0.5.5 [INFO] finished frobbing crypto-tests-0.5.5 [INFO] frobbed toml for crypto-tests-0.5.5 written to work/ex/clippy-test-run/sources/stable/reg/crypto-tests/0.5.5/Cargo.toml [INFO] started frobbing crypto-tests-0.5.5 [INFO] finished frobbing crypto-tests-0.5.5 [INFO] frobbed toml for crypto-tests-0.5.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crypto-tests/0.5.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting crypto-tests-0.5.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/crypto-tests/0.5.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14e8076950f2b7d8a9ded82ab24d89e7b113f316bd96641911511ff0c57fe805 [INFO] running `"docker" "start" "-a" "14e8076950f2b7d8a9ded82ab24d89e7b113f316bd96641911511ff0c57fe805"` [INFO] [stderr] Checking crypto-tests v0.5.5 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | sh.input(&[b'a'; 500000]); [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/hash.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | left = left - take; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `left -= take` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/hash.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | left = left - take; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `left -= take` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/mac.rs:35:36 [INFO] [stderr] | [INFO] [stderr] 35 | hmac.input(&test.input[i..i + 1]); [INFO] [stderr] | ^^^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | sh.input(&[b'a'; 500000]); [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/hash.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | left = left - take; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `left -= take` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/hash.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | left = left - take; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `left -= take` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/mac.rs:35:36 [INFO] [stderr] | [INFO] [stderr] 35 | hmac.input(&test.input[i..i + 1]); [INFO] [stderr] | ^^^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.53s [INFO] running `"docker" "inspect" "14e8076950f2b7d8a9ded82ab24d89e7b113f316bd96641911511ff0c57fe805"` [INFO] running `"docker" "rm" "-f" "14e8076950f2b7d8a9ded82ab24d89e7b113f316bd96641911511ff0c57fe805"` [INFO] [stdout] 14e8076950f2b7d8a9ded82ab24d89e7b113f316bd96641911511ff0c57fe805