[INFO] crate cryogen_prelude 0.1.0 is already in cache [INFO] extracting crate cryogen_prelude 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cryogen_prelude/0.1.0 [INFO] extracting crate cryogen_prelude 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cryogen_prelude/0.1.0 [INFO] validating manifest of cryogen_prelude-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cryogen_prelude-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cryogen_prelude-0.1.0 [INFO] finished frobbing cryogen_prelude-0.1.0 [INFO] frobbed toml for cryogen_prelude-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cryogen_prelude/0.1.0/Cargo.toml [INFO] started frobbing cryogen_prelude-0.1.0 [INFO] finished frobbing cryogen_prelude-0.1.0 [INFO] frobbed toml for cryogen_prelude-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cryogen_prelude/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cryogen_prelude-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cryogen_prelude/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 217df0c70b93093b9a01298f8462257cf75c616c8b25fa099b56f188ef2228f9 [INFO] running `"docker" "start" "-a" "217df0c70b93093b9a01298f8462257cf75c616c8b25fa099b56f188ef2228f9"` [INFO] [stderr] warning: unused manifest key: package.license_file [INFO] [stderr] Checking clap v2.20.5 [INFO] [stderr] Checking tera v0.8.1 [INFO] [stderr] Checking cryogen_prelude v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | var_name: var_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `var_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | file_path: file_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | var_name: var_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `var_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | file_path: file_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn from_str(s: &'a str) -> Result, &'static str> { [INFO] [stderr] 24 | | let mut splits = s.splitn(2, ":"); [INFO] [stderr] 25 | | let var_name = splits.next().unwrap(); [INFO] [stderr] 26 | | [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | let mut splits = s.splitn(2, ":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn from_str(s: &'a str) -> Result, &'static str> { [INFO] [stderr] 24 | | let mut splits = s.splitn(2, ":"); [INFO] [stderr] 25 | | let var_name = splits.next().unwrap(); [INFO] [stderr] 26 | | [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | let mut splits = s.splitn(2, ":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.77s [INFO] running `"docker" "inspect" "217df0c70b93093b9a01298f8462257cf75c616c8b25fa099b56f188ef2228f9"` [INFO] running `"docker" "rm" "-f" "217df0c70b93093b9a01298f8462257cf75c616c8b25fa099b56f188ef2228f9"` [INFO] [stdout] 217df0c70b93093b9a01298f8462257cf75c616c8b25fa099b56f188ef2228f9