[INFO] crate crushtool 0.3.10 is already in cache
[INFO] extracting crate crushtool 0.3.10 into work/ex/clippy-test-run/sources/stable/reg/crushtool/0.3.10
[INFO] extracting crate crushtool 0.3.10 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crushtool/0.3.10
[INFO] validating manifest of crushtool-0.3.10 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of crushtool-0.3.10 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing crushtool-0.3.10
[INFO] finished frobbing crushtool-0.3.10
[INFO] frobbed toml for crushtool-0.3.10 written to work/ex/clippy-test-run/sources/stable/reg/crushtool/0.3.10/Cargo.toml
[INFO] started frobbing crushtool-0.3.10
[INFO] finished frobbing crushtool-0.3.10
[INFO] frobbed toml for crushtool-0.3.10 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crushtool/0.3.10/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting crushtool-0.3.10 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/crushtool/0.3.10:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2ea900b2c94d90e857116939aa5362ec0f7a4495a9cc2d5632e4639af32bfcc8
[INFO] running `"docker" "start" "-a" "2ea900b2c94d90e857116939aa5362ec0f7a4495a9cc2d5632e4639af32bfcc8"`
[INFO] [stderr]     Checking uuid v0.4.0
[INFO] [stderr]     Checking clap v2.14.1
[INFO] [stderr]     Checking crushtool v0.3.10 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/io.rs:27:27
[INFO] [stderr]    |
[INFO] [stderr] 27 | static CRUSH_MAGIC: u32 = 0x00010000;  /* for detecting algorithm revisions */
[INFO] [stderr]    |                           ^^^^^^^^^^ help: consider: `0x0001_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/io.rs:414:13
[INFO] [stderr]     |
[INFO] [stderr] 414 |             return IResult::Incomplete(needed);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Incomplete(needed)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/io.rs:417:13
[INFO] [stderr]     |
[INFO] [stderr] 417 |             return IResult::Error(e);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Error(e)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/io.rs:605:21
[INFO] [stderr]     |
[INFO] [stderr] 605 |                     return IResult::Done(unparsed_data, None);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Done(unparsed_data, None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/io.rs:623:17
[INFO] [stderr]     |
[INFO] [stderr] 623 |                 return IResult::Incomplete(needed);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Incomplete(needed)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/io.rs:626:17
[INFO] [stderr]     |
[INFO] [stderr] 626 |                 return IResult::Error(e);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Error(e)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/io.rs:804:13
[INFO] [stderr]     |
[INFO] [stderr] 804 |             return Ok(map.clone());
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(map.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:452:9
[INFO] [stderr]     |
[INFO] [stderr] 452 |         crushmap
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:451:28
[INFO] [stderr]     |
[INFO] [stderr] 451 |         let mut crushmap = CrushMap::default();
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/io.rs:27:27
[INFO] [stderr]    |
[INFO] [stderr] 27 | static CRUSH_MAGIC: u32 = 0x00010000;  /* for detecting algorithm revisions */
[INFO] [stderr]    |                           ^^^^^^^^^^ help: consider: `0x0001_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/io.rs:414:13
[INFO] [stderr]     |
[INFO] [stderr] 414 |             return IResult::Incomplete(needed);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Incomplete(needed)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/io.rs:417:13
[INFO] [stderr]     |
[INFO] [stderr] 417 |             return IResult::Error(e);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Error(e)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/io.rs:605:21
[INFO] [stderr]     |
[INFO] [stderr] 605 |                     return IResult::Done(unparsed_data, None);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Done(unparsed_data, None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/io.rs:623:17
[INFO] [stderr]     |
[INFO] [stderr] 623 |                 return IResult::Incomplete(needed);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Incomplete(needed)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/io.rs:626:17
[INFO] [stderr]     |
[INFO] [stderr] 626 |                 return IResult::Error(e);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `IResult::Error(e)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/io.rs:804:13
[INFO] [stderr]     |
[INFO] [stderr] 804 |             return Ok(map.clone());
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(map.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:452:9
[INFO] [stderr]     |
[INFO] [stderr] 452 |         crushmap
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:451:28
[INFO] [stderr]     |
[INFO] [stderr] 451 |         let mut crushmap = CrushMap::default();
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/lib.rs:451:13
[INFO] [stderr]     |
[INFO] [stderr] 451 |         let mut crushmap = CrushMap::default();
[INFO] [stderr]     |             ----^^^^^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/io.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 62 | |         chain!(
[INFO] [stderr] 63 | |             input,
[INFO] [stderr] 64 | |             bucket: call!(Bucket::parse)~
[INFO] [stderr] ...  |
[INFO] [stderr] 72 | |         )
[INFO] [stderr] 73 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/io.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 86 | |         chain!(
[INFO] [stderr] 87 | |             input,
[INFO] [stderr] 88 | |             bucket: call!(Bucket::parse)~
[INFO] [stderr] ...  |
[INFO] [stderr] 98 | |         )
[INFO] [stderr] 99 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:115:5
[INFO] [stderr]     |
[INFO] [stderr] 115 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 116 | |         chain!(
[INFO] [stderr] 117 | |             input,
[INFO] [stderr] 118 | |             bucket: call!(Bucket::parse)~
[INFO] [stderr] ...   |
[INFO] [stderr] 128 | |         )
[INFO] [stderr] 129 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:145:5
[INFO] [stderr]     |
[INFO] [stderr] 145 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 146 | |         chain!(
[INFO] [stderr] 147 | |             input,
[INFO] [stderr] 148 | |             bucket: call!(Bucket::parse)~
[INFO] [stderr] ...   |
[INFO] [stderr] 156 | |         )
[INFO] [stderr] 157 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:202:5
[INFO] [stderr]     |
[INFO] [stderr] 202 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 203 | |         chain!(
[INFO] [stderr] 204 | |             input,
[INFO] [stderr] 205 | |             bucket: call!(Bucket::parse)~
[INFO] [stderr] ...   |
[INFO] [stderr] 215 | |         )
[INFO] [stderr] 216 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/io.rs:280:8
[INFO] [stderr]     |
[INFO] [stderr] 280 |     if input.len() < 1 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:347:1
[INFO] [stderr]     |
[INFO] [stderr] 347 | / fn parse_bucket<'a>(input: &'a [u8]) -> IResult<&[u8], BucketTypes> {
[INFO] [stderr] 348 | |     trace!("parse_bucket input: {:?}", input);
[INFO] [stderr] 349 | |     let alg_type_bits = le_u32(input);
[INFO] [stderr] 350 | |     match alg_type_bits {
[INFO] [stderr] ...   |
[INFO] [stderr] 419 | |     }
[INFO] [stderr] 420 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/lib.rs:451:13
[INFO] [stderr]     |
[INFO] [stderr] 451 |         let mut crushmap = CrushMap::default();
[INFO] [stderr]     |             ----^^^^^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:423:5
[INFO] [stderr]     |
[INFO] [stderr] 423 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 424 | |         trace!("bucket input: {:?}", input);
[INFO] [stderr] 425 | |         chain!(
[INFO] [stderr] 426 | |             input,
[INFO] [stderr] ...   |
[INFO] [stderr] 456 | |         )
[INFO] [stderr] 457 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 35
[INFO] [stderr]    --> src/io.rs:423:5
[INFO] [stderr]     |
[INFO] [stderr] 423 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 424 | |         trace!("bucket input: {:?}", input);
[INFO] [stderr] 425 | |         chain!(
[INFO] [stderr] 426 | |             input,
[INFO] [stderr] ...   |
[INFO] [stderr] 456 | |         )
[INFO] [stderr] 457 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/io.rs:475:49
[INFO] [stderr]     |
[INFO] [stderr] 475 |     fn update_name_mapping(&mut self, name_map: &Vec<(i32, String)>) {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, String)]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:495:5
[INFO] [stderr]     |
[INFO] [stderr] 495 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 496 | |         trace!("rule step input: {:?}", input);
[INFO] [stderr] 497 | |         chain!(
[INFO] [stderr] 498 | |             input,
[INFO] [stderr] ...   |
[INFO] [stderr] 511 | |         )
[INFO] [stderr] 512 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/io.rs:514:48
[INFO] [stderr]     |
[INFO] [stderr] 514 |     fn update_arg_mapping(&mut self, type_map: &Vec<(i32, String)>) {
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, String)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:551:5
[INFO] [stderr]     |
[INFO] [stderr] 551 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 552 | |         trace!("rule mask input: {:?}", input);
[INFO] [stderr] 553 | |         chain!(
[INFO] [stderr] 554 | |             input,
[INFO] [stderr] ...   |
[INFO] [stderr] 568 | |         )
[INFO] [stderr] 569 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:599:5
[INFO] [stderr]     |
[INFO] [stderr] 599 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Option<Self>> {
[INFO] [stderr] 600 | |         trace!("rule input: {:?}", input);
[INFO] [stderr] 601 | |         let yes_bits = le_u32(input);
[INFO] [stderr] 602 | |         match yes_bits {
[INFO] [stderr] ...   |
[INFO] [stderr] 628 | |         }
[INFO] [stderr] 629 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/io.rs:649:40
[INFO] [stderr]     |
[INFO] [stderr] 649 |                              type_map: &Vec<(i32, String)>)
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, String)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/io.rs:652:9
[INFO] [stderr]     |
[INFO] [stderr] 652 | /         match *rule {
[INFO] [stderr] 653 | |             Some(ref mut r) => {
[INFO] [stderr] 654 | |                 for step in r.steps.iter_mut() {
[INFO] [stderr] 655 | |                     step.update_arg_mapping(type_map)
[INFO] [stderr] ...   |
[INFO] [stderr] 660 | |             }
[INFO] [stderr] 661 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 652 |         if let Some(ref mut r) = *rule {
[INFO] [stderr] 653 |     for step in r.steps.iter_mut() {
[INFO] [stderr] 654 |         step.update_arg_mapping(type_map)
[INFO] [stderr] 655 |     }
[INFO] [stderr] 656 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/io.rs:667:37
[INFO] [stderr]     |
[INFO] [stderr] 667 |                           name_map: &Vec<(i32, String)>)
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, String)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:733:1
[INFO] [stderr]     |
[INFO] [stderr] 733 | / pub fn parse_crushmap<'a>(input: &'a [u8]) -> IResult<&[u8], CrushMap> {
[INFO] [stderr] 734 | |     trace!("crushmap input: {:?}", input);
[INFO] [stderr] 735 | |     chain!(
[INFO] [stderr] 736 | |         input,
[INFO] [stderr] ...   |
[INFO] [stderr] 788 | |     )
[INFO] [stderr] 789 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 44
[INFO] [stderr]    --> src/io.rs:733:1
[INFO] [stderr]     |
[INFO] [stderr] 733 | / pub fn parse_crushmap<'a>(input: &'a [u8]) -> IResult<&[u8], CrushMap> {
[INFO] [stderr] 734 | |     trace!("crushmap input: {:?}", input);
[INFO] [stderr] 735 | |     chain!(
[INFO] [stderr] 736 | |         input,
[INFO] [stderr] ...   |
[INFO] [stderr] 788 | |     )
[INFO] [stderr] 789 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:793:1
[INFO] [stderr]     |
[INFO] [stderr] 793 | / pub fn decode_crushmap<'a>(input: &'a [u8]) -> Result<CrushMap, String> {
[INFO] [stderr] 794 | |     let mut result = parse_crushmap(input);
[INFO] [stderr] 795 | |     match result {
[INFO] [stderr] 796 | |         IResult::Done(_, ref mut map) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 808 | |     }
[INFO] [stderr] 809 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/io.rs:821:9
[INFO] [stderr]     |
[INFO] [stderr] 821 | /         match bucket {
[INFO] [stderr] 822 | |             &BucketTypes::Uniform(ref uniform) => {
[INFO] [stderr] 823 | |                 trace!("Trying to encode uniform bucket");
[INFO] [stderr] 824 | |                 buffer.extend(try!(uniform.compile()));
[INFO] [stderr] ...   |
[INFO] [stderr] 844 | |             }
[INFO] [stderr] 845 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 821 |         match *bucket {
[INFO] [stderr] 822 |             BucketTypes::Uniform(ref uniform) => {
[INFO] [stderr] 823 |                 trace!("Trying to encode uniform bucket");
[INFO] [stderr] 824 |                 buffer.extend(try!(uniform.compile()));
[INFO] [stderr] 825 |             }
[INFO] [stderr] 826 |             BucketTypes::List(ref list) => {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/io.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 62 | |         chain!(
[INFO] [stderr] 63 | |             input,
[INFO] [stderr] 64 | |             bucket: call!(Bucket::parse)~
[INFO] [stderr] ...  |
[INFO] [stderr] 72 | |         )
[INFO] [stderr] 73 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/io.rs:85:5
[INFO] [stderr]    |
[INFO] [stderr] 85 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 86 | |         chain!(
[INFO] [stderr] 87 | |             input,
[INFO] [stderr] 88 | |             bucket: call!(Bucket::parse)~
[INFO] [stderr] ...  |
[INFO] [stderr] 98 | |         )
[INFO] [stderr] 99 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:115:5
[INFO] [stderr]     |
[INFO] [stderr] 115 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 116 | |         chain!(
[INFO] [stderr] 117 | |             input,
[INFO] [stderr] 118 | |             bucket: call!(Bucket::parse)~
[INFO] [stderr] ...   |
[INFO] [stderr] 128 | |         )
[INFO] [stderr] 129 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:145:5
[INFO] [stderr]     |
[INFO] [stderr] 145 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 146 | |         chain!(
[INFO] [stderr] 147 | |             input,
[INFO] [stderr] 148 | |             bucket: call!(Bucket::parse)~
[INFO] [stderr] ...   |
[INFO] [stderr] 156 | |         )
[INFO] [stderr] 157 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:202:5
[INFO] [stderr]     |
[INFO] [stderr] 202 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 203 | |         chain!(
[INFO] [stderr] 204 | |             input,
[INFO] [stderr] 205 | |             bucket: call!(Bucket::parse)~
[INFO] [stderr] ...   |
[INFO] [stderr] 215 | |         )
[INFO] [stderr] 216 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/io.rs:280:8
[INFO] [stderr]     |
[INFO] [stderr] 280 |     if input.len() < 1 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:347:1
[INFO] [stderr]     |
[INFO] [stderr] 347 | / fn parse_bucket<'a>(input: &'a [u8]) -> IResult<&[u8], BucketTypes> {
[INFO] [stderr] 348 | |     trace!("parse_bucket input: {:?}", input);
[INFO] [stderr] 349 | |     let alg_type_bits = le_u32(input);
[INFO] [stderr] 350 | |     match alg_type_bits {
[INFO] [stderr] ...   |
[INFO] [stderr] 419 | |     }
[INFO] [stderr] 420 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:423:5
[INFO] [stderr]     |
[INFO] [stderr] 423 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 424 | |         trace!("bucket input: {:?}", input);
[INFO] [stderr] 425 | |         chain!(
[INFO] [stderr] 426 | |             input,
[INFO] [stderr] ...   |
[INFO] [stderr] 456 | |         )
[INFO] [stderr] 457 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 35
[INFO] [stderr]    --> src/io.rs:423:5
[INFO] [stderr]     |
[INFO] [stderr] 423 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 424 | |         trace!("bucket input: {:?}", input);
[INFO] [stderr] 425 | |         chain!(
[INFO] [stderr] 426 | |             input,
[INFO] [stderr] ...   |
[INFO] [stderr] 456 | |         )
[INFO] [stderr] 457 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:450:24
[INFO] [stderr]     |
[INFO] [stderr] 450 |     pub fn to_crushmap(self) -> CrushMap {
[INFO] [stderr]     |                        ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/io.rs:475:49
[INFO] [stderr]     |
[INFO] [stderr] 475 |     fn update_name_mapping(&mut self, name_map: &Vec<(i32, String)>) {
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, String)]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:495:5
[INFO] [stderr]     |
[INFO] [stderr] 495 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 496 | |         trace!("rule step input: {:?}", input);
[INFO] [stderr] 497 | |         chain!(
[INFO] [stderr] 498 | |             input,
[INFO] [stderr] ...   |
[INFO] [stderr] 511 | |         )
[INFO] [stderr] 512 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/io.rs:514:48
[INFO] [stderr]     |
[INFO] [stderr] 514 |     fn update_arg_mapping(&mut self, type_map: &Vec<(i32, String)>) {
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, String)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:551:5
[INFO] [stderr]     |
[INFO] [stderr] 551 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Self> {
[INFO] [stderr] 552 | |         trace!("rule mask input: {:?}", input);
[INFO] [stderr] 553 | |         chain!(
[INFO] [stderr] 554 | |             input,
[INFO] [stderr] ...   |
[INFO] [stderr] 568 | |         )
[INFO] [stderr] 569 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:599:5
[INFO] [stderr]     |
[INFO] [stderr] 599 | /     fn parse<'a>(input: &'a [u8]) -> IResult<&[u8], Option<Self>> {
[INFO] [stderr] 600 | |         trace!("rule input: {:?}", input);
[INFO] [stderr] 601 | |         let yes_bits = le_u32(input);
[INFO] [stderr] 602 | |         match yes_bits {
[INFO] [stderr] ...   |
[INFO] [stderr] 628 | |         }
[INFO] [stderr] 629 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/io.rs:649:40
[INFO] [stderr]     |
[INFO] [stderr] 649 |                              type_map: &Vec<(i32, String)>)
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, String)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/io.rs:652:9
[INFO] [stderr]     |
[INFO] [stderr] 652 | /         match *rule {
[INFO] [stderr] 653 | |             Some(ref mut r) => {
[INFO] [stderr] 654 | |                 for step in r.steps.iter_mut() {
[INFO] [stderr] 655 | |                     step.update_arg_mapping(type_map)
[INFO] [stderr] ...   |
[INFO] [stderr] 660 | |             }
[INFO] [stderr] 661 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 652 |         if let Some(ref mut r) = *rule {
[INFO] [stderr] 653 |     for step in r.steps.iter_mut() {
[INFO] [stderr] 654 |         step.update_arg_mapping(type_map)
[INFO] [stderr] 655 |     }
[INFO] [stderr] 656 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/io.rs:667:37
[INFO] [stderr]     |
[INFO] [stderr] 667 |                           name_map: &Vec<(i32, String)>)
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, String)]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:733:1
[INFO] [stderr]     |
[INFO] [stderr] 733 | / pub fn parse_crushmap<'a>(input: &'a [u8]) -> IResult<&[u8], CrushMap> {
[INFO] [stderr] 734 | |     trace!("crushmap input: {:?}", input);
[INFO] [stderr] 735 | |     chain!(
[INFO] [stderr] 736 | |         input,
[INFO] [stderr] ...   |
[INFO] [stderr] 788 | |     )
[INFO] [stderr] 789 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 44
[INFO] [stderr]    --> src/io.rs:733:1
[INFO] [stderr]     |
[INFO] [stderr] 733 | / pub fn parse_crushmap<'a>(input: &'a [u8]) -> IResult<&[u8], CrushMap> {
[INFO] [stderr] 734 | |     trace!("crushmap input: {:?}", input);
[INFO] [stderr] 735 | |     chain!(
[INFO] [stderr] 736 | |         input,
[INFO] [stderr] ...   |
[INFO] [stderr] 788 | |     )
[INFO] [stderr] 789 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/io.rs:793:1
[INFO] [stderr]     |
[INFO] [stderr] 793 | / pub fn decode_crushmap<'a>(input: &'a [u8]) -> Result<CrushMap, String> {
[INFO] [stderr] 794 | |     let mut result = parse_crushmap(input);
[INFO] [stderr] 795 | |     match result {
[INFO] [stderr] 796 | |         IResult::Done(_, ref mut map) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 808 | |     }
[INFO] [stderr] 809 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/io.rs:821:9
[INFO] [stderr]     |
[INFO] [stderr] 821 | /         match bucket {
[INFO] [stderr] 822 | |             &BucketTypes::Uniform(ref uniform) => {
[INFO] [stderr] 823 | |                 trace!("Trying to encode uniform bucket");
[INFO] [stderr] 824 | |                 buffer.extend(try!(uniform.compile()));
[INFO] [stderr] ...   |
[INFO] [stderr] 844 | |             }
[INFO] [stderr] 845 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 821 |         match *bucket {
[INFO] [stderr] 822 |             BucketTypes::Uniform(ref uniform) => {
[INFO] [stderr] 823 |                 trace!("Trying to encode uniform bucket");
[INFO] [stderr] 824 |                 buffer.extend(try!(uniform.compile()));
[INFO] [stderr] 825 |             }
[INFO] [stderr] 826 |             BucketTypes::List(ref list) => {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:450:24
[INFO] [stderr]     |
[INFO] [stderr] 450 |     pub fn to_crushmap(self) -> CrushMap {
[INFO] [stderr]     |                        ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead
[INFO] [stderr]   --> src/main.rs:22:1
[INFO] [stderr]    |
[INFO] [stderr] 22 | / arg_enum!{
[INFO] [stderr] 23 | |   enum Mode {
[INFO] [stderr] 24 | |     compile,
[INFO] [stderr] 25 | |     decompile
[INFO] [stderr] 26 | |   }
[INFO] [stderr] 27 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead
[INFO] [stderr]   --> src/main.rs:22:1
[INFO] [stderr]    |
[INFO] [stderr] 22 | / arg_enum!{
[INFO] [stderr] 23 | |   enum Mode {
[INFO] [stderr] 24 | |     compile,
[INFO] [stderr] 25 | |     decompile
[INFO] [stderr] 26 | |   }
[INFO] [stderr] 27 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 12.52s
[INFO] running `"docker" "inspect" "2ea900b2c94d90e857116939aa5362ec0f7a4495a9cc2d5632e4639af32bfcc8"`
[INFO] running `"docker" "rm" "-f" "2ea900b2c94d90e857116939aa5362ec0f7a4495a9cc2d5632e4639af32bfcc8"`
[INFO] [stdout] 2ea900b2c94d90e857116939aa5362ec0f7a4495a9cc2d5632e4639af32bfcc8