[INFO] crate crowbook-intl 0.2.1 is already in cache [INFO] extracting crate crowbook-intl 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/crowbook-intl/0.2.1 [INFO] extracting crate crowbook-intl 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crowbook-intl/0.2.1 [INFO] validating manifest of crowbook-intl-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of crowbook-intl-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing crowbook-intl-0.2.1 [INFO] finished frobbing crowbook-intl-0.2.1 [INFO] frobbed toml for crowbook-intl-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/crowbook-intl/0.2.1/Cargo.toml [INFO] started frobbing crowbook-intl-0.2.1 [INFO] finished frobbing crowbook-intl-0.2.1 [INFO] frobbed toml for crowbook-intl-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crowbook-intl/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting crowbook-intl-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/crowbook-intl/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5b6ab62bf06887b98011c6752b0d5b239c48c089631c25b00b245ef45f79de8e [INFO] running `"docker" "start" "-a" "5b6ab62bf06887b98011c6752b0d5b239c48c089631c25b00b245ef45f79de8e"` [INFO] [stderr] Checking crowbook-intl v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/localizer.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | extractor: extractor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extractor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/localizer.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | extractor: extractor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extractor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/extractor.rs:148:20 [INFO] [stderr] | [INFO] [stderr] 148 | const POT_HEADER: &'static str = r#"# SOME DESCRIPTIVE TITLE [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/extractor.rs:148:20 [INFO] [stderr] | [INFO] [stderr] 148 | const POT_HEADER: &'static str = r#"# SOME DESCRIPTIVE TITLE [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / match bytes[i] { [INFO] [stderr] 37 | | b'"' => if begin.is_some() { [INFO] [stderr] 38 | | if bytes[i-1] != b'\\' { [INFO] [stderr] 39 | | break [INFO] [stderr] ... | [INFO] [stderr] 47 | | _ => (), [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | if let b'"' = bytes[i] { if begin.is_some() { [INFO] [stderr] 37 | if bytes[i-1] != b'\\' { [INFO] [stderr] 38 | break [INFO] [stderr] 39 | } [INFO] [stderr] 40 | } else { [INFO] [stderr] 41 | if i + 1 >= bytes.len() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/macrogen.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | let ref mut hash = curr[i].content; [INFO] [stderr] | ----^^^^^^^^^^^^------------------- help: try: `let hash = &mut curr[i].content;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/macrogen.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | let ref mut hash = other_lang.content; [INFO] [stderr] | ----^^^^^^^^^^^^---------------------- help: try: `let hash = &mut other_lang.content;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/macrogen.rs:116:24 [INFO] [stderr] | [INFO] [stderr] 116 | return !(c == next_c); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `c != next_c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lang.rs:46:60 [INFO] [stderr] | [INFO] [stderr] 46 | if lines[i].is_empty() || lines[i].starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lang.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lang.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `extractor::Extractor` [INFO] [stderr] --> src/extractor.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new() -> Extractor { [INFO] [stderr] 48 | | Extractor { [INFO] [stderr] 49 | | messages: HashMap::new(), [INFO] [stderr] 50 | | orig_strings: HashMap::new(), [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/extractor.rs:65:54 [INFO] [stderr] | [INFO] [stderr] 65 | static ref FIND_MSGS: Regex = Regex::new(r#"lformat!\("#).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / match bytes[i] { [INFO] [stderr] 37 | | b'"' => if begin.is_some() { [INFO] [stderr] 38 | | if bytes[i-1] != b'\\' { [INFO] [stderr] 39 | | break [INFO] [stderr] ... | [INFO] [stderr] 47 | | _ => (), [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | if let b'"' = bytes[i] { if begin.is_some() { [INFO] [stderr] 37 | if bytes[i-1] != b'\\' { [INFO] [stderr] 38 | break [INFO] [stderr] 39 | } [INFO] [stderr] 40 | } else { [INFO] [stderr] 41 | if i + 1 >= bytes.len() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/macrogen.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | let ref mut hash = curr[i].content; [INFO] [stderr] | ----^^^^^^^^^^^^------------------- help: try: `let hash = &mut curr[i].content;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/macrogen.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | let ref mut hash = other_lang.content; [INFO] [stderr] | ----^^^^^^^^^^^^---------------------- help: try: `let hash = &mut other_lang.content;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/macrogen.rs:116:24 [INFO] [stderr] | [INFO] [stderr] 116 | return !(c == next_c); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `c != next_c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lang.rs:46:60 [INFO] [stderr] | [INFO] [stderr] 46 | if lines[i].is_empty() || lines[i].starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lang.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lang.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lang.rs:173:16 [INFO] [stderr] | [INFO] [stderr] 173 | assert_eq!(lang.content.get("foo").unwrap(), "foobar"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&lang.content["foo"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lang.rs:186:16 [INFO] [stderr] | [INFO] [stderr] 186 | assert_eq!(lang.content.get("foobar").unwrap(), "foobar"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&lang.content["foobar"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `extractor::Extractor` [INFO] [stderr] --> src/extractor.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new() -> Extractor { [INFO] [stderr] 48 | | Extractor { [INFO] [stderr] 49 | | messages: HashMap::new(), [INFO] [stderr] 50 | | orig_strings: HashMap::new(), [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/extractor.rs:65:54 [INFO] [stderr] | [INFO] [stderr] 65 | static ref FIND_MSGS: Regex = Regex::new(r#"lformat!\("#).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.76s [INFO] running `"docker" "inspect" "5b6ab62bf06887b98011c6752b0d5b239c48c089631c25b00b245ef45f79de8e"` [INFO] running `"docker" "rm" "-f" "5b6ab62bf06887b98011c6752b0d5b239c48c089631c25b00b245ef45f79de8e"` [INFO] [stdout] 5b6ab62bf06887b98011c6752b0d5b239c48c089631c25b00b245ef45f79de8e