[INFO] crate cross 0.1.14 is already in cache
[INFO] extracting crate cross 0.1.14 into work/ex/clippy-test-run/sources/stable/reg/cross/0.1.14
[INFO] extracting crate cross 0.1.14 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cross/0.1.14
[INFO] validating manifest of cross-0.1.14 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cross-0.1.14 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cross-0.1.14
[INFO] finished frobbing cross-0.1.14
[INFO] frobbed toml for cross-0.1.14 written to work/ex/clippy-test-run/sources/stable/reg/cross/0.1.14/Cargo.toml
[INFO] started frobbing cross-0.1.14
[INFO] finished frobbing cross-0.1.14
[INFO] frobbed toml for cross-0.1.14 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cross/0.1.14/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cross-0.1.14 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cross/0.1.14:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bba661c8e265eb9232534269a3f51fa6b89f8592f50692c6add051f113df5b28
[INFO] running `"docker" "start" "-a" "bba661c8e265eb9232534269a3f51fa6b89f8592f50692c6add051f113df5b28"`
[INFO] [stderr]    Compiling cross v0.1.14 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cli.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         all: all,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `all`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cli.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         target: target,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `target`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: lint `unused_doc_comment` has been renamed to `unused_doc_comments`
[INFO] [stderr]  --> src/errors.rs:1:10
[INFO] [stderr]   |
[INFO] [stderr] 1 | #![allow(unused_doc_comment)]
[INFO] [stderr]   |          ^^^^^^^^^^^^^^^^^^ help: use the new name: `unused_doc_comments`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cli.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         all: all,
[INFO] [stderr]    |         ^^^^^^^^ help: replace it with: `all`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cli.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         target: target,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `target`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: lint `unused_doc_comment` has been renamed to `unused_doc_comments`
[INFO] [stderr]  --> src/errors.rs:1:10
[INFO] [stderr]   |
[INFO] [stderr] 1 | #![allow(unused_doc_comment)]
[INFO] [stderr]   |          ^^^^^^^^^^^^^^^^^^ help: use the new name: `unused_doc_comments`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/docker.rs:78:20
[INFO] [stderr]    |
[INFO] [stderr] 78 |     let home_dir = env::home_dir().ok_or_else(|| "couldn't get home directory. Is $HOME not set?")?;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/docker.rs:78:20
[INFO] [stderr]    |
[INFO] [stderr] 78 |     let home_dir = env::home_dir().ok_or_else(|| "couldn't get home directory. Is $HOME not set?")?;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/cargo.rs:20:25
[INFO] [stderr]    |
[INFO] [stderr] 20 |     pub fn needs_docker(&self) -> bool {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/cargo.rs:27:30
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn needs_interpreter(&self) -> bool {
[INFO] [stderr]    |                              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant
[INFO] [stderr]    --> src/docker.rs:118:5
[INFO] [stderr]     |
[INFO] [stderr] 118 | /     if let Some(strace) = env::var("QEMU_STRACE").ok() {
[INFO] [stderr] 119 | |         docker.args(&["-e", &format!("QEMU_STRACE={}", strace)]);
[INFO] [stderr] 120 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::if_let_some_result)] on by default
[INFO] [stderr]     = help: Consider matching on `Ok(strace)` and removing the call to `ok` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/docker.rs:124:29
[INFO] [stderr]     |
[INFO] [stderr] 124 |             if var.contains("=") {
[INFO] [stderr]     |                             ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/rustc.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 | /         !(self.semver >= Version {
[INFO] [stderr] 32 | |             major: 1,
[INFO] [stderr] 33 | |             minor: 19,
[INFO] [stderr] 34 | |             patch: 0,
[INFO] [stderr] 35 | |             pre: vec![],
[INFO] [stderr] 36 | |             build: vec![],
[INFO] [stderr] 37 | |         })
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 31 |         self.semver < Version {
[INFO] [stderr] 32 |             major: 1,
[INFO] [stderr] 33 |             minor: 19,
[INFO] [stderr] 34 |             patch: 0,
[INFO] [stderr] 35 |             pre: vec![],
[INFO] [stderr] 36 |             build: vec![],
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/rustup.rs:47:23
[INFO] [stderr]    |
[INFO] [stderr] 47 |         .chain_err(|| format!("couldn't install the `rust-src` component"))
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"couldn't install the `rust-src` component".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:47:21
[INFO] [stderr]    |
[INFO] [stderr] 47 |     fn is_supported(&self, target: Option<&Target>) -> bool {
[INFO] [stderr]    |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:57:15
[INFO] [stderr]    |
[INFO] [stderr] 57 |     fn triple(&self) -> &'static str {
[INFO] [stderr]    |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:423:18
[INFO] [stderr]     |
[INFO] [stderr] 423 |                 .unwrap_or(Target::from(host.triple(), &target_list));
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Target::from(host.triple(), &target_list))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/cargo.rs:20:25
[INFO] [stderr]    |
[INFO] [stderr] 20 |     pub fn needs_docker(&self) -> bool {
[INFO] [stderr]    |                         ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/cargo.rs:27:30
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn needs_interpreter(&self) -> bool {
[INFO] [stderr]    |                              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant
[INFO] [stderr]    --> src/docker.rs:118:5
[INFO] [stderr]     |
[INFO] [stderr] 118 | /     if let Some(strace) = env::var("QEMU_STRACE").ok() {
[INFO] [stderr] 119 | |         docker.args(&["-e", &format!("QEMU_STRACE={}", strace)]);
[INFO] [stderr] 120 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::if_let_some_result)] on by default
[INFO] [stderr]     = help: Consider matching on `Ok(strace)` and removing the call to `ok` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/docker.rs:124:29
[INFO] [stderr]     |
[INFO] [stderr] 124 |             if var.contains("=") {
[INFO] [stderr]     |                             ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/rustc.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 | /         !(self.semver >= Version {
[INFO] [stderr] 32 | |             major: 1,
[INFO] [stderr] 33 | |             minor: 19,
[INFO] [stderr] 34 | |             patch: 0,
[INFO] [stderr] 35 | |             pre: vec![],
[INFO] [stderr] 36 | |             build: vec![],
[INFO] [stderr] 37 | |         })
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 31 |         self.semver < Version {
[INFO] [stderr] 32 |             major: 1,
[INFO] [stderr] 33 |             minor: 19,
[INFO] [stderr] 34 |             patch: 0,
[INFO] [stderr] 35 |             pre: vec![],
[INFO] [stderr] 36 |             build: vec![],
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/rustup.rs:47:23
[INFO] [stderr]    |
[INFO] [stderr] 47 |         .chain_err(|| format!("couldn't install the `rust-src` component"))
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"couldn't install the `rust-src` component".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:47:21
[INFO] [stderr]    |
[INFO] [stderr] 47 |     fn is_supported(&self, target: Option<&Target>) -> bool {
[INFO] [stderr]    |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:57:15
[INFO] [stderr]    |
[INFO] [stderr] 57 |     fn triple(&self) -> &'static str {
[INFO] [stderr]    |               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:423:18
[INFO] [stderr]     |
[INFO] [stderr] 423 |                 .unwrap_or(Target::from(host.triple(), &target_list));
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Target::from(host.triple(), &target_list))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.95s
[INFO] running `"docker" "inspect" "bba661c8e265eb9232534269a3f51fa6b89f8592f50692c6add051f113df5b28"`
[INFO] running `"docker" "rm" "-f" "bba661c8e265eb9232534269a3f51fa6b89f8592f50692c6add051f113df5b28"`
[INFO] [stdout] bba661c8e265eb9232534269a3f51fa6b89f8592f50692c6add051f113df5b28