[INFO] crate crontab 0.2.0 is already in cache [INFO] extracting crate crontab 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/crontab/0.2.0 [INFO] extracting crate crontab 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crontab/0.2.0 [INFO] validating manifest of crontab-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of crontab-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing crontab-0.2.0 [INFO] finished frobbing crontab-0.2.0 [INFO] frobbed toml for crontab-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/crontab/0.2.0/Cargo.toml [INFO] started frobbing crontab-0.2.0 [INFO] finished frobbing crontab-0.2.0 [INFO] frobbed toml for crontab-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crontab/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting crontab-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/crontab/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 739c4daeb7448196b68d6bae4ae1ef1b9314177b5515d61a01f3a0ee858cd32f [INFO] running `"docker" "start" "-a" "739c4daeb7448196b68d6bae4ae1ef1b9314177b5515d61a01f3a0ee858cd32f"` [INFO] [stderr] Checking crontab v0.2.0 (/opt/crater/workdir) [INFO] [stderr] Checking expectest v0.9.2 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/crontab.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | schedule: schedule, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `schedule` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsing.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | minutes: minutes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minutes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsing.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | hours: hours, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hours` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsing.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | days: days, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `days` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsing.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | months: months, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `months` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsing.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | weekdays: weekdays, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `weekdays` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | let mut next_time = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:112:28 [INFO] [stderr] | [INFO] [stderr] 112 | let mut use_time = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:115:28 [INFO] [stderr] | [INFO] [stderr] 115 | use_time.tm_mday = times.days.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.days.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:115:28 [INFO] [stderr] | [INFO] [stderr] 115 | use_time.tm_mday = times.days.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.days[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:117:28 [INFO] [stderr] | [INFO] [stderr] 117 | use_time.tm_hour = times.hours.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.hours.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:117:28 [INFO] [stderr] | [INFO] [stderr] 117 | use_time.tm_hour = times.hours.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.hours[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | use_time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.minutes.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | use_time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.minutes[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/crontab.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | time.tm_year = time.tm_year + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time.tm_year += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:128:24 [INFO] [stderr] | [INFO] [stderr] 128 | time.tm_mon = (times.months.get(0).unwrap().clone() - 1) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.months.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:128:24 [INFO] [stderr] | [INFO] [stderr] 128 | time.tm_mon = (times.months.get(0).unwrap().clone() - 1) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.months[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | time.tm_mday = times.days.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.days.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | time.tm_mday = times.days.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.days[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:132:24 [INFO] [stderr] | [INFO] [stderr] 132 | time.tm_hour = times.hours.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.hours.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:132:24 [INFO] [stderr] | [INFO] [stderr] 132 | time.tm_hour = times.hours.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.hours[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:134:23 [INFO] [stderr] | [INFO] [stderr] 134 | time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.minutes.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:134:23 [INFO] [stderr] | [INFO] [stderr] 134 | time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.minutes[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:152:28 [INFO] [stderr] | [INFO] [stderr] 152 | let mut use_time = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:154:28 [INFO] [stderr] | [INFO] [stderr] 154 | use_time.tm_mday = day.clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:156:28 [INFO] [stderr] | [INFO] [stderr] 156 | use_time.tm_hour = times.hours.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.hours.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:156:28 [INFO] [stderr] | [INFO] [stderr] 156 | use_time.tm_hour = times.hours.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.hours[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:158:27 [INFO] [stderr] | [INFO] [stderr] 158 | use_time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.minutes.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:158:27 [INFO] [stderr] | [INFO] [stderr] 158 | use_time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.minutes[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:184:28 [INFO] [stderr] | [INFO] [stderr] 184 | let mut use_time = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:186:28 [INFO] [stderr] | [INFO] [stderr] 186 | use_time.tm_hour = hour.clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*hour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:188:27 [INFO] [stderr] | [INFO] [stderr] 188 | use_time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.minutes.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:188:27 [INFO] [stderr] | [INFO] [stderr] 188 | use_time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.minutes[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:208:26 [INFO] [stderr] | [INFO] [stderr] 208 | let mut use_time = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:216:28 [INFO] [stderr] | [INFO] [stderr] 216 | let mut use_time = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:218:27 [INFO] [stderr] | [INFO] [stderr] 218 | use_time.tm_min = minute.clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / match self { [INFO] [stderr] 29 | | &CrontabError::ErrCronFormat(ref x) => write!(f, " {:?}", x), [INFO] [stderr] 30 | | &CrontabError::ErrParseInt(ref e) => write!(f, " {:?}", e), [INFO] [stderr] 31 | | &CrontabError::FieldOutsideRange{ ref description } => { [INFO] [stderr] 32 | | write!(f, " {:?}", description) [INFO] [stderr] 33 | | }, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | match *self { [INFO] [stderr] 29 | CrontabError::ErrCronFormat(ref x) => write!(f, " {:?}", x), [INFO] [stderr] 30 | CrontabError::ErrParseInt(ref e) => write!(f, " {:?}", e), [INFO] [stderr] 31 | CrontabError::FieldOutsideRange{ ref description } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parsing.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | for part in field.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parsing.rs:75:46 [INFO] [stderr] | [INFO] [stderr] 75 | let stepped : Vec<&str> = part.splitn(2, "/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parsing.rs:78:50 [INFO] [stderr] | [INFO] [stderr] 78 | let range : Vec<&str> = stepped[0].splitn(2, "-").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parsing.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | let values = (min .. max + 1).filter(|i| i % step == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(min..=max)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/times.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / if year % 400 == 0 [INFO] [stderr] 27 | | || (year % 4 == 0 && year % 100 != 0) { [INFO] [stderr] 28 | | true [INFO] [stderr] 29 | | } else { [INFO] [stderr] 30 | | false [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 26 | year % 400 == 0 [INFO] [stderr] 27 | || (year % 4 == 0 && year % 100 != 0) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/crontab.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | schedule: schedule, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `schedule` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsing.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | minutes: minutes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minutes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsing.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | hours: hours, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hours` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsing.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | days: days, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `days` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsing.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | months: months, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `months` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsing.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | weekdays: weekdays, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `weekdays` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/usage.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | let mut timestamp = 1500001200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_500_001_200` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/crontab.rs:465:34 [INFO] [stderr] | [INFO] [stderr] 465 | let timespec = Timespec::new(1483228800, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_483_228_800` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/times.rs:112:34 [INFO] [stderr] | [INFO] [stderr] 112 | let timespec = Timespec::new(1483228800, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_483_228_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/times.rs:150:34 [INFO] [stderr] | [INFO] [stderr] 150 | let timespec = Timespec::new(1483228800, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_483_228_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/times.rs:197:34 [INFO] [stderr] | [INFO] [stderr] 197 | let timespec = Timespec::new(1483228800, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_483_228_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/test_helpers.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | let mut tm = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | let mut next_time = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:112:28 [INFO] [stderr] | [INFO] [stderr] 112 | let mut use_time = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:115:28 [INFO] [stderr] | [INFO] [stderr] 115 | use_time.tm_mday = times.days.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.days.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:115:28 [INFO] [stderr] | [INFO] [stderr] 115 | use_time.tm_mday = times.days.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.days[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:117:28 [INFO] [stderr] | [INFO] [stderr] 117 | use_time.tm_hour = times.hours.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.hours.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:117:28 [INFO] [stderr] | [INFO] [stderr] 117 | use_time.tm_hour = times.hours.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.hours[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | use_time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.minutes.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | use_time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.minutes[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/crontab.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | time.tm_year = time.tm_year + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time.tm_year += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:128:24 [INFO] [stderr] | [INFO] [stderr] 128 | time.tm_mon = (times.months.get(0).unwrap().clone() - 1) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.months.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:128:24 [INFO] [stderr] | [INFO] [stderr] 128 | time.tm_mon = (times.months.get(0).unwrap().clone() - 1) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.months[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | time.tm_mday = times.days.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.days.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | time.tm_mday = times.days.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.days[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:132:24 [INFO] [stderr] | [INFO] [stderr] 132 | time.tm_hour = times.hours.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.hours.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:132:24 [INFO] [stderr] | [INFO] [stderr] 132 | time.tm_hour = times.hours.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.hours[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:134:23 [INFO] [stderr] | [INFO] [stderr] 134 | time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.minutes.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:134:23 [INFO] [stderr] | [INFO] [stderr] 134 | time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.minutes[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:152:28 [INFO] [stderr] | [INFO] [stderr] 152 | let mut use_time = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:154:28 [INFO] [stderr] | [INFO] [stderr] 154 | use_time.tm_mday = day.clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:156:28 [INFO] [stderr] | [INFO] [stderr] 156 | use_time.tm_hour = times.hours.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.hours.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:156:28 [INFO] [stderr] | [INFO] [stderr] 156 | use_time.tm_hour = times.hours.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.hours[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:158:27 [INFO] [stderr] | [INFO] [stderr] 158 | use_time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.minutes.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:158:27 [INFO] [stderr] | [INFO] [stderr] 158 | use_time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.minutes[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:184:28 [INFO] [stderr] | [INFO] [stderr] 184 | let mut use_time = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:186:28 [INFO] [stderr] | [INFO] [stderr] 186 | use_time.tm_hour = hour.clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*hour` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:188:27 [INFO] [stderr] | [INFO] [stderr] 188 | use_time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*times.minutes.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crontab.rs:188:27 [INFO] [stderr] | [INFO] [stderr] 188 | use_time.tm_min = times.minutes.get(0).unwrap().clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `×.minutes[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:208:26 [INFO] [stderr] | [INFO] [stderr] 208 | let mut use_time = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:216:28 [INFO] [stderr] | [INFO] [stderr] 216 | let mut use_time = time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:218:27 [INFO] [stderr] | [INFO] [stderr] 218 | use_time.tm_min = minute.clone() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:467:20 [INFO] [stderr] | [INFO] [stderr] 467 | let mut next = last.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `last` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/crontab.rs:468:24 [INFO] [stderr] | [INFO] [stderr] 468 | let mut expected = last.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `last` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / match self { [INFO] [stderr] 29 | | &CrontabError::ErrCronFormat(ref x) => write!(f, " {:?}", x), [INFO] [stderr] 30 | | &CrontabError::ErrParseInt(ref e) => write!(f, " {:?}", e), [INFO] [stderr] 31 | | &CrontabError::FieldOutsideRange{ ref description } => { [INFO] [stderr] 32 | | write!(f, " {:?}", description) [INFO] [stderr] 33 | | }, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | match *self { [INFO] [stderr] 29 | CrontabError::ErrCronFormat(ref x) => write!(f, " {:?}", x), [INFO] [stderr] 30 | CrontabError::ErrParseInt(ref e) => write!(f, " {:?}", e), [INFO] [stderr] 31 | CrontabError::FieldOutsideRange{ ref description } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parsing.rs:69:27 [INFO] [stderr] | [INFO] [stderr] 69 | for part in field.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parsing.rs:75:46 [INFO] [stderr] | [INFO] [stderr] 75 | let stepped : Vec<&str> = part.splitn(2, "/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parsing.rs:78:50 [INFO] [stderr] | [INFO] [stderr] 78 | let range : Vec<&str> = stepped[0].splitn(2, "-").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parsing.rs:106:18 [INFO] [stderr] | [INFO] [stderr] 106 | let values = (min .. max + 1).filter(|i| i % step == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(min..=max)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/times.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / if year % 400 == 0 [INFO] [stderr] 27 | | || (year % 4 == 0 && year % 100 != 0) { [INFO] [stderr] 28 | | true [INFO] [stderr] 29 | | } else { [INFO] [stderr] 30 | | false [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 26 | year % 400 == 0 [INFO] [stderr] 27 | || (year % 4 == 0 && year % 100 != 0) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.52s [INFO] running `"docker" "inspect" "739c4daeb7448196b68d6bae4ae1ef1b9314177b5515d61a01f3a0ee858cd32f"` [INFO] running `"docker" "rm" "-f" "739c4daeb7448196b68d6bae4ae1ef1b9314177b5515d61a01f3a0ee858cd32f"` [INFO] [stdout] 739c4daeb7448196b68d6bae4ae1ef1b9314177b5515d61a01f3a0ee858cd32f