[INFO] crate cronparse 0.5.1 is already in cache [INFO] extracting crate cronparse 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/cronparse/0.5.1 [INFO] extracting crate cronparse 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cronparse/0.5.1 [INFO] validating manifest of cronparse-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cronparse-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cronparse-0.5.1 [INFO] finished frobbing cronparse-0.5.1 [INFO] frobbed toml for cronparse-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/cronparse/0.5.1/Cargo.toml [INFO] started frobbing cronparse-0.5.1 [INFO] finished frobbing cronparse-0.5.1 [INFO] frobbed toml for cronparse-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cronparse/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cronparse-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cronparse/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 11d91630ca81ffe258e7c440768ae8436251f039c46e2f7ab2c1fd27dc5c31d7 [INFO] running `"docker" "start" "-a" "11d91630ca81ffe258e7c440768ae8436251f039c46e2f7ab2c1fd27dc5c31d7"` [INFO] [stderr] Checking skeptic v0.5.0 [INFO] [stderr] Compiling cronparse v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/crontab.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | / if value.len() > 1 { [INFO] [stderr] 150 | | if &value[..1] == "'" || &value[..1] == "\"" && &value[..1] == &value[value.len()-1..] { [INFO] [stderr] 151 | | value = &value[1..value.len()-1]; [INFO] [stderr] 152 | | } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 149 | if value.len() > 1 && (&value[..1] == "'" || &value[..1] == "\"" && &value[..1] == &value[value.len()-1..]) { [INFO] [stderr] 150 | value = &value[1..value.len()-1]; [INFO] [stderr] 151 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/schedule.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/crontab.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | / if value.len() > 1 { [INFO] [stderr] 150 | | if &value[..1] == "'" || &value[..1] == "\"" && &value[..1] == &value[value.len()-1..] { [INFO] [stderr] 151 | | value = &value[1..value.len()-1]; [INFO] [stderr] 152 | | } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 149 | if value.len() > 1 && (&value[..1] == "'" || &value[..1] == "\"" && &value[..1] == &value[value.len()-1..]) { [INFO] [stderr] 150 | value = &value[1..value.len()-1]; [INFO] [stderr] 151 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/schedule.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/schedule.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `FromIterator` [INFO] [stderr] --> src/schedule.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | use std::iter::{FromIterator, IntoIterator, Iterator}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::FromIterator` [INFO] [stderr] --> src/crontab.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::iter::FromIterator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/schedule.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `FromIterator` [INFO] [stderr] --> src/schedule.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | use std::iter::{FromIterator, IntoIterator, Iterator}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter::FromIterator` [INFO] [stderr] --> src/crontab.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::iter::FromIterator; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/schedule.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | / pub fn from_iter<'a, I>(mut parts: I) -> Result where I: Iterator { [INFO] [stderr] 138 | | Ok(Calendar { [INFO] [stderr] 139 | | mins: parse_cron_rec_field!(parts, MissingMinutes, Minutes), [INFO] [stderr] 140 | | hrs: parse_cron_rec_field!(parts, MissingHours, Hours), [INFO] [stderr] ... | [INFO] [stderr] 144 | | }) [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: the `r @ _` pattern can be written as just `r` [INFO] [stderr] --> src/schedule.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | r @ _ if r.starts_with("@") => return Err(PeriodParseError::UnknownPeriod), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/schedule.rs:217:36 [INFO] [stderr] | [INFO] [stderr] 217 | r @ _ if r.starts_with("@") => return Err(PeriodParseError::UnknownPeriod), [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/schedule.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | / pub fn from_iter<'a, I>(mut parts: I) -> Result where I: Iterator { [INFO] [stderr] 138 | | Ok(Calendar { [INFO] [stderr] 139 | | mins: parse_cron_rec_field!(parts, MissingMinutes, Minutes), [INFO] [stderr] 140 | | hrs: parse_cron_rec_field!(parts, MissingHours, Hours), [INFO] [stderr] ... | [INFO] [stderr] 144 | | }) [INFO] [stderr] 145 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: the `r @ _` pattern can be written as just `r` [INFO] [stderr] --> src/schedule.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | r @ _ if r.starts_with("@") => return Err(PeriodParseError::UnknownPeriod), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/schedule.rs:217:36 [INFO] [stderr] | [INFO] [stderr] 217 | r @ _ if r.starts_with("@") => return Err(PeriodParseError::UnknownPeriod), [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/schedule.rs:498:26 [INFO] [stderr] | [INFO] [stderr] 498 | if s.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/schedule.rs:507:5 [INFO] [stderr] | [INFO] [stderr] 507 | / pub fn from_iter<'a, I>(iter: I) -> Result where I: Iterator { [INFO] [stderr] 508 | | let mut it = iter.into_iter().peekable(); [INFO] [stderr] 509 | | let is_period = match it.peek() { [INFO] [stderr] 510 | | None => return Err(ScheduleParseError::MissingSchedule), [INFO] [stderr] ... | [INFO] [stderr] 518 | | } [INFO] [stderr] 519 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/schedule.rs:508:22 [INFO] [stderr] | [INFO] [stderr] 508 | let mut it = iter.into_iter().peekable(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/schedule.rs:511:38 [INFO] [stderr] | [INFO] [stderr] 511 | Some(s) => s.starts_with("@") [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/schedule.rs:498:26 [INFO] [stderr] | [INFO] [stderr] 498 | if s.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_iter` on this type; consider implementing the `std::iter::FromIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/schedule.rs:507:5 [INFO] [stderr] | [INFO] [stderr] 507 | / pub fn from_iter<'a, I>(iter: I) -> Result where I: Iterator { [INFO] [stderr] 508 | | let mut it = iter.into_iter().peekable(); [INFO] [stderr] 509 | | let is_period = match it.peek() { [INFO] [stderr] 510 | | None => return Err(ScheduleParseError::MissingSchedule), [INFO] [stderr] ... | [INFO] [stderr] 518 | | } [INFO] [stderr] 519 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/schedule.rs:508:22 [INFO] [stderr] | [INFO] [stderr] 508 | let mut it = iter.into_iter().peekable(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/schedule.rs:511:38 [INFO] [stderr] | [INFO] [stderr] 511 | Some(s) => s.starts_with("@") [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/crontab.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn period<'a>(&'a self) -> Option<&'a Period> { [INFO] [stderr] 79 | | match *self { [INFO] [stderr] 80 | | CrontabEntry::Anacron(AnacrontabEntry { ref period, .. }) => Some(period), [INFO] [stderr] 81 | | CrontabEntry::User(UserCrontabEntry { sched: Schedule::Period(ref period), .. }) => Some(period), [INFO] [stderr] ... | [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/crontab.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / pub fn calendar<'a>(&'a self) -> Option<&'a Calendar> { [INFO] [stderr] 88 | | match *self { [INFO] [stderr] 89 | | CrontabEntry::User(UserCrontabEntry { sched: Schedule::Calendar(ref cal), .. }) => Some(cal), [INFO] [stderr] 90 | | CrontabEntry::System(SystemCrontabEntry { sched: Schedule::Calendar(ref cal), .. }) => Some(cal), [INFO] [stderr] 91 | | _ => None [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/crontab.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / pub fn command<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 96 | | match *self { [INFO] [stderr] 97 | | CrontabEntry::User(UserCrontabEntry { ref cmd, .. }) => Some(&**cmd), [INFO] [stderr] 98 | | CrontabEntry::System(SystemCrontabEntry { ref cmd, .. }) => Some(&**cmd), [INFO] [stderr] ... | [INFO] [stderr] 101 | | } [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/crontab.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / pub fn user<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 105 | | match *self { [INFO] [stderr] 106 | | CrontabEntry::System(SystemCrontabEntry { user: UserInfo(ref user, _, _), .. }) => Some(&**user), [INFO] [stderr] 107 | | _ => None [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/crontab.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / pub fn group<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 112 | | match *self { [INFO] [stderr] 113 | | CrontabEntry::System(SystemCrontabEntry { user: UserInfo(_, Some(ref group), _), .. }) => Some(&**group), [INFO] [stderr] 114 | | _ => None [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/crontab.rs:136:12 [INFO] [stderr] | [INFO] [stderr] 136 | if name.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/crontab.rs:150:61 [INFO] [stderr] | [INFO] [stderr] 150 | if &value[..1] == "'" || &value[..1] == "\"" && &value[..1] == &value[value.len()-1..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 150 | if &value[..1] == "'" || &value[..1] == "\"" && value[..1] == value[value.len()-1..] { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/crontab.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn period<'a>(&'a self) -> Option<&'a Period> { [INFO] [stderr] 79 | | match *self { [INFO] [stderr] 80 | | CrontabEntry::Anacron(AnacrontabEntry { ref period, .. }) => Some(period), [INFO] [stderr] 81 | | CrontabEntry::User(UserCrontabEntry { sched: Schedule::Period(ref period), .. }) => Some(period), [INFO] [stderr] ... | [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/crontab.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / pub fn calendar<'a>(&'a self) -> Option<&'a Calendar> { [INFO] [stderr] 88 | | match *self { [INFO] [stderr] 89 | | CrontabEntry::User(UserCrontabEntry { sched: Schedule::Calendar(ref cal), .. }) => Some(cal), [INFO] [stderr] 90 | | CrontabEntry::System(SystemCrontabEntry { sched: Schedule::Calendar(ref cal), .. }) => Some(cal), [INFO] [stderr] 91 | | _ => None [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/crontab.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / pub fn command<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 96 | | match *self { [INFO] [stderr] 97 | | CrontabEntry::User(UserCrontabEntry { ref cmd, .. }) => Some(&**cmd), [INFO] [stderr] 98 | | CrontabEntry::System(SystemCrontabEntry { ref cmd, .. }) => Some(&**cmd), [INFO] [stderr] ... | [INFO] [stderr] 101 | | } [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/crontab.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / pub fn user<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 105 | | match *self { [INFO] [stderr] 106 | | CrontabEntry::System(SystemCrontabEntry { user: UserInfo(ref user, _, _), .. }) => Some(&**user), [INFO] [stderr] 107 | | _ => None [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/crontab.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / pub fn group<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 112 | | match *self { [INFO] [stderr] 113 | | CrontabEntry::System(SystemCrontabEntry { user: UserInfo(_, Some(ref group), _), .. }) => Some(&**group), [INFO] [stderr] 114 | | _ => None [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/crontab.rs:136:12 [INFO] [stderr] | [INFO] [stderr] 136 | if name.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/crontab.rs:150:61 [INFO] [stderr] | [INFO] [stderr] 150 | if &value[..1] == "'" || &value[..1] == "\"" && &value[..1] == &value[value.len()-1..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 150 | if &value[..1] == "'" || &value[..1] == "\"" && value[..1] == value[value.len()-1..] { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | if line.len() == 0 || line.starts_with("#") || line.chars().all(|c| c == ' ' || c == '\t') { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:109:60 [INFO] [stderr] | [INFO] [stderr] 109 | if line.len() == 0 || line.starts_with("#") || line.chars().all(|c| c == ' ' || c == '\t') { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | if line.len() == 0 || line.starts_with("#") || line.chars().all(|c| c == ' ' || c == '\t') { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:109:60 [INFO] [stderr] | [INFO] [stderr] 109 | if line.len() == 0 || line.starts_with("#") || line.chars().all(|c| c == ' ' || c == '\t') { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> /opt/crater/target/debug/build/cronparse-00d820c9d9d94e1e/out/skeptic-tests.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | let ref s = format!("{}", r####"extern crate cronparse; [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 5 | | [INFO] [stderr] 6 | | use cronparse::crontab::UserCrontabEntry; [INFO] [stderr] 7 | | use cronparse::CrontabFile; [INFO] [stderr] ... | [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | "####); [INFO] [stderr] | |_______- help: try: `let s = &$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) );` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> /opt/crater/target/debug/build/cronparse-00d820c9d9d94e1e/out/skeptic-tests.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | let ref s = format!("{}", r####"extern crate cronparse; [INFO] [stderr] | _________________^ [INFO] [stderr] 5 | | [INFO] [stderr] 6 | | use cronparse::crontab::UserCrontabEntry; [INFO] [stderr] 7 | | use cronparse::CrontabFile; [INFO] [stderr] ... | [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | "####); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( r####"extern crate cronparse; [INFO] [stderr] 3 | [INFO] [stderr] 4 | use cronparse::crontab::UserCrontabEntry; [INFO] [stderr] 5 | use cronparse::CrontabFile; [INFO] [stderr] 6 | [INFO] [stderr] 7 | fn main() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.76s [INFO] running `"docker" "inspect" "11d91630ca81ffe258e7c440768ae8436251f039c46e2f7ab2c1fd27dc5c31d7"` [INFO] running `"docker" "rm" "-f" "11d91630ca81ffe258e7c440768ae8436251f039c46e2f7ab2c1fd27dc5c31d7"` [INFO] [stdout] 11d91630ca81ffe258e7c440768ae8436251f039c46e2f7ab2c1fd27dc5c31d7