[INFO] crate cronenberg 0.3.0 is already in cache [INFO] extracting crate cronenberg 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/cronenberg/0.3.0 [INFO] extracting crate cronenberg 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cronenberg/0.3.0 [INFO] validating manifest of cronenberg-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cronenberg-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cronenberg-0.3.0 [INFO] finished frobbing cronenberg-0.3.0 [INFO] frobbed toml for cronenberg-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/cronenberg/0.3.0/Cargo.toml [INFO] started frobbing cronenberg-0.3.0 [INFO] finished frobbing cronenberg-0.3.0 [INFO] frobbed toml for cronenberg-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cronenberg/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cronenberg-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cronenberg/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 308d1906903a73160fd9b65eaf537dc3ba9e144205fb9ea101ca587ece598043 [INFO] running `"docker" "start" "-a" "308d1906903a73160fd9b65eaf537dc3ba9e144205fb9ea101ca587ece598043"` [INFO] [stderr] Checking cronenberg v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `super::CronItem` [INFO] [stderr] --> src/cron_item.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | use super::CronItem; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::TimeItem::*` [INFO] [stderr] --> src/cron_item.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | use super::TimeItem::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::FromStr` [INFO] [stderr] --> src/cron_item.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | use std::str::FromStr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::string::ToString` [INFO] [stderr] --> src/cron_item.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | use std::string::ToString; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/parser.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cron_item.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match self { [INFO] [stderr] 38 | | &TimeItem::AllValues => write!(f, "*"), [INFO] [stderr] 39 | | &TimeItem::Interval((start, end)) => write!(f, "{}-{}", start, end), [INFO] [stderr] 40 | | &TimeItem::MultipleValues(ref values) => { [INFO] [stderr] ... | [INFO] [stderr] 53 | | &TimeItem::SingleValue(value) => write!(f, "{}", value), [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | match *self { [INFO] [stderr] 38 | TimeItem::AllValues => write!(f, "*"), [INFO] [stderr] 39 | TimeItem::Interval((start, end)) => write!(f, "{}-{}", start, end), [INFO] [stderr] 40 | TimeItem::MultipleValues(ref values) => { [INFO] [stderr] 41 | let result = values.iter().map(|val| val.to_string()).fold( [INFO] [stderr] 42 | String::from(""), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cron_item.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match self { [INFO] [stderr] 38 | | &TimeItem::AllValues => write!(f, "*"), [INFO] [stderr] 39 | | &TimeItem::Interval((start, end)) => write!(f, "{}-{}", start, end), [INFO] [stderr] 40 | | &TimeItem::MultipleValues(ref values) => { [INFO] [stderr] ... | [INFO] [stderr] 53 | | &TimeItem::SingleValue(value) => write!(f, "{}", value), [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | match *self { [INFO] [stderr] 38 | TimeItem::AllValues => write!(f, "*"), [INFO] [stderr] 39 | TimeItem::Interval((start, end)) => write!(f, "{}-{}", start, end), [INFO] [stderr] 40 | TimeItem::MultipleValues(ref values) => { [INFO] [stderr] 41 | let result = values.iter().map(|val| val.to_string()).fold( [INFO] [stderr] 42 | String::from(""), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `cronenberg::TimeItem::*` [INFO] [stderr] --> tests/lib_test.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use cronenberg::TimeItem::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.67s [INFO] running `"docker" "inspect" "308d1906903a73160fd9b65eaf537dc3ba9e144205fb9ea101ca587ece598043"` [INFO] running `"docker" "rm" "-f" "308d1906903a73160fd9b65eaf537dc3ba9e144205fb9ea101ca587ece598043"` [INFO] [stdout] 308d1906903a73160fd9b65eaf537dc3ba9e144205fb9ea101ca587ece598043