[INFO] crate cron 0.6.0 is already in cache [INFO] extracting crate cron 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/cron/0.6.0 [INFO] extracting crate cron 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cron/0.6.0 [INFO] validating manifest of cron-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cron-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cron-0.6.0 [INFO] finished frobbing cron-0.6.0 [INFO] frobbed toml for cron-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/cron/0.6.0/Cargo.toml [INFO] started frobbing cron-0.6.0 [INFO] finished frobbing cron-0.6.0 [INFO] frobbed toml for cron-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cron/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cron-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cron/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c5f5a7c570b3db6498ecd74b20ca7fb6f150c8271f2649dd453b4e98bab975f [INFO] running `"docker" "start" "-a" "7c5f5a7c570b3db6498ecd74b20ca7fb6f150c8271f2649dd453b4e98bab975f"` [INFO] [stderr] Checking cron v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | years: years, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `years` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | days_of_week: days_of_week, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `days_of_week` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | months: months, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `months` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | days_of_month: days_of_month, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `days_of_month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | hours: hours, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hours` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | minutes: minutes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minutes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | seconds: seconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:323:13 [INFO] [stderr] | [INFO] [stderr] 323 | schedule: schedule, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `schedule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | years: years, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `years` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | days_of_week: days_of_week, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `days_of_week` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | months: months, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `months` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | days_of_month: days_of_month, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `days_of_month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | hours: hours, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hours` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | minutes: minutes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minutes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | seconds: seconds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `seconds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/schedule.rs:323:13 [INFO] [stderr] | [INFO] [stderr] 323 | schedule: schedule, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `schedule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/time_unit/mod.rs:31:7 [INFO] [stderr] | [INFO] [stderr] 31 | self.set_iter.next().map(|ordinal| ordinal.clone()) // No real expense; Ordinal is u32: Copy [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.set_iter.next().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/time_unit/mod.rs:31:42 [INFO] [stderr] | [INFO] [stderr] 31 | self.set_iter.next().map(|ordinal| ordinal.clone()) // No real expense; Ordinal is u32: Copy [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*ordinal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/time_unit/mod.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | self.range_iter.next().map(|ordinal| ordinal.clone()) // No real expense; Ordinal is u32: Copy [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.range_iter.next().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/time_unit/mod.rs:42:42 [INFO] [stderr] | [INFO] [stderr] 42 | self.range_iter.next().map(|ordinal| ordinal.clone()) // No real expense; Ordinal is u32: Copy [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*ordinal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/time_unit/mod.rs:113:3 [INFO] [stderr] | [INFO] [stderr] 113 | fn iter<'a>(&'a self) -> OrdinalIter<'a>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/time_unit/mod.rs:130:3 [INFO] [stderr] | [INFO] [stderr] 130 | fn range<'a, R>(&'a self, range: R) -> OrdinalRangeIter<'a> where R: RangeBounds; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/time_unit/mod.rs:150:3 [INFO] [stderr] | [INFO] [stderr] 150 | / fn iter<'a>(&'a self) -> OrdinalIter<'a> { [INFO] [stderr] 151 | | OrdinalIter { [INFO] [stderr] 152 | | set_iter: TimeUnitField::ordinals(self).iter() [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/time_unit/mod.rs:155:3 [INFO] [stderr] | [INFO] [stderr] 155 | / fn range<'a, R>(&'a self, range: R) -> OrdinalRangeIter<'a> where R: RangeBounds { [INFO] [stderr] 156 | | OrdinalRangeIter { [INFO] [stderr] 157 | | range_iter: TimeUnitField::ordinals(self).range(range) [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/time_unit/mod.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | (Self::inclusive_min()..Self::inclusive_max() + 1).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(Self::inclusive_min()..=Self::inclusive_max())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/time_unit/mod.rs:222:20 [INFO] [stderr] | [INFO] [stderr] 222 | Ok((start..Self::inclusive_max() + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(start..=Self::inclusive_max())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/time_unit/mod.rs:228:64 [INFO] [stderr] | [INFO] [stderr] 228 | (Ok(start), Ok(end)) if start <= end => Ok((start..end + 1).collect()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(start..=end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/time_unit/mod.rs:241:64 [INFO] [stderr] | [INFO] [stderr] 241 | (Ok(start), Ok(end)) if start <= end => Ok((start..end + 1).collect()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(start..=end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/schedule.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | / for second in self.seconds.ordinals().range(second_range).cloned() { [INFO] [stderr] 213 | | let timezone = after.timezone(); [INFO] [stderr] 214 | | let candidate = timezone [INFO] [stderr] 215 | | .ymd(year as i32, month, day_of_month) [INFO] [stderr] ... | [INFO] [stderr] 222 | | return Some(candidate); [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cron`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/time_unit/mod.rs:31:7 [INFO] [stderr] | [INFO] [stderr] 31 | self.set_iter.next().map(|ordinal| ordinal.clone()) // No real expense; Ordinal is u32: Copy [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.set_iter.next().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/time_unit/mod.rs:31:42 [INFO] [stderr] | [INFO] [stderr] 31 | self.set_iter.next().map(|ordinal| ordinal.clone()) // No real expense; Ordinal is u32: Copy [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*ordinal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/time_unit/mod.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | self.range_iter.next().map(|ordinal| ordinal.clone()) // No real expense; Ordinal is u32: Copy [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.range_iter.next().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/time_unit/mod.rs:42:42 [INFO] [stderr] | [INFO] [stderr] 42 | self.range_iter.next().map(|ordinal| ordinal.clone()) // No real expense; Ordinal is u32: Copy [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*ordinal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/time_unit/mod.rs:113:3 [INFO] [stderr] | [INFO] [stderr] 113 | fn iter<'a>(&'a self) -> OrdinalIter<'a>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/time_unit/mod.rs:130:3 [INFO] [stderr] | [INFO] [stderr] 130 | fn range<'a, R>(&'a self, range: R) -> OrdinalRangeIter<'a> where R: RangeBounds; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/time_unit/mod.rs:150:3 [INFO] [stderr] | [INFO] [stderr] 150 | / fn iter<'a>(&'a self) -> OrdinalIter<'a> { [INFO] [stderr] 151 | | OrdinalIter { [INFO] [stderr] 152 | | set_iter: TimeUnitField::ordinals(self).iter() [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/time_unit/mod.rs:155:3 [INFO] [stderr] | [INFO] [stderr] 155 | / fn range<'a, R>(&'a self, range: R) -> OrdinalRangeIter<'a> where R: RangeBounds { [INFO] [stderr] 156 | | OrdinalRangeIter { [INFO] [stderr] 157 | | range_iter: TimeUnitField::ordinals(self).range(range) [INFO] [stderr] 158 | | } [INFO] [stderr] 159 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/time_unit/mod.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | (Self::inclusive_min()..Self::inclusive_max() + 1).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(Self::inclusive_min()..=Self::inclusive_max())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/time_unit/mod.rs:222:20 [INFO] [stderr] | [INFO] [stderr] 222 | Ok((start..Self::inclusive_max() + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(start..=Self::inclusive_max())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/time_unit/mod.rs:228:64 [INFO] [stderr] | [INFO] [stderr] 228 | (Ok(start), Ok(end)) if start <= end => Ok((start..end + 1).collect()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(start..=end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/time_unit/mod.rs:241:64 [INFO] [stderr] | [INFO] [stderr] 241 | (Ok(start), Ok(end)) if start <= end => Ok((start..end + 1).collect()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `(start..=end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/schedule.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | / for second in self.seconds.ordinals().range(second_range).cloned() { [INFO] [stderr] 213 | | let timezone = after.timezone(); [INFO] [stderr] 214 | | let candidate = timezone [INFO] [stderr] 215 | | .ymd(year as i32, month, day_of_month) [INFO] [stderr] ... | [INFO] [stderr] 222 | | return Some(candidate); [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cron`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7c5f5a7c570b3db6498ecd74b20ca7fb6f150c8271f2649dd453b4e98bab975f"` [INFO] running `"docker" "rm" "-f" "7c5f5a7c570b3db6498ecd74b20ca7fb6f150c8271f2649dd453b4e98bab975f"` [INFO] [stdout] 7c5f5a7c570b3db6498ecd74b20ca7fb6f150c8271f2649dd453b4e98bab975f