[INFO] crate criterion 0.2.5 is already in cache [INFO] extracting crate criterion 0.2.5 into work/ex/clippy-test-run/sources/stable/reg/criterion/0.2.5 [INFO] extracting crate criterion 0.2.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/criterion/0.2.5 [INFO] validating manifest of criterion-0.2.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of criterion-0.2.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing criterion-0.2.5 [INFO] finished frobbing criterion-0.2.5 [INFO] frobbed toml for criterion-0.2.5 written to work/ex/clippy-test-run/sources/stable/reg/criterion/0.2.5/Cargo.toml [INFO] started frobbing criterion-0.2.5 [INFO] finished frobbing criterion-0.2.5 [INFO] frobbed toml for criterion-0.2.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/criterion/0.2.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting criterion-0.2.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/criterion/0.2.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2feef6b559631dcc257347adee2abc48d0980b75f389257c72564702e5c790a3 [INFO] running `"docker" "start" "-a" "2feef6b559631dcc257347adee2abc48d0980b75f389257c72564702e5c790a3"` [INFO] [stderr] Checking criterion-stats v0.2.5 [INFO] [stderr] Checking simplelog v0.5.3 [INFO] [stderr] Checking handlebars v0.32.4 [INFO] [stderr] Checking criterion-plot v0.2.7 [INFO] [stderr] Checking criterion v0.2.5 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/analysis/compare.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | #[cfg_attr(feature = "cargo-clippy", allow(type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/report.rs:333:48 [INFO] [stderr] | [INFO] [stderr] 333 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/plot/both.rs:17:44 [INFO] [stderr] | [INFO] [stderr] 17 | #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `explicit_counter_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/plot/summary.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | #[cfg_attr(feature = "cargo-clippy", allow(explicit_counter_loop))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::explicit_counter_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/analysis/compare.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | #[cfg_attr(feature = "cargo-clippy", allow(type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/analysis/compare.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | #[cfg_attr(feature = "cargo-clippy", allow(type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:124:23 [INFO] [stderr] | [INFO] [stderr] 124 | while float < 999999.9 { [INFO] [stderr] | ^^^^^^^^ help: consider: `999_999.9` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:135:24 [INFO] [stderr] | [INFO] [stderr] 135 | while float > -999999.9 { [INFO] [stderr] | ^^^^^^^^ help: consider: `999_999.9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/report.rs:333:48 [INFO] [stderr] | [INFO] [stderr] 333 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/plot/both.rs:17:44 [INFO] [stderr] | [INFO] [stderr] 17 | #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `explicit_counter_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/plot/summary.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | #[cfg_attr(feature = "cargo-clippy", allow(explicit_counter_loop))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::explicit_counter_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/analysis/compare.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | #[cfg_attr(feature = "cargo-clippy", allow(type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/plot/summary.rs:92:10 [INFO] [stderr] | [INFO] [stderr] 92 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/plot/summary.rs:137:26 [INFO] [stderr] | [INFO] [stderr] 137 | let all_curves_vec = all_curves.iter().rev().map(|&t| t).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `all_curves.iter().rev().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/plot/summary.rs:92:10 [INFO] [stderr] | [INFO] [stderr] 92 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/plot/summary.rs:137:26 [INFO] [stderr] | [INFO] [stderr] 137 | let all_curves_vec = all_curves.iter().rev().map(|&t| t).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `all_curves.iter().rev().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> benches/benchmarks/compare_functions.rs:21:14 [INFO] [stderr] | [INFO] [stderr] 21 | for _ in 0..(n + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/criterion_tests.rs:419:33 [INFO] [stderr] | [INFO] [stderr] 419 | tempdir.path().join(format!("test_output/output______")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"test_output/output______".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.36s [INFO] running `"docker" "inspect" "2feef6b559631dcc257347adee2abc48d0980b75f389257c72564702e5c790a3"` [INFO] running `"docker" "rm" "-f" "2feef6b559631dcc257347adee2abc48d0980b75f389257c72564702e5c790a3"` [INFO] [stdout] 2feef6b559631dcc257347adee2abc48d0980b75f389257c72564702e5c790a3