[INFO] crate critcmp 0.1.2 is already in cache [INFO] extracting crate critcmp 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/critcmp/0.1.2 [INFO] extracting crate critcmp 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/critcmp/0.1.2 [INFO] validating manifest of critcmp-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of critcmp-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing critcmp-0.1.2 [INFO] finished frobbing critcmp-0.1.2 [INFO] frobbed toml for critcmp-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/critcmp/0.1.2/Cargo.toml [INFO] started frobbing critcmp-0.1.2 [INFO] finished frobbing critcmp-0.1.2 [INFO] frobbed toml for critcmp-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/critcmp/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting critcmp-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/critcmp/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c43594192969f16c10f3860694bfa14718c16c0b37675f8ab95673e0d2d3ee6 [INFO] running `"docker" "start" "-a" "9c43594192969f16c10f3860694bfa14718c16c0b37675f8ab95673e0d2d3ee6"` [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking tabwriter v1.1.0 [INFO] [stderr] Checking grep-cli v0.1.1 [INFO] [stderr] Checking critcmp v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | benchmarks: benchmarks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `benchmarks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(wtr, "")` [INFO] [stderr] --> src/output.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | writeln!(wtr, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(wtr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(wtr, "")` [INFO] [stderr] --> src/output.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | writeln!(wtr, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(wtr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(wtr, "")` [INFO] [stderr] --> src/output.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | writeln!(wtr, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(wtr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(wtr, "")` [INFO] [stderr] --> src/output.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | writeln!(wtr, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(wtr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(wtr, "")` [INFO] [stderr] --> src/output.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | writeln!(wtr, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(wtr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(stdout, "")` [INFO] [stderr] --> src/main.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | writeln!(stdout, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(stdout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | benchmarks: benchmarks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `benchmarks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(wtr, "")` [INFO] [stderr] --> src/output.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | writeln!(wtr, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(wtr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(wtr, "")` [INFO] [stderr] --> src/output.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | writeln!(wtr, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(wtr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(wtr, "")` [INFO] [stderr] --> src/output.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | writeln!(wtr, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(wtr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(wtr, "")` [INFO] [stderr] --> src/output.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | writeln!(wtr, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(wtr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(wtr, "")` [INFO] [stderr] --> src/output.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | writeln!(wtr, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(wtr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(stdout, "")` [INFO] [stderr] --> src/main.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | writeln!(stdout, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(stdout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | const TEMPLATE: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | const ABOUT: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | const TEMPLATE: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | const ABOUT: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/output.rs:230:40 [INFO] [stderr] | [INFO] [stderr] 230 | format!("{:.1} KB/sec", (per / (1<<10) as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(1<<10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/output.rs:232:40 [INFO] [stderr] | [INFO] [stderr] 232 | format!("{:.1} MB/sec", (per / (1<<20) as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(1<<20)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/output.rs:234:40 [INFO] [stderr] | [INFO] [stderr] 234 | format!("{:.1} GB/sec", (per / (1<<30) as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(1<<30)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | .or_insert(vec![]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:133:18 [INFO] [stderr] | [INFO] [stderr] 133 | .or_insert(vec![]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/output.rs:230:40 [INFO] [stderr] | [INFO] [stderr] 230 | format!("{:.1} KB/sec", (per / (1<<10) as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(1<<10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/output.rs:232:40 [INFO] [stderr] | [INFO] [stderr] 232 | format!("{:.1} MB/sec", (per / (1<<20) as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(1<<20)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/output.rs:234:40 [INFO] [stderr] | [INFO] [stderr] 234 | format!("{:.1} GB/sec", (per / (1<<30) as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(1<<30)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | .or_insert(vec![]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:133:18 [INFO] [stderr] | [INFO] [stderr] 133 | .or_insert(vec![]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.10s [INFO] running `"docker" "inspect" "9c43594192969f16c10f3860694bfa14718c16c0b37675f8ab95673e0d2d3ee6"` [INFO] running `"docker" "rm" "-f" "9c43594192969f16c10f3860694bfa14718c16c0b37675f8ab95673e0d2d3ee6"` [INFO] [stdout] 9c43594192969f16c10f3860694bfa14718c16c0b37675f8ab95673e0d2d3ee6