[INFO] crate crisp-status-local 1.1.0 is already in cache [INFO] extracting crate crisp-status-local 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/crisp-status-local/1.1.0 [INFO] extracting crate crisp-status-local 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crisp-status-local/1.1.0 [INFO] validating manifest of crisp-status-local-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of crisp-status-local-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing crisp-status-local-1.1.0 [INFO] finished frobbing crisp-status-local-1.1.0 [INFO] frobbed toml for crisp-status-local-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/crisp-status-local/1.1.0/Cargo.toml [INFO] started frobbing crisp-status-local-1.1.0 [INFO] finished frobbing crisp-status-local-1.1.0 [INFO] frobbed toml for crisp-status-local-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crisp-status-local/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting crisp-status-local-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/crisp-status-local/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0828139c59ae1b4d040186433035607afbdb259088f1e2101974c2f821590adf [INFO] running `"docker" "start" "-a" "0828139c59ae1b4d040186433035607afbdb259088f1e2101974c2f821590adf"` [INFO] [stderr] Checking crisp-status-local v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/probe/report.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | interval: interval, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `interval` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/probe/report.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | interval: interval, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `interval` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/config/mod.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub mod config; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/config/mod.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub mod config; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/probe/status.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &Status::Healthy => "healthy", [INFO] [stderr] 18 | | &Status::Sick => "sick", [INFO] [stderr] 19 | | &Status::Dead => "dead", [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | Status::Healthy => "healthy", [INFO] [stderr] 18 | Status::Sick => "sick", [INFO] [stderr] 19 | Status::Dead => "dead", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/probe/replica.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match self { [INFO] [stderr] 50 | | &ReplicaURL::TCP(ref raw_url, _, _) => raw_url, [INFO] [stderr] 51 | | &ReplicaURL::HTTP(ref raw_url, _) => raw_url, [INFO] [stderr] 52 | | &ReplicaURL::HTTPS(ref raw_url, _) => raw_url, [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *self { [INFO] [stderr] 50 | ReplicaURL::TCP(ref raw_url, _, _) => raw_url, [INFO] [stderr] 51 | ReplicaURL::HTTP(ref raw_url, _) => raw_url, [INFO] [stderr] 52 | ReplicaURL::HTTPS(ref raw_url, _) => raw_url, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/probe/poll.rs:25:27 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn dispatch(services: &Vec, metrics: &Option, interval: u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[MapService]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/probe/poll.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | let retry_times = if let &Some(ref metrics_inner) = metrics { [INFO] [stderr] | _______________________^ [INFO] [stderr] 62 | | metrics_inner.local.retry [INFO] [stderr] 63 | | } else { [INFO] [stderr] 64 | | 2 [INFO] [stderr] 65 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 61 | let retry_times = if let Some(ref metrics_inner) = *metrics { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/probe/poll.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | let is_up = match replica { [INFO] [stderr] | _________________^ [INFO] [stderr] 139 | | &ReplicaURL::TCP(_, ref host, port) => proceed_replica_request_tcp(host, port, metrics), [INFO] [stderr] 140 | | &ReplicaURL::HTTP(_, ref url) => proceed_replica_request_http(url, http, metrics), [INFO] [stderr] 141 | | &ReplicaURL::HTTPS(_, ref url) => proceed_replica_request_http(url, http, metrics), [INFO] [stderr] 142 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 138 | let is_up = match *replica { [INFO] [stderr] 139 | ReplicaURL::TCP(_, ref host, port) => proceed_replica_request_tcp(host, port, metrics), [INFO] [stderr] 140 | ReplicaURL::HTTP(_, ref url) => proceed_replica_request_http(url, http, metrics), [INFO] [stderr] 141 | ReplicaURL::HTTPS(_, ref url) => proceed_replica_request_http(url, http, metrics), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/probe/poll.rs:144:8 [INFO] [stderr] | [INFO] [stderr] 144 | if is_up == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `is_up` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/probe/poll.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | / if let &Some(ref metrics_inner) = metrics { [INFO] [stderr] 148 | | if duration_since >= Duration::from_secs(metrics_inner.local.delay_sick) { [INFO] [stderr] 149 | | return Status::Sick; [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 147 | if let Some(ref metrics_inner) = *metrics { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/probe/poll.rs:167:20 [INFO] [stderr] | [INFO] [stderr] 167 | return match TcpStream::connect_timeout( [INFO] [stderr] | ____________________^ [INFO] [stderr] 168 | | &address_value, [INFO] [stderr] 169 | | acquire_dead_timeout(metrics), [INFO] [stderr] 170 | | ) { [INFO] [stderr] 171 | | Ok(_) => true, [INFO] [stderr] 172 | | Err(_) => false, [INFO] [stderr] 173 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 167 | return TcpStream::connect_timeout( [INFO] [stderr] 168 | &address_value, [INFO] [stderr] 169 | acquire_dead_timeout(metrics), [INFO] [stderr] 170 | ).is_ok(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/probe/status.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match self { [INFO] [stderr] 17 | | &Status::Healthy => "healthy", [INFO] [stderr] 18 | | &Status::Sick => "sick", [INFO] [stderr] 19 | | &Status::Dead => "dead", [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/probe/poll.rs:193:20 [INFO] [stderr] | [INFO] [stderr] 193 | if healthy_match_inner.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!healthy_match_inner.is_empty()` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *self { [INFO] [stderr] 17 | Status::Healthy => "healthy", [INFO] [stderr] 18 | Status::Sick => "sick", [INFO] [stderr] 19 | Status::Dead => "dead", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/probe/poll.rs:213:23 [INFO] [stderr] | [INFO] [stderr] 213 | let response = if http_body_healthy_match.is_some() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `http_body_healthy_match.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/probe/poll.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | / if let &Some(ref http_inner) = http { [INFO] [stderr] 233 | | if let Some(ref http_inner_status_inner) = http_inner.status { [INFO] [stderr] 234 | | if let Some(healthy_above_inner) = http_inner_status_inner.healthy_above { [INFO] [stderr] 235 | | http_healthy_above = healthy_above_inner; [INFO] [stderr] ... | [INFO] [stderr] 241 | | } [INFO] [stderr] 242 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 232 | if let Some(ref http_inner) = *http { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/probe/poll.rs:256:24 [INFO] [stderr] | [INFO] [stderr] 256 | if text.contains(http_body_healthy_match_inner) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!text.contains(http_body_healthy_match_inner)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/probe/poll.rs:278:25 [INFO] [stderr] | [INFO] [stderr] 278 | Duration::from_secs(if let &Some(ref metrics_inner) = metrics { [INFO] [stderr] | _________________________^ [INFO] [stderr] 279 | | metrics_inner.local.delay_dead [INFO] [stderr] 280 | | } else { [INFO] [stderr] 281 | | 20 [INFO] [stderr] 282 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 278 | Duration::from_secs(if let Some(ref metrics_inner) = *metrics { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/probe/replica.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match self { [INFO] [stderr] 50 | | &ReplicaURL::TCP(ref raw_url, _, _) => raw_url, [INFO] [stderr] 51 | | &ReplicaURL::HTTP(ref raw_url, _) => raw_url, [INFO] [stderr] 52 | | &ReplicaURL::HTTPS(ref raw_url, _) => raw_url, [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *self { [INFO] [stderr] 50 | ReplicaURL::TCP(ref raw_url, _, _) => raw_url, [INFO] [stderr] 51 | ReplicaURL::HTTP(ref raw_url, _) => raw_url, [INFO] [stderr] 52 | ReplicaURL::HTTPS(ref raw_url, _) => raw_url, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/probe/poll.rs:25:27 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn dispatch(services: &Vec, metrics: &Option, interval: u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[MapService]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/probe/poll.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | let retry_times = if let &Some(ref metrics_inner) = metrics { [INFO] [stderr] | _______________________^ [INFO] [stderr] 62 | | metrics_inner.local.retry [INFO] [stderr] 63 | | } else { [INFO] [stderr] 64 | | 2 [INFO] [stderr] 65 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 61 | let retry_times = if let Some(ref metrics_inner) = *metrics { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused return value of `lazy_static::Deref::deref` that must be used [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | APP_ARGS.deref(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused return value of `lazy_static::Deref::deref` that must be used [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | APP_CONF.deref(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused return value of `lazy_static::Deref::deref` that must be used [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | REPORT_HTTP_CLIENT.deref(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/probe/poll.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | let is_up = match replica { [INFO] [stderr] | _________________^ [INFO] [stderr] 139 | | &ReplicaURL::TCP(_, ref host, port) => proceed_replica_request_tcp(host, port, metrics), [INFO] [stderr] 140 | | &ReplicaURL::HTTP(_, ref url) => proceed_replica_request_http(url, http, metrics), [INFO] [stderr] 141 | | &ReplicaURL::HTTPS(_, ref url) => proceed_replica_request_http(url, http, metrics), [INFO] [stderr] 142 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 138 | let is_up = match *replica { [INFO] [stderr] 139 | ReplicaURL::TCP(_, ref host, port) => proceed_replica_request_tcp(host, port, metrics), [INFO] [stderr] 140 | ReplicaURL::HTTP(_, ref url) => proceed_replica_request_http(url, http, metrics), [INFO] [stderr] 141 | ReplicaURL::HTTPS(_, ref url) => proceed_replica_request_http(url, http, metrics), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/probe/poll.rs:144:8 [INFO] [stderr] | [INFO] [stderr] 144 | if is_up == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `is_up` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:91:8 [INFO] [stderr] | [INFO] [stderr] 91 | if has_error == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `has_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/probe/poll.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | / if let &Some(ref metrics_inner) = metrics { [INFO] [stderr] 148 | | if duration_since >= Duration::from_secs(metrics_inner.local.delay_sick) { [INFO] [stderr] 149 | | return Status::Sick; [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 147 | if let Some(ref metrics_inner) = *metrics { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/probe/poll.rs:167:20 [INFO] [stderr] | [INFO] [stderr] 167 | return match TcpStream::connect_timeout( [INFO] [stderr] | ____________________^ [INFO] [stderr] 168 | | &address_value, [INFO] [stderr] 169 | | acquire_dead_timeout(metrics), [INFO] [stderr] 170 | | ) { [INFO] [stderr] 171 | | Ok(_) => true, [INFO] [stderr] 172 | | Err(_) => false, [INFO] [stderr] 173 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 167 | return TcpStream::connect_timeout( [INFO] [stderr] 168 | &address_value, [INFO] [stderr] 169 | acquire_dead_timeout(metrics), [INFO] [stderr] 170 | ).is_ok(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/probe/poll.rs:193:20 [INFO] [stderr] | [INFO] [stderr] 193 | if healthy_match_inner.is_empty() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!healthy_match_inner.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/probe/poll.rs:213:23 [INFO] [stderr] | [INFO] [stderr] 213 | let response = if http_body_healthy_match.is_some() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `http_body_healthy_match.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/probe/poll.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | / if let &Some(ref http_inner) = http { [INFO] [stderr] 233 | | if let Some(ref http_inner_status_inner) = http_inner.status { [INFO] [stderr] 234 | | if let Some(healthy_above_inner) = http_inner_status_inner.healthy_above { [INFO] [stderr] 235 | | http_healthy_above = healthy_above_inner; [INFO] [stderr] ... | [INFO] [stderr] 241 | | } [INFO] [stderr] 242 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 232 | if let Some(ref http_inner) = *http { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/probe/poll.rs:256:24 [INFO] [stderr] | [INFO] [stderr] 256 | if text.contains(http_body_healthy_match_inner) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!text.contains(http_body_healthy_match_inner)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/probe/poll.rs:278:25 [INFO] [stderr] | [INFO] [stderr] 278 | Duration::from_secs(if let &Some(ref metrics_inner) = metrics { [INFO] [stderr] | _________________________^ [INFO] [stderr] 279 | | metrics_inner.local.delay_dead [INFO] [stderr] 280 | | } else { [INFO] [stderr] 281 | | 20 [INFO] [stderr] 282 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 278 | Duration::from_secs(if let Some(ref metrics_inner) = *metrics { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused return value of `lazy_static::Deref::deref` that must be used [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | APP_ARGS.deref(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused return value of `lazy_static::Deref::deref` that must be used [INFO] [stderr] --> src/main.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | APP_CONF.deref(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused return value of `lazy_static::Deref::deref` that must be used [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | REPORT_HTTP_CLIENT.deref(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:91:8 [INFO] [stderr] | [INFO] [stderr] 91 | if has_error == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `has_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.21s [INFO] running `"docker" "inspect" "0828139c59ae1b4d040186433035607afbdb259088f1e2101974c2f821590adf"` [INFO] running `"docker" "rm" "-f" "0828139c59ae1b4d040186433035607afbdb259088f1e2101974c2f821590adf"` [INFO] [stdout] 0828139c59ae1b4d040186433035607afbdb259088f1e2101974c2f821590adf