[INFO] crate credibility 0.1.3 is already in cache [INFO] extracting crate credibility 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/credibility/0.1.3 [INFO] extracting crate credibility 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/credibility/0.1.3 [INFO] validating manifest of credibility-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of credibility-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing credibility-0.1.3 [INFO] finished frobbing credibility-0.1.3 [INFO] frobbed toml for credibility-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/credibility/0.1.3/Cargo.toml [INFO] started frobbing credibility-0.1.3 [INFO] finished frobbing credibility-0.1.3 [INFO] frobbed toml for credibility-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/credibility/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting credibility-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/credibility/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 860f2e048a74711b98c066cd9a38c3c3bef8be4b805ac0222e2517f65e359da0 [INFO] running `"docker" "start" "-a" "860f2e048a74711b98c066cd9a38c3c3bef8be4b805ac0222e2517f65e359da0"` [INFO] [stderr] Checking credibility v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/test_reporter.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / match catch_unwind(|| { [INFO] [stderr] 13 | | test_block!(_inner_tb, "Block with a default test reporter", { [INFO] [stderr] 14 | | panic!("hey hey"); [INFO] [stderr] 15 | | }); [INFO] [stderr] ... | [INFO] [stderr] 18 | | Err(_) => {} // Ok. [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | if let Ok(_) = catch_unwind(|| { [INFO] [stderr] 13 | test_block!(_inner_tb, "Block with a default test reporter", { [INFO] [stderr] 14 | panic!("hey hey"); [INFO] [stderr] 15 | }); [INFO] [stderr] 16 | }) { panic!("Should have properly panicked") } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> tests/test_reporter.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | catch_unwind(|| { [INFO] [stderr] | _________________________^ [INFO] [stderr] 26 | | test_block!(inner_tb, "Block with a default test reporter", { [INFO] [stderr] 27 | | aver!(inner_tb, false, "Executed"); [INFO] [stderr] 28 | | aver!(inner_tb, false, "Also executed"); [INFO] [stderr] 29 | | Ok(()) [INFO] [stderr] 30 | | }); [INFO] [stderr] 31 | | }).is_err() [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> tests/test_reporter.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | catch_unwind(|| { [INFO] [stderr] | _________________________^ [INFO] [stderr] 39 | | test_block!(inner_tb, "Block with a default test reporter", { [INFO] [stderr] 40 | | Err(format_err!("I should fail!")) [INFO] [stderr] 41 | | }); [INFO] [stderr] 42 | | }).is_err() [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.38s [INFO] running `"docker" "inspect" "860f2e048a74711b98c066cd9a38c3c3bef8be4b805ac0222e2517f65e359da0"` [INFO] running `"docker" "rm" "-f" "860f2e048a74711b98c066cd9a38c3c3bef8be4b805ac0222e2517f65e359da0"` [INFO] [stdout] 860f2e048a74711b98c066cd9a38c3c3bef8be4b805ac0222e2517f65e359da0