[INFO] crate credentials 0.10.0 is already in cache [INFO] extracting crate credentials 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/credentials/0.10.0 [INFO] extracting crate credentials 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/credentials/0.10.0 [INFO] validating manifest of credentials-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of credentials-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing credentials-0.10.0 [INFO] finished frobbing credentials-0.10.0 [INFO] frobbed toml for credentials-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/credentials/0.10.0/Cargo.toml [INFO] started frobbing credentials-0.10.0 [INFO] finished frobbing credentials-0.10.0 [INFO] frobbed toml for credentials-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/credentials/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting credentials-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/credentials/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5cf8dda2422a23d256dff3b1ca0ebc92da1979ee7fa4043186a9fddaf23325be [INFO] running `"docker" "start" "-a" "5cf8dda2422a23d256dff3b1ca0ebc92da1979ee7fa4043186a9fddaf23325be"` [INFO] [stderr] Checking credentials v0.10.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vault/mod.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vault/mod.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | secretfile: secretfile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secretfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vault/mod.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vault/mod.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | secretfile: secretfile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `secretfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | let result = match client_cell.borrow_mut().deref_mut() { [INFO] [stderr] | __________________^ [INFO] [stderr] 187 | | &mut Some(ref mut client) => body(client), [INFO] [stderr] 188 | | // We theoretically handed this just above, and exited if we [INFO] [stderr] 189 | | // failed. [INFO] [stderr] 190 | | &mut None => panic!("Should have a client, but we don't"), [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/vault/mod.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | let mut path = env::home_dir().ok_or(Error::NoHomeDirectory)?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | let result = match client_cell.borrow_mut().deref_mut() { [INFO] [stderr] | __________________^ [INFO] [stderr] 187 | | &mut Some(ref mut client) => body(client), [INFO] [stderr] 188 | | // We theoretically handed this just above, and exited if we [INFO] [stderr] 189 | | // failed. [INFO] [stderr] 190 | | &mut None => panic!("Should have a client, but we don't"), [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/vault/mod.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | let mut path = env::home_dir().ok_or(Error::NoHomeDirectory)?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/secretfile.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | / pub fn from_str>(s: S) -> Result { [INFO] [stderr] 171 | | let mut cursor = io::Cursor::new(s.as_ref().as_bytes()); [INFO] [stderr] 172 | | Secretfile::read(&mut cursor) [INFO] [stderr] 173 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/secretfile.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | / pub fn from_str>(s: S) -> Result { [INFO] [stderr] 171 | | let mut cursor = io::Cursor::new(s.as_ref().as_bytes()); [INFO] [stderr] 172 | | Secretfile::read(&mut cursor) [INFO] [stderr] 173 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/vault/mod.rs:163:30 [INFO] [stderr] | [INFO] [stderr] 163 | let secret = self.secrets.get(path).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.secrets[path]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | let result = match client_cell.borrow_mut().deref_mut() { [INFO] [stderr] | __________________^ [INFO] [stderr] 187 | | &mut Some(ref mut client) => body(client), [INFO] [stderr] 188 | | // We theoretically handed this just above, and exited if we [INFO] [stderr] 189 | | // failed. [INFO] [stderr] 190 | | &mut None => panic!("Should have a client, but we don't"), [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 186 | let result = match *client_cell.borrow_mut().deref_mut() { [INFO] [stderr] 187 | Some(ref mut client) => body(client), [INFO] [stderr] 188 | // We theoretically handed this just above, and exited if we [INFO] [stderr] 189 | // failed. [INFO] [stderr] 190 | None => panic!("Should have a client, but we don't"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/vault/mod.rs:163:30 [INFO] [stderr] | [INFO] [stderr] 163 | let secret = self.secrets.get(path).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.secrets[path]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | let result = match client_cell.borrow_mut().deref_mut() { [INFO] [stderr] | __________________^ [INFO] [stderr] 187 | | &mut Some(ref mut client) => body(client), [INFO] [stderr] 188 | | // We theoretically handed this just above, and exited if we [INFO] [stderr] 189 | | // failed. [INFO] [stderr] 190 | | &mut None => panic!("Should have a client, but we don't"), [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 186 | let result = match *client_cell.borrow_mut().deref_mut() { [INFO] [stderr] 187 | Some(ref mut client) => body(client), [INFO] [stderr] 188 | // We theoretically handed this just above, and exited if we [INFO] [stderr] 189 | // failed. [INFO] [stderr] 190 | None => panic!("Should have a client, but we don't"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.64s [INFO] running `"docker" "inspect" "5cf8dda2422a23d256dff3b1ca0ebc92da1979ee7fa4043186a9fddaf23325be"` [INFO] running `"docker" "rm" "-f" "5cf8dda2422a23d256dff3b1ca0ebc92da1979ee7fa4043186a9fddaf23325be"` [INFO] [stdout] 5cf8dda2422a23d256dff3b1ca0ebc92da1979ee7fa4043186a9fddaf23325be