[INFO] crate crdts 1.3.0 is already in cache
[INFO] extracting crate crdts 1.3.0 into work/ex/clippy-test-run/sources/stable/reg/crdts/1.3.0
[INFO] extracting crate crdts 1.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crdts/1.3.0
[INFO] validating manifest of crdts-1.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of crdts-1.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing crdts-1.3.0
[INFO] removed 0 missing tests
[INFO] finished frobbing crdts-1.3.0
[INFO] frobbed toml for crdts-1.3.0 written to work/ex/clippy-test-run/sources/stable/reg/crdts/1.3.0/Cargo.toml
[INFO] started frobbing crdts-1.3.0
[INFO] removed 0 missing tests
[INFO] finished frobbing crdts-1.3.0
[INFO] frobbed toml for crdts-1.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crdts/1.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting crdts-1.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/crdts/1.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ca5a913366e413e3b6363ac0270f18b74cbaa23d120304682208b7ae8399657b
[INFO] running `"docker" "start" "-a" "ca5a913366e413e3b6363ac0270f18b74cbaa23d120304682208b7ae8399657b"`
[INFO] [stderr]     Checking crdts v1.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/vclock.rs:214:18
[INFO] [stderr]     |
[INFO] [stderr] 214 |         VClock { dots: dots }
[INFO] [stderr]     |                  ^^^^^^^^^^ help: replace it with: `dots`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/vclock.rs:228:18
[INFO] [stderr]     |
[INFO] [stderr] 228 |         VClock { dots: dots }
[INFO] [stderr]     |                  ^^^^^^^^^^ help: replace it with: `dots`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/orswot.rs:247:21
[INFO] [stderr]     |
[INFO] [stderr] 247 |                     ctx: ctx,
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `ctx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/orswot.rs:262:29
[INFO] [stderr]     |
[INFO] [stderr] 262 |                             member: member,
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^ help: replace it with: `member`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/orswot.rs:263:29
[INFO] [stderr]     |
[INFO] [stderr] 263 |                             actor: actor,
[INFO] [stderr]     |                             ^^^^^^^^^^^^ help: replace it with: `actor`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/orswot.rs:299:21
[INFO] [stderr]     |
[INFO] [stderr] 299 |             OpVec { ops: ops }
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `ops`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pncounter.rs:139:21
[INFO] [stderr]     |
[INFO] [stderr] 139 |             OpVec { ops: ops }
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `ops`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/vclock.rs:214:18
[INFO] [stderr]     |
[INFO] [stderr] 214 |         VClock { dots: dots }
[INFO] [stderr]     |                  ^^^^^^^^^^ help: replace it with: `dots`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/vclock.rs:228:18
[INFO] [stderr]     |
[INFO] [stderr] 228 |         VClock { dots: dots }
[INFO] [stderr]     |                  ^^^^^^^^^^ help: replace it with: `dots`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/orswot.rs:247:21
[INFO] [stderr]     |
[INFO] [stderr] 247 |                     ctx: ctx,
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `ctx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/orswot.rs:262:29
[INFO] [stderr]     |
[INFO] [stderr] 262 |                             member: member,
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^ help: replace it with: `member`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/orswot.rs:263:29
[INFO] [stderr]     |
[INFO] [stderr] 263 |                             actor: actor,
[INFO] [stderr]     |                             ^^^^^^^^^^^^ help: replace it with: `actor`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/orswot.rs:299:21
[INFO] [stderr]     |
[INFO] [stderr] 299 |             OpVec { ops: ops }
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `ops`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/pncounter.rs:139:21
[INFO] [stderr]     |
[INFO] [stderr] 139 |             OpVec { ops: ops }
[INFO] [stderr]     |                     ^^^^^^^^ help: replace it with: `ops`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]   --> src/vclock.rs:45:50
[INFO] [stderr]    |
[INFO] [stderr] 45 |           } else if other.dots.iter().all(|(w, c)| {
[INFO] [stderr]    |  __________________________________________________^
[INFO] [stderr] 46 | |             self.contains_descendent_element(w, c)
[INFO] [stderr] 47 | |         })
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]   --> src/vclock.rs:50:49
[INFO] [stderr]    |
[INFO] [stderr] 50 |           } else if self.dots.iter().all(|(w, c)| {
[INFO] [stderr]    |  _________________________________________________^
[INFO] [stderr] 51 | |             other.contains_descendent_element(w, c)
[INFO] [stderr] 52 | |         })
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vclock::VClock<A>`
[INFO] [stderr]   --> src/vclock.rs:63:5
[INFO] [stderr]    |
[INFO] [stderr] 63 | /     pub fn new() -> VClock<A> {
[INFO] [stderr] 64 | |         VClock { dots: BTreeMap::new() }
[INFO] [stderr] 65 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 36 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/vclock.rs:105:20
[INFO] [stderr]     |
[INFO] [stderr] 105 |         let next = self.dots.get(&actor).map(|c| *c).unwrap_or(0) + 1;
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.dots.get(&actor).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/vclock.rs:140:18
[INFO] [stderr]     |
[INFO] [stderr] 140 |         counter: &Counter,
[INFO] [stderr]     |                  ^^^^^^^^ help: consider passing by value instead: `Counter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/vclock.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 |         self.dots.get(actor).map(|counter| *counter)
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.dots.get(actor).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/vclock.rs:180:25
[INFO] [stderr]     |
[INFO] [stderr] 180 |             let other = dots.get(actor).map(|c| *c).unwrap_or(0);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `dots.get(actor).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `orswot::Orswot<Member, Actor>`
[INFO] [stderr]   --> src/orswot.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     pub fn new() -> Orswot<Member, Actor> {
[INFO] [stderr] 30 | |         Orswot {
[INFO] [stderr] 31 | |             clock: VClock::new(),
[INFO] [stderr] 32 | |             entries: BTreeMap::new(),
[INFO] [stderr] 33 | |             deferred: BTreeMap::new(),
[INFO] [stderr] 34 | |         }
[INFO] [stderr] 35 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 24 | impl Default for orswot::Orswot<Member, Actor> {
[INFO] [stderr] 25 |     fn default() -> Self {
[INFO] [stderr] 26 |         Self::new()
[INFO] [stderr] 27 |     }
[INFO] [stderr] 28 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/orswot.rs:83:17
[INFO] [stderr]    |
[INFO] [stderr] 83 |                 self.deferred.remove(context).unwrap_or(BTreeSet::new());
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.deferred.remove(context).unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/orswot.rs:175:17
[INFO] [stderr]     |
[INFO] [stderr] 175 |                 self.deferred.remove(&clock).unwrap_or(BTreeSet::new());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.deferred.remove(&clock).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly
[INFO] [stderr]   --> src/gcounter.rs:20:28
[INFO] [stderr]    |
[INFO] [stderr] 20 | #[derive(Debug, Eq, Clone, Hash, Serialize, Deserialize)]
[INFO] [stderr]    |                            ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::derive_hash_xor_eq)] on by default
[INFO] [stderr] note: `PartialEq` implemented here
[INFO] [stderr]   --> src/gcounter.rs:38:1
[INFO] [stderr]    |
[INFO] [stderr] 38 | / impl<A: Ord + Clone + Serialize + DeserializeOwned> PartialEq for GCounter<A> {
[INFO] [stderr] 39 | |     fn eq(&self, other: &GCounter<A>) -> bool {
[INFO] [stderr] 40 | |         let (c, oc) = (self.value(), other.value());
[INFO] [stderr] 41 | |         c == oc
[INFO] [stderr] 42 | |     }
[INFO] [stderr] 43 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `gcounter::GCounter<A>`
[INFO] [stderr]   --> src/gcounter.rs:47:5
[INFO] [stderr]    |
[INFO] [stderr] 47 | /     pub fn new() -> GCounter<A> {
[INFO] [stderr] 48 | |         GCounter { inner: VClock::new() }
[INFO] [stderr] 49 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 45 | impl Default for gcounter::GCounter<A> {
[INFO] [stderr] 46 |     fn default() -> Self {
[INFO] [stderr] 47 |         Self::new()
[INFO] [stderr] 48 |     }
[INFO] [stderr] 49 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/gcounter.rs:58:33
[INFO] [stderr]    |
[INFO] [stderr] 58 |         self.inner.dots.values().fold(0, |acc, count| acc + count)
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly
[INFO] [stderr]   --> src/pncounter.rs:24:28
[INFO] [stderr]    |
[INFO] [stderr] 24 | #[derive(Debug, Eq, Clone, Hash, Serialize, Deserialize)]
[INFO] [stderr]    |                            ^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: `PartialEq` implemented here
[INFO] [stderr]   --> src/pncounter.rs:44:1
[INFO] [stderr]    |
[INFO] [stderr] 44 | / impl<A: Ord + Clone + Serialize + DeserializeOwned> PartialEq for PNCounter<A> {
[INFO] [stderr] 45 | |     fn eq(&self, other: &PNCounter<A>) -> bool {
[INFO] [stderr] 46 | |         let (c, oc) = (self.value(), other.value());
[INFO] [stderr] 47 | |         c == oc
[INFO] [stderr] 48 | |     }
[INFO] [stderr] 49 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `pncounter::PNCounter<A>`
[INFO] [stderr]   --> src/pncounter.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 | /     pub fn new() -> PNCounter<A> {
[INFO] [stderr] 54 | |         PNCounter {
[INFO] [stderr] 55 | |             p: GCounter::new(),
[INFO] [stderr] 56 | |             n: GCounter::new(),
[INFO] [stderr] 57 | |         }
[INFO] [stderr] 58 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 51 | impl Default for pncounter::PNCounter<A> {
[INFO] [stderr] 52 |     fn default() -> Self {
[INFO] [stderr] 53 |         Self::new()
[INFO] [stderr] 54 |     }
[INFO] [stderr] 55 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `crdts`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]   --> src/vclock.rs:45:50
[INFO] [stderr]    |
[INFO] [stderr] 45 |           } else if other.dots.iter().all(|(w, c)| {
[INFO] [stderr]    |  __________________________________________________^
[INFO] [stderr] 46 | |             self.contains_descendent_element(w, c)
[INFO] [stderr] 47 | |         })
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]   --> src/vclock.rs:50:49
[INFO] [stderr]    |
[INFO] [stderr] 50 |           } else if self.dots.iter().all(|(w, c)| {
[INFO] [stderr]    |  _________________________________________________^
[INFO] [stderr] 51 | |             other.contains_descendent_element(w, c)
[INFO] [stderr] 52 | |         })
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vclock::VClock<A>`
[INFO] [stderr]   --> src/vclock.rs:63:5
[INFO] [stderr]    |
[INFO] [stderr] 63 | /     pub fn new() -> VClock<A> {
[INFO] [stderr] 64 | |         VClock { dots: BTreeMap::new() }
[INFO] [stderr] 65 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 36 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/vclock.rs:105:20
[INFO] [stderr]     |
[INFO] [stderr] 105 |         let next = self.dots.get(&actor).map(|c| *c).unwrap_or(0) + 1;
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.dots.get(&actor).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/vclock.rs:140:18
[INFO] [stderr]     |
[INFO] [stderr] 140 |         counter: &Counter,
[INFO] [stderr]     |                  ^^^^^^^^ help: consider passing by value instead: `Counter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/vclock.rs:165:9
[INFO] [stderr]     |
[INFO] [stderr] 165 |         self.dots.get(actor).map(|counter| *counter)
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.dots.get(actor).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/vclock.rs:180:25
[INFO] [stderr]     |
[INFO] [stderr] 180 |             let other = dots.get(actor).map(|c| *c).unwrap_or(0);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `dots.get(actor).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `orswot::Orswot<Member, Actor>`
[INFO] [stderr]   --> src/orswot.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     pub fn new() -> Orswot<Member, Actor> {
[INFO] [stderr] 30 | |         Orswot {
[INFO] [stderr] 31 | |             clock: VClock::new(),
[INFO] [stderr] 32 | |             entries: BTreeMap::new(),
[INFO] [stderr] 33 | |             deferred: BTreeMap::new(),
[INFO] [stderr] 34 | |         }
[INFO] [stderr] 35 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 24 | impl Default for orswot::Orswot<Member, Actor> {
[INFO] [stderr] 25 |     fn default() -> Self {
[INFO] [stderr] 26 |         Self::new()
[INFO] [stderr] 27 |     }
[INFO] [stderr] 28 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/orswot.rs:83:17
[INFO] [stderr]    |
[INFO] [stderr] 83 |                 self.deferred.remove(context).unwrap_or(BTreeSet::new());
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.deferred.remove(context).unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/orswot.rs:175:17
[INFO] [stderr]     |
[INFO] [stderr] 175 |                 self.deferred.remove(&clock).unwrap_or(BTreeSet::new());
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.deferred.remove(&clock).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/orswot.rs:253:13
[INFO] [stderr]     |
[INFO] [stderr] 253 | /             match self {
[INFO] [stderr] 254 | |                 &Op::Remove {
[INFO] [stderr] 255 | |                     ctx: Some(ref ctx),
[INFO] [stderr] 256 | |                     member,
[INFO] [stderr] ...   |
[INFO] [stderr] 267 | |                 _ => Box::new(vec![].into_iter()),
[INFO] [stderr] 268 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 253 |             match *self {
[INFO] [stderr] 254 |                 Op::Remove {
[INFO] [stderr] 255 |                     ctx: Some(ref ctx),
[INFO] [stderr] 256 |                     member,
[INFO] [stderr] 257 |                     actor,
[INFO] [stderr] 258 |                 } => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/orswot.rs:289:46
[INFO] [stderr]     |
[INFO] [stderr] 289 |                             seen_adds.insert(member.clone());
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^ help: try removing the `clone` call: `member`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/orswot.rs:325:17
[INFO] [stderr]     |
[INFO] [stderr] 325 | /                 match op {
[INFO] [stderr] 326 | |                     &Op::Add { member, actor } => {
[INFO] [stderr] 327 | |                         witnesses[(actor % i) as usize].add(member, actor);
[INFO] [stderr] 328 | |                     }
[INFO] [stderr] ...   |
[INFO] [stderr] 345 | |                     }
[INFO] [stderr] 346 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 325 |                 match *op {
[INFO] [stderr] 326 |                     Op::Add { member, actor } => {
[INFO] [stderr] 327 |                         witnesses[(actor % i) as usize].add(member, actor);
[INFO] [stderr] 328 |                     }
[INFO] [stderr] 329 |                     Op::Remove {
[INFO] [stderr] 330 |                         ctx: None,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly
[INFO] [stderr]   --> src/gcounter.rs:20:28
[INFO] [stderr]    |
[INFO] [stderr] 20 | #[derive(Debug, Eq, Clone, Hash, Serialize, Deserialize)]
[INFO] [stderr]    |                            ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::derive_hash_xor_eq)] on by default
[INFO] [stderr] note: `PartialEq` implemented here
[INFO] [stderr]   --> src/gcounter.rs:38:1
[INFO] [stderr]    |
[INFO] [stderr] 38 | / impl<A: Ord + Clone + Serialize + DeserializeOwned> PartialEq for GCounter<A> {
[INFO] [stderr] 39 | |     fn eq(&self, other: &GCounter<A>) -> bool {
[INFO] [stderr] 40 | |         let (c, oc) = (self.value(), other.value());
[INFO] [stderr] 41 | |         c == oc
[INFO] [stderr] 42 | |     }
[INFO] [stderr] 43 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `gcounter::GCounter<A>`
[INFO] [stderr]   --> src/gcounter.rs:47:5
[INFO] [stderr]    |
[INFO] [stderr] 47 | /     pub fn new() -> GCounter<A> {
[INFO] [stderr] 48 | |         GCounter { inner: VClock::new() }
[INFO] [stderr] 49 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 45 | impl Default for gcounter::GCounter<A> {
[INFO] [stderr] 46 |     fn default() -> Self {
[INFO] [stderr] 47 |         Self::new()
[INFO] [stderr] 48 |     }
[INFO] [stderr] 49 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/gcounter.rs:58:33
[INFO] [stderr]    |
[INFO] [stderr] 58 |         self.inner.dots.values().fold(0, |acc, count| acc + count)
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly
[INFO] [stderr]   --> src/pncounter.rs:24:28
[INFO] [stderr]    |
[INFO] [stderr] 24 | #[derive(Debug, Eq, Clone, Hash, Serialize, Deserialize)]
[INFO] [stderr]    |                            ^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: `PartialEq` implemented here
[INFO] [stderr]   --> src/pncounter.rs:44:1
[INFO] [stderr]    |
[INFO] [stderr] 44 | / impl<A: Ord + Clone + Serialize + DeserializeOwned> PartialEq for PNCounter<A> {
[INFO] [stderr] 45 | |     fn eq(&self, other: &PNCounter<A>) -> bool {
[INFO] [stderr] 46 | |         let (c, oc) = (self.value(), other.value());
[INFO] [stderr] 47 | |         c == oc
[INFO] [stderr] 48 | |     }
[INFO] [stderr] 49 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `pncounter::PNCounter<A>`
[INFO] [stderr]   --> src/pncounter.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 | /     pub fn new() -> PNCounter<A> {
[INFO] [stderr] 54 | |         PNCounter {
[INFO] [stderr] 55 | |             p: GCounter::new(),
[INFO] [stderr] 56 | |             n: GCounter::new(),
[INFO] [stderr] 57 | |         }
[INFO] [stderr] 58 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 51 | impl Default for pncounter::PNCounter<A> {
[INFO] [stderr] 52 |     fn default() -> Self {
[INFO] [stderr] 53 |         Self::new()
[INFO] [stderr] 54 |     }
[INFO] [stderr] 55 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/pncounter.rs:163:17
[INFO] [stderr]     |
[INFO] [stderr] 163 | /                 match op {
[INFO] [stderr] 164 | |                     &Op::Increment(actor) => {
[INFO] [stderr] 165 | |                         witnesses[(actor as usize % i as usize)].increment(
[INFO] [stderr] 166 | |                             actor,
[INFO] [stderr] ...   |
[INFO] [stderr] 173 | |                     }
[INFO] [stderr] 174 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 163 |                 match *op {
[INFO] [stderr] 164 |                     Op::Increment(actor) => {
[INFO] [stderr] 165 |                         witnesses[(actor as usize % i as usize)].increment(
[INFO] [stderr] 166 |                             actor,
[INFO] [stderr] 167 |                         );
[INFO] [stderr] 168 |                     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `crdts`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "ca5a913366e413e3b6363ac0270f18b74cbaa23d120304682208b7ae8399657b"`
[INFO] running `"docker" "rm" "-f" "ca5a913366e413e3b6363ac0270f18b74cbaa23d120304682208b7ae8399657b"`
[INFO] [stdout] ca5a913366e413e3b6363ac0270f18b74cbaa23d120304682208b7ae8399657b