[INFO] crate crates_io_api 0.3.0 is already in cache [INFO] extracting crate crates_io_api 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/crates_io_api/0.3.0 [INFO] extracting crate crates_io_api 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crates_io_api/0.3.0 [INFO] validating manifest of crates_io_api-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of crates_io_api-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing crates_io_api-0.3.0 [INFO] finished frobbing crates_io_api-0.3.0 [INFO] frobbed toml for crates_io_api-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/crates_io_api/0.3.0/Cargo.toml [INFO] started frobbing crates_io_api-0.3.0 [INFO] finished frobbing crates_io_api-0.3.0 [INFO] frobbed toml for crates_io_api-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crates_io_api/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting crates_io_api-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/crates_io_api/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98de7c69d58baf5a1e81aaaf3af70e9ffe7f5ffc4adc9628b76e03d76af674b1 [INFO] running `"docker" "start" "-a" "98de7c69d58baf5a1e81aaaf3af70e9ffe7f5ffc4adc9628b76e03d76af674b1"` [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] Checking crates_io_api v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/async.rs:229:21 [INFO] [stderr] | [INFO] [stderr] 229 | versions: versions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `versions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/async.rs:274:29 [INFO] [stderr] | [INFO] [stderr] 274 | page: page, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `page` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | versions: versions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `versions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | page: page, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `page` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/async.rs:229:21 [INFO] [stderr] | [INFO] [stderr] 229 | versions: versions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `versions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/async.rs:274:29 [INFO] [stderr] | [INFO] [stderr] 274 | page: page, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `page` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | versions: versions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `versions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sync.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | page: page, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `page` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/async.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | c [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/async.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | let c = Self { [INFO] [stderr] | _________________^ [INFO] [stderr] 21 | | client: async::Client::new(), [INFO] [stderr] 22 | | base_url: Url::parse("https://crates.io/api/v1/").unwrap(), [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/sync.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | c [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/sync.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | let c = SyncClient { [INFO] [stderr] | _________________^ [INFO] [stderr] 21 | | client: reqwest::Client::new(), [INFO] [stderr] 22 | | base_url: Url::parse("https://crates.io/api/v1/").unwrap(), [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/async.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | c [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/async.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | let c = Self { [INFO] [stderr] | _________________^ [INFO] [stderr] 21 | | client: async::Client::new(), [INFO] [stderr] 22 | | base_url: Url::parse("https://crates.io/api/v1/").unwrap(), [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/sync.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | c [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/sync.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | let c = SyncClient { [INFO] [stderr] | _________________^ [INFO] [stderr] 21 | | client: reqwest::Client::new(), [INFO] [stderr] 22 | | base_url: Url::parse("https://crates.io/api/v1/").unwrap(), [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `async::Client` [INFO] [stderr] --> src/async.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Self { [INFO] [stderr] 20 | | let c = Self { [INFO] [stderr] 21 | | client: async::Client::new(), [INFO] [stderr] 22 | | base_url: Url::parse("https://crates.io/api/v1/").unwrap(), [INFO] [stderr] 23 | | }; [INFO] [stderr] 24 | | c [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for async::Client { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/async.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | if data.dependencies.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.dependencies.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/async.rs:182:20 [INFO] [stderr] | [INFO] [stderr] 182 | if all_versions == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!all_versions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/async.rs:270:39 [INFO] [stderr] | [INFO] [stderr] 270 | let streams_futures = (1..pages) [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 271 | | .into_iter() [INFO] [stderr] | |________________________________^ help: consider removing `.into_iter()`: `(1..pages)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/async.rs:315:17 [INFO] [stderr] | [INFO] [stderr] 315 | assert!(summary.most_downloaded.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!summary.most_downloaded.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sync::SyncClient` [INFO] [stderr] --> src/sync.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Self { [INFO] [stderr] 20 | | let c = SyncClient { [INFO] [stderr] 21 | | client: reqwest::Client::new(), [INFO] [stderr] 22 | | base_url: Url::parse("https://crates.io/api/v1/").unwrap(), [INFO] [stderr] 23 | | }; [INFO] [stderr] 24 | | c [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for sync::SyncClient { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sync.rs:83:16 [INFO] [stderr] | [INFO] [stderr] 83 | if res.dependencies.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!res.dependencies.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/sync.rs:153:27 [INFO] [stderr] | [INFO] [stderr] 153 | let versions = if resp.versions.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `resp.versions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sync.rs:262:17 [INFO] [stderr] | [INFO] [stderr] 262 | assert!(summary.most_downloaded.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!summary.most_downloaded.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `async::Client` [INFO] [stderr] --> src/async.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Self { [INFO] [stderr] 20 | | let c = Self { [INFO] [stderr] 21 | | client: async::Client::new(), [INFO] [stderr] 22 | | base_url: Url::parse("https://crates.io/api/v1/").unwrap(), [INFO] [stderr] 23 | | }; [INFO] [stderr] 24 | | c [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for async::Client { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/async.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | if data.dependencies.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.dependencies.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/async.rs:182:20 [INFO] [stderr] | [INFO] [stderr] 182 | if all_versions == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!all_versions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/async.rs:270:39 [INFO] [stderr] | [INFO] [stderr] 270 | let streams_futures = (1..pages) [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 271 | | .into_iter() [INFO] [stderr] | |________________________________^ help: consider removing `.into_iter()`: `(1..pages)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sync::SyncClient` [INFO] [stderr] --> src/sync.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> Self { [INFO] [stderr] 20 | | let c = SyncClient { [INFO] [stderr] 21 | | client: reqwest::Client::new(), [INFO] [stderr] 22 | | base_url: Url::parse("https://crates.io/api/v1/").unwrap(), [INFO] [stderr] 23 | | }; [INFO] [stderr] 24 | | c [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for sync::SyncClient { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sync.rs:83:16 [INFO] [stderr] | [INFO] [stderr] 83 | if res.dependencies.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!res.dependencies.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/sync.rs:153:27 [INFO] [stderr] | [INFO] [stderr] 153 | let versions = if resp.versions.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `resp.versions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.51s [INFO] running `"docker" "inspect" "98de7c69d58baf5a1e81aaaf3af70e9ffe7f5ffc4adc9628b76e03d76af674b1"` [INFO] running `"docker" "rm" "-f" "98de7c69d58baf5a1e81aaaf3af70e9ffe7f5ffc4adc9628b76e03d76af674b1"` [INFO] [stdout] 98de7c69d58baf5a1e81aaaf3af70e9ffe7f5ffc4adc9628b76e03d76af674b1