[INFO] crate crates-io-changes 0.1.0 is already in cache [INFO] extracting crate crates-io-changes 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/crates-io-changes/0.1.0 [INFO] extracting crate crates-io-changes 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crates-io-changes/0.1.0 [INFO] validating manifest of crates-io-changes-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of crates-io-changes-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing crates-io-changes-0.1.0 [INFO] finished frobbing crates-io-changes-0.1.0 [INFO] frobbed toml for crates-io-changes-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/crates-io-changes/0.1.0/Cargo.toml [INFO] started frobbing crates-io-changes-0.1.0 [INFO] finished frobbing crates-io-changes-0.1.0 [INFO] frobbed toml for crates-io-changes-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crates-io-changes/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting crates-io-changes-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/crates-io-changes/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a73ccffdd7628c9a3320c0ca73e05954ebb6b6287e2710687018b5587c84854b [INFO] running `"docker" "start" "-a" "a73ccffdd7628c9a3320c0ca73e05954ebb6b6287e2710687018b5587c84854b"` [INFO] [stderr] Checking crates-io-changes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | Ok(CratesIndex { repo: repo }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `repo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | Ok(CratesIndex { repo: repo }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `repo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn iter<'a>(&'a self) -> Result, Error> { [INFO] [stderr] 45 | | let mut revwalk = self.repo.revwalk()?; [INFO] [stderr] 46 | | revwalk.set_sorting(git2::SORT_REVERSE); [INFO] [stderr] 47 | | revwalk.push_head()?; [INFO] [stderr] ... | [INFO] [stderr] 51 | | Ok(IndexIter { repo: &self.repo, revwalk }) [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn iter<'a>(&'a self) -> Result, Error> { [INFO] [stderr] 45 | | let mut revwalk = self.repo.revwalk()?; [INFO] [stderr] 46 | | revwalk.set_sorting(git2::SORT_REVERSE); [INFO] [stderr] 47 | | revwalk.push_head()?; [INFO] [stderr] ... | [INFO] [stderr] 51 | | Ok(IndexIter { repo: &self.repo, revwalk }) [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.36s [INFO] running `"docker" "inspect" "a73ccffdd7628c9a3320c0ca73e05954ebb6b6287e2710687018b5587c84854b"` [INFO] running `"docker" "rm" "-f" "a73ccffdd7628c9a3320c0ca73e05954ebb6b6287e2710687018b5587c84854b"` [INFO] [stdout] a73ccffdd7628c9a3320c0ca73e05954ebb6b6287e2710687018b5587c84854b