[INFO] crate crates-index 0.12.0 is already in cache [INFO] extracting crate crates-index 0.12.0 into work/ex/clippy-test-run/sources/stable/reg/crates-index/0.12.0 [INFO] extracting crate crates-index 0.12.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crates-index/0.12.0 [INFO] validating manifest of crates-index-0.12.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of crates-index-0.12.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing crates-index-0.12.0 [INFO] finished frobbing crates-index-0.12.0 [INFO] frobbed toml for crates-index-0.12.0 written to work/ex/clippy-test-run/sources/stable/reg/crates-index/0.12.0/Cargo.toml [INFO] started frobbing crates-index-0.12.0 [INFO] finished frobbing crates-index-0.12.0 [INFO] frobbed toml for crates-index-0.12.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crates-index/0.12.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting crates-index-0.12.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/crates-index/0.12.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cd2e25a2069324119724f7a5f3f381f7b856d9a07e0aef73c41aa84f8c52cb97 [INFO] running `"docker" "start" "-a" "cd2e25a2069324119724f7a5f3f381f7b856d9a07e0aef73c41aa84f8c52cb97"` [INFO] [stderr] Checking crates-index v0.12.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:284:17 [INFO] [stderr] | [INFO] [stderr] 284 | Crate { versions: versions } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `versions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:284:17 [INFO] [stderr] | [INFO] [stderr] 284 | Crate { versions: versions } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `versions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/lib.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / match self.target { [INFO] [stderr] 139 | | Some(ref s) => Some(s), [INFO] [stderr] 140 | | None => None, [INFO] [stderr] 141 | | } [INFO] [stderr] | |_________^ help: try this: `self.target.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/lib.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / match self.kind { [INFO] [stderr] 146 | | Some(ref s) => Some(s), [INFO] [stderr] 147 | | None => None, [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ help: try this: `self.kind.as_ref()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/lib.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / match self.target { [INFO] [stderr] 139 | | Some(ref s) => Some(s), [INFO] [stderr] 140 | | None => None, [INFO] [stderr] 141 | | } [INFO] [stderr] | |_________^ help: try this: `self.target.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/lib.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / match self.kind { [INFO] [stderr] 146 | | Some(ref s) => Some(s), [INFO] [stderr] 147 | | None => None, [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ help: try this: `self.kind.as_ref()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.30s [INFO] running `"docker" "inspect" "cd2e25a2069324119724f7a5f3f381f7b856d9a07e0aef73c41aa84f8c52cb97"` [INFO] running `"docker" "rm" "-f" "cd2e25a2069324119724f7a5f3f381f7b856d9a07e0aef73c41aa84f8c52cb97"` [INFO] [stdout] cd2e25a2069324119724f7a5f3f381f7b856d9a07e0aef73c41aa84f8c52cb97