[INFO] crate cranelift-codegen-meta 0.25.0 is already in cache
[INFO] extracting crate cranelift-codegen-meta 0.25.0 into work/ex/clippy-test-run/sources/stable/reg/cranelift-codegen-meta/0.25.0
[INFO] extracting crate cranelift-codegen-meta 0.25.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cranelift-codegen-meta/0.25.0
[INFO] validating manifest of cranelift-codegen-meta-0.25.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of cranelift-codegen-meta-0.25.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing cranelift-codegen-meta-0.25.0
[INFO] finished frobbing cranelift-codegen-meta-0.25.0
[INFO] frobbed toml for cranelift-codegen-meta-0.25.0 written to work/ex/clippy-test-run/sources/stable/reg/cranelift-codegen-meta/0.25.0/Cargo.toml
[INFO] started frobbing cranelift-codegen-meta-0.25.0
[INFO] finished frobbing cranelift-codegen-meta-0.25.0
[INFO] frobbed toml for cranelift-codegen-meta-0.25.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cranelift-codegen-meta/0.25.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting cranelift-codegen-meta-0.25.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cranelift-codegen-meta/0.25.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1bfb507cdb23e9af3c3d8de0b04a28470fb1988bb8939fcff15223f3f326b375
[INFO] running `"docker" "start" "-a" "1bfb507cdb23e9af3c3d8de0b04a28470fb1988bb8939fcff15223f3f326b375"`
[INFO] [stderr]     Checking cranelift-codegen-meta v0.25.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cdsl/regs.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             start: start,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `start`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cdsl/regs.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             start: start,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `start`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]  --> src/gen_registers.rs:8:20
[INFO] [stderr]   |
[INFO] [stderr] 8 |     let names = if reg_bank.names.len() > 0 {
[INFO] [stderr]   |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!reg_bank.names.is_empty()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]   --> src/isa/mod.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         Isa::all()
[INFO] [stderr] 22 | |             .iter()
[INFO] [stderr] 23 | |             .cloned()
[INFO] [stderr] 24 | |             .filter(|isa| isa.to_string() == name)
[INFO] [stderr] 25 | |             .next()
[INFO] [stderr]    | |___________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]    = note: replace `filter(|isa| isa.to_string() == name).next()` with `find(|isa| isa.to_string() == name)`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]   --> src/isa/mod.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 | /         Isa::all()
[INFO] [stderr] 31 | |             .iter()
[INFO] [stderr] 32 | |             .cloned()
[INFO] [stderr] 33 | |             .filter(|isa| isa.is_arch_applicable(arch))
[INFO] [stderr] 34 | |             .next()
[INFO] [stderr]    | |___________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: replace `filter(|isa| isa.is_arch_applicable(arch)).next()` with `find(|isa| isa.is_arch_applicable(arch))`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/isa/mod.rs:43:27
[INFO] [stderr]    |
[INFO] [stderr] 43 |     fn is_arch_applicable(&self, arch: &str) -> bool {
[INFO] [stderr]    |                           ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/cdsl/isa.rs:35:29
[INFO] [stderr]    |
[INFO] [stderr] 35 |         let first_unit = if self.isa.reg_banks.len() == 0 {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.isa.reg_banks.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/cdsl/isa.rs:154:29
[INFO] [stderr]     |
[INFO] [stderr] 154 | /                             self.isa
[INFO] [stderr] 155 | |                                 .reg_classes
[INFO] [stderr] 156 | |                                 .get(*i1)
[INFO] [stderr] 157 | |                                 .unwrap()
[INFO] [stderr] ...   |
[INFO] [stderr] 160 | |                                 .find(|x| **x == *i2)
[INFO] [stderr] 161 | |                                 .is_some()
[INFO] [stderr]     | |__________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]     = note: replace `find(|x| **x == *i2).is_some()` with `any(|x| **x == *i2)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]  --> src/gen_registers.rs:8:20
[INFO] [stderr]   |
[INFO] [stderr] 8 |     let names = if reg_bank.names.len() > 0 {
[INFO] [stderr]   |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!reg_bank.names.is_empty()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]   --> src/isa/mod.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         Isa::all()
[INFO] [stderr] 22 | |             .iter()
[INFO] [stderr] 23 | |             .cloned()
[INFO] [stderr] 24 | |             .filter(|isa| isa.to_string() == name)
[INFO] [stderr] 25 | |             .next()
[INFO] [stderr]    | |___________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]    = note: replace `filter(|isa| isa.to_string() == name).next()` with `find(|isa| isa.to_string() == name)`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]   --> src/isa/mod.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 | /         Isa::all()
[INFO] [stderr] 31 | |             .iter()
[INFO] [stderr] 32 | |             .cloned()
[INFO] [stderr] 33 | |             .filter(|isa| isa.is_arch_applicable(arch))
[INFO] [stderr] 34 | |             .next()
[INFO] [stderr]    | |___________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: replace `filter(|isa| isa.is_arch_applicable(arch)).next()` with `find(|isa| isa.is_arch_applicable(arch))`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/isa/mod.rs:43:27
[INFO] [stderr]    |
[INFO] [stderr] 43 |     fn is_arch_applicable(&self, arch: &str) -> bool {
[INFO] [stderr]    |                           ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/cdsl/isa.rs:35:29
[INFO] [stderr]    |
[INFO] [stderr] 35 |         let first_unit = if self.isa.reg_banks.len() == 0 {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.isa.reg_banks.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/cdsl/isa.rs:154:29
[INFO] [stderr]     |
[INFO] [stderr] 154 | /                             self.isa
[INFO] [stderr] 155 | |                                 .reg_classes
[INFO] [stderr] 156 | |                                 .get(*i1)
[INFO] [stderr] 157 | |                                 .unwrap()
[INFO] [stderr] ...   |
[INFO] [stderr] 160 | |                                 .find(|x| **x == *i2)
[INFO] [stderr] 161 | |                                 .is_some()
[INFO] [stderr]     | |__________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]     = note: replace `find(|x| **x == *i2).is_some()` with `any(|x| **x == *i2)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.83s
[INFO] running `"docker" "inspect" "1bfb507cdb23e9af3c3d8de0b04a28470fb1988bb8939fcff15223f3f326b375"`
[INFO] running `"docker" "rm" "-f" "1bfb507cdb23e9af3c3d8de0b04a28470fb1988bb8939fcff15223f3f326b375"`
[INFO] [stdout] 1bfb507cdb23e9af3c3d8de0b04a28470fb1988bb8939fcff15223f3f326b375