[INFO] crate cqc 0.3.5 is already in cache [INFO] extracting crate cqc 0.3.5 into work/ex/clippy-test-run/sources/stable/reg/cqc/0.3.5 [INFO] extracting crate cqc 0.3.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cqc/0.3.5 [INFO] validating manifest of cqc-0.3.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cqc-0.3.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cqc-0.3.5 [INFO] finished frobbing cqc-0.3.5 [INFO] frobbed toml for cqc-0.3.5 written to work/ex/clippy-test-run/sources/stable/reg/cqc/0.3.5/Cargo.toml [INFO] started frobbing cqc-0.3.5 [INFO] finished frobbing cqc-0.3.5 [INFO] frobbed toml for cqc-0.3.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cqc/0.3.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cqc-0.3.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/cqc/0.3.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 418484234fdee634b855fcb96a1933be9a39c7417c282e23811b01ac2fc45816 [INFO] running `"docker" "start" "-a" "418484234fdee634b855fcb96a1933be9a39c7417c282e23811b01ac2fc45816"` [INFO] [stderr] Checking cqc v0.3.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | msg_type: msg_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | msg_type: msg_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:422:24 [INFO] [stderr] | [INFO] [stderr] 422 | const FIELDS: &'static [&'static str] = &["cqc_hdr", "notify"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:422:34 [INFO] [stderr] | [INFO] [stderr] 422 | const FIELDS: &'static [&'static str] = &["cqc_hdr", "notify"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:422:24 [INFO] [stderr] | [INFO] [stderr] 422 | const FIELDS: &'static [&'static str] = &["cqc_hdr", "notify"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:422:34 [INFO] [stderr] | [INFO] [stderr] 422 | const FIELDS: &'static [&'static str] = &["cqc_hdr", "notify"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hdr/mod.rs:474:18 [INFO] [stderr] | [INFO] [stderr] 474 | pub fn is_tp(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:475:9 [INFO] [stderr] | [INFO] [stderr] 475 | / match self { [INFO] [stderr] 476 | | &MsgType::Tp(_) => true, [INFO] [stderr] 477 | | &MsgType::Err(_) => false, [INFO] [stderr] 478 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 475 | match *self { [INFO] [stderr] 476 | MsgType::Tp(_) => true, [INFO] [stderr] 477 | MsgType::Err(_) => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hdr/mod.rs:482:19 [INFO] [stderr] | [INFO] [stderr] 482 | pub fn is_err(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | / match self { [INFO] [stderr] 484 | | &MsgType::Tp(_) => false, [INFO] [stderr] 485 | | &MsgType::Err(_) => true, [INFO] [stderr] 486 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 483 | match *self { [INFO] [stderr] 484 | MsgType::Tp(_) => false, [INFO] [stderr] 485 | MsgType::Err(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 489 | def_is_tp!(Tp::Hello, is_hello); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 490 | def_is_tp!(Tp::Command, is_command); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 491 | def_is_tp!(Tp::Factory, is_factory); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 492 | def_is_tp!(Tp::Expire, is_expire); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 493 | def_is_tp!(Tp::Done, is_done); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 494 | def_is_tp!(Tp::Recv, is_recv); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 495 | def_is_tp!(Tp::EprOk, is_epr_ok); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 496 | def_is_tp!(Tp::MeasOut, is_measout); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 497 | def_is_tp!(Tp::GetTime, is_get_time); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 498 | def_is_tp!(Tp::InfTime, is_inf_time); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 499 | def_is_tp!(Tp::NewOk, is_new_ok); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | / match self { [INFO] [stderr] 465 | | &MsgType::Err($tp) => true, [INFO] [stderr] 466 | | _ => false, [INFO] [stderr] 467 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 501 | def_is_err!(Err::General, is_err_general); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | / match self { [INFO] [stderr] 465 | | &MsgType::Err($tp) => true, [INFO] [stderr] 466 | | _ => false, [INFO] [stderr] 467 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 502 | def_is_err!(Err::NoQubit, is_err_noqubit); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | / match self { [INFO] [stderr] 465 | | &MsgType::Err($tp) => true, [INFO] [stderr] 466 | | _ => false, [INFO] [stderr] 467 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 503 | def_is_err!(Err::Unsupp, is_err_unsupp); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | / match self { [INFO] [stderr] 465 | | &MsgType::Err($tp) => true, [INFO] [stderr] 466 | | _ => false, [INFO] [stderr] 467 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 504 | def_is_err!(Err::Timeout, is_err_timeout); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | / match self { [INFO] [stderr] 465 | | &MsgType::Err($tp) => true, [INFO] [stderr] 466 | | _ => false, [INFO] [stderr] 467 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 505 | def_is_err!(Err::InUse, is_err_inuse); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | / match self { [INFO] [stderr] 465 | | &MsgType::Err($tp) => true, [INFO] [stderr] 466 | | _ => false, [INFO] [stderr] 467 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 506 | def_is_err!(Err::Unknown, is_err_unknown); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:545:9 [INFO] [stderr] | [INFO] [stderr] 545 | / match self { [INFO] [stderr] 546 | | &MsgType::Tp(tp) => serializer.serialize_u8(tp as u8), [INFO] [stderr] 547 | | &MsgType::Err(err) => serializer.serialize_u8(err as u8), [INFO] [stderr] 548 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 545 | match *self { [INFO] [stderr] 546 | MsgType::Tp(tp) => serializer.serialize_u8(tp as u8), [INFO] [stderr] 547 | MsgType::Err(err) => serializer.serialize_u8(err as u8), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `Request` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:195:1 [INFO] [stderr] | [INFO] [stderr] 195 | / impl Request { [INFO] [stderr] 196 | | pub fn len(&self) -> u32 { [INFO] [stderr] 197 | | CqcHdr::hdr_len() + [INFO] [stderr] 198 | | match self.req_cmd { [INFO] [stderr] ... | [INFO] [stderr] 202 | | } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `ReqCmd` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:231:1 [INFO] [stderr] | [INFO] [stderr] 231 | / impl ReqCmd { [INFO] [stderr] 232 | | pub fn len(&self) -> u32 { [INFO] [stderr] 233 | | CmdHdr::hdr_len() + self.xtra_hdr.len() [INFO] [stderr] 234 | | } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `XtraHdr` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:268:1 [INFO] [stderr] | [INFO] [stderr] 268 | / impl XtraHdr { [INFO] [stderr] 269 | | pub fn len(&self) -> u32 { [INFO] [stderr] 270 | | match *self { [INFO] [stderr] 271 | | XtraHdr::Rot(_) => RotHdr::hdr_len(), [INFO] [stderr] ... | [INFO] [stderr] 298 | | } [INFO] [stderr] 299 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | / match self { [INFO] [stderr] 163 | | &$enum_name::$variant(_) => true, [INFO] [stderr] 164 | | _ => false, [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 278 | def_is_hdr!(XtraHdr, Rot, is_rot_hdr); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | / match self { [INFO] [stderr] 163 | | &$enum_name::$variant(_) => true, [INFO] [stderr] 164 | | _ => false, [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 279 | def_is_hdr!(XtraHdr, Qubit, is_qubit_hdr); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | / match self { [INFO] [stderr] 163 | | &$enum_name::$variant(_) => true, [INFO] [stderr] 164 | | _ => false, [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 280 | def_is_hdr!(XtraHdr, Comm, is_comm_hdr); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | / match self { [INFO] [stderr] 288 | | &XtraHdr::None => false, [INFO] [stderr] 289 | | _ => true, [INFO] [stderr] 290 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 287 | match *self { [INFO] [stderr] 288 | XtraHdr::None => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | / match self { [INFO] [stderr] 295 | | &XtraHdr::None => true, [INFO] [stderr] 296 | | _ => false, [INFO] [stderr] 297 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 294 | match *self { [INFO] [stderr] 295 | XtraHdr::None => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | / match self { [INFO] [stderr] 163 | | &$enum_name::$variant(_) => true, [INFO] [stderr] 164 | | _ => false, [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 324 | def_is_hdr!(RspInfo, Notify, is_notify_hdr); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | / match self { [INFO] [stderr] 163 | | &$enum_name::$variant(_) => true, [INFO] [stderr] 164 | | _ => false, [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 325 | def_is_hdr!(RspInfo, EntInfo, is_ent_info_hdr); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:337:9 [INFO] [stderr] | [INFO] [stderr] 337 | / match self { [INFO] [stderr] 338 | | &RspInfo::None => false, [INFO] [stderr] 339 | | _ => true, [INFO] [stderr] 340 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 337 | match *self { [INFO] [stderr] 338 | RspInfo::None => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:344:9 [INFO] [stderr] | [INFO] [stderr] 344 | / match self { [INFO] [stderr] 345 | | &RspInfo::None => true, [INFO] [stderr] 346 | | _ => false, [INFO] [stderr] 347 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 344 | match *self { [INFO] [stderr] 345 | RspInfo::None => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Encoder` [INFO] [stderr] --> src/lib.rs:436:5 [INFO] [stderr] | [INFO] [stderr] 436 | / pub fn new() -> Encoder { [INFO] [stderr] 437 | | let mut config = bincode::config(); [INFO] [stderr] 438 | | config.big_endian(); [INFO] [stderr] 439 | | [INFO] [stderr] 440 | | Encoder { config } [INFO] [stderr] 441 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 434 | impl Default for Encoder { [INFO] [stderr] 435 | fn default() -> Self { [INFO] [stderr] 436 | Self::new() [INFO] [stderr] 437 | } [INFO] [stderr] 438 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:459:21 [INFO] [stderr] | [INFO] [stderr] 459 | pub fn into_vec(&self, request: &Request) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Decoder` [INFO] [stderr] --> src/lib.rs:473:5 [INFO] [stderr] | [INFO] [stderr] 473 | / pub fn new() -> Decoder { [INFO] [stderr] 474 | | let mut config = bincode::config(); [INFO] [stderr] 475 | | config.big_endian(); [INFO] [stderr] 476 | | [INFO] [stderr] 477 | | Decoder { config } [INFO] [stderr] 478 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 471 | impl Default for Decoder { [INFO] [stderr] 472 | fn default() -> Self { [INFO] [stderr] 473 | Self::new() [INFO] [stderr] 474 | } [INFO] [stderr] 475 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hdr/mod.rs:474:18 [INFO] [stderr] | [INFO] [stderr] 474 | pub fn is_tp(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:475:9 [INFO] [stderr] | [INFO] [stderr] 475 | / match self { [INFO] [stderr] 476 | | &MsgType::Tp(_) => true, [INFO] [stderr] 477 | | &MsgType::Err(_) => false, [INFO] [stderr] 478 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 475 | match *self { [INFO] [stderr] 476 | MsgType::Tp(_) => true, [INFO] [stderr] 477 | MsgType::Err(_) => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hdr/mod.rs:482:19 [INFO] [stderr] | [INFO] [stderr] 482 | pub fn is_err(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:483:9 [INFO] [stderr] | [INFO] [stderr] 483 | / match self { [INFO] [stderr] 484 | | &MsgType::Tp(_) => false, [INFO] [stderr] 485 | | &MsgType::Err(_) => true, [INFO] [stderr] 486 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 483 | match *self { [INFO] [stderr] 484 | MsgType::Tp(_) => false, [INFO] [stderr] 485 | MsgType::Err(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 489 | def_is_tp!(Tp::Hello, is_hello); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 490 | def_is_tp!(Tp::Command, is_command); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 491 | def_is_tp!(Tp::Factory, is_factory); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 492 | def_is_tp!(Tp::Expire, is_expire); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 493 | def_is_tp!(Tp::Done, is_done); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 494 | def_is_tp!(Tp::Recv, is_recv); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 495 | def_is_tp!(Tp::EprOk, is_epr_ok); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 496 | def_is_tp!(Tp::MeasOut, is_measout); [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 497 | def_is_tp!(Tp::GetTime, is_get_time); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 498 | def_is_tp!(Tp::InfTime, is_inf_time); [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | / match self { [INFO] [stderr] 453 | | &MsgType::Tp($tp) => true, [INFO] [stderr] 454 | | _ => false, [INFO] [stderr] 455 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 499 | def_is_tp!(Tp::NewOk, is_new_ok); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | / match self { [INFO] [stderr] 465 | | &MsgType::Err($tp) => true, [INFO] [stderr] 466 | | _ => false, [INFO] [stderr] 467 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 501 | def_is_err!(Err::General, is_err_general); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | / match self { [INFO] [stderr] 465 | | &MsgType::Err($tp) => true, [INFO] [stderr] 466 | | _ => false, [INFO] [stderr] 467 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 502 | def_is_err!(Err::NoQubit, is_err_noqubit); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | / match self { [INFO] [stderr] 465 | | &MsgType::Err($tp) => true, [INFO] [stderr] 466 | | _ => false, [INFO] [stderr] 467 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 503 | def_is_err!(Err::Unsupp, is_err_unsupp); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | / match self { [INFO] [stderr] 465 | | &MsgType::Err($tp) => true, [INFO] [stderr] 466 | | _ => false, [INFO] [stderr] 467 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 504 | def_is_err!(Err::Timeout, is_err_timeout); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | / match self { [INFO] [stderr] 465 | | &MsgType::Err($tp) => true, [INFO] [stderr] 466 | | _ => false, [INFO] [stderr] 467 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 505 | def_is_err!(Err::InUse, is_err_inuse); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | / match self { [INFO] [stderr] 465 | | &MsgType::Err($tp) => true, [INFO] [stderr] 466 | | _ => false, [INFO] [stderr] 467 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 506 | def_is_err!(Err::Unknown, is_err_unknown); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hdr/mod.rs:545:9 [INFO] [stderr] | [INFO] [stderr] 545 | / match self { [INFO] [stderr] 546 | | &MsgType::Tp(tp) => serializer.serialize_u8(tp as u8), [INFO] [stderr] 547 | | &MsgType::Err(err) => serializer.serialize_u8(err as u8), [INFO] [stderr] 548 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 545 | match *self { [INFO] [stderr] 546 | MsgType::Tp(tp) => serializer.serialize_u8(tp as u8), [INFO] [stderr] 547 | MsgType::Err(err) => serializer.serialize_u8(err as u8), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/decode.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | msg_type: msg_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/decode.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/decode.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | msg_type: msg_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/decode.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/decode.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | msg_type: msg_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `msg_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/decode.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: item `Request` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:195:1 [INFO] [stderr] | [INFO] [stderr] 195 | / impl Request { [INFO] [stderr] 196 | | pub fn len(&self) -> u32 { [INFO] [stderr] 197 | | CqcHdr::hdr_len() + [INFO] [stderr] 198 | | match self.req_cmd { [INFO] [stderr] ... | [INFO] [stderr] 202 | | } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `ReqCmd` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:231:1 [INFO] [stderr] | [INFO] [stderr] 231 | / impl ReqCmd { [INFO] [stderr] 232 | | pub fn len(&self) -> u32 { [INFO] [stderr] 233 | | CmdHdr::hdr_len() + self.xtra_hdr.len() [INFO] [stderr] 234 | | } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `XtraHdr` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:268:1 [INFO] [stderr] | [INFO] [stderr] 268 | / impl XtraHdr { [INFO] [stderr] 269 | | pub fn len(&self) -> u32 { [INFO] [stderr] 270 | | match *self { [INFO] [stderr] 271 | | XtraHdr::Rot(_) => RotHdr::hdr_len(), [INFO] [stderr] ... | [INFO] [stderr] 298 | | } [INFO] [stderr] 299 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | / match self { [INFO] [stderr] 163 | | &$enum_name::$variant(_) => true, [INFO] [stderr] 164 | | _ => false, [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 278 | def_is_hdr!(XtraHdr, Rot, is_rot_hdr); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | / match self { [INFO] [stderr] 163 | | &$enum_name::$variant(_) => true, [INFO] [stderr] 164 | | _ => false, [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 279 | def_is_hdr!(XtraHdr, Qubit, is_qubit_hdr); [INFO] [stderr] | ------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | / match self { [INFO] [stderr] 163 | | &$enum_name::$variant(_) => true, [INFO] [stderr] 164 | | _ => false, [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 280 | def_is_hdr!(XtraHdr, Comm, is_comm_hdr); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | / match self { [INFO] [stderr] 288 | | &XtraHdr::None => false, [INFO] [stderr] 289 | | _ => true, [INFO] [stderr] 290 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 287 | match *self { [INFO] [stderr] 288 | XtraHdr::None => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | / match self { [INFO] [stderr] 295 | | &XtraHdr::None => true, [INFO] [stderr] 296 | | _ => false, [INFO] [stderr] 297 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 294 | match *self { [INFO] [stderr] 295 | XtraHdr::None => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | / match self { [INFO] [stderr] 163 | | &$enum_name::$variant(_) => true, [INFO] [stderr] 164 | | _ => false, [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 324 | def_is_hdr!(RspInfo, Notify, is_notify_hdr); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | / match self { [INFO] [stderr] 163 | | &$enum_name::$variant(_) => true, [INFO] [stderr] 164 | | _ => false, [INFO] [stderr] 165 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 325 | def_is_hdr!(RspInfo, EntInfo, is_ent_info_hdr); [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:337:9 [INFO] [stderr] | [INFO] [stderr] 337 | / match self { [INFO] [stderr] 338 | | &RspInfo::None => false, [INFO] [stderr] 339 | | _ => true, [INFO] [stderr] 340 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 337 | match *self { [INFO] [stderr] 338 | RspInfo::None => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:344:9 [INFO] [stderr] | [INFO] [stderr] 344 | / match self { [INFO] [stderr] 345 | | &RspInfo::None => true, [INFO] [stderr] 346 | | _ => false, [INFO] [stderr] 347 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 344 | match *self { [INFO] [stderr] 345 | RspInfo::None => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Encoder` [INFO] [stderr] --> src/lib.rs:436:5 [INFO] [stderr] | [INFO] [stderr] 436 | / pub fn new() -> Encoder { [INFO] [stderr] 437 | | let mut config = bincode::config(); [INFO] [stderr] 438 | | config.big_endian(); [INFO] [stderr] 439 | | [INFO] [stderr] 440 | | Encoder { config } [INFO] [stderr] 441 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 434 | impl Default for Encoder { [INFO] [stderr] 435 | fn default() -> Self { [INFO] [stderr] 436 | Self::new() [INFO] [stderr] 437 | } [INFO] [stderr] 438 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:459:21 [INFO] [stderr] | [INFO] [stderr] 459 | pub fn into_vec(&self, request: &Request) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Decoder` [INFO] [stderr] --> src/lib.rs:473:5 [INFO] [stderr] | [INFO] [stderr] 473 | / pub fn new() -> Decoder { [INFO] [stderr] 474 | | let mut config = bincode::config(); [INFO] [stderr] 475 | | config.big_endian(); [INFO] [stderr] 476 | | [INFO] [stderr] 477 | | Decoder { config } [INFO] [stderr] 478 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 471 | impl Default for Decoder { [INFO] [stderr] 472 | fn default() -> Self { [INFO] [stderr] 473 | Self::new() [INFO] [stderr] 474 | } [INFO] [stderr] 475 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.41s [INFO] running `"docker" "inspect" "418484234fdee634b855fcb96a1933be9a39c7417c282e23811b01ac2fc45816"` [INFO] running `"docker" "rm" "-f" "418484234fdee634b855fcb96a1933be9a39c7417c282e23811b01ac2fc45816"` [INFO] [stdout] 418484234fdee634b855fcb96a1933be9a39c7417c282e23811b01ac2fc45816